From nobody Wed May 15 01:06:50 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+110683+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+110683+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1699197560; cv=none; d=zohomail.com; s=zohoarc; b=BUgYCCMbzsY8P8GwwS2X4eUYoVPL+Y/0fsm0c3kM7ErTJfZzaOVsNYBdYO7Rd+rqQZOXCkVMR0i/G8keZFkdr/Muia6UFgvCzc52s2yoGAJFf9dRncdTUlXbMuTLMyJu2HBsfCAPWYk5A9jiljsIexNxTvx3Cic1vYtLcLMtE+E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1699197560; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=hy7Yn21y0hKZ2kOsGmV6Y3d737hotEEWnB/c9eBwa7s=; b=b0g9qZ1fZyoiajMVpM5rQ/cHCCW9NUHyRaNJMEaAToSNqcw0mx9dxJ4v3X+OTz0gtvaoFTkoHi7z/QQ+m4SjJQX+FEWWN2m4kj/T5CLoXek+CkwjZlXJ/qR/ZU9HGgObNkFaKESR5duI0n698GFpl5AL+6AlDm9DINmhHeR+dFw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+110683+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1699197560618987.209354670844; Sun, 5 Nov 2023 07:19:20 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=RY7cw/LGCgT7Vh6g2WfhxLuyck+Jdp948wQa2wdJg9Y=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1699197560; v=1; b=FViYlgCOqtJ2OoEmUV11pr82nIjmbbobeSNTyEYjl0Ys1Zot93XXtTd7Yo37t8jwgBn3HPVn aB/NgyvtmiNG1GdZC5qMxEU3yMqCFN23GArNkPcbDW8b0mOuUGheFXPbiBvM170rejFHx22xrcn ONVSLJYZU90vDYACZDbjSLsI= X-Received: by 127.0.0.2 with SMTP id c30OYY1788612xDalG15BBiD; Sun, 05 Nov 2023 07:19:20 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.31884.1699197559833388715 for ; Sun, 05 Nov 2023 07:19:19 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10885"; a="369361949" X-IronPort-AV: E=Sophos;i="6.03,279,1694761200"; d="scan'208";a="369361949" X-Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Nov 2023 07:19:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10885"; a="738573010" X-IronPort-AV: E=Sophos;i="6.03,279,1694761200"; d="scan'208";a="738573010" X-Received: from shpfwdbuild003.ccr.corp.intel.com ([10.239.56.82]) by orsmga006.jf.intel.com with ESMTP; 05 Nov 2023 07:19:17 -0800 From: "Xu, Wei6" To: devel@edk2.groups.io Cc: Wei6 Xu , Abner Chang , Nate DeSimone , Liming Gao Subject: [edk2-devel] [PATCH v2 edk2-platforms 1/1] IpmiFeaturePkg/SmmIpmiBaseLib: Support Standalone MM. Date: Sun, 5 Nov 2023 23:18:54 +0800 Message-Id: <8594af88f257a5274215a8a31734c1097c4a8570.1699196971.git.wei6.xu@intel.com> In-Reply-To: References: MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,wei6.xu@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 01eeWrI8DePRLD332msZecsVx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1699197562513100003 Content-Type: text/plain; charset="utf-8" Add MM_STANDALONE type support for SmmIpmiBaseLib instance. Replace Smst with Mmst. Remove unused UefiBootServicesTableLib reference. Cc: Abner Chang Cc: Nate DeSimone Cc: Liming Gao Signed-off-by: Wei6 Xu Reviewed-by: Nate DeSimone --- .../Library/SmmIpmiBaseLib/SmmIpmiBaseLib.c | 39 +++++-------------- .../Library/SmmIpmiBaseLib/SmmIpmiBaseLib.inf | 7 ++-- 2 files changed, 12 insertions(+), 34 deletions(-) diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/SmmI= pmiBaseLib/SmmIpmiBaseLib.c b/Features/Intel/OutOfBandManagement/IpmiFeatur= ePkg/Library/SmmIpmiBaseLib/SmmIpmiBaseLib.c index 6282adc269f8..d05798d94866 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/SmmIpmiBase= Lib/SmmIpmiBaseLib.c +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/SmmIpmiBase= Lib/SmmIpmiBaseLib.c @@ -2,15 +2,14 @@ A Library to support all BMC access via IPMI command during SMM Phase. =20 @copyright - Copyright 1999 - 2021 Intel Corporation.
+ Copyright 1999 - 2023 Intel Corporation.
SPDX-License-Identifier: BSD-2-Clause-Patent **/ =20 -#include +#include #include #include -#include -#include +#include #include =20 STATIC IPMI_TRANSPORT *mIpmiTransport =3D NULL; @@ -37,7 +36,7 @@ NotifyIpmiTransportCallback ( EFI_STATUS Status; Status =3D EFI_SUCCESS; if (mIpmiTransport =3D=3D NULL) { - Status =3D gSmst->SmmLocateProtocol ( + Status =3D gMmst->MmLocateProtocol ( &gSmmIpmiTransportProtocolGuid, NULL, (VOID **) &mIpmiTransport @@ -60,15 +59,15 @@ InitializeIpmiBase ( { EFI_STATUS Status; if (mIpmiTransport =3D=3D NULL) { - Status =3D gSmst->SmmLocateProtocol ( + Status =3D gMmst->MmLocateProtocol ( &gSmmIpmiTransportProtocolGuid, NULL, (VOID **) &mIpmiTransport ); if (EFI_ERROR (Status)) { - Status =3D gSmst->SmmRegisterProtocolNotify ( + Status =3D gMmst->MmRegisterProtocolNotify ( &gSmmIpmiTransportProtocolGuid, - (EFI_SMM_NOTIFY_FN) NotifyIpmiTransportCallback, + (EFI_MM_NOTIFY_FN) NotifyIpmiTransportCallback, &mEfiIpmiProtocolNotifyReg ); } @@ -104,30 +103,10 @@ IpmiSubmitCommand ( OUT UINT8 *ResponseData, IN OUT UINT32 *ResponseDataSize ) -/*++ - -Routine Description: - - Routine to send commands to BMC - -Arguments: - - NetFunction - Net function of the command - Command - IPMI Command - CommandData - Command Data - CommandDataSize - Size of CommandData - ResponseData - Response Data - ResponseDataSize - Response Data Size - -Returns: - - EFI_NOT_AVAILABLE_YET - IpmiTransport Protocol is not installed yet - ---*/ { EFI_STATUS Status; =20 - Status =3D gSmst->SmmLocateProtocol (&gSmmIpmiTransportProtocolGuid, NUL= L, (VOID **) &mIpmiTransport); + Status =3D gMmst->MmLocateProtocol (&gSmmIpmiTransportProtocolGuid, NULL= , (VOID **) &mIpmiTransport); if (EFI_ERROR (Status)) { ASSERT_EFI_ERROR (Status); return Status; @@ -164,7 +143,7 @@ GetBmcStatus ( { EFI_STATUS Status; =20 - Status =3D gSmst->SmmLocateProtocol (&gSmmIpmiTransportProtocolGuid, NUL= L, (VOID **) &mIpmiTransport); + Status =3D gMmst->MmLocateProtocol (&gSmmIpmiTransportProtocolGuid, NULL= , (VOID **) &mIpmiTransport); if (EFI_ERROR (Status)) { ASSERT_EFI_ERROR (Status); return Status; diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/SmmI= pmiBaseLib/SmmIpmiBaseLib.inf b/Features/Intel/OutOfBandManagement/IpmiFeat= urePkg/Library/SmmIpmiBaseLib/SmmIpmiBaseLib.inf index 7ea688fc165f..df43c81e6493 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/SmmIpmiBase= Lib/SmmIpmiBaseLib.inf +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/SmmIpmiBase= Lib/SmmIpmiBaseLib.inf @@ -1,7 +1,7 @@ ## @file # # @copyright -# Copyright 2010 - 2021 Intel Corporation.
+# Copyright 2010 - 2023 Intel Corporation.
# SPDX-License-Identifier: BSD-2-Clause-Patent ## =20 @@ -11,7 +11,7 @@ FILE_GUID =3D 2B5AD78E-5CF8-45d2-B2AC-749A09425911 MODULE_TYPE =3D DXE_SMM_DRIVER VERSION_STRING =3D 1.0 - LIBRARY_CLASS =3D IpmiBaseLib|DXE_SMM_DRIVER SMM_CORE + LIBRARY_CLASS =3D IpmiBaseLib|DXE_SMM_DRIVER SMM_CORE M= M_STANDALONE MM_CORE_STANDALONE =20 [sources] SmmIpmiBaseLib.c @@ -21,9 +21,8 @@ IpmiFeaturePkg/IpmiFeaturePkg.dec =20 [LibraryClasses] - UefiBootServicesTableLib DebugLib - SmmServicesTableLib + MmServicesTableLib =20 [Protocols] gSmmIpmiTransportProtocolGuid --=20 2.29.2.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110683): https://edk2.groups.io/g/devel/message/110683 Mute This Topic: https://groups.io/mt/102402215/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-