From nobody Tue May 14 06:58:26 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+109986+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109986+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1698126845; cv=none; d=zohomail.com; s=zohoarc; b=ghUG3JbhQl6OCtxAEk4xH/SjfXBbGhNDqzkdTzujoHSbn84iorwJrf2Q5R9PKq5/JDTmBXwLZtOGQWlpMDaQcbO2I83V85ERM2qB15oz9Y+Fl4xxms6jebgnNatf7FLynd1F63nwHMuF3aNUZsRExPIX35kY2mu+h3I8XL9bnog= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1698126845; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=1D/wbyK9mNVQPLzOJhbPT/oVeH9VNrXpWPIwQ2hJcOA=; b=eOYRjXh2JAkKcrnYVBMMou/Ed02jo+u5hzdBhy5gFJXBTI4IL2xKIpA4N2l+tKEDcAdFL6Zw11mDwtiys/f9O+axLxhjK05p5uNZj07bwJx/Sgv5Ord0RxXc63qu30mr6nhVlNqNIKFOE26zvLxc8gwDlZo5aiApOivalUdo02g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109986+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 16981268454944.1053777300751335; Mon, 23 Oct 2023 22:54:05 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=SK8k74mj6PXLctr+7n3NrDVem5D4Ly1d1KlAXxFQrbU=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1698126845; v=1; b=qZ64ZauCSyuYfXf5CvcKgR7x8gNmVIirzCvrhK8hCtGRoc6Y6T/LUDAgGQx9xlQyJarmqpDq RvVlst+KoZdlV+9tlVcqrQiNZ1yPFlCKOTtur3rtjmBdwvnaGYhPV7oDzxHRlfHawJ11knXP5eV 4Kc88bIexB2JXayMob1quRjA= X-Received: by 127.0.0.2 with SMTP id QklJYY1788612xd7M0stOYGB; Mon, 23 Oct 2023 22:54:05 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.11853.1698126840726459328 for ; Mon, 23 Oct 2023 22:54:04 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10872"; a="367220282" X-IronPort-AV: E=Sophos;i="6.03,246,1694761200"; d="scan'208";a="367220282" X-Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Oct 2023 22:54:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10872"; a="931925283" X-IronPort-AV: E=Sophos;i="6.03,246,1694761200"; d="scan'208";a="931925283" X-Received: from shpfwdbuild003.ccr.corp.intel.com ([10.239.56.82]) by orsmga005.jf.intel.com with ESMTP; 23 Oct 2023 22:54:02 -0700 From: "Xu, Wei6" To: devel@edk2.groups.io Cc: Wei6 Xu , Ard Biesheuvel , Sami Mujawar , Ray Ni Subject: [edk2-devel] [PATCH 1/1] StandaloneMmPkg: Fix the failure to find uncompressed inner FV. Date: Tue, 24 Oct 2023 13:53:54 +0800 Message-Id: In-Reply-To: References: MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,wei6.xu@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: hdEyLj7U8TRTbut4xZHQZxJ0x1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1698126846295100005 Content-Type: text/plain; charset="utf-8" The MmCoreFfsFindMmDriver only checks for encapsulated compressed FVs. When an inner FV is uncompressed, StandaloneMmCore will miss the FV and all the MM drivers in the FV will not be dispatched. Add checks for uncompressed inner FV to fix this issue. Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Ray Ni Signed-off-by: Wei6 Xu --- StandaloneMmPkg/Core/FwVol.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/StandaloneMmPkg/Core/FwVol.c b/StandaloneMmPkg/Core/FwVol.c index 1f6d7714ba97..1a85d80eb9f7 100644 --- a/StandaloneMmPkg/Core/FwVol.c +++ b/StandaloneMmPkg/Core/FwVol.c @@ -104,6 +104,17 @@ MmCoreFfsFindMmDriver ( break; } =20 + Status =3D FfsFindSectionData ( + EFI_SECTION_FIRMWARE_VOLUME_IMAGE, + FileHeader, + &SectionData, + &SectionDataSize + ); + if (!EFI_ERROR (Status)) { + InnerFvHeader =3D (EFI_FIRMWARE_VOLUME_HEADER *)SectionData; + MmCoreFfsFindMmDriver (InnerFvHeader); + } + Status =3D FfsFindSectionData ( EFI_SECTION_GUID_DEFINED, FileHeader, --=20 2.29.2.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109986): https://edk2.groups.io/g/devel/message/109986 Mute This Topic: https://groups.io/mt/102152694/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-