From nobody Fri May 10 11:47:48 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+106848+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1689143074; cv=none; d=zohomail.com; s=zohoarc; b=Wh489PnQKMUOnKk5D6FaVkKWr+iOd+zYuCp8jfEiprC4/54k8xInOdbeq9XcOCiq0wNy+xmSG82p3+HoCNngvtCQlXSc3EtIuheacFBGqQ04lFQZoyk92mYvFLRnymCGolWVqxL2ydqyafC8M6WKKeB7wHIp5MkYia1v5SwhykQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1689143074; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=nOmAJSElKr8vUOzY9atY8VAK+JlGWwdWagPrg9WfZKk=; b=FmwVt9pwzoRJ7J4RyKl3ZcKpinQuwg1X7N1TxYyF+kIou/QXffuIOo9rbZ3/+mhovesC307oI9pW0rYLQ/2a2xGBds5k7IFlPc5gMpo45d3hOm49cPVfhgAxW2lKXu4YkH1+5NiGWyhexNcIYKpNOGBsjTcOqC5AKrNTpRzVmtU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+106848+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1689143074886479.92250146509934; Tue, 11 Jul 2023 23:24:34 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=oLB2UaFMHJ64NaPqhF4bHudwpVJNd19gCIdZiau0oGY=; c=relaxed/simple; d=groups.io; h=X-Received:X-Received:ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:X-Received:X-Received:X-MS-Exchange-Authentication-Results:Received-SPF:X-Received:X-Received:X-Received:X-Received:From:To:CC:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:X-EOPAttributedMessage:X-MS-PublicTrafficType:X-MS-TrafficTypeDiagnostic:X-MS-Office365-Filtering-Correlation-Id:X-MS-Exchange-SenderADCheck:X-MS-Exchange-AntiSpam-Relay:X-Microsoft-Antispam-Message-Info:X-OriginatorOrg:X-MS-Exchange-CrossTenant-OriginalArrivalTime:X-MS-Exchange-CrossTenant-Network-Message-Id:X-MS-Exchange-CrossTenant-Id:X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp:X-MS-Exchange-CrossTenant-AuthSource:X-MS-Exchange-CrossTenant-AuthAs:X-MS-Exchange-CrossTenant-FromEntityHeader:X-MS-Exchange-Transport-CrossTenantHeadersStamped:Precedence:List-Unsubscribe:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:X-Gm-Message-State:Content-Transfer-Encoding:Content-Type; s=20140610; t=1689143074; v=1; b=KzZ0TwHpZY64oQ20GSeJb71y0uAyNoEBIIL8+sCB0Q74zpQLX7VIWZUlofn4tYdOgK0uYtJ3 33cHbBrz0bBUyXaxAAIeF/l2oa+YHk7Jwy2vA3YNzvKjTMQaFcg862VKcTxCDJ2zKoT5nkeRrty 5RwqGwH3Yyl1ZT9jYuckWki0= X-Received: by 127.0.0.2 with SMTP id ZWqXYY1788612x2Tc1vyvuUL; Tue, 11 Jul 2023 23:24:34 -0700 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.53]) by mx.groups.io with SMTP id smtpd.web11.1549.1689143073680056722 for ; Tue, 11 Jul 2023 23:24:33 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eZoMQ2wSn68+seWkLDM7uF86cOrAHO44VXyUzK2uq2xH2dcBUEbZk0OgSlNdrpYERqfmraF1A3jivnH+Z5u9wqjaXTIqzIdPjk7MwmF2WRDMFS9Qb7HOyzA1aXlMWs9YBiBXp4J2h6wvl2t7UBY0ADJtFcchiwUj28u2Syyz43ozst42vj5YDFxBxoJ9BBG0jLxHG4IR6GtI4yu9rbgLVCLLKyIAdv3DF3ckGaPvxa1WSo67Jj5N04NDiclTka2pDAmwU6sfb3hcV1f+S1YILV91+x/kDQKlUQyzCuPgtFJa1Ae4cksQJXi06XKCeQI+toF7mL4SOPv/J0vCoyK/VA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LUk7S/Ue/B/A38BNsKGxw4DLl/aogKseevs+yPLDY3Q=; b=XS84b8OGk48U2II7V1MjrXGWPyVqChY3uSYKIX3fbRoO9NlzZ2M7ga7feggNEAbxfu2fYOTrD3E0PATggoQgFLeV3pq1VeUOMcyWqANEjC1WgPl3AWs7f1cZAlYNRyVoxx6iKlPcWUQXsEI3vmCPvoq7Hl0Rw+93wzOLAaE7G4waHX7kO+lq+2Ex0qSataDp/07sKz2y1q5r2YwWSlCwwwphxRlud6uENyXqZvY8rJs3nmrctf3PQcaz9L/EeiMXbEEir2OFJ/hHH6wnmleDuQsx/xlxhfXVMqSDGLjGotLNe4uP4iXv8v7Y9/3QDP9hUzAGlc47tz8LZRS27kISWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none X-Received: from DS7PR03CA0028.namprd03.prod.outlook.com (2603:10b6:5:3b8::33) by MN2PR12MB4096.namprd12.prod.outlook.com (2603:10b6:208:1dc::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.20; Wed, 12 Jul 2023 06:24:30 +0000 X-Received: from DM6NAM11FT022.eop-nam11.prod.protection.outlook.com (2603:10b6:5:3b8:cafe::e5) by DS7PR03CA0028.outlook.office365.com (2603:10b6:5:3b8::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.20 via Frontend Transport; Wed, 12 Jul 2023 06:24:30 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+106848+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C X-Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT022.mail.protection.outlook.com (10.13.172.210) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6588.20 via Frontend Transport; Wed, 12 Jul 2023 06:24:30 +0000 X-Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 12 Jul 2023 01:24:29 -0500 X-Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 11 Jul 2023 23:24:29 -0700 X-Received: from BLR-LAB-SFW01.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.23 via Frontend Transport; Wed, 12 Jul 2023 01:24:27 -0500 From: "Abdul Lateef Attar via groups.io" To: CC: Abdul Lateef Attar , Eric Dong , Ray Ni , Rahul Kumar , Gerd Hoffmann , Abner Chang Subject: [edk2-devel] [PATCH v1 1/1] UefiCpuPkg: Uses gMmst in MmSaveStateLib Date: Wed, 12 Jul 2023 11:54:21 +0530 Message-ID: <9f4ee69f63e53cf8e001d8e0ea516da131494b23.1689142923.git.abdattar@amd.com> In-Reply-To: References: MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT022:EE_|MN2PR12MB4096:EE_ X-MS-Office365-Filtering-Correlation-Id: 576874f1-084f-45df-8f41-08db82a0a671 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: CLPD4K5ajX+eldErHTNglKt3qyg0yx6HVkh6s6QB1rNXRFTq3V+bY70+hcuktA4L3OJ+4Po+JitlQfPNrdVmYQFytqqxyU4qgTYSJm5n0gIejcShgEhrLXAf1vLijRa0Xq2qFrl9HnFh3OydGs6d6Swh3Tg6VODYDb3ypdTkWf3h7O3Bj9TJUE9xEQiGtY4Wiin73Q1eKedH1JbfdSKDUuctS+pbDRyZVSm63f8MOHOmaFA8rYJ+b5N1CDIUAhIk51Qa32Kd6Xzi9O12Kno3DwCi0E3Fw21xAFz1LCe0GUsrRoGHWYsMMClgKGZHcg4NPMlnzaPCwGpIwWThWnqlRo+uKtqtuYewNuRyxLb/31vfO4GSGx5KDinomkCuat1sxY9aBV0bZXkjTDIESJxOyvFSMv9paE03Z6phCLK7bWZSUp2thDc+D4mZ4WokZcOKIoJdiMKQtJdGzBhKhiRdaKYAGgzWJ7Kdiep+pvUw1F5LzqSK0ZapZv3aJpiOO74vukaNGSGLhtGGUkXkb/M2+V1fK5/uQPKQoYWKOnETX5m/fbahjNBz2YmJzrYP2PKWB2Y8VLQGJY1GI1XHEBmIIhvjJkpsA7pZPkrDBwAdKB7uQAwiMBOXHPMM+lYrVHrNJ0U6SdrARrbpdc1kg5/XnzolkAwzkwxZt0XRGQJsZhmty8bMlJhhdK1Mwlw6jSX3GFmnTHQVzST10csJtq48ed6F6ZSHBEo9ULe17q0UIuE4rRB9exdwbJgCcXeniwLi X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2023 06:24:30.0958 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 576874f1-084f-45df-8f41-08db82a0a671 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT022.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4096 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abdattar@amd.com X-Gm-Message-State: Ee2S2oDIA4h7iQ1fOCqp4y1Xx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1689143076047100004 Content-Type: text/plain; charset="utf-8" From: Abdul Lateef Attar BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4182 Use gMmst instead of gSmst. Replace SmmServicesTableLib with MmServicesTableLib. Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Cc: Abner Chang Signed-off-by: Abdul Lateef Attar Acked-by: Abner Chang Reviewed-by: Ray Ni --- UefiCpuPkg/Library/MmSaveStateLib/AmdMmSaveStateLib.inf | 2 +- UefiCpuPkg/Library/MmSaveStateLib/IntelMmSaveStateLib.inf | 2 +- UefiCpuPkg/Library/MmSaveStateLib/MmSaveState.h | 2 +- UefiCpuPkg/Library/MmSaveStateLib/AmdMmSaveState.c | 4 ++-- UefiCpuPkg/Library/MmSaveStateLib/IntelMmSaveState.c | 2 +- UefiCpuPkg/Library/MmSaveStateLib/MmSaveStateCommon.c | 8 ++++---- 6 files changed, 10 insertions(+), 10 deletions(-) diff --git a/UefiCpuPkg/Library/MmSaveStateLib/AmdMmSaveStateLib.inf b/Uefi= CpuPkg/Library/MmSaveStateLib/AmdMmSaveStateLib.inf index 5c0685f283d3..dcee6c401d30 100644 --- a/UefiCpuPkg/Library/MmSaveStateLib/AmdMmSaveStateLib.inf +++ b/UefiCpuPkg/Library/MmSaveStateLib/AmdMmSaveStateLib.inf @@ -31,4 +31,4 @@ [LibraryClasses] BaseLib BaseMemoryLib DebugLib - SmmServicesTableLib + MmServicesTableLib diff --git a/UefiCpuPkg/Library/MmSaveStateLib/IntelMmSaveStateLib.inf b/Ue= fiCpuPkg/Library/MmSaveStateLib/IntelMmSaveStateLib.inf index b92dfa643203..b7fd4078f58a 100644 --- a/UefiCpuPkg/Library/MmSaveStateLib/IntelMmSaveStateLib.inf +++ b/UefiCpuPkg/Library/MmSaveStateLib/IntelMmSaveStateLib.inf @@ -31,4 +31,4 @@ [LibraryClasses] BaseLib BaseMemoryLib DebugLib - SmmServicesTableLib + MmServicesTableLib diff --git a/UefiCpuPkg/Library/MmSaveStateLib/MmSaveState.h b/UefiCpuPkg/L= ibrary/MmSaveStateLib/MmSaveState.h index c3499cbb3b17..6c7e8abd5f62 100644 --- a/UefiCpuPkg/Library/MmSaveStateLib/MmSaveState.h +++ b/UefiCpuPkg/Library/MmSaveStateLib/MmSaveState.h @@ -14,7 +14,7 @@ #include #include #include -#include +#include #include =20 // Macro used to simplify the lookup table entries of type CPU_MM_SAVE_STA= TE_REGISTER_RANGE diff --git a/UefiCpuPkg/Library/MmSaveStateLib/AmdMmSaveState.c b/UefiCpuPk= g/Library/MmSaveStateLib/AmdMmSaveState.c index 9fed52896f5c..3315a6cc44ff 100644 --- a/UefiCpuPkg/Library/MmSaveStateLib/AmdMmSaveState.c +++ b/UefiCpuPkg/Library/MmSaveStateLib/AmdMmSaveState.c @@ -108,7 +108,7 @@ MmSaveStateReadRegister ( UINT8 DataWidth; =20 // Read CPU State - CpuSaveState =3D (AMD_SMRAM_SAVE_STATE_MAP *)gSmst->CpuSaveState[CpuInde= x]; + CpuSaveState =3D (AMD_SMRAM_SAVE_STATE_MAP *)gMmst->CpuSaveState[CpuInde= x]; =20 // Check for special EFI_MM_SAVE_STATE_REGISTER_LMA if (Register =3D=3D EFI_MM_SAVE_STATE_REGISTER_LMA) { @@ -226,7 +226,7 @@ MmSaveStateWriteRegister ( return EFI_NOT_FOUND; } =20 - CpuSaveState =3D gSmst->CpuSaveState[CpuIndex]; + CpuSaveState =3D gMmst->CpuSaveState[CpuIndex]; =20 // // Do not write non-writable SaveState, because it will cause exception. diff --git a/UefiCpuPkg/Library/MmSaveStateLib/IntelMmSaveState.c b/UefiCpu= Pkg/Library/MmSaveStateLib/IntelMmSaveState.c index fd321bb571d5..c2ccd65b1dc4 100644 --- a/UefiCpuPkg/Library/MmSaveStateLib/IntelMmSaveState.c +++ b/UefiCpuPkg/Library/MmSaveStateLib/IntelMmSaveState.c @@ -296,7 +296,7 @@ MmSaveStateWriteRegister ( return EFI_NOT_FOUND; } =20 - CpuSaveState =3D gSmst->CpuSaveState[CpuIndex]; + CpuSaveState =3D gMmst->CpuSaveState[CpuIndex]; =20 // // Do not write non-writable SaveState, because it will cause exception. diff --git a/UefiCpuPkg/Library/MmSaveStateLib/MmSaveStateCommon.c b/UefiCp= uPkg/Library/MmSaveStateLib/MmSaveStateCommon.c index 09c6c3f96fed..f66245b82c40 100644 --- a/UefiCpuPkg/Library/MmSaveStateLib/MmSaveStateCommon.c +++ b/UefiCpuPkg/Library/MmSaveStateLib/MmSaveStateCommon.c @@ -99,8 +99,8 @@ MmSaveStateReadRegisterByIndex ( // // Write return buffer // - ASSERT (gSmst->CpuSaveState[CpuIndex] !=3D NULL); - CopyMem (Buffer, (UINT8 *)gSmst->CpuSaveState[CpuIndex] + mCpuWidthOff= set[RegisterIndex].Offset32, Width); + ASSERT (gMmst->CpuSaveState[CpuIndex] !=3D NULL); + CopyMem (Buffer, (UINT8 *)gMmst->CpuSaveState[CpuIndex] + mCpuWidthOff= set[RegisterIndex].Offset32, Width); } else { // // If 64-bit mode width is zero, then the specified register can not b= e accessed @@ -119,12 +119,12 @@ MmSaveStateReadRegisterByIndex ( // // Write lower 32-bits of return buffer // - CopyMem (Buffer, (UINT8 *)gSmst->CpuSaveState[CpuIndex] + mCpuWidthOff= set[RegisterIndex].Offset64Lo, MIN (4, Width)); + CopyMem (Buffer, (UINT8 *)gMmst->CpuSaveState[CpuIndex] + mCpuWidthOff= set[RegisterIndex].Offset64Lo, MIN (4, Width)); if (Width > 4) { // // Write upper 32-bits of return buffer // - CopyMem ((UINT8 *)Buffer + 4, (UINT8 *)gSmst->CpuSaveState[CpuIndex]= + mCpuWidthOffset[RegisterIndex].Offset64Hi, Width - 4); + CopyMem ((UINT8 *)Buffer + 4, (UINT8 *)gMmst->CpuSaveState[CpuIndex]= + mCpuWidthOffset[RegisterIndex].Offset64Hi, Width - 4); } } =20 --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#106848): https://edk2.groups.io/g/devel/message/106848 Mute This Topic: https://groups.io/mt/100095032/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-