Update CpuDxe MMU Logic to Improve Consistency

[edk2-devel] [PATCH 0/4] Update CpuDxe MMU Logic to Improve Consistency

Posted by Taylor Beebe 10 months, 1 week ago

This patch series:

1. Updates applies uncrustify to noncompliant files
2. Updates GetMemoryRegion() to handle the case where
   BaseAddress is an unmapped page, and update some other
   return values to be more consistent.
3. Adds some branching paths to what were previously only
   ASSERT statements to avoid dereferencing NULL and producing
   non-deterministic behavior when ASSERTs are disabled.
4. Adds function headers to the MMU logic documenting the
   behavior, parameters, and potetial return values.

Taylor Beebe (4):
  ArmPkg: Apply Uncrustify to Non-Compliant Files
  ArmPkg: Update GetMemoryRegion() to Handle No mapping
  ArmPkg: Fix Unsafe ASSERTs in MMU Logic
  ArmPkg: Add Function Headers to MMU Logic

Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>

 ArmPkg/Drivers/CpuDxe/AArch64/Mmu.c           | 143 ++++++++++++--
 ArmPkg/Drivers/CpuDxe/Arm/Mmu.c               | 187 ++++++++++++++----
 .../MmCommunicationPei/MmCommunicationPei.c   |   6 +-
 ArmPkg/Include/IndustryStandard/ArmStdSmc.h   |   8 +-
 4 files changed, 281 insertions(+), 63 deletions(-)

-- 
2.41.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#106517): https://edk2.groups.io/g/devel/message/106517
Mute This Topic: https://groups.io/mt/99854259/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/4] Update CpuDxe MMU Logic to Improve Consistency

Posted by Ard Biesheuvel 10 months ago

On Thu, 29 Jun 2023 at 18:20, Taylor Beebe <t@taylorbeebe.com> wrote:
>
> This patch series:
>
> 1. Updates applies uncrustify to noncompliant files
> 2. Updates GetMemoryRegion() to handle the case where
>    BaseAddress is an unmapped page, and update some other
>    return values to be more consistent.
> 3. Adds some branching paths to what were previously only
>    ASSERT statements to avoid dereferencing NULL and producing
>    non-deterministic behavior when ASSERTs are disabled.
> 4. Adds function headers to the MMU logic documenting the
>    behavior, parameters, and potetial return values.
>
> Taylor Beebe (4):
>   ArmPkg: Apply Uncrustify to Non-Compliant Files
>   ArmPkg: Update GetMemoryRegion() to Handle No mapping
>   ArmPkg: Fix Unsafe ASSERTs in MMU Logic
>   ArmPkg: Add Function Headers to MMU Logic
>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>

Thanks a lot for cleaning this up.

For the series,

Reviewed-by: Ard Biesheuvel <ardb@kernel.org>

I've submitted these to be merged,


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#106606): https://edk2.groups.io/g/devel/message/106606
Mute This Topic: https://groups.io/mt/99854259/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-