From nobody Sat May 11 08:39:03 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+93247+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93247+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1662483383; cv=none; d=zohomail.com; s=zohoarc; b=a1p0i6MwVR3UEF3jdhKV6N6z3/e8JpH3+L13A4krya0Kay+ayi0Ee0JRZMGZS3BindU1DTbid8+k2MRI7IUBwSWNY1T1BJhdlGC6JwKaYBXItLYwPRT1zUxK6XK9Gu3u3ofFmenJ+Q2ruegB3e6NrH8FD3Eahm0wKvqT9DyDy98= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1662483383; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=ww1uJbOHGA9xY1gEvEldi4jsCnKhk1g5Ol2MYEt2xMg=; b=mOuKeJcD8xVcm81azGN+8TmxyB/Xg7Q/6J6wA48Jc7onRZbMljuj0gghxoH+5ywZz5objPIZgEbDfduiuqf2dRKwvPRCqNmDhYqgEj4ifvof1aCjURpL4v2NJ+16rasJkBTV71pgGtjpiFq5CcDKMDOUkzfN25+UGvztPhQzplI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93247+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1662483383009873.679807397069; Tue, 6 Sep 2022 09:56:23 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id vvsPYY1788612xiAka796jXS; Tue, 06 Sep 2022 09:56:22 -0700 X-Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com [209.85.222.177]) by mx.groups.io with SMTP id smtpd.web10.1754.1662483380789316832 for ; Tue, 06 Sep 2022 09:56:20 -0700 X-Received: by mail-qk1-f177.google.com with SMTP id h27so8614603qkk.9 for ; Tue, 06 Sep 2022 09:56:20 -0700 (PDT) X-Gm-Message-State: HUm9ZVe5dZBCaEugjCkeZ7Emx1787277AA= X-Google-Smtp-Source: AA6agR7oPHRmV0GvFv8JxFM5kctgt4rOYnJxSWaNbqHUcK8Xkbmw2Z7PQyOhKFwJClnZUq4lFyaSaA== X-Received: by 2002:a05:620a:2a0d:b0:6b9:9976:1bf3 with SMTP id o13-20020a05620a2a0d00b006b999761bf3mr35307813qkp.255.1662483379688; Tue, 06 Sep 2022 09:56:19 -0700 (PDT) X-Received: from aturtleortwo-benjamindomain.. ([2607:f2c0:e98c:e:46bc:db07:bbf3:df6d]) by smtp.gmail.com with ESMTPSA id s7-20020a375e07000000b006b5e1aeb777sm10861247qkb.43.2022.09.06.09.56.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Sep 2022 09:56:19 -0700 (PDT) From: "Benjamin Doron" To: devel@edk2.groups.io Cc: Chasel Chiu , Nate DeSimone Subject: [edk2-devel][edk2-platforms][PATCH v1 1/4] KabylakeOpenBoardPkg/Acpi: BoardAcpiDxe also installs all PcdAcpiTableStorageFile Date: Tue, 6 Sep 2022 12:55:21 -0400 Message-Id: <873d3a93064c7a7f6d52eeefe97d04b949b24fb7.1662482547.git.benjamin.doron00@gmail.com> In-Reply-To: References: MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,benjamin.doron00@gmail.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1662483382; bh=MfdLgPHBkcZOY3yK9h+n38v1UASqpZf+pGoyefyI6j8=; h=Cc:Date:From:Reply-To:Subject:To; b=QPR/QCSSLNLYFf2Uzw9WafyO38oBygR15nor35LkceN5tvxZfE5hqDruuv/gZvBMLyx MCtM0JYEbVMdIQ8TgfwyuCnP0wJppPyEDKwi4DB41Sxi6DgYafpJlQ6WTTqg76DhPxcNX Zkyi+Ug9WRByuPSw8i+mtWwAV29Q/W9owTI= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1662483383778100010 Content-Type: text/plain; charset="utf-8" Follow AcpiPlatformDxe (from which this module is derived) and install all ACPI tables added by board. Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Benjamin Doron --- .../Acpi/BoardAcpiDxe/BoardAcpiDxe.c | 15 ++++++++++++++- .../Acpi/BoardAcpiDxe/BoardAcpiDxe.inf | 2 ++ 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcp= iDxe.c b/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe= .c index 0361ffc2fbf9..c6df1714af9a 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.c +++ b/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.c @@ -288,7 +288,20 @@ InstallAcpiBoard ( // // Platform ACPI Tables // - PublishAcpiTablesFromFv (&gEfiCallerIdGuid); + Status =3D PublishAcpiTablesFromFv (&gEfiCallerIdGuid); + if (EFI_ERROR (Status)) { + DEBUG ((DEBUG_ERROR, "Error: PublishAcpiTablesFromFv[%g] - %r", &gEfiC= allerIdGuid, Status)); + } + Status =3D PublishAcpiTablesFromFv (PcdGetPtr (PcdAcpiTableStorageFile)); + if (EFI_ERROR (Status)) { + DEBUG (( + DEBUG_ERROR, + "Error: PublishAcpiTablesFromFv[%g] - %r", + PcdGetPtr (PcdAcpiTableStorageFile), + Status + )); + DEBUG ((DEBUG_INFO, "Does board contain ACPI tables?\n")); + } =20 // // This protocol publish must be done after PublishAcpiTablesFromFv. diff --git a/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcp= iDxe.inf b/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiD= xe.inf index 5d3d4c3a2b33..7b400cf967f3 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf +++ b/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf @@ -67,6 +67,8 @@ gKabylakeOpenBoardPkgTokenSpaceGuid.PcdDisablePassiveTripPoints gKabylakeOpenBoardPkgTokenSpaceGuid.PcdDisableCriticalTripPoints =20 + gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiTableStorageFile + [Depex] gEfiAcpiTableProtocolGuid AND gEfiFirmwareVolume2ProtocolGuid AND --=20 2.37.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93247): https://edk2.groups.io/g/devel/message/93247 Mute This Topic: https://groups.io/mt/93505943/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 11 08:39:03 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+93248+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93248+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1662483383; cv=none; d=zohomail.com; s=zohoarc; b=PL5cZfSInH4nW19x6/8xjpMjXqpSmP2u6mswAeoJPTs1x6RbnvbrLSBbgGmFiZ9bAjj2OTQCt6ViPSDxe0luJuihCKKRi+2ixJliyokhb+tXK87iaiieZMGZ3Z8WtgclFYFmvS0+dvMDLyaduYrX1RYuVYDHJhePiQXi0q0ae3Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1662483383; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=f/GElbwVEDwKICxj1k1K6PBXlCQvb39RYogNAisVXE8=; b=DiEneKjpe7yBtBbZT30yWuORKRO5Grxaltttv1jyCLfX8bbISgjxx5u65Xyzw2gDsOCmlE/3CEI3b/EmQtvFjjcyUpBmgHTmnU341qM0W6ONJtxR5OFI0Xjc/EKbhNxUjBonrO4Q3nLsONI1IuOwQnHOr5mVXrEokNq7Ev+MZKQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93248+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1662483383279964.5325195658113; Tue, 6 Sep 2022 09:56:23 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 4w1rYY1788612xvFLK5o6UdY; Tue, 06 Sep 2022 09:56:22 -0700 X-Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) by mx.groups.io with SMTP id smtpd.web08.1753.1662483382066897105 for ; Tue, 06 Sep 2022 09:56:22 -0700 X-Received: by mail-qk1-f169.google.com with SMTP id b9so8639714qka.2 for ; Tue, 06 Sep 2022 09:56:21 -0700 (PDT) X-Gm-Message-State: mC9krAQ9V7fqg3WxJWbsMOOlx1787277AA= X-Google-Smtp-Source: AA6agR6bG1PmunlsN9AqVGwWPRVdBSh/NPIpSlEFq7jYro7axvqLSQ2oyp3LLkLXWwbOcskiZRRd+A== X-Received: by 2002:a05:620a:1432:b0:6be:6c4a:b800 with SMTP id k18-20020a05620a143200b006be6c4ab800mr36360515qkj.578.1662483380916; Tue, 06 Sep 2022 09:56:20 -0700 (PDT) X-Received: from aturtleortwo-benjamindomain.. ([2607:f2c0:e98c:e:46bc:db07:bbf3:df6d]) by smtp.gmail.com with ESMTPSA id s7-20020a375e07000000b006b5e1aeb777sm10861247qkb.43.2022.09.06.09.56.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Sep 2022 09:56:20 -0700 (PDT) From: "Benjamin Doron" To: devel@edk2.groups.io Cc: Chasel Chiu , Nate DeSimone , Rangasai V Chaganty , Deepika Kethi Reddy , Kathappan Esakkithevar Subject: [edk2-devel][edk2-platforms][PATCH v1 2/4] CometlakeOpenBoardPkg/Acpi: BoardAcpiDxe also installs all PcdAcpiTableStorageFile Date: Tue, 6 Sep 2022 12:55:22 -0400 Message-Id: <6e0303689772f9494865150d6a3b9171655f80a4.1662482547.git.benjamin.doron00@gmail.com> In-Reply-To: References: MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,benjamin.doron00@gmail.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1662483382; bh=nojLuiANgjEF8uDQUe2WnEZoexrZyHzuJdUDqGJ1sxE=; h=Cc:Date:From:Reply-To:Subject:To; b=OY1Nxh4mWKEcr28/oFTIHzfF/4ZI0naCwfF4FbAFKw5R1WBKhVwbmb/7lFz+VmgMec3 htpd/rDSzGQ/nF217OQL62ijodEmzmbPbz4ve/ciOQO1XFJgoPrXYbUL/PbyA/Bfx3otN vgejLJg6Oilu4ELmKpn5AsFw6arQP0/lc3w= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1662483383776100009 Content-Type: text/plain; charset="utf-8" Follow AcpiPlatformDxe (from which this module is derived) and install all ACPI tables added by board. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Rangasai V Chaganty Cc: Deepika Kethi Reddy Cc: Kathappan Esakkithevar Signed-off-by: Benjamin Doron --- .../Acpi/BoardAcpiDxe/BoardAcpiDxe.c | 15 ++++++++++++++- .../Acpi/BoardAcpiDxe/BoardAcpiDxe.inf | 2 ++ 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/Platform/Intel/CometlakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAc= piDxe.c b/Platform/Intel/CometlakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiD= xe.c index 7fc71bca644a..ba59c84fd4ba 100644 --- a/Platform/Intel/CometlakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.c +++ b/Platform/Intel/CometlakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.c @@ -270,7 +270,20 @@ InstallAcpiBoard ( // // Platform ACPI Tables // - PublishAcpiTablesFromFv (&gEfiCallerIdGuid); + Status =3D PublishAcpiTablesFromFv (&gEfiCallerIdGuid); + if (EFI_ERROR (Status)) { + DEBUG ((DEBUG_ERROR, "Error: PublishAcpiTablesFromFv[%g] - %r", &gEfiC= allerIdGuid, Status)); + } + Status =3D PublishAcpiTablesFromFv (PcdGetPtr (PcdAcpiTableStorageFile)); + if (EFI_ERROR (Status)) { + DEBUG (( + DEBUG_ERROR, + "Error: PublishAcpiTablesFromFv[%g] - %r", + PcdGetPtr (PcdAcpiTableStorageFile), + Status + )); + DEBUG ((DEBUG_INFO, "Does board contain ACPI tables?\n")); + } =20 // // This protocol publish must be done after PublishAcpiTablesFromFv. diff --git a/Platform/Intel/CometlakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAc= piDxe.inf b/Platform/Intel/CometlakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcp= iDxe.inf index 09b67376fbc1..e201964a6896 100644 --- a/Platform/Intel/CometlakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.i= nf +++ b/Platform/Intel/CometlakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.i= nf @@ -62,6 +62,8 @@ gMinPlatformPkgTokenSpaceGuid.PcdPciReservedMemBase gMinPlatformPkgTokenSpaceGuid.PcdPciReservedMemLimit =20 + gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiTableStorageFile + [Depex] gEfiAcpiTableProtocolGuid AND gEfiFirmwareVolume2ProtocolGuid AND --=20 2.37.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93248): https://edk2.groups.io/g/devel/message/93248 Mute This Topic: https://groups.io/mt/93505944/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 11 08:39:03 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+93249+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93249+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1662483385; cv=none; d=zohomail.com; s=zohoarc; b=OdeYBm9bHMO4/wZuMCy7NIi+5ixrs6OLXEOapy5l3Y9Gc3ygxajz4hErw9HlqpO26KzBizzWFDgSHi2eZFDNIog5NkYjaFzuUiWHq7O+8KkvIa7YhciKWKzgg+GISZtIPMmcKqegN4qgqbCLa/fraR1KFjgKKyjU/BX9qDB+0Jk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1662483385; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=J4nPR6frxOXnp4FSvm21pIBTgJqJ3IFKsnA4EcYKoLQ=; b=WxXEuPMPYKoqAGLN3V32oU+AOVtEZVk+XMce3uQWeCWSzMMzVRpeuhRUqKDlmqVZSIndrVl699fjakjF+tDgKCdbWnGaA5h1eklPobctpIulSSAmsWVYYW8dzEWpcM/B486KCmvv2fYDSaSklof3kO5Eme08QEhUwNrOeWwJ5C8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93249+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1662483385365571.9729891926686; Tue, 6 Sep 2022 09:56:25 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id Su6JYY1788612xNrzTt0HaMm; Tue, 06 Sep 2022 09:56:23 -0700 X-Received: from mail-qv1-f47.google.com (mail-qv1-f47.google.com [209.85.219.47]) by mx.groups.io with SMTP id smtpd.web09.1785.1662483383158801725 for ; Tue, 06 Sep 2022 09:56:23 -0700 X-Received: by mail-qv1-f47.google.com with SMTP id i15so109204qvp.5 for ; Tue, 06 Sep 2022 09:56:23 -0700 (PDT) X-Gm-Message-State: upXuSyVn7wspRI3YwsDy2Xeix1787277AA= X-Google-Smtp-Source: AA6agR70ILPa7EiC0WzmzSOzpPhk7HlbMsJIRxiRv+9uyWeztlVokxmevw04rnxkKZYvO/3wn51JyQ== X-Received: by 2002:a05:6214:76f:b0:47b:31f3:db89 with SMTP id f15-20020a056214076f00b0047b31f3db89mr45360938qvz.68.1662483382136; Tue, 06 Sep 2022 09:56:22 -0700 (PDT) X-Received: from aturtleortwo-benjamindomain.. ([2607:f2c0:e98c:e:46bc:db07:bbf3:df6d]) by smtp.gmail.com with ESMTPSA id s7-20020a375e07000000b006b5e1aeb777sm10861247qkb.43.2022.09.06.09.56.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Sep 2022 09:56:21 -0700 (PDT) From: "Benjamin Doron" To: devel@edk2.groups.io Cc: Chasel Chiu , Nate DeSimone , Liming Gao , Eric Dong Subject: [edk2-devel][edk2-platforms][PATCH v1 3/4] MinPlatformPkg/Acpi: MinDsdt also installs all PcdAcpiTableStorageFile Date: Tue, 6 Sep 2022 12:55:23 -0400 Message-Id: In-Reply-To: References: MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,benjamin.doron00@gmail.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1662483383; bh=gDEg3h+KmSPiany+HCcEVzdzMbpmQCGFXl+WgwN/OT0=; h=Cc:Date:From:Reply-To:Subject:To; b=olzAIPLWeuumFAQ2aSDmegMNnEZh4uDn13gYmXr4IoZsk5Ef8AkjNfyG2Vj43iJD+fw n7yebrjPEEDq1EBcsBKJN8ADKGb8nvV5zWcd7qzmoZ1V/Khl9lah1IcfzJy2qGDBYwmeI 3z4/0evlqwQq4f6vD1xdA1fHlTTBfMc52Es= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1662483385810100019 Content-Type: text/plain; charset="utf-8" Follow AcpiPlatformDxe (from which this module is derived) and install all ACPI tables added by board. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Signed-off-by: Benjamin Doron --- Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c | 10 ++++++++++ Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf | 3 +++ 2 files changed, 13 insertions(+) diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c b/Platfor= m/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c index 9bc222453857..ac343afca7d4 100644 --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c @@ -227,6 +227,16 @@ InstallMinDsdt ( =20 Status =3D PublishAcpiTablesFromFv (&gEfiCallerIdGuid); ASSERT_EFI_ERROR (Status); + Status =3D PublishAcpiTablesFromFv (PcdGetPtr (PcdAcpiTableStorageFile)); + if (EFI_ERROR (Status)) { + DEBUG (( + DEBUG_ERROR, + "Error: PublishAcpiTablesFromFv[%g] - %r", + PcdGetPtr (PcdAcpiTableStorageFile), + Status + )); + DEBUG ((DEBUG_INFO, "Does board contain ACPI tables?\n")); + } =20 return EFI_SUCCESS; } diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf b/Platf= orm/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf index 3437bc489cd3..dc32186eb361 100644 --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf @@ -21,6 +21,7 @@ =20 [Packages] MdePkg/MdePkg.dec + MdeModulePkg/MdeModulePkg.dec MinPlatformPkg/MinPlatformPkg.dec =20 [LibraryClasses] @@ -41,6 +42,8 @@ gMinPlatformPkgTokenSpaceGuid.PcdPciReservedMemBase gMinPlatformPkgTokenSpaceGuid.PcdPciReservedMemLimit =20 + gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiTableStorageFile + [Depex] gEfiAcpiTableProtocolGuid AND gEfiFirmwareVolume2ProtocolGuid --=20 2.37.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93249): https://edk2.groups.io/g/devel/message/93249 Mute This Topic: https://groups.io/mt/93505946/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 11 08:39:03 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+93250+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93250+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1662483385; cv=none; d=zohomail.com; s=zohoarc; b=F6tAD8xcIKw8em7DB5MyTJFAV0aT9MnPAHUh3U9U65PG/gEh4dJhIpMEEzXIhuZBOVJ77NDvtw0A3Tub1Zx9P3jchP90qGLJrPjBR2KDVDGC9GJQtwgtZm/8IUNGU0ley1CM8d/2OaRwKL+VbD4QtUR9IgUQvAvuaQFYkXDnRq8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1662483385; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=7kqQa3lse2IPn/AXquzJy6DS0vcega+dKQD34wn98EY=; b=N9ziPCf7/2cSldkLtIQ7C7cDaK0RcqzFz+xeqJx4rH7vT9Iv/529Tdt1Qp08kqAD3KSLjJjhkncFNgimzgAKIi9I3bss0EqpSQPFtyNF/CBN23EnquFOcZk8nmNtANLSt2SySeo43+8frChmT2LTSryn9y2qRagSXsk5VhvfKwc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93250+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1662483385741112.88541263798231; Tue, 6 Sep 2022 09:56:25 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id kF5rYY1788612xX4nnZ4PffR; Tue, 06 Sep 2022 09:56:25 -0700 X-Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) by mx.groups.io with SMTP id smtpd.web08.1755.1662483384557460430 for ; Tue, 06 Sep 2022 09:56:24 -0700 X-Received: by mail-qt1-f176.google.com with SMTP id l5so8510188qtv.4 for ; Tue, 06 Sep 2022 09:56:24 -0700 (PDT) X-Gm-Message-State: seZDC1mUCliXFHfWaUQJS4n2x1787277AA= X-Google-Smtp-Source: AA6agR7RYUpun+2ysHI4RcqQlCgBDAzmHJI6zNp4JTq6j8u3Mx7ED7QVO32bcdWZDKiSVyHLuOieKA== X-Received: by 2002:a05:622a:546:b0:343:5a1a:9a9c with SMTP id m6-20020a05622a054600b003435a1a9a9cmr44961815qtx.417.1662483383412; Tue, 06 Sep 2022 09:56:23 -0700 (PDT) X-Received: from aturtleortwo-benjamindomain.. ([2607:f2c0:e98c:e:46bc:db07:bbf3:df6d]) by smtp.gmail.com with ESMTPSA id s7-20020a375e07000000b006b5e1aeb777sm10861247qkb.43.2022.09.06.09.56.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Sep 2022 09:56:22 -0700 (PDT) From: "Benjamin Doron" To: devel@edk2.groups.io Cc: Chasel Chiu , Nate DeSimone Subject: [edk2-devel][edk2-platforms][PATCH v1 4/4] WhiskeylakeOpenBoardPkg/Acpi: BoardAcpiDxe also installs all PcdAcpiTableStorageFile Date: Tue, 6 Sep 2022 12:55:24 -0400 Message-Id: <33c3bef31299b6b06e250bbe59a709dc9af1e7e5.1662482547.git.benjamin.doron00@gmail.com> In-Reply-To: References: MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,benjamin.doron00@gmail.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1662483385; bh=uInHl5hBYUrr75HcPTJ5cehqSbj9IWr0z5Qzxg/lUUA=; h=Cc:Date:From:Reply-To:Subject:To; b=bh2RfbZsfgG1afe7MUj0xF6dlHVO5Mg9EBK0dRItUoymVDKOOG2NPlPA6mgcfIXRn7z sUJ7ez2wkg+FGH8b1zyZployFwvH/F7FGZkqPPEtmw7xt8kMOAq9iu0IKAE9AuYFlKPc8 K8pbnZz9zxbd9QFfi2XVx9ZizJJtvAyurjw= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1662483387795100023 Content-Type: text/plain; charset="utf-8" Follow AcpiPlatformDxe (from which this module is derived) and install all ACPI tables added by board. Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Benjamin Doron --- .../Acpi/BoardAcpiDxe/BoardAcpiDxe.c | 15 ++++++++++++++- .../Acpi/BoardAcpiDxe/BoardAcpiDxe.inf | 2 ++ 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/Acpi/BoardAcpiDxe/Board= AcpiDxe.c b/Platform/Intel/WhiskeylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardA= cpiDxe.c index cb5f328a3909..c8c1e0cc2cf2 100644 --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe= .c +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe= .c @@ -270,7 +270,20 @@ InstallAcpiBoard ( // // Platform ACPI Tables // - PublishAcpiTablesFromFv (&gEfiCallerIdGuid); + Status =3D PublishAcpiTablesFromFv (&gEfiCallerIdGuid); + if (EFI_ERROR (Status)) { + DEBUG ((DEBUG_ERROR, "Error: PublishAcpiTablesFromFv[%g] - %r", &gEfiC= allerIdGuid, Status)); + } + Status =3D PublishAcpiTablesFromFv (PcdGetPtr (PcdAcpiTableStorageFile)); + if (EFI_ERROR (Status)) { + DEBUG (( + DEBUG_ERROR, + "Error: PublishAcpiTablesFromFv[%g] - %r", + PcdGetPtr (PcdAcpiTableStorageFile), + Status + )); + DEBUG ((DEBUG_INFO, "Does board contain ACPI tables?\n")); + } =20 // // This protocol publish must be done after PublishAcpiTablesFromFv. diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/Acpi/BoardAcpiDxe/Board= AcpiDxe.inf b/Platform/Intel/WhiskeylakeOpenBoardPkg/Acpi/BoardAcpiDxe/Boar= dAcpiDxe.inf index af5c8f1c0609..f17fb588ddb8 100644 --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe= .inf +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe= .inf @@ -60,6 +60,8 @@ gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdDisablePassiveTripPoints gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdDisableCriticalTripPoints =20 + gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiTableStorageFile + [Depex] gEfiAcpiTableProtocolGuid AND gEfiFirmwareVolume2ProtocolGuid AND --=20 2.37.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93250): https://edk2.groups.io/g/devel/message/93250 Mute This Topic: https://groups.io/mt/93505950/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-