BaseTools: RegEx refactoring

[edk2] [PATCH v1 0/5] BaseTools: RegEx refactoring

Jaben Carsey posted 5 patches 6 years ago

Download series mbox

Failed in applying to current master (apply log)

BaseTools/Source/Python/AutoGen/AutoGen.py        | 22 +++++++++++++-------
BaseTools/Source/Python/AutoGen/IdfClassObject.py |  5 +++--
BaseTools/Source/Python/AutoGen/UniClassObject.py |  8 +++----
BaseTools/Source/Python/Common/GlobalData.py      |  3 +++
BaseTools/Source/Python/GenFds/FdfParser.py       |  5 ++---
5 files changed, 27 insertions(+), 16 deletions(-)

Expand all Fold all

[edk2] [PATCH v1 0/5] BaseTools: RegEx refactoring

Posted by Jaben Carsey 6 years ago

move RegEx compile out of functions/loops
share RegEx when have identical data

Jaben Carsey (5):
  BaseTools: Autogen - move RegEx compile
  BaseTools: GenFds - move RegEx compile
  BaseTools: Add new RegEx pattern to GlobalData
  BaseTools: AutoGen - use the new shared RegEx
  BaseTools: remove redundant check

 BaseTools/Source/Python/AutoGen/AutoGen.py        | 22 +++++++++++++-------
 BaseTools/Source/Python/AutoGen/IdfClassObject.py |  5 +++--
 BaseTools/Source/Python/AutoGen/UniClassObject.py |  8 +++----
 BaseTools/Source/Python/Common/GlobalData.py      |  3 +++
 BaseTools/Source/Python/GenFds/FdfParser.py       |  5 ++---
 5 files changed, 27 insertions(+), 16 deletions(-)

-- 
2.16.2.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v1 0/5] BaseTools: RegEx refactoring

Posted by Zhu, Yonghong 6 years ago

The patches are good to me.

Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 

Best Regards,
Zhu Yonghong


-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Jaben Carsey
Sent: Wednesday, April 04, 2018 6:34 AM
To: edk2-devel@lists.01.org
Subject: [edk2] [PATCH v1 0/5] BaseTools: RegEx refactoring

move RegEx compile out of functions/loops share RegEx when have identical data

Jaben Carsey (5):
  BaseTools: Autogen - move RegEx compile
  BaseTools: GenFds - move RegEx compile
  BaseTools: Add new RegEx pattern to GlobalData
  BaseTools: AutoGen - use the new shared RegEx
  BaseTools: remove redundant check

 BaseTools/Source/Python/AutoGen/AutoGen.py        | 22 +++++++++++++-------
 BaseTools/Source/Python/AutoGen/IdfClassObject.py |  5 +++--  BaseTools/Source/Python/AutoGen/UniClassObject.py |  8 +++----
 BaseTools/Source/Python/Common/GlobalData.py      |  3 +++
 BaseTools/Source/Python/GenFds/FdfParser.py       |  5 ++---
 5 files changed, 27 insertions(+), 16 deletions(-)

--
2.16.2.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel