From nobody Fri May 17 05:00:05 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+87463+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+87463+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1647006086; cv=none; d=zohomail.com; s=zohoarc; b=YGQycU1O/ys8+H4hi7mlnGb4f6z1gzE2OfSRZiluECz9TetHs6GNhzWpM9xTt65MsfXic75FoXP8sV35c/RdUgSsRM9lP14/41hFSznfixevAdkG8CipT8y3YHnP1m06wGui3SGwCP7W+XaggBestxkuCNcNtIFyOkV7SyGNWjY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1647006086; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=SOjc3ANwJaFP2MiIizZ99aEHbDuGr+w0vkEC1A6ntQ4=; b=lshqKag6JVI7rQtGwFsXem5eEIIy5xOW/3r7a9oxm3LOWM5qXmhQRC7v8iFr2votyGuQ+nGNRc20qlIqPjuPVonfxGiAjC4Du/7XzqwuyEumNLL4MncKkHyNW6JaOJX6cXXCIWRW/KzD+TbpTfUyoGWyROdPV3kWh1HH/03y8Q0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+87463+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1647006086804759.2872473623871; Fri, 11 Mar 2022 05:41:26 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id b6lJYY1788612x830YyOJPxw; Fri, 11 Mar 2022 05:41:26 -0800 X-Received: from smarthost01b.ixn.mail.zen.net.uk (smarthost01b.ixn.mail.zen.net.uk [212.23.1.21]) by mx.groups.io with SMTP id smtpd.web08.5297.1647006084561062087 for ; Fri, 11 Mar 2022 05:41:24 -0800 X-Received: from [51.148.147.4] (helo=sean-StarBook.lan) by smarthost01b.ixn.mail.zen.net.uk with esmtp (Exim 4.90_1) (envelope-from ) id 1nSfWB-0003Ek-NA; Fri, 11 Mar 2022 13:41:19 +0000 From: "Sean Rhodes" To: devel@edk2.groups.io Cc: Guo Dong , Ray Ni , Maurice Ma , Benjamin You Subject: [edk2-devel] [PATCH] UefiPayloadPkg: Fix build error Date: Fri, 11 Mar 2022 13:41:17 +0000 Message-Id: MIME-Version: 1.0 X-Originating-smarthost01b-IP: [51.148.147.4] Feedback-ID: 51.148.147.4 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sean@starlabs.systems X-Gm-Message-State: r5dGaztd2uTnpT0vanAq7c32x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1647006086; bh=dGbBThNkTZeP+OKCxHCen739eGAifHbkCIXP5EsF3mM=; h=Cc:Date:From:Reply-To:Subject:To; b=ekrEmkq646fKFC/S7hHarbMSVy7baLjjWu88qp353wNANS1e34ECufNSLDKd8zs067p 7tOblaLNriHkL3hkc11IMOspndKPxdDoUQJAR7wnr7qenk5VdTA9Z9/H7+fc7MApYDXcz hz43CveKW/zWN85xO1td5Lgw6ttsm3E/Hyc= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1647006088499100001 Content-Type: text/plain; charset="utf-8" From: Guo Dong On windows build, need add -DPLATFORMX64_ENABLE=3DTRUE in the build command line beside -DNETWORK_DRIVER_ENABLE=3DTRUE in order build network features. So set PLATFORMX64_ENABLE to TRUE when need build network feature. On Linux build, DSC file should not have PcdAllowHttpConnections when network feature is not built, else would cause build error. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: Guo Dong Reviewed-by Sean Rhodes --- UefiPayloadPkg/UefiPayloadPkg.dsc | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPayload= Pkg.dsc index 558513baf1..f3806a8ebc 100644 --- a/UefiPayloadPkg/UefiPayloadPkg.dsc +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc @@ -407,7 +407,9 @@ [PcdsPatchableInModule.X64] gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister|$(RTC_INDEX_REGISTER) gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister|$(RTC_TARGET_REGISTER) +!if $(NETWORK_DRIVER_ENABLE) =3D=3D TRUE gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE +!endif =20 [PcdsPatchableInModule.common] gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21, 0xaa, 0x2c= , 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0x66, 0x23, 0= x31 } @@ -530,6 +532,8 @@ # UEFI network modules # !if $(NETWORK_DRIVER_ENABLE) =3D=3D TRUE +[Defines] + DEFINE PLATFORMX64_ENABLE =3D TRUE !include NetworkPkg/Network.dsc.inc !endif =20 --=20 2.32.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#87463): https://edk2.groups.io/g/devel/message/87463 Mute This Topic: https://groups.io/mt/89710183/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-