From nobody Sun May 19 20:29:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+99094+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+99094+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1674762853; cv=none; d=zohomail.com; s=zohoarc; b=ShfdTMBQLSla2fobyq2MOz7zlxo3F7jsM95Z+0Lek+mVFxwycA0jnJ98Ky/TcF/vT0s5ZVb38keEhalZ+T++02AToo8vJXxlqR/FH7SOvH2Ik4PYWEdMbtAM/iCdgwu5pokVS5m14GLh+ii5ssKwIiodyX+pLd3+jGxJ0+Dqfg0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1674762853; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=5UYMRkGLZrbInwDjebVmdtCCDjwPOkW6Qzn6myclF7k=; b=cRHDC2NFk8IzTjPC7ktRuCdYO+sWBVkG7yfGS2yr6kcjyuvWF+1XrNStF9CZjFpWOc7lMEiHqPYXsJd3sazT8yHNmTNzcTf52h+uidl3SznTEpXeo6JohKkkww9W5Q5jg6duIBg3wQSyxnZqxyVt5maGyIv5eADKLmR2x8pIwi0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+99094+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1674762853420690.7736083721198; Thu, 26 Jan 2023 11:54:13 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id tpxZYY1788612xogrHJziUsK; Thu, 26 Jan 2023 11:54:13 -0800 X-Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by mx.groups.io with SMTP id smtpd.web11.82064.1674757764856764959 for ; Thu, 26 Jan 2023 10:29:24 -0800 X-Received: by mail-pf1-f173.google.com with SMTP id 203so393790pfx.6 for ; Thu, 26 Jan 2023 10:29:24 -0800 (PST) X-Gm-Message-State: KTu1dOO034zRQONJvfi3ubRcx1787277AA= X-Google-Smtp-Source: AMrXdXsdSDeGt0ubFCugXqMR4dw1U8EGdHZhPoQq/bN4Yr1ugjt7c1tccUWVQhe5zh1WulAU0Q4gnA== X-Received: by 2002:a05:6a00:2a04:b0:582:26bc:a75b with SMTP id ce4-20020a056a002a0400b0058226bca75bmr37659127pfb.9.1674757764148; Thu, 26 Jan 2023 10:29:24 -0800 (PST) X-Received: from archlinux.bits-pilani.ac.in ([103.144.92.160]) by smtp.gmail.com with ESMTPSA id c136-20020a624e8e000000b005898fcb7c2bsm1150299pfb.170.2023.01.26.10.29.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Jan 2023 10:29:23 -0800 (PST) From: "Sahil Siddiq" To: devel@edk2.groups.io Cc: Sahil Siddiq Subject: [edk2-devel] [PATCH] MdeModulePkg/SmmLockBoxLib: Remove dead code Date: Thu, 26 Jan 2023 23:59:06 +0530 Message-Id: MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,icegambit91@gmail.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1674762853; bh=xr54jW196Uruzop9SKGeG172pkqespdoWtEYbA4roUk=; h=Cc:Date:From:Reply-To:Subject:To; b=ZKhJH1L6se7FlO0Bnx6JFRrGXQFYKO/jNgaPHXaeUIqifnbyblo0hW4yFJxlO6k4oH/ +7936HaA275M70Mbd598tJJM6iAd2ujeEkymbpZuX8Q4g1nweYjNgLHi/a7Jl8BSTIXzP +pJ+mU4J0jHjKfVvZGMpX0XRmWFYihjYTmQ= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1674762854598100008 Content-Type: text/plain; charset="utf-8" Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4317 The "if" condition on line 554 ensures that Guid won't be NULL (or 0) on li= ne 600. So, there will never be a situation where the "else" block on line 603 is e= xecuted. Signed-off-by: Sahil Siddiq --- MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxPeiLib.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxPeiLib.c b/MdeMod= ulePkg/Library/SmmLockBoxLib/SmmLockBoxPeiLib.c index 69d4c42ad1..9326158bd4 100644 --- a/MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxPeiLib.c +++ b/MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxPeiLib.c @@ -597,11 +597,7 @@ RestoreLockBox ( LockBoxParameterRestore->Header.Command =3D EFI_SMM_LOCK_BOX_COMMAN= D_RESTORE; LockBoxParameterRestore->Header.DataLength =3D sizeof (*LockBoxParamet= erRestore); LockBoxParameterRestore->Header.ReturnStatus =3D (UINT64)-1; - if (Guid !=3D 0) { - CopyMem (&LockBoxParameterRestore->Guid, Guid, sizeof (*Guid)); - } else { - ZeroMem (&LockBoxParameterRestore->Guid, sizeof (*Guid)); - } + CopyMem (&LockBoxParameterRestore->Guid, Guid, sizeof (*Guid)); =20 LockBoxParameterRestore->Buffer =3D (EFI_PHYSICAL_ADDRESS)(UINTN)Buffer; if (Length !=3D NULL) { --=20 2.39.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#99094): https://edk2.groups.io/g/devel/message/99094 Mute This Topic: https://groups.io/mt/96551254/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-