DynamicTablesPkg: SSDT _LPI revision is incorrect

[edk2-devel] [PATCH] DynamicTablesPkg: SSDT _LPI revision is incorrect

Posted by Jeff Brasen via groups.io 1 year, 5 months ago

_LPI Revision should be 0 per the ACPI 6.5 specification.
"The revision number of the _LPI object. Current revision is 0."

Signed-off-by: Jeff Brasen <jbrasen@nvidia.com>
---
 .../Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c
index d06c7615fb..91199c4af2 100644
--- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c
+++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c
@@ -482,7 +482,7 @@ GenerateLpiStates (
     }
 
     // We do not support the LevelId field for now, let it to 0.
-    Status = AmlCreateLpiNode (AslName, 1, 0, ScopeNode, &LpiNode);
+    Status = AmlCreateLpiNode (AslName, 0, 0, ScopeNode, &LpiNode);
     if (EFI_ERROR (Status)) {
       ASSERT (0);
       return Status;
-- 
2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#96407): https://edk2.groups.io/g/devel/message/96407
Mute This Topic: https://groups.io/mt/95048993/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] DynamicTablesPkg: SSDT _LPI revision is incorrect

Posted by Sami Mujawar 1 year, 4 months ago

Hi Jeff,

Apologies for the delay and thank you for this fix.

This change looks good to me.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

On 15/11/2022 06:01 pm, Jeff Brasen wrote:
> _LPI Revision should be 0 per the ACPI 6.5 specification.
> "The revision number of the _LPI object. Current revision is 0."
>
> Signed-off-by: Jeff Brasen <jbrasen@nvidia.com>
> ---
>   .../Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c    | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c
> index d06c7615fb..91199c4af2 100644
> --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c
> +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c
> @@ -482,7 +482,7 @@ GenerateLpiStates (
>       }
>   
>       // We do not support the LevelId field for now, let it to 0.
> -    Status = AmlCreateLpiNode (AslName, 1, 0, ScopeNode, &LpiNode);
> +    Status = AmlCreateLpiNode (AslName, 0, 0, ScopeNode, &LpiNode);
>       if (EFI_ERROR (Status)) {
>         ASSERT (0);
>         return Status;


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#97372): https://edk2.groups.io/g/devel/message/97372
Mute This Topic: https://groups.io/mt/95048993/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] DynamicTablesPkg: SSDT _LPI revision is incorrect

Posted by Sami Mujawar 1 year, 4 months ago

Merged as d103840cfb55..916825b84f23

Thanks.

Regards,

Sami Mujawar


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#97376): https://edk2.groups.io/g/devel/message/97376
Mute This Topic: https://groups.io/mt/95048993/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] DynamicTablesPkg: SSDT _LPI revision is incorrect

Posted by PierreGondois 1 year, 5 months ago

Hello Jeff,
The Lpi version should effectively be 0:
Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>

Regards,
Pierre

On 11/15/22 19:01, Jeff Brasen wrote:
> _LPI Revision should be 0 per the ACPI 6.5 specification.
> "The revision number of the _LPI object. Current revision is 0."
> 
> Signed-off-by: Jeff Brasen <jbrasen@nvidia.com>
> ---
>   .../Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c    | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c
> index d06c7615fb..91199c4af2 100644
> --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c
> +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c
> @@ -482,7 +482,7 @@ GenerateLpiStates (
>       }
>   
>       // We do not support the LevelId field for now, let it to 0.
> -    Status = AmlCreateLpiNode (AslName, 1, 0, ScopeNode, &LpiNode);
> +    Status = AmlCreateLpiNode (AslName, 0, 0, ScopeNode, &LpiNode);
>       if (EFI_ERROR (Status)) {
>         ASSERT (0);
>         return Status;


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#96489): https://edk2.groups.io/g/devel/message/96489
Mute This Topic: https://groups.io/mt/95048993/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-