From nobody Sat May 18 17:34:33 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+105503+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+105503+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1685546338676227.8726917418096; Wed, 31 May 2023 08:18:58 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 3cFKYY1788612xf2h0fHdmcQ; Wed, 31 May 2023 08:18:58 -0700 X-Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.107.94.119]) by mx.groups.io with SMTP id smtpd.web10.4773.1685500704192586973 for ; Tue, 30 May 2023 19:38:24 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N78JCPCYxcQ4MaKh5l2cziSdwSpirGncYZyK01jz3hNTWTyIJJsbnAR3cqRcqmvCFJB37GT8QCXi/DcrBKV0U9svjOPDVR6q06tjzOaF0C0CzsFgzavfBl12gcVOdrBcowOEzOBjMQVqSSQroU7Hwwl5QS8+fuYYTvV6HJ1geNUt96XZ9jirgi7O9U26bcoc5TD/CYhP57TcptYelb+j0sYbUPBcYioBO5eggRJTWYlK13pammIKgfyI5AnrxGJG0XtdG4xqqAyYg1cHVnCetsub4IaK3A2n24WYOKopY+24yjjqyeIfUKL+v9vuoFpNVU+kECaBmfx3uSmPXcdClQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5tEsUXG+keVhI1HseJVSaX10pOtm/fJI0HaGJRTHDKQ=; b=F6IWyzU/Y/jovVtZHb8J+hxBE5sMvsv9K+tGlmeXGh0O1IpsGViB76RTrdHDh/gSa4N/E2QRJOZtQ3EMIJpPaTF9G1EpA/RKZ3Xs0RDBgqeuHT9FAqKr76qSxZEqJrwnjJBsEXs816z+vSnFhPsBQwYwlPD0kVco/sfSNwhgIYsgSy1f4s1e63myBq0wMXPUwEY8EogmxW50icYJ7ivHuwVh031A+nzjKPTdOzGCACOvCWYRKVr1UHjzbV58Tzv9j2tO2GjWoDUpAihIGej0F/x3WRprVBL21I2oXd0VvKnznx5SNg1K6PhfT8ADWEI6mjE9NK8rKMw0IM8dKINquQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amperecomputing.com; dmarc=pass action=none header.from=amperecomputing.com; dkim=pass header.d=amperecomputing.com; arc=none X-Received: from SJ2PR01MB8006.prod.exchangelabs.com (2603:10b6:a03:4ca::22) by BY3PR01MB6753.prod.exchangelabs.com (2603:10b6:a03:361::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.22; Wed, 31 May 2023 02:38:18 +0000 X-Received: from SJ2PR01MB8006.prod.exchangelabs.com ([fe80::859d:80a3:6d4c:e451]) by SJ2PR01MB8006.prod.exchangelabs.com ([fe80::859d:80a3:6d4c:e451%7]) with mapi id 15.20.6433.020; Wed, 31 May 2023 02:38:17 +0000 From: "Adrian Sperber via groups.io" To: "devel@edk2.groups.io" , "Demeter, Miki" , "Gao, Liming" Subject: [edk2-devel] [PATCH] ShellPkg\SmbiosView: SmBiosView does not print correct Slot ID information Thread-Topic: [edk2-devel] [PATCH] ShellPkg\SmbiosView: SmBiosView does not print correct Slot ID information Thread-Index: AQHZk2j0JaWKsP7a6k2suGzNh2eIjg== Date: Wed, 31 May 2023 02:38:17 +0000 Message-ID: References: <20230530185322.70-1-michael.d.kinney@intel.com> <20230530185322.70-3-michael.d.kinney@intel.com> In-Reply-To: <20230530185322.70-3-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_5b82cb1d-c2e0-4643-920a-bbe7b2d7cc47_ActionId=54d8d23a-3abc-4689-b76b-4472dbaadbfc;MSIP_Label_5b82cb1d-c2e0-4643-920a-bbe7b2d7cc47_ContentBits=0;MSIP_Label_5b82cb1d-c2e0-4643-920a-bbe7b2d7cc47_Enabled=true;MSIP_Label_5b82cb1d-c2e0-4643-920a-bbe7b2d7cc47_Method=Standard;MSIP_Label_5b82cb1d-c2e0-4643-920a-bbe7b2d7cc47_Name=Confidential (Default);MSIP_Label_5b82cb1d-c2e0-4643-920a-bbe7b2d7cc47_SetDate=2023-05-31T02:20:56Z;MSIP_Label_5b82cb1d-c2e0-4643-920a-bbe7b2d7cc47_SiteId=3bc2b170-fd94-476d-b0ce-4229bdc904a7; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ2PR01MB8006:EE_|BY3PR01MB6753:EE_ x-ms-office365-filtering-correlation-id: b2638a6f-f31c-4990-6304-08db61801736 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: AyGv4RdTix7ACCKpVPBj42vrRaIxyApgGU9AVHzqtnE0t3lAhyOuE9ZG8L4mH0dVk57awg5aAv+Vy9X9kCJjLII65nx8TCXROdZQN745BBbuGNhtqeo7VOcezEj/PJm/kjulLCoTqlaI/z5k1YqzrBaMvYxl+OKWDQjV/bNwvzs7/Cy0v+SBgf0qm+HYdwNR6zb4bsVsU2EwqQNMBMSwCbYoXxipizQRgCmZc+wbbMZen7mKhaEBCSHpxCtdt5TPzAPtca37qZ0LECtyf3xjAmKsIC2wzv2lrBdOALn+qaw4Z85rdwSo7c1EpXB47HefHG59TlVci5tOV7aciIpBJIvFkGF91d4JsSmEfOekfmfOp5VCYOIH+tObKPeGKWFhLbs0Cl1Jcg0052I7q0Q6RuZnicM8rLe44kKBNrSDiKPcLrnyPa2DvAp6iozgEN/pojIjoqbEVqbfhu43JZ2COt5BG2WoL3oFDF19DDeXqjpCiiJKXhiD8wCXf64oIA6nw2noJ8+Y95xPqmUH28DDcFNC9yMLwRVok0We8TuM/owBzwZN5jNUxtwKebwjsx36X75+fwMe7yrDTBz9/QgK9F2g/KsDpzN2tLMa0Ybmj2c= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?yt0Q+l6KOInFHk5Lh4FgqACi2GGf6SGCwg8dpL44VGFHXyVv7B3jGJqU3fZE?= =?us-ascii?Q?ZRpVLjHFpyFQDix8DPSWQl0SQz7lbe9JjIZV2fqFK5jgK+nwY+u0tkoL5Bqc?= =?us-ascii?Q?7EwXZ2yetM/IYXmPdkYqiHEOgS1GRyVGmqcl3j1hhCE30cmSQgVRuZWMi20P?= =?us-ascii?Q?D8hLszDYNPD3LL+Jqe19BK0+V3pCfu7wwR7aIR0fLz1YRXQeSH6oMJ//LuY2?= =?us-ascii?Q?TAOoFosWS3qlRd4fWMjjhK0O0u8i1Nqltyi0Fqt7hSHMIqhSCaZgInrEn9HK?= =?us-ascii?Q?ZhiKuWoSSgXGPUxyYXDddz2Qa7qVKSlFtvdIDjhOaDaFMNRWIItyAthkc3TJ?= =?us-ascii?Q?HIVBfVpYmS5ecwMDsSSU+sHDDp1WlyrRDBhYskSMWbGF22BJxVqGi1g3ggx3?= =?us-ascii?Q?IAqrwuyKxZQZXuggY/2nHR1HP0v8vI22/tKZw6QAsYo7jhTCGRCT8JkV41GF?= =?us-ascii?Q?naSpxf8sB1Uh5IabL/P04eWAXPQXq/1icuJ2p3gTOC/rAlwgJH9fxE/Nub/j?= =?us-ascii?Q?B0pnkiRQBwptuLySX5FBICNjttbNdhwT5ja0hDBkFEQ5FM0sHmrKoLX8jz+E?= =?us-ascii?Q?aSNUZyoq7kWuYNBOpNMkGMNzjOfOTySfhlHV4Df2C6SCHw5sQcuz1BrtMT3Z?= =?us-ascii?Q?U6O+m+IhS0x9hGM/hSQobHLuk0AXT1qCSvtcPCIFpgkWQvhwmbu9/mTN5U8A?= =?us-ascii?Q?HIqA6qBfRY1YKT96IupQBapsIchOLRJbUcHspoaRdBsXCmn9OC8fH34Ic2m0?= =?us-ascii?Q?Jmlydbb2R8va4X3OWLZeMwTcDdg7grsiyoxMx/W8OmFHBaI7q40QfR7b0o1t?= =?us-ascii?Q?HGyIo6optAvpCAyJW8O/18VR7zbKeLcAiCswqeqSw2ZSsQ3TCLDjaG5PAx28?= =?us-ascii?Q?zpd/JzszSCmQOEtaycPff6uK+QDHprXtXuCGWHPk/560cQjPUV4ACwUlcMzz?= =?us-ascii?Q?EPxgvy4QMAeSSkTgmUHcAvzhNAB+yVZVXdbF8wsZzorGiWGSZJrN6AKGGIMP?= =?us-ascii?Q?RYnVEiRFc15SFZVCHpZMhnNwY1jlPsgrIe1AHbljap7kDUEfVBdbwFeg6Tiu?= =?us-ascii?Q?Jks5qUWFlK76mZMr+l+OoA/+xwiQOqKHstMki2dc+V12dGnKMxUPEL8yIYS/?= =?us-ascii?Q?s7+UsEs1+RiOG/tnbCb4O54Tv/IcYO7/EPx/qsUrp0v0a9JoLde122TJxngC?= =?us-ascii?Q?IMlHdtM+cbuJAuclHho74Y8Og6pw5MNeVUe2J+CRVSIRQPjTmwTC9SKj9Gt0?= =?us-ascii?Q?NwzFyFLsf5McEmNcG7H8/5zv/B2YcqLedy+Z5+JLem+rpCrI/OIEUpYaCWAr?= =?us-ascii?Q?4UlxR9lnRD9fEkJuU3pUJiJbdezXsEHTeFeOH2VWAS16Cr82WCSOBjOrM7DG?= =?us-ascii?Q?9vhHAWg4zpd/4ndyRB0PwCrZqyy42dP1GywKlVfwmKpG4TezExj8U1irF5PS?= =?us-ascii?Q?/r279FjYAovu0L8WonLG9+mnm6cNjO7u6nwdcJ82R0OzIjoAN6kYbN76Oa4c?= =?us-ascii?Q?B9wn1m+ElqO5+rsdoysd2EXC3ibSscjBPaPUUtelmXH4lH2C6RjUKTGewaFR?= =?us-ascii?Q?GjXEe6CQxakqxFI5INe1cvYLYoO7Zv0WM6HrBPxTWE40Au/1yR84pwmbTbS1?= =?us-ascii?Q?G4BLbuGm8F37luXZKRdPhPgaaVVtbMiytSqre9Ye+KnNTbKeiNto5DWC467a?= =?us-ascii?Q?arRu2A=3D=3D?= MIME-Version: 1.0 X-OriginatorOrg: amperecomputing.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ2PR01MB8006.prod.exchangelabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: b2638a6f-f31c-4990-6304-08db61801736 X-MS-Exchange-CrossTenant-originalarrivaltime: 31 May 2023 02:38:17.5695 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 604b7LxkQKXwLC+wbIDB7NCJ1ZF/TiwkVD35bTN3mTxy5MP/4eckFFhNlf9sDoxFDbd6JherSNyjIOQhDt4oDKmag1Ix++2UdtHozQwhijM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY3PR01MB6753 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,asperber@amperecomputing.com X-Gm-Message-State: kBPzwzbHePXAu0Vop07XYEFEx1787277AA= Content-Language: en-US Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1685546338; bh=StpdlMZjffAuqMACCGT0xH/oO2zwqsZ0Pz5bVrdq3I0=; h=Content-Type:Date:From:Reply-To:Subject:To; b=Cn8gnFOrYA9YRE19UzTR7Jqc3mYpBMURtIrQ8wtW6/eAZ5925ZH9omJRiKARviSLaIS tjN3Qq6Tp0BhZrxQttKiWUlCK5BlhvJWXBwjffS0XTHeR1tzj2uG2rRXOKyqvdQUf2Fn8 BGBBYyWZYBmxPVv56zb+TXMCJ9aEYx4xqgM= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1685546339625100006 Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4469 SlotType related check only supports PcieGen3 checks within DisplaySystemSlotId. SmbiosView will print: Slot Id: undefined Slot Id Updating this check to Gen6andBeyond which fixes the problem: Slot Id: the value present in the Slot Number field of the PCI Interrupt Routing table entry that is associated with this slot is: Signed-off-by: Adrian Sperber --- .../Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintIn= fo.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c index a14b79904d..b109934f58 100644 --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c @@ -2998,7 +2998,7 @@ DisplaySystemSlotId ( break; default: - if (((SlotType >=3D 0x0E) && (SlotType <=3D 0x12)) || ((SlotType >= =3D 0xA6) && (SlotType <=3D 0xB6))) { + if (((SlotType >=3D 0x0E) && (SlotType <=3D 0x12)) || ((SlotType >= =3D 0xA6) && (SlotType <=3D SlotTypePCIExpressGen6andBeyond))) { ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_SMBIOSVIEW_PRINTI= NFO_VALUE_PRESENT), gShellDebug1HiiHandle, SlotId); } else { ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_SMBIOSVIEW_PRINTI= NFO_UNDEFINED_SLOT_ID), gShellDebug1HiiHandle); -- 2.38.1.windows.1 CONFIDENTIALITY NOTICE: This e-mail message, including any attachments, is = for the sole use of the intended recipient(s) and contains information that= is confidential and proprietary to Ampere Computing or its subsidiaries. I= t is to be used solely for the purpose of furthering the parties' business = relationship. Any unauthorized review, copying, or distribution of this ema= il (or any attachments thereto) is strictly prohibited. If you are not the = intended recipient, please contact the sender immediately and permanently d= elete the original and any copies of this email and any attachments thereto. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#105503): https://edk2.groups.io/g/devel/message/105503 Mute This Topic: https://groups.io/mt/99244489/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-