From nobody Fri May 10 20:57:07 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+93452+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93452+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1662569051; cv=none; d=zohomail.com; s=zohoarc; b=YgJg1wRKLvNSOL1fQj3e3U9M+Acwfa36Yo3gKc1vascPpQXFsEtc/rNkR8kBnpxeqfZvxCZwQO84015XWSd2ImS9eC7fL1f9/xXhqlo/Gg5DkdAAbduOb3E4D42cBQyZCaOlIav8Hsg5GccydagMBGD7c9AdC6isWKPa8Mo+4cA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1662569051; h=Content-Type:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=3Qgp3gjxw1DqexNz0owCTStI+f1e9kTEpCwqTeXItJY=; b=lazztzwXOQU20jCYYUhyHwGwOT56X/QdjwXiMuqEGjLGHU5vRiXM25US7odV99QcyQpB3SN/dh1GjIq3C+TEyDPKD1jribhP2Fsnje37M4xssd0pJzQw+8lKnplyUe1wH4A9WBetPoXGT8fx4bTb+Mu3G6Twe6lioBP6wmwTu6g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93452+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1662569051629720.6695451276971; Wed, 7 Sep 2022 09:44:11 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id xTMaYY1788612x8RdlFBsdqx; Wed, 07 Sep 2022 09:44:10 -0700 X-Received: from us-smtp-delivery-162.mimecast.com (us-smtp-delivery-162.mimecast.com [170.10.129.162]) by mx.groups.io with SMTP id smtpd.web09.970.1662569047686208293 for ; Wed, 07 Sep 2022 09:44:09 -0700 X-Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2173.outbound.protection.outlook.com [104.47.57.173]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-439-fgxZfNpKPjqTYfyJCiY4dA-1; Wed, 07 Sep 2022 12:44:03 -0400 X-MC-Unique: fgxZfNpKPjqTYfyJCiY4dA-1 X-Received: from DM4PR84MB1520.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:8:4b::12) by MW4PR84MB1516.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:303:1a7::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.15; Wed, 7 Sep 2022 16:44:01 +0000 X-Received: from DM4PR84MB1520.NAMPRD84.PROD.OUTLOOK.COM ([fe80::d044:814e:df73:19a3]) by DM4PR84MB1520.NAMPRD84.PROD.OUTLOOK.COM ([fe80::d044:814e:df73:19a3%8]) with mapi id 15.20.5588.011; Wed, 7 Sep 2022 16:44:01 +0000 From: "Anbazhagan, Baraneedharan via groups.io" To: "devel@edk2.groups.io" CC: gaoliming , "hao.a.wu@intel.com" , "ray.ni@intel.com" Subject: [edk2-devel] MdeModulePkg: Use configurable PCD for AHCI command retries Thread-Topic: MdeModulePkg: Use configurable PCD for AHCI command retries Thread-Index: AdjC1bnQg3WorTfySbipk/mtO9c6LA== Date: Wed, 7 Sep 2022 16:44:01 +0000 Message-ID: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 10aff687-4817-48bd-d8d8-08da90f02b0f x-ms-traffictypediagnostic: MW4PR84MB1516:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: xX49VcccRdtsSU5iK/KYTgUA5aR7+eg5zvsSk9VyLGok4Rl/LQoe1PPVaZd+g/mmqnAlmNdWgyVtqp0UUXjCVXkNwHV9UWDvfi8WekGN6foUnGFD3D1ryZjeoKXu6BZtoboEbBYbKA2PaYEnfklUmd6TYTO8sess+HxJ0mZ1cOYCazQqcVBdqqhtGQ41iDRrZ9IA9tDu/kM8zEnuUh44P3rK/B2+I8dmtktkwOsjYdfVpP613I2flKs6/6KSILHvySiPgBKSKu4R0r0mbIXzSLFKGVuvI7xTQPrCRSJiK0uNyDyPWUPI88S011H4ey+csUZHFtKtgapycuKP1VtIAHkS4ymHWyJmVNANteat0Am2+FiFW2S4TdNlA4bv7MdRwYlHdss9KO9c+Scwn79rAx+EHF7zqRCQ8gsEDQGCEkEIuMgTASrX+xa1reyvpz0ADCWebFdNeXE0A0BM7mzgqSKYDeoVL5FTFBEOntAXOaCGBP3li0ur5227je8V6t9ZxiZbr9/WpixrC/zEwhVXU0MEVG37sEkPfmqyJQaThTKtChmxLzqe46KVaC3t/sBu1kfF9vLFEG9dXndYahMiNUkqsoPKdoZ3Y58WQIhjeS8p5FSJPe687BrcXQNdj5+ntW7che98OCxI/d3UDFXUYkC4I4QNt4mCcCDMvtGb20KCxgIH6LzrSBSdyBVmonE12kA5QF9KCIuyt8XcuaBlGGboUI8A0zQ0/gOO+7kOZNeRXfWnXwN02rJQydwZpK7BQMK5TqMtUjERzlH/25wCUC7MneHYTy0sBTxHJr8OFtM= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?JeQbuS9dEpCg5lEOWlqRNx3GbT18kLeUzdLUCNA17Kd2+IBgUh7fwKNTYMDP?= =?us-ascii?Q?s/C/4pJUoTu54epQNWmEqw0qh24bdKepzrPBHynfGD0tYx1We/5JhRyZlBU8?= =?us-ascii?Q?+Bg3sDqikVgm2sDQOzTFk6yUYkw6uHJZ8zbuqHM8BLSErXWvNsP0uLAmJqPF?= =?us-ascii?Q?f8SA+v5qh2KxEJOuE6pH+aBfo6gIBkLUZYtd97mnvSh9/wN8wf9Xr/Emt27R?= =?us-ascii?Q?kCK000pK0kCkS2kzQt6Tr7F7abcZgHpC44S/vvUwREn3bIUFdDxcFbHmJ0CY?= =?us-ascii?Q?DQzuVwJq+Hb4XXQMxQGPn+rLuVw2KLFyqPtNtnwU99YPWaVGd5GBlmbXySN/?= =?us-ascii?Q?PGFJ6xNHd31GCXjWWOTBvvs+xiWSyH5aYW29gwVy1Yv30o53direk5a54NpK?= =?us-ascii?Q?DSjOti8jOwnfCHMkr7uXt8k49gSTB355yjQ7yR+n2Z8fsr/R33o893GTTwG3?= =?us-ascii?Q?/dcKhu4Fh0hRgMSTy0Ewux8jFKQmjl3zCz17CP4SCiHoz1KCS9IL6S9ySzQf?= =?us-ascii?Q?3xEhDRFmT3s2oyh+fbAXeZNAglkT11fOz7F3EgS+4RXuJ/9VyLSz1E5M9LDZ?= =?us-ascii?Q?gImiFCCJi79XMkS1cuAoCAHE81EO2V87wduuFeLaX3aHkAY4FgT4ca5f4+5k?= =?us-ascii?Q?T8GDSxfrS7PUkgJZcBZahj3V5HlVn1pWcGZB1+H+XcpcO0uOhlkXgBDDNoBj?= =?us-ascii?Q?mpu56zzkb7Lw4hKx6NsMfWOz7Loguoh9vRV+BiAfWoSCqZXDKElO5iKsRx3J?= =?us-ascii?Q?hFnH3vvqudWQKDuKKy4q0gT9lVZrQJUTjdHPNcLAT6QLvXH/ccybyHOEwCQl?= =?us-ascii?Q?vBesWF3UjdFFlIi10SHAUYiZEA9FwGmKdoIUd7vSSejjVv/PuCu5dD5b4ssP?= =?us-ascii?Q?AQuywUWG2/njdgAcmqzYGrQHJftmL9Ox1ZPxHly65Ve9wpaqJjwRwctaHoeJ?= =?us-ascii?Q?jMwGexnk3nHEUf0xzG4YQF9IrGW6z/AQBM2k2+vvqGQIzNqRTCB9vhOaM8mE?= =?us-ascii?Q?8317IcDIwYnWifEfCD87R+VjxlUaJL53AxT1Q6g5hAA6/Tw+n16Guw5lsDCA?= =?us-ascii?Q?Y0aijBnMaOiRTPtk7L6tea/IUuzdYdAaWT9Enqd4XJQmByJpO/4qWCdoa/8V?= =?us-ascii?Q?JxU9T3wDh8E81zQHR59dRic1Y9XgA8oHhIl04ZVR4S9/q6lpxSBBtXViDs9l?= =?us-ascii?Q?wYPXDM7KPyZHjq2kobwSRKS/H29YHGTIrj50rjNiTamn2XVUl84+OUDuApva?= =?us-ascii?Q?xkESy9eRCfWxsVVf1aJMPgOh+VCI0xMwO05XXSd/MKeyGcZGvqqbOq+jX7xW?= =?us-ascii?Q?46/RSrx3PFbrNviIfza5UowBX2cYxJ49cB3yI9lq5pJJOxpwMkjIPLoXW1DT?= =?us-ascii?Q?GHIMvxnf9CBvmk/nPR5ah+NqIex5w62siGtxF8vAzLBWGpUQ+e4c2dO8K0r0?= =?us-ascii?Q?ZtwS3S0hIn268r/idz3l3DT//wjQWprlX6LZWpYWMw4roOatn27eYylpC7Xi?= =?us-ascii?Q?mlL9lxUvrkd6U8FNqDWXO+lYDrKVqIeobkln0kqSX1o1BjKm+ZlY/6Ss6nGb?= =?us-ascii?Q?Wp8RSQmliAnS5gxZGm4=3D?= MIME-Version: 1.0 X-OriginatorOrg: hp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR84MB1520.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 10aff687-4817-48bd-d8d8-08da90f02b0f X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2022 16:44:01.4887 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: ca7981a2-785a-463d-b82a-3db87dfc3ce6 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GoTtpxenYRaA9I8QyYylZXDBdQNWQH8iVXo2ORprLwe58nYb/n9BPKvsYpkg+E/OGgboWeW7Fe/srg+2hY8fTw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR84MB1516 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: hp.com Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,anbazhagan@hp.com X-Gm-Message-State: XEcEVbgeuFao3KXj6i5a9iKMx1787277AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_DM4PR84MB1520DE08C27E50BD2B23E278BA419DM4PR84MB1520NAMP_" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1662569050; bh=QTFE/WPJKwhjA8ESCUJm+YgHCgH/SEdQ2IfNgF98vW8=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=ERqIDbJOYBGGAJyW+KMJo1jdQEPFmDq0G2QahlBVN/JJIdBS654jvJ94jrf6KddewKZ rLDncEhpbKft8bY0XUqzhqKl6GA/I+MgOlZaQQEQ9Sl4ZPij+O7pUu8oRfyzC+bVYRr1U UOXJvBG7e9jc/TBY3svTeMKnxcffNvjqoFU= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1662569052355100003 --_000_DM4PR84MB1520DE08C27E50BD2B23E278BA419DM4PR84MB1520NAMP_ Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" https://bugzilla.tianocore.org/show_bug.cgi?id=3D4011 AHCI commands are retried internally which prevents platform feature like drive password to process correctly entered password on subsequent attempts. PCD allows the platform to determine the number of retries. Signed-off-by: Baraneedharan Anbazhagan anbazhagan@hp.com --- MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c | 6 +++--- MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.h | 2 -- MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf | 3 ++- MdeModulePkg/MdeModulePkg.dec | 4 ++++ 4 files changed, 9 insertions(+), 6 deletions(-) diff --git a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c b/MdeModulePk= g/Bus/Ata/AtaAtapiPassThru/AhciMode.c index a240be940d..bf8105d4e7 100644 --- a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c +++ b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c @@ -983,7 +983,7 @@ AhciPioTransfer ( CmdList.AhciCmdCfl =3D EFI_AHCI_FIS_REGISTER_H2D_LENGTH / 4; CmdList.AhciCmdW =3D Read ? 0 : 1; - for (Retry =3D 0; Retry < AHCI_COMMAND_RETRIES; Retry++) { + for (Retry =3D 0; Retry < PcdGet32 (PcdAhciCommandRetryCount); Retry++) { AhciBuildCommand ( PciIo, AhciRegisters, @@ -1190,7 +1190,7 @@ AhciDmaTransfer ( } gBS->RestoreTPL (OldTpl); - for (Retry =3D 0; Retry < AHCI_COMMAND_RETRIES; Retry++) { + for (Retry =3D 0; Retry < PcdGet32 (PcdAhciCommandRetryCount); Retry++= ) { AhciBuildCommand ( PciIo, AhciRegisters, @@ -1385,7 +1385,7 @@ AhciNonDataTransfer ( CmdList.AhciCmdCfl =3D EFI_AHCI_FIS_REGISTER_H2D_LENGTH / 4; - for (Retry =3D 0; Retry < AHCI_COMMAND_RETRIES; Retry++) { + for (Retry =3D 0; Retry < PcdGet32 (PcdAhciCommandRetryCount); Retry++) { AhciBuildCommand ( PciIo, AhciRegisters, diff --git a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.h b/MdeModulePk= g/Bus/Ata/AtaAtapiPassThru/AhciMode.h index 7802ebd200..66256bf718 100644 --- a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.h +++ b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.h @@ -193,8 +193,6 @@ typedef union { #define AHCI_PORT_DEVSLP_DITO_MASK 0x01FF8000 #define AHCI_PORT_DEVSLP_DM_MASK 0x1E000000 -#define AHCI_COMMAND_RETRIES 5 - #pragma pack(1) // // Command List structure includes total 32 entries. diff --git a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf b/M= deModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf index a3e42a9ab4..78caa3c458 100644 --- a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf +++ b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf @@ -65,7 +65,8 @@ gEdkiiAtaAtapiPolicyProtocolGuid ## CONSUMES [Pcd] - gEfiMdeModulePkgTokenSpaceGuid.PcdAtaSmartEnable ## SOMETIMES_CONSUMES + gEfiMdeModulePkgTokenSpaceGuid.PcdAtaSmartEnable ## SOMETIMES_C= ONSUMES + gEfiMdeModulePkgTokenSpaceGuid.PcdAhciCommandRetryCount ## SOMETIMES_C= ONSUMES # [Event] # EVENT_TYPE_PERIODIC_TIMER ## SOMETIMES_CONSUMES diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec index 7d98910832..58e6ab0048 100644 --- a/MdeModulePkg/MdeModulePkg.dec +++ b/MdeModulePkg/MdeModulePkg.dec @@ -1574,6 +1574,10 @@ # @Prompt SD/MMC Host Controller Operations Timeout (us). gEfiMdeModulePkgTokenSpaceGuid.PcdSdMmcGenericTimeoutValue|1000000|UINT3= 2|0x00000031 + ## The Retry Count of AHCI command if there is a failure + # @Prompt The value of Retry Count, Default value is 5. + gEfiMdeModulePkgTokenSpaceGuid.PcdAhciCommandRetryCount|5|UINT32|0x00000= 032 + [PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] ## This PCD defines the Console output row. The default value is 25 acco= rding to UEFI spec. # This PCD could be set to 0 then console output would be at max column= and max row. -- 2.36.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93452): https://edk2.groups.io/g/devel/message/93452 Mute This Topic: https://groups.io/mt/93529220/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_DM4PR84MB1520DE08C27E50BD2B23E278BA419DM4PR84MB1520NAMP_ Content-Type: text/html; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable

https://bugzilla.tianocore.org/show_bug.cgi?id=3D4011

 

AHCI commands are retried internally which prevents = platform feature

like drive password to process correctly entered pas= sword on subsequent

attempts. PCD allows the platform to determine the n= umber of retries.

 

Signed-off-by: Baraneedharan Anbazhagan anbazhagan@hp.com

---

MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c&nbs= p;          | 6 +++---

MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.h&nbs= p;          | 2 --<= /p>

MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassTh= ru.inf | 3 ++-

MdeModulePkg/MdeModulePkg.dec    = ;            &n= bsp;            = ; | 4 ++++

4 files changed, 9 insertions(+), 6 deletions(-)

 

diff --git a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/A= hciMode.c b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c

index a240be940d..bf8105d4e7 100644

--- a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode= .c

+++ b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode= .c

@@ -983,7 +983,7 @@ AhciPioTransfer (

   CmdList.AhciCmdCfl =3D EFI_AHCI_FIS_REG= ISTER_H2D_LENGTH / 4;

   CmdList.AhciCmdW   =3D Read ?= 0 : 1;

-  for (Retry =3D 0; Retry < AHCI_COMMAND_RE= TRIES; Retry++) {

+  for (Retry =3D 0; Retry < PcdGet32 (PcdAh= ciCommandRetryCount); Retry++) {

     AhciBuildCommand (

       PciIo,

       AhciRegisters,<= o:p>

@@ -1190,7 +1190,7 @@ AhciDmaTransfer (

     }

     gBS->RestoreTPL (Ol= dTpl);

-    for (Retry =3D 0; Retry < AHC= I_COMMAND_RETRIES; Retry++) {

+    for (Retry =3D 0; Retry < Pcd= Get32 (PcdAhciCommandRetryCount); Retry++) {

       AhciBuildComman= d (

         Pci= Io,

         Ahc= iRegisters,

@@ -1385,7 +1385,7 @@ AhciNonDataTransfer (

   CmdList.AhciCmdCfl =3D EFI_AHCI_FI= S_REGISTER_H2D_LENGTH / 4;

-  for (Retry =3D 0; Retry < AHCI_COMMAND_RE= TRIES; Retry++) {

+  for (Retry =3D 0; Retry < PcdGet32 (PcdAh= ciCommandRetryCount); Retry++) {

     AhciBuildCommand (

       PciIo,

       AhciRegisters,<= o:p>

diff --git a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/A= hciMode.h b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.h

index 7802ebd200..66256bf718 100644

--- a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode= .h

+++ b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode= .h

@@ -193,8 +193,6 @@ typedef union {

#define   AHCI_PORT_DEVSLP_DITO_MASK =      0x01FF8000

#define   AHCI_PORT_DEVSLP_DM_MASK &n= bsp;      0x1E000000

-#define AHCI_COMMAND_RETRIES  5

-

#pragma pack(1)

//

// Command List structure includes total 32 entries.=

diff --git a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/A= taAtapiPassThru.inf b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThr= u.inf

index a3e42a9ab4..78caa3c458 100644

--- a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapi= PassThru.inf

+++ b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapi= PassThru.inf

@@ -65,7 +65,8 @@

   gEdkiiAtaAtapiPolicyProtocolGuid &= nbsp;            ## = CONSUMES

 [Pcd]

-  gEfiMdeModulePkgTokenSpaceGuid.PcdAtaSmartEn= able   ## SOMETIMES_CONSUMES

+  gEfiMdeModulePkgTokenSpaceGuid.PcdAtaSmartEn= able          ## SOMETIMES_CON= SUMES

+  gEfiMdeModulePkgTokenSpaceGuid.PcdAhciComman= dRetryCount   ## SOMETIMES_CONSUMES

 # [Event]

# EVENT_TYPE_PERIODIC_TIMER ## SOMETIMES_CONSUMES

diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModu= lePkg/MdeModulePkg.dec

index 7d98910832..58e6ab0048 100644

--- a/MdeModulePkg/MdeModulePkg.dec

+++ b/MdeModulePkg/MdeModulePkg.dec

@@ -1574,6 +1574,10 @@

   # @Prompt SD/MMC Host Controller Operat= ions Timeout (us).

   gEfiMdeModulePkgTokenSpaceGuid.PcdSdMmc= GenericTimeoutValue|1000000|UINT32|0x00000031

+  ## The Retry Count of AHCI command if there = is a failure

+  # @Prompt The value of Retry Count,  De= fault value is 5.

+  gEfiMdeModulePkgTokenSpaceGuid.PcdAhciComman= dRetryCount|5|UINT32|0x00000032

+

[PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx]<= o:p>

   ## This PCD defines the Console output = row. The default value is 25 according to UEFI spec.

   #  This PCD could be set to 0 then= console output would be at max column and max row.

--

2.36.1.windows.1

 

_._,_._,_
G= roups.io Links:

You receive all messages sent to this group.

Vi= ew/Reply Online (#93452) | | Mute This Topic | New Topic
Your Subscription | Contact Group Owner | Unsubscribe [importer@patchew.org]
_._,_._,_=20 --_000_DM4PR84MB1520DE08C27E50BD2B23E278BA419DM4PR84MB1520NAMP_--