From nobody Tue May 14 21:23:40 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+93479+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93479+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1662611864; cv=none; d=zohomail.com; s=zohoarc; b=XwM/52LBkWFMa0VyQ7eowk06wkAocLPnqO/z9c9Lvcz9OnhmRGajWd7BJsO+r5nT4CGl6pLn8CQOyjLBtCLX8mLzIKsrNfxsrMr8H3wvbs+37WO6wB/REe+Y4He/VtwMP9EVWZcWzysPvLmQXVgSAAFbx3oWBXkT9pDcdHxiQnk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1662611864; h=Content-Type:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=jVlWIEpcs5849G74T1juAg9bQ8o724UfuosM0pMgJM0=; b=Do9HQ6RSTfUE6KT64UoAqTzk2M5dgxLY0wEp4cN4UzNatu7nKXCHUJyMnlw5I/oA1VzPDj7Nvn7CYKJQ2quS18Kp9Nc754GGAGNPwYHG3iIMHEkSA2IJ0YIbHclUa8fpH5O2eVeihaYO1BVO2qp9ivC3gwpPvs24hsW++D1stX8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+93479+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1662611864746751.3847831607912; Wed, 7 Sep 2022 21:37:44 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id i9c5YY1788612xwjvuFf0bi7; Wed, 07 Sep 2022 21:37:43 -0700 X-Received: from us-smtp-delivery-162.mimecast.com (us-smtp-delivery-162.mimecast.com [170.10.133.162]) by mx.groups.io with SMTP id smtpd.web11.1588.1662611861995538219 for ; Wed, 07 Sep 2022 21:37:42 -0700 X-Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11lp2172.outbound.protection.outlook.com [104.47.56.172]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-140-eXrCk2tTPHCYcpROEghcoA-1; Thu, 08 Sep 2022 00:37:39 -0400 X-MC-Unique: eXrCk2tTPHCYcpROEghcoA-1 X-Received: from DM4PR84MB1520.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:8:4b::12) by MW5PR84MB1643.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:303:1c1::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.15; Thu, 8 Sep 2022 04:37:37 +0000 X-Received: from DM4PR84MB1520.NAMPRD84.PROD.OUTLOOK.COM ([fe80::d044:814e:df73:19a3]) by DM4PR84MB1520.NAMPRD84.PROD.OUTLOOK.COM ([fe80::d044:814e:df73:19a3%8]) with mapi id 15.20.5588.011; Thu, 8 Sep 2022 04:37:37 +0000 From: "Anbazhagan, Baraneedharan via groups.io" To: "devel@edk2.groups.io" CC: gaoliming , "hao.a.wu@intel.com" , "ray.ni@intel.com" Subject: [edk2-devel] [PATCH v2] MdeModulePkg: Use configurable PCD for AHCI command retries Thread-Topic: [PATCH v2] MdeModulePkg: Use configurable PCD for AHCI command retries Thread-Index: AdjDO47NgG9qllpbRjOTlew4fZd/cg== Date: Thu, 8 Sep 2022 04:37:37 +0000 Message-ID: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9d0ad145-aca4-4c76-dc64-08da9153db2b x-ms-traffictypediagnostic: MW5PR84MB1643:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 8k1EWZ3aSlJwmXHHSrmfbZyzpaQHzz7knM1buRoaTDZCeyCQfSRtPhafSab/85aPN7u7uhlHK9MG9Xl7qRtxVHsGuE2v/e+gDHPNnos8CGMBUJuvyAzPI24a8c0hFAyiloB94mejzYfifhDSgY03wePYFfH+0gMFO221ac0qovlF7C9UCp+yyHdTgqH5vM0x2p/GXXMTITLM537IDUvltjM0yBUpiConZwMDsGZGwwRxOclo48HKTywsN+B2JREMRuPr5w9tTOFYZBdpt4Bux6DrV3+JuuYA6sbftk3mVCXD5tmcgAXdHmASTMwvmfHsQY2IB2AIBDeZzKcwqzauh9deHpJSOgJkSdcFzxa3stDsQgp/NIv5ZmF77x4yuMi8YDLaHZWcgDkG3rjIsS6sTRzBT8/VP9kzoYfjI2bEisSSmb4T6YjSCACGGgY5plbv55XmXePgMOpUYUoJUZYDMoi9zZvhYZoiYhYXCesvAJTqW/GzRDcVj7Zt0FDKt/4/Hm/WsBkEj3bL6XKx0oWDXjV/BGJCsm6VNuttwsEsatFjCmM2esGSs2GZaeGA+hY5ELBtQc1Zo128qruE3Xm4sMqRHx8J3ozcIlnpSuhk/OgUy3cgNu47Fww5Bw2Ku7qnSFvSG4YsdFcdVQbLOvipycgoigbfr+0t69NH+u84ho8bTGLaxqYykT0omM1fOWa/jzvEcG1kGc8o+ZiK8nkGDOavXOizehTQVg4m/43qluhxvimsuQuHq3ht1YCM5Gxb44EXgU+6vJU0HS0IlVXqADp3sjf7flR6Q25EgCzUGs4= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?To/6U1EvQkhiEqJ6PJ1zG3/T5n+QDzBEmd6HQrvaXWYkAKfcgZCSR4Jpn0Vs?= =?us-ascii?Q?lFaHBMS5DhBmVKNd9G2l8DTlTnhk/bgQqiGOJnT4c2i6kUWzT7mUq5QulMHF?= =?us-ascii?Q?UTzToQO3HN42Cez4bnhhf1q8nmLBkJCOqrDkCWc2qIwSYrRULa1bNpkq6WZs?= =?us-ascii?Q?rDkZfkb+uCzNcLIqskBxiEUaoTGmVGLuD6gUzmTD/rc2U86nCLkK8M1arIdJ?= =?us-ascii?Q?2KnTdYNWFtaqdynTrJxSBf0me8xIXctd6CBybod0AosROo+4EN9aNFc1v/mO?= =?us-ascii?Q?3xTsreZBrDTT6w7krvu5n9pjxYwsFO6H1AaDt9UhDeL7LLDTRG5AFOQNKjlc?= =?us-ascii?Q?R2SNlYK3nT7/Neqne80hry729WiBJ9WfKUENZc69PYBLpmsTdq8k17S9xHbz?= =?us-ascii?Q?OaPHoQUalK4pYeslWyPqwqC7imTdShAytWZTe5PW424mFPRW3miqANt8ST9I?= =?us-ascii?Q?v/uZKvkLcdcybrsZk6yjolgkfaiZO5q3biUhcvTuAJXIMLgZtWD5hhuQOlkg?= =?us-ascii?Q?lsYNfjCrsyFaJVwRsXm7eq2k2/jeZIfoWzeTVLQeaNYQNEfgyqkXy7Qp6rhl?= =?us-ascii?Q?QfYaKnHsIH3eDlQrCV3MqRl+qUskpq7W46TAAtgJ9YsL399AlWmvwkPnJ3s9?= =?us-ascii?Q?NnP9/DaJ8paZTTbRBR8dzz0n0zLigzOWkZN0jX6Pbn9QjvARPtsGUKYjY2Xq?= =?us-ascii?Q?dCB2wQj/ivGjjsOfv1E/ETum8RwH4E4ZT8DVkvJpjrUjCapijbpeLwdEI5NL?= =?us-ascii?Q?GCUC2fsE0iEBHHVQ37Cr3NLlmO2xYwitpDnZKV7JQ+cdkjcD/KIBxgmKe16+?= =?us-ascii?Q?ZATPLrHXceaTSy1POMr8bx5ZvtbjXR1fpMjsl6cvb46LpnI6mEsXJzFFoUPC?= =?us-ascii?Q?fxqXmKpUVLUuKZO+Y6SkWhuP5wtRS9mjJN9LEWiWkTD/3Fzg2+tqwVPg6lMB?= =?us-ascii?Q?i/fSXoKZ/Vk/8I9DV4puXffUu/YpUrudXy6FpKOjha+LNEwc4mRs9E0rEl/s?= =?us-ascii?Q?2FAelz0fwD2X8ofbdmymm2plmr54zhGoYbSccqx+TrLv19IiHfeXfwkkA72L?= =?us-ascii?Q?B2TIPv75YZ1pFjAHCulSnLLC9Y6wACMnXjPfYOd4XBIbcWl3NbbhPPntRabS?= =?us-ascii?Q?+dNGsH+B3ieNwrHw8TrQ5YZSmTJLDB/4EM9xicXg6svPp+Ad0SpoP3bn1pub?= =?us-ascii?Q?vWih9Svg3UusND8TweMv2g1joXRRWLQyzhnNM7ihDFgKMmcB68JG7IodcR31?= =?us-ascii?Q?/ZE5hcQJGIXfE12A9dDlYccLwhqHYm9kQJV5NpCQlfON/6Rn9b2eMgoS67Vj?= =?us-ascii?Q?zWw7uoBAb2s0WC8PZG+brdW3cGwwyEvqvZMzP7H0d30B9MtZTx2xweaJ5rCC?= =?us-ascii?Q?0iRjid1MP4kTt7x88lT+mZfyxbPT8ehbd2m5SuG7TahvdabRd7yl4V9QVrKC?= =?us-ascii?Q?QR11P3IOjUH9DviJD0xzcpVk+5GI77e3WWT7u9HIeYSujPJMbaGbeXebDhep?= =?us-ascii?Q?NCvP//2jx2VJMaciQSAHXL4gwwSgdr32BjtxUZCdSfwT/7O5pEjt2M0GhhSj?= =?us-ascii?Q?EKw0gYT9QkCER7jAC3p0bQbwfj5+Ah2oSEfiTQ2XsOL1yuqv0OXPnoKAiHTj?= =?us-ascii?Q?bmDIN9HEmNm4DEXk1vzX65E=3D?= MIME-Version: 1.0 X-OriginatorOrg: hp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR84MB1520.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 9d0ad145-aca4-4c76-dc64-08da9153db2b X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Sep 2022 04:37:37.0962 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: ca7981a2-785a-463d-b82a-3db87dfc3ce6 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tCFueih6cbwChcUIxbMQmY6qjqkzPCHjVaN+dMF0Sjp8c9rSgNZhupJAjR+6NQsX1FaW881Yd4Mi49z091nOkA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR84MB1643 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: hp.com Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,anbazhagan@hp.com X-Gm-Message-State: pjvNeZI7FvbBF1KSFQ3mTZExx1787277AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_DM4PR84MB1520BF668496AC3923059D7DBA409DM4PR84MB1520NAMP_" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1662611863; bh=vvpzzUOm3hw5nR2OhR8MBolUS+EeBhzdr8mHZj8302U=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=FjrCDbLyIb+kUNp8cntvVZrMeiSqk4W3VmpoHoNClQkLe0so1n/KNl4OUR6cQlOop2G G14oCbvi4X6MtTY+eQJ1QTZxiQj48GZtbhpG206Poq/TI1p5SR8fYKcHP5qNauabT4iCv 6z90Bo1+eG63k6+iWmTZwjaneifS3Km8jO0= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1662611866571100003 --_000_DM4PR84MB1520BF668496AC3923059D7DBA409DM4PR84MB1520NAMP_ Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4011 AHCI commands are retried internally which prevents platform feature like drive password to process correctly entered password on subsequent attempts. PCD allows the platform to determine the number of retries. Signed-off-by: Baraneedharan Anbazhagan anbazhagan@hp.com Reviewed-by: Hao A Wu > Reviewed-by: Hao A Wu --- MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.h | 2 +- MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf | 3 ++- MdeModulePkg/MdeModulePkg.dec | 4 ++++ MdeModulePkg/MdeModulePkg.uni | 4 ++++ 4 files changed, 11 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.h b/MdeModulePk= g/Bus/Ata/AtaAtapiPassThru/AhciMode.h index 7802ebd200..7fe9ac2da7 100644 --- a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.h +++ b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.h @@ -193,7 +193,7 @@ typedef union { #define AHCI_PORT_DEVSLP_DITO_MASK 0x01FF8000 #define AHCI_PORT_DEVSLP_DM_MASK 0x1E000000 -#define AHCI_COMMAND_RETRIES 5 +#define AHCI_COMMAND_RETRIES PcdGet32 (PcdAhciCommandRetryCount) #pragma pack(1) // diff --git a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf b/M= deModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf index a3e42a9ab4..78caa3c458 100644 --- a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf +++ b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf @@ -65,7 +65,8 @@ gEdkiiAtaAtapiPolicyProtocolGuid ## CONSUMES [Pcd] - gEfiMdeModulePkgTokenSpaceGuid.PcdAtaSmartEnable ## SOMETIMES_CONSUMES + gEfiMdeModulePkgTokenSpaceGuid.PcdAtaSmartEnable ## SOMETIMES_C= ONSUMES + gEfiMdeModulePkgTokenSpaceGuid.PcdAhciCommandRetryCount ## SOMETIMES_C= ONSUMES # [Event] # EVENT_TYPE_PERIODIC_TIMER ## SOMETIMES_CONSUMES diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec index 7d98910832..58e6ab0048 100644 --- a/MdeModulePkg/MdeModulePkg.dec +++ b/MdeModulePkg/MdeModulePkg.dec @@ -1574,6 +1574,10 @@ # @Prompt SD/MMC Host Controller Operations Timeout (us). gEfiMdeModulePkgTokenSpaceGuid.PcdSdMmcGenericTimeoutValue|1000000|UINT3= 2|0x00000031 + ## The Retry Count of AHCI command if there is a failure + # @Prompt The value of Retry Count, Default value is 5. + gEfiMdeModulePkgTokenSpaceGuid.PcdAhciCommandRetryCount|5|UINT32|0x00000= 032 + [PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] ## This PCD defines the Console output row. The default value is 25 acco= rding to UEFI spec. # This PCD could be set to 0 then console output would be at max column= and max row. diff --git a/MdeModulePkg/MdeModulePkg.uni b/MdeModulePkg/MdeModulePkg.uni index b070f15ff2..33ce9f6198 100644 --- a/MdeModulePkg/MdeModulePkg.uni +++ b/MdeModulePkg/MdeModulePkg.uni @@ -1166,6 +1166,10 @@ = "in the DXE phase. Minimum value is 1. Sections ne= sted more deeply are
" = "rejected." +#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdAhciCommandRetryCount_PROMPT= #language en-US "Retry Count of AHCI command if there is a failure" + +#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdAhciCommandRetryCount_HELP = #language en-US "This value is used to configure number of retries on AHCI = commands, if there is a failure." + #string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdCapsuleInRamSupport_PROMPT #= language en-US "Enable Capsule In Ram support" #string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdCapsuleInRamSupport_HELP #l= anguage en-US "Capsule In Ram is to use memory to deliver the capsules th= at will be processed after system reset.

" -- 2.36.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93479): https://edk2.groups.io/g/devel/message/93479 Mute This Topic: https://groups.io/mt/93542414/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_DM4PR84MB1520BF668496AC3923059D7DBA409DM4PR84MB1520NAMP_ Content-Type: text/html; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4011

 

AHCI commands are retried internally which prevents = platform feature

like drive password to process correctly entered pas= sword on subsequent

attempts. PCD allows the platform to determine the n= umber of retries.

        &nbs= p;            &= nbsp;           &nbs= p;            &= nbsp;           &nbs= p;            &= nbsp;           &nbs= p;            &= nbsp;           &nbs= p;            &= nbsp;           &nbs= p;            &= nbsp;           &nbs= p;            &= nbsp;           &nbs= p;            &= nbsp;           &nbs= p;         

Signed-off-by: Baraneedharan Anbazhagan anbazhagan@hp.com

---

MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.h&nbs= p;          | 2 +-<= /p>

MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassTh= ru.inf | 3 ++-

MdeModulePkg/MdeModulePkg.dec    = ;            &n= bsp;            = ; | 4 ++++

MdeModulePkg/MdeModulePkg.uni    = ;            &n= bsp;            = ; | 4 ++++

4 files changed, 11 insertions(+), 2 deletions(-)

 

diff --git a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/A= hciMode.h b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.h

index 7802ebd200..7fe9ac2da7 100644

--- a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode= .h

+++ b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode= .h

@@ -193,7 +193,7 @@ typedef union {

#define   AHCI_PORT_DEVSLP_DITO_MASK =      0x01FF8000

#define   AHCI_PORT_DEVSLP_DM_MASK &n= bsp;      0x1E000000

-#define AHCI_COMMAND_RETRIES  5

+#define AHCI_COMMAND_RETRIES  PcdGet32 (PcdAhc= iCommandRetryCount)

 #pragma pack(1)

//

diff --git a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/A= taAtapiPassThru.inf b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThr= u.inf

index a3e42a9ab4..78caa3c458 100644

--- a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapi= PassThru.inf

+++ b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapi= PassThru.inf

@@ -65,7 +65,8 @@

   gEdkiiAtaAtapiPolicyProtocolGuid &= nbsp;            ## = CONSUMES

 [Pcd]

-  gEfiMdeModulePkgTokenSpaceGuid.PcdAtaSmartEn= able   ## SOMETIMES_CONSUMES

+  gEfiMdeModulePkgTokenSpaceGuid.PcdAtaSmartEn= able          ## SOMETIMES_CON= SUMES

+  gEfiMdeModulePkgTokenSpaceGuid.PcdAhciComman= dRetryCount   ## SOMETIMES_CONSUMES

 # [Event]

# EVENT_TYPE_PERIODIC_TIMER ## SOMETIMES_CONSUMES

diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModu= lePkg/MdeModulePkg.dec

index 7d98910832..58e6ab0048 100644

--- a/MdeModulePkg/MdeModulePkg.dec

+++ b/MdeModulePkg/MdeModulePkg.dec

@@ -1574,6 +1574,10 @@

   # @Prompt SD/MMC Host Controller Operat= ions Timeout (us).

   gEfiMdeModulePkgTokenSpaceGuid.PcdSdMmc= GenericTimeoutValue|1000000|UINT32|0x00000031

+  ## The Retry Count of AHCI command if there = is a failure

+  # @Prompt The value of Retry Count,  De= fault value is 5.

+  gEfiMdeModulePkgTokenSpaceGuid.PcdAhciComman= dRetryCount|5|UINT32|0x00000032

+

[PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx]<= o:p>

   ## This PCD defines the Console output = row. The default value is 25 according to UEFI spec.

   #  This PCD could be set to 0 then= console output would be at max column and max row.

diff --git a/MdeModulePkg/MdeModulePkg.uni b/MdeModu= lePkg/MdeModulePkg.uni

index b070f15ff2..33ce9f6198 100644

--- a/MdeModulePkg/MdeModulePkg.uni

+++ b/MdeModulePkg/MdeModulePkg.uni

@@ -1166,6 +1166,10 @@

        &nbs= p;            &= nbsp;           &nbs= p;            &= nbsp;           &nbs= p;            &= nbsp;           &nbs= p;            &= nbsp;   "in the DXE phase. Minimum value is 1. Sections nest= ed more deeply are<BR>"

        &nbs= p;             =             &nb= sp;            =             &nb= sp;            =             &nb= sp;            =    "rejected."

+#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdAhciC= ommandRetryCount_PROMPT  #language en-US "Retry Count of AHCI com= mand if there is a failure"

+

+#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdAhciC= ommandRetryCount_HELP  #language en-US "This value is used to con= figure number of retries on AHCI commands, if there is a failure."

+

#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdCapsul= eInRamSupport_PROMPT  #language en-US "Enable Capsule In Ram supp= ort"

 #string STR_gEfiMdeModulePkgTokenSpaceGuid_Pcd= CapsuleInRamSupport_HELP  #language en-US   "Capsule In= Ram is to use memory to deliver the capsules that will be processed after = system reset.<BR><BR>"

--

2.36.1.windows.1

 

_._,_._,_
G= roups.io Links:

You receive all messages sent to this group.

Vi= ew/Reply Online (#93479) | | Mute This Topic | New Topic
Your Subscription | Contact Group Owner | Unsubscribe [importer@patchew.org]
_._,_._,_=20 --_000_DM4PR84MB1520BF668496AC3923059D7DBA409DM4PR84MB1520NAMP_--