From nobody Tue Apr 30 07:56:21 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 151496920995956.567842069896756; Wed, 3 Jan 2018 00:46:49 -0800 (PST) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 5D06A222A54E2; Wed, 3 Jan 2018 00:41:45 -0800 (PST) Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-oln040092004097.outbound.protection.outlook.com [40.92.4.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id EFAA721CB2E27 for ; Wed, 3 Jan 2018 00:41:43 -0800 (PST) Received: from SN1NAM02FT013.eop-nam02.prod.protection.outlook.com (10.152.72.58) by SN1NAM02HT054.eop-nam02.prod.protection.outlook.com (10.152.73.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.20.302.6; Wed, 3 Jan 2018 08:46:45 +0000 Received: from CO2PR19MB0137.namprd19.prod.outlook.com (10.152.72.51) by SN1NAM02FT013.mail.protection.outlook.com (10.152.72.98) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.20.345.12 via Frontend Transport; Wed, 3 Jan 2018 08:46:46 +0000 Received: from CO2PR19MB0137.namprd19.prod.outlook.com ([10.161.82.25]) by CO2PR19MB0137.namprd19.prod.outlook.com ([10.161.82.25]) with mapi id 15.20.0366.009; Wed, 3 Jan 2018 08:46:45 +0000 X-Original-To: edk2-devel@lists.01.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=40.92.4.97; helo=nam02-cy1-obe.outbound.protection.outlook.com; envelope-from=vanjeff_919@hotmail.com; receiver=edk2-devel@lists.01.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=YVc8PuH+/7mvnR96tB3lSt52AJDKJxs7GpQ0hn6DTxo=; b=Ty4C+99ZMxpdqG5N6jP701xk3O3w0eHciRLuwP/h5gseFQuZrZB492JDFrRR2JhRGG5+Hs8wQAIZsgknsj1ojzXJ7y54tUBkffHou9mJzw5VKIY7lKpVCWbJoW1ScUn7SRC4FjytxOor/cXil9+geg/47atcuTi0QY5aZ/AbuGI6MdugQ6JRmvK/ugRFRV6BgMnN2ohc70Vk5X7CfntJeSbuwAfKhBIWdKnGaLNdjvoE/Bt97SceRDHlJCv2hQLdJyLoz2jefxP4mourAJHNUok+gWeTfmI9o+Qe06cOc+d2KwJ5nnyA/wjZx+sLUOxh3ifQPL/VIyWuWdvvNiKRrA== From: Fan Jeff To: Paulo Alcantara , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [RFC v4 6/6] UefiCpuPkg/CpuExceptionHandlerLib: Correctly print IP addresses Thread-Index: AQHTgF9HTz1NcoOCN0+TpP2e/4VaZqNh28Yw Date: Wed, 3 Jan 2018 08:46:45 +0000 Message-ID: References: , <7405ac1dcf60165ad4b044a140b5c7c2ed10902c.1514517573.git.paulo@paulo.ac> In-Reply-To: <7405ac1dcf60165ad4b044a140b5c7c2ed10902c.1514517573.git.paulo@paulo.ac> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-incomingtopheadermarker: OriginalChecksum:7B3848BE5A386222A0A30731A23AEF5EC66B7ADBAFF67391D8B9D60556AA4E77; UpperCasedChecksum:4F47CBDB5381A224CF8B4A70E9C0E74CA187B135BC6597D4F2B5E4EF5108D086; SizeAsReceived:7282; Count:47 x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [55fz8y6fhpSvk5kBP+oIKSQF7PvdWXi1] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; SN1NAM02HT054; 6:dZmuk7TTGyRZLrIE371RWZv5Y21exi6eO2VXbREaD2tBHbYWfD3DkHsd4k5p+RunhnFxj6hYcv1aES7NyzLa9u4nQBhe5QUAkLAqXhYpZaiw3odeh42Jfg4BeAoyS6Knd1tHKw8B2bZAUngeRgHKDmhTTPfdRS2AwiY+4LFzYy76mCiDZXfqedDEepLzrLQSQ8c5ukmoY6T1NOjEusNAFMSl4fYffxE/FA8BfC3hXC7sQ/1IaMTndBBLWofDWwuhq7dKcihB/iXu0zhNtml8A9yVkdzx1qnzemSBN3WFwSXVTALVjtd4SKnk8htznTGqVq+IAJk4RXQ9ci9ZeMfKnD8j3hgb4XjZHidTmUGZEb8=; 5:rGzu47nyG35SdfaM3YfOpfZlHSJo0JOcV73ZwDSuAGyCgB4DamKK4TQogzwIMi02W3ATBaFV95W1LRypXxl2tmRqkUbu1NpsGYS9eIb02uhRpwy1A/DqOyVWEPo6a5G4qkeVdr/snYtIn4y7rmjKARpF5quJiPBRkEwIE+VoZwc=; 24:GK6Gl5uPXa5ESdIhD3rRySzWVqUMY0iSwaiExfWZyzxENeEAnPIbryLzaD4aVapYXqAuEPMc9mJckLce1wv+nKxYNfofykC/q98DbcFC2kk=; 7:vGZtNo89t7EhKMN6SXc5CUnKAnonyZpjW1uju3jh7YMrR5oIm3I/l3XRLSeFpMFn5o0phj9itdJyps3pdfZrsP/zOkv5zMydJMJeA3SF3ZAlk1hml1crJNnpBWsZEiH1s5sc09YmpizZP1+GLAiA7CXZEr9DsV9QY1mNN96KW8lN10wQ2Vlj8pnMTvEugGEDtHojeZ8aQP+EEmPnCoBelVviEayfzwlDb6IjTX1CcnlNrgIZHClqrAelsi8L+ejY x-incomingheadercount: 47 x-eopattributedmessage: 0 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(201702061074)(5061506573)(5061507331)(1603103135)(2017031320274)(2017031324274)(2017031323274)(2017031322404)(1603101448)(1601125374)(1701031045); SRVR:SN1NAM02HT054; x-ms-traffictypediagnostic: SN1NAM02HT054: x-ms-office365-filtering-correlation-id: 260b69fb-ce0e-450e-2b25-08d552868559 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(444000031); SRVR:SN1NAM02HT054; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:SN1NAM02HT054; x-forefront-prvs: 0541031FF6 x-forefront-antispam-report: SFV:NSPM; SFS:(7070007)(98901004); DIR:OUT; SFP:1901; SCL:1; SRVR:SN1NAM02HT054; H:CO2PR19MB0137.namprd19.prod.outlook.com; FPR:; SPF:None; LANG:; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: hotmail.com X-MS-Exchange-CrossTenant-Network-Message-Id: 260b69fb-ce0e-450e-2b25-08d552868559 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jan 2018 08:46:45.8789 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1NAM02HT054 X-Content-Filtered-By: Mailman/MimeDel 2.1.23 Subject: [edk2] =?big5?b?tarOYDogIFtSRkMgdjQgNi82XSBVZWZpQ3B1UGtnL0NwdUV4?= =?big5?b?Y2VwdGlvbkhhbmRsZXJMaWI6IENvcnJlY3RseSBwcmludCBJUCBhZGRyZXNzZXM=?= X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laszlo Ersek , Eric Dong Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Paulo, Thanks. Reviewed-by: Jeff Fan Jeff ________________________________ From: edk2-devel on behalf of Paulo Alcan= tara Sent: Friday, December 29, 2017 12:39:39 PM To: edk2-devel@lists.01.org Cc: Laszlo Ersek; Eric Dong Subject: [edk2] [RFC v4 6/6] UefiCpuPkg/CpuExceptionHandlerLib: Correctly p= rint IP addresses Remove the supurious '- 1' when calculating the IP addresses during the stack traces. Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Eric Dong Cc: Laszlo Ersek Requested-by: Jeff Fan Signed-off-by: Paulo Alcantara --- UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32/ArchExceptionHandler.c | 2 = +- UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/ArchExceptionHandler.c | 2 = +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32/ArchExceptionHa= ndler.c b/UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32/ArchExceptionHandl= er.c index 9b52d4f6d2..e2a3341286 100644 --- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32/ArchExceptionHandler.c +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32/ArchExceptionHandler.c @@ -573,7 +573,7 @@ DumpStackTrace ( *UnwoundStacksCount - 1, Eip, ImageBase, - Eip - ImageBase - 1, + Eip - ImageBase, Ebp, PdbFileName ); diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/ArchExceptionHan= dler.c b/UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/ArchExceptionHandler= .c index 8067c34122..5ae3aa4e73 100644 --- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/ArchExceptionHandler.c +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/ArchExceptionHandler.c @@ -717,7 +717,7 @@ DumpStackTrace ( *UnwoundStacksCount - 1, Rip, ImageBase, - Rip - ImageBase - 1, + Rip - ImageBase, Rbp, PdbFileName ); -- 2.14.3 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel