From nobody Fri May 17 12:14:56 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+106527+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+106527+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1688069813; cv=none; d=zohomail.com; s=zohoarc; b=IeiVNbrWcDPa5sLXbfkX/0xzL6674cnQtZtGfgJMweczro4LVvQnwHzasVGS3q1LQom/Qj6BRC5pYmAF20ROhe35xIDK63ZUpYyN5KEqy8V7WyBfSm8t3KB3kh22c4Lnw56+ux/OqNqk3T6IH7Oq8rYt8FqMEYBY3AnMsQBYMQw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1688069813; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=S2Xn1Ho1GPbUIhdBDVz9kslScHdMnpxnUpj/bG9WHHk=; b=URryytuNWYr/b0l7GizRvu0fXM9jvRLTdvK9g/ytOL7G/oWmtZZon5unbpmxuu8islBbhMFZGGBaEqi49iv6/15tfSjEocUjJWTQ1DN+n8QQ256swguHLCcGhJb7ZZaPYX/kPg36Czhwk3EFhX1+G1Tk5BL7PVWfhnD72/K0+GU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+106527+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1688069813655948.2523406397157; Thu, 29 Jun 2023 13:16:53 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id PTzLYY1788612xCwdsYn7l3E; Thu, 29 Jun 2023 13:16:53 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.7448.1688069812372262620 for ; Thu, 29 Jun 2023 13:16:52 -0700 X-Received: from [192.168.1.197] (ip72-199-172-9.sd.sd.cox.net [72.199.172.9]) by linux.microsoft.com (Postfix) with ESMTPSA id 949682083967; Thu, 29 Jun 2023 13:16:51 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 949682083967 Message-ID: <75d1a49a-1df2-0669-0053-7d91a46d875a@linux.microsoft.com> Date: Thu, 29 Jun 2023 13:16:50 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 To: devel@edk2.groups.io Cc: Abner.Chang@amd.com, michael.d.kinney@intel.com From: "Aaron Pop" Subject: [edk2-devel] Subject: [PATCH] Modify IPMI_GET_SYSTEM_UUID_RESPONSE to use IPMI_GUID. Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,aaronpop@linux.microsoft.com X-Gm-Message-State: GAZ7XDKIUhphcUvf4z7L9n5Rx1787277AA= Content-Language: en-US Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1688069813; bh=oTrLoHERlEqD+Adz9MtT01ihY8OPqBF2C3uLNancNPY=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=ufyK4t183CHEY23tDZ1tSYp09C3/7p0Up9HNa2kAfje1V236huDYiS5684/CQ1DlkW6 snhqNaH22a0yIpfgv2qH5mbN1JsXperkZUcmt+1LmnnQEqH61RKR51nLdfI6L3WIjvOLK Nmp3LTNPt/2nfSbtNcjT1lB6fulNjispqyU= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1688069815379100001 Content-Type: text/plain; charset="utf-8"; format="flowed" IPMI specification's Get Device Guid Command says that data is returned in "least signification byte first" and "this is the reverse of convention described in RFC4122". IPMI_GET_SYSTEM_UUID_RESPONSE is defined to use EFI_GUID, which is reverse format of Ipmi specification. Correcting IPMI_GET_SYSTEM_UUID_RESPONSE to use IPMI_GUID. Signed-off-by: Aaron Pop --- MdePkg/Include/IndustryStandard/IpmiNetFnApp.h | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h=20 b/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h index b6bc91f46c..afdc2dc30b 100644 --- a/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h +++ b/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h @@ -14,6 +14,7 @@ Copyright (c) 1999 - 2018, Intel Corporation. All rights reserved.
Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.
Copyright (c) 2023, Ampere Computing LLC. All rights reserved.
+ Copyright (c) Microsoft Corporation. SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -488,9 +489,22 @@ typedef struct { // #define IPMI_APP_GET_SYSTEM_GUID 0x37 +// +// In IPMI, GUID are stored least-significant byte first. +// The order of fields are the reverse of convention described in=20 [RFC4122]. +// Note: This definition is used for both the IPMI_APP_GET_SYSTEM_GUID +// and IPMI_APP_GET_DEVICE_GUID. +// +typedef struct { + UINT8 Data4[8]; + UINT16 Data3; + UINT16 Data2; + UINT32 Data1; +} IPMI_GUID; + typedef struct { - UINT8 CompletionCode; - EFI_GUID SystemUuid; + UINT8 CompletionCode; + IPMI_GUID SystemUuid; } IPMI_GET_SYSTEM_UUID_RESPONSE; // --=20 2.41.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#106527): https://edk2.groups.io/g/devel/message/106527 Mute This Topic: https://groups.io/mt/99858608/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-