From nobody Sat May 18 11:46:56 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+91211+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91211+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1657515938; cv=none; d=zohomail.com; s=zohoarc; b=XU7xsCdJcoq1oFu7GgpMTfXjf4erjuZPq/kXV+i9btpJYSlaS58m4vM+L15HTF2YHe/peUM2h+UKOjuj2A4J5n3+MpPqZ7WRbTmMQzfZQmszyF8oOP/jHu1E2EA6nlS02KnbhK9WY6/PK4ftBUVRHlOlXFNi7WF/ETslMHA/k9c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657515938; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=LLXcacGbwdgLca/B0P7FECatIKibSITP3Gpgmxx3ncY=; b=QlRe2wFZ1ThXotbJD8pj/Z8v+sUJ5crX4JKCYOleB95pTgsEC+2nCPpDYJNN+TQXj2L9e9At1pfpNUHok9Kkzpdr5CVNw6trDzitlq75z6qjkBotUgHtE0rYOUrSAwv1LlFLTVUEaDFa2O0mWS06oaATjC5Oaa+BZfT547cQT7I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91211+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1657515938806790.3585483217582; Sun, 10 Jul 2022 22:05:38 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 048qYY1788612xI3CMcoqgjt; Sun, 10 Jul 2022 22:05:37 -0700 X-Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web09.24990.1657515937122848097 for ; Sun, 10 Jul 2022 22:05:37 -0700 X-IronPort-AV: E=McAfee;i="6400,9594,10404"; a="283330474" X-IronPort-AV: E=Sophos;i="5.92,262,1650956400"; d="scan'208";a="283330474" X-Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jul 2022 22:05:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,262,1650956400"; d="scan'208";a="771396959" X-Received: from jameslu8-desk2.gar.corp.intel.com ([10.5.215.168]) by orsmga005.jf.intel.com with ESMTP; 10 Jul 2022 22:05:34 -0700 From: "Lu, James" To: devel@edk2.groups.io Cc: James Lu , Ray Ni , Guo Dong , Gua Guo Subject: [edk2-devel] [PATCH] UefiPayloadPkg: Fix RelaAddress type always mismatch in if condition Date: Mon, 11 Jul 2022 13:05:31 +0800 Message-Id: <6749516ae40598938d4a7447d5d607aa6ad52756.1657515840.git.james.lu@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,james.lu@intel.com X-Gm-Message-State: xva0PpfGBCFuagst0gRVMSzTx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1657515937; bh=VrLQ6jcQbCnZ0QSVfJfunui1C2L4C81TTWsOG2Mp/lw=; h=Cc:Date:From:Reply-To:Subject:To; b=gmSGEqCfrxcMZjn4eT1irtNAYFZwFTN68Fi7GtIDJ0sakqDznJQdl2StgXsAmGf3C0q 9mXesCxTAOGQdbNzNE06O61nz/TTGLW0E7jszN8nRC0ngB7qebcItni9AZ5ZvwZc0jtvt IKkPUOpljeNdvcQHi1QvM4sDfb7bK3vdIGQ= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1657515940755100001 Content-Type: text/plain; charset="utf-8" From: James Lu REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3984 Under function RolocateElfDynamic() in Elf32Lib.c if (RelaAddress =3D=3D MAX_UINT64) is always FALSE while RelaAddress is UIN= T32 Fix is to modify if condition check to "if (RelaAddress =3D=3D MAX_UINT32)" Cc: Ray Ni Cc: Guo Dong Cc: Gua Guo Signed-off-by: James Lu Reviewed-by: Guo Dong --- UefiPayloadPkg/PayloadLoaderPeim/ElfLib/Elf32Lib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/UefiPayloadPkg/PayloadLoaderPeim/ElfLib/Elf32Lib.c b/UefiPaylo= adPkg/PayloadLoaderPeim/ElfLib/Elf32Lib.c index b002c4b9cf..cb915e7142 100644 --- a/UefiPayloadPkg/PayloadLoaderPeim/ElfLib/Elf32Lib.c +++ b/UefiPayloadPkg/PayloadLoaderPeim/ElfLib/Elf32Lib.c @@ -292,7 +292,7 @@ RelocateElf32Dynamic ( } } =20 - if (RelaAddress =3D=3D MAX_UINT64) { + if (RelaAddress =3D=3D MAX_UINT32) { ASSERT (RelaCount =3D=3D 0); ASSERT (RelaEntrySize =3D=3D 0); ASSERT (RelaSize =3D=3D 0); --=20 2.26.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#91211): https://edk2.groups.io/g/devel/message/91211 Mute This Topic: https://groups.io/mt/92303921/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-