From nobody Fri May 17 02:03:26 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92741+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1661315748101632.084661302669; Tue, 23 Aug 2022 21:35:48 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id YprQYY1788612xpHoNtArjWx; Tue, 23 Aug 2022 21:35:46 -0700 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.40]) by mx.groups.io with SMTP id smtpd.web10.7443.1661315745799872479 for ; Tue, 23 Aug 2022 21:35:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F9FrJaScMIMzzHoklVu+QpV4OAdnA0NZLSFZtZOHrq/Do+LyaXMAPbez+hcukMs9+Dg8FC2o33F2aiFojX1nJPSwnsQObOV+ePP1OGSQkUg4kDiiCWE1aC1z0ZVnV6aoF4xv65Urvw/lWs5uL9MCMn2SL9boB4tfu9c1A9QLDLn+VwgqwhEW3lpt6Zm1LJCJpQ9qHrLCw5iwcloGHTkFYFgcjrdp4k3L64Q5ZUncEHAhrHWZW77UB7eozU3zdhi/W4SVyx7/15EJYS8A5zNyksacwI1c+f0/BFRaa7ZhzAfFWMVkZtgZVWiH+ioyYnokzqDAux4/6j4ujE0HilpPyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aHCz3nHzc+QUzRy1iRNo7sO7LEzldjSfcrMxZp99q1Y=; b=BJA8J0j9OYu6T2ieerudx+FBRwYSA8fSJSAix1iGGEnUPrP2nr7M76GEelejAqz9jV2Kprsh4IADbhUCqeuKWls9N2Vv8JihIJE88odNgthyuEXXmK5VBMhth0Oas1R7AeXpypB1KHzY244DaHh5UAtizmIjCb6QZnGg4ofPxxeCOp3+RvKTFAgrpxcvTAmZB+GCYrBQee5IGlB/gKCPmTPffWhQZEQJKmxkj12+eNeCRH23Q62TTe2gveV+JqTSMZfUJrksbcyY05thrXlEC+msqvyxT8N5+w9HopxT3w+WI/GuvDMURzwqPn2CuwsBTeu3a8y4qlS7pXyjJCU8Yg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 12.22.5.238) smtp.rcpttodomain=arm.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none X-Received: from MW4PR03CA0354.namprd03.prod.outlook.com (2603:10b6:303:dc::29) by CY4PR1201MB0056.namprd12.prod.outlook.com (2603:10b6:910:1c::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.22; Wed, 24 Aug 2022 04:35:43 +0000 X-Received: from CO1NAM11FT015.eop-nam11.prod.protection.outlook.com (2603:10b6:303:dc:cafe::fa) by MW4PR03CA0354.outlook.office365.com (2603:10b6:303:dc::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.22 via Frontend Transport; Wed, 24 Aug 2022 04:35:43 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 12.22.5.238) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+92741+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 12.22.5.238 as permitted sender) receiver=protection.outlook.com; client-ip=12.22.5.238; helo=mail.nvidia.com; pr=C X-Received: from mail.nvidia.com (12.22.5.238) by CO1NAM11FT015.mail.protection.outlook.com (10.13.175.130) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.5566.15 via Frontend Transport; Wed, 24 Aug 2022 04:35:42 +0000 X-Received: from rnnvmail201.nvidia.com (10.129.68.8) by DRHQMAIL105.nvidia.com (10.27.9.14) with Microsoft SMTP Server (TLS) id 15.0.1497.38; Wed, 24 Aug 2022 04:35:41 +0000 X-Received: from rnnvmail203.nvidia.com (10.129.68.9) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Tue, 23 Aug 2022 21:35:40 -0700 X-Received: from ed7fa55790ac.nvidia.com (10.127.8.14) by mail.nvidia.com (10.129.68.9) with Microsoft SMTP Server id 15.2.986.29 via Frontend Transport; Tue, 23 Aug 2022 21:35:40 -0700 From: "Jeff Brasen via groups.io" To: CC: , , , , Jeff Brasen Subject: [edk2-devel] [PATCH v2] DynamicTablesPkg: AcpiSsdtPcieLibArm : Add UID to slot creation Date: Tue, 23 Aug 2022 22:35:53 -0600 Message-ID: <42a40dcf43d62ff985fd89bbcde47558344384bc.1661315727.git.jbrasen@nvidia.com> MIME-Version: 1.0 X-NVConfidentiality: public X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ec5dafb3-5f6c-4db8-b6a0-08da858a1a6a X-MS-TrafficTypeDiagnostic: CY4PR1201MB0056:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: 4TssPXG/z4DW9jtZgTbaXQiIhuZqlGZkClegCCbVB1IKR2kSo29ajrhOfP8frtsTv2VhqnThFglFHh8KUJSzpb23qrRPph/xu3dG0yD/v9gSttAc8k85Sm8OG+uk+dF4UfXnE0PkeNJ0XJySbF2ELmXWhGGTBYmV4H2eqKcl01VA0G3PoSohbVJW0fz/kKKizaBk2migeSUDjjc4nGSyXN7YJJXyeAtpp62qXA1kdu7jnuXal3S49m108D79hZKafgoUjfFwF392ZtWjWvcAHawUKFDkkOTMW6tZc3n5Bsxf0TmCkSgl55G3KWbASPPP/EyyIYhqzTkET1JGquJ797TVXemWQf24OJxOhLjfv0E1W4BKcsp5XZyruu3/eAnFBsZrsFK2ZH4JXuTpZnO3BH6XFc0PmOxh+/LOEGpjEsZV6BhpRaAbJ9z/7xvLaV6i7k4FeoxAlOKSWoUzVqeghHzlOZWYWjl9kBY++qSjXqYv3NCsX/+nvZPoe2w0FLDa5BMKLaSZMHZ4rzZppVTdpQIzgFHfL1ehrcDRTQMPA9+M43oIF6TeMG/YzhqVCTGzKDs3rOo6XY/GMmO8uQlSLhv/pWywkWqiDOBzuinGG1tcoFZvU3DWa7LgDAKTxg/qI9dVPpDFf4RHMbAzc9lkluPB0PVywK9D89Ck13zzMKJMApiDPCPEk9ipu94I20KJi3moShiCIxfsAHZ2MyjVbYF3Ph/xXj7h1P5G6vkriIdjIJ87+Rpq4n5qnvmjcM/s/B++SglNKls3k8GFINcM6SbHQpOOAFRj1J9HqDKkF+22WkyPmA8+3nLuW3wixPpWF54WEx3Q/7ap3YtiHuTE4Lu6IRG3sFN5GTGoTyKSEQai3ky2cJqkd+6iVYtqessNaiZs75/Sw3xNeE8gRCQKmJld6Xv2k7DDSNSdtubbv2U= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Aug 2022 04:35:42.0435 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ec5dafb3-5f6c-4db8-b6a0-08da858a1a6a X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[12.22.5.238];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT015.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1201MB0056 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jbrasen@nvidia.com X-Gm-Message-State: 1rrU8ob6LCDuzQUVpzG7tMAax1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1661315746; bh=df/Yz9tOb5qHQhks/DITFOa78WSOlLNh6r5RTN6wusQ=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=LO10yIYOX4qTAV7voJEfz+ICDDQmQ6SD6UFlO7ANtc/h7gYowJnC/NUY3LKWKIyJy5P 1G/Rr9TDoXCRWOIcM6erasigw9c18RCJaJ5AsQiQ6QM7tiaj/zUF7F4aOz1NoquJTDJcU skNJdIoSGZVXLU/yLZg6wfLULDHHicWKmTc= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1661315749395100001 Content-Type: text/plain; charset="utf-8" Expose the UID value to GeneratePciSlots(). This is needed for some cases for example: https://docs.microsoft.com/en-us/windows-hardware/drivers/pci/dsd-for-pcie-= root-ports#identifying-externally-exposed-pcie-root-ports Name (_DSD, Package () { ToUUID("EFCC06CC-73AC-4BC3-BFF0-76143807C389"), Package () { Package (2) {"ExternalFacingPort", 1}, Package (2) {"UID", 0}, } }) Signed-off-by: Jeff Brasen Reviewed-by: Pierre Gondois Reviewed-by: Sami Mujawar --- DynamicTablesPkg/Include/Library/SsdtPcieSupportLib.h | 8 +++++--- .../Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c | 5 ++++- .../Common/SsdtPcieSupportLib/SsdtPcieSupportLib.c | 8 +++++--- 3 files changed, 14 insertions(+), 7 deletions(-) diff --git a/DynamicTablesPkg/Include/Library/SsdtPcieSupportLib.h b/Dynami= cTablesPkg/Include/Library/SsdtPcieSupportLib.h index 85e283a994..4171dabc33 100644 --- a/DynamicTablesPkg/Include/Library/SsdtPcieSupportLib.h +++ b/DynamicTablesPkg/Include/Library/SsdtPcieSupportLib.h @@ -54,9 +54,10 @@ AddOscMethod ( used. It should be possible to enumerate them, but this is additional information. =20 - @param [in] PciInfo Pci device information. - @param [in] MappingTable The mapping table structure. - @param [in, out] PciNode Pci node to amend. + @param [in] PciInfo Pci device information. + @param [in] MappingTable The mapping table structure. + @param [in] Uid Unique Id of the Pci device. + @param [in, out] PciNode Pci node to amend. =20 @retval EFI_SUCCESS Success. @retval EFI_INVALID_PARAMETER Invalid parameter. @@ -67,6 +68,7 @@ EFIAPI GeneratePciSlots ( IN CONST CM_ARM_PCI_CONFIG_SPACE_INFO *PciInfo, IN CONST MAPPING_TABLE *MappingTable, + IN UINT32 Uid, IN OUT AML_OBJECT_NODE_HANDLE PciNode ); =20 diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieG= enerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieG= enerator.c index ceffe2838c..24e074ea90 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerato= r.c +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerato= r.c @@ -295,6 +295,7 @@ GeneratePciDeviceInfo ( @param [in] CfgMgrProtocol Pointer to the Configuration Manager Protocol interface. @param [in] PciInfo Pci device information. + @param [in] Uid Unique Id of the Pci device. @param [in, out] PciNode Pci node to amend. =20 @retval EFI_SUCCESS The function completed successfully. @@ -308,6 +309,7 @@ GeneratePrt ( IN ACPI_PCI_GENERATOR *Generator, IN CONST EDKII_CONFIGURATION_MANAGER_PROTOCOL *CONST CfgMgrProtoc= ol, IN CONST CM_ARM_PCI_CONFIG_SPACE_INFO *PciInfo, + IN UINT32 Uid, IN OUT AML_OBJECT_NODE_HANDLE PciNode ) { @@ -416,7 +418,7 @@ GeneratePrt ( PrtNode =3D NULL; =20 // Generate the Pci slots once all the device have been added. - Status =3D GeneratePciSlots (PciInfo, &Generator->DeviceTable, PciNode); + Status =3D GeneratePciSlots (PciInfo, &Generator->DeviceTable, Uid, PciN= ode); if (EFI_ERROR (Status)) { ASSERT (0); goto exit_handler; @@ -687,6 +689,7 @@ GeneratePciDevice ( Generator, CfgMgrProtocol, PciInfo, + Uid, PciNode ); if (EFI_ERROR (Status)) { diff --git a/DynamicTablesPkg/Library/Common/SsdtPcieSupportLib/SsdtPcieSup= portLib.c b/DynamicTablesPkg/Library/Common/SsdtPcieSupportLib/SsdtPcieSupp= ortLib.c index e5ab3a3ca8..b35fb6a7dd 100644 --- a/DynamicTablesPkg/Library/Common/SsdtPcieSupportLib/SsdtPcieSupportLib= .c +++ b/DynamicTablesPkg/Library/Common/SsdtPcieSupportLib/SsdtPcieSupportLib= .c @@ -41,9 +41,10 @@ used. It should be possible to enumerate them, but this is additional information. =20 - @param [in] PciInfo Pci device information. - @param [in] MappingTable The mapping table structure. - @param [in, out] PciNode Pci node to amend. + @param [in] PciInfo Pci device information. + @param [in] MappingTable The mapping table structure. + @param [in] Uid Unique Id of the Pci device. + @param [in, out] PciNode Pci node to amend. =20 @retval EFI_SUCCESS Success. @retval EFI_INVALID_PARAMETER Invalid parameter. @@ -54,6 +55,7 @@ EFIAPI GeneratePciSlots ( IN CONST CM_ARM_PCI_CONFIG_SPACE_INFO *PciInfo, IN CONST MAPPING_TABLE *MappingTable, + IN UINT32 Uid, IN OUT AML_OBJECT_NODE_HANDLE PciNode ) { --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92741): https://edk2.groups.io/g/devel/message/92741 Mute This Topic: https://groups.io/mt/93220941/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-