From nobody Fri May 17 07:08:05 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+113453+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+113453+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1704812698; cv=none; d=zohomail.com; s=zohoarc; b=n5c0WJj77ccVJclcPS9EqzgWsrfH6aDFFdB6KaHMdSASH3+YYwsipJTl/Rq8ow2Xum8oAeg7X0s6eyVGtkkzO0IC5c+rVvJaabZ+IwjOaCqwxWYgrPkSjY4QOAAF02UY77pBQ/WR4BXCU1MK8inWE61HpYtDqzYEXR5JkfLclgQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1704812698; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Sender:Subject:Subject:To:To:Message-Id; bh=s9dVeUS4k5sSvtMbeuXCmDtBqMtJZ4SkAylT6WscFUg=; b=QrhAIZMsaaH5f02nKg1PnVoSZLMIrKU6iGkJ4B5IccXqFxL7cu7h7PJ8Ti/DGRbezF0gu0sqYhtaaBtD9Mle1ODIqwD7cjBHq8TbJ3azJuBrIl24Ct1PBjNsEw2r5LAwWHh2KWAi7GHGswBsrHxGcbZpCZyGLL0fpOMCEI9X+o0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+113453+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 17048126980691001.4162876415263; Tue, 9 Jan 2024 07:04:58 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=s24uyVPJdQeUJrtplpiWT6CURKHJvtQfgGlYII2g1sg=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1704812697; v=1; b=KNTaY1ARmO5SDy5oDADgnqoNupyLC3ltC8bz4d6vGOieahvc6yBqSfOMPm8zZ/gMnSBMwbhV EKx8nI+syIw9Actm6J0ruqTuKvid04DaqD9hifrzjt/42x8ueEuSDJr7JQoTTZkj8tFecBqA5Se UhSOQckHJE01BOw6b+4xax3g= X-Received: by 127.0.0.2 with SMTP id ybiJYY1788612xEKbQfNkN1D; Tue, 09 Jan 2024 07:04:57 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web10.1534.1704696172441964401 for ; Sun, 07 Jan 2024 22:42:52 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10946"; a="377290531" X-IronPort-AV: E=Sophos;i="6.04,340,1695711600"; d="scan'208";a="377290531" X-Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jan 2024 22:42:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10946"; a="924768188" X-IronPort-AV: E=Sophos;i="6.04,340,1695711600"; d="scan'208";a="924768188" X-Received: from basatg01.gar.corp.intel.com ([10.66.253.28]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jan 2024 22:42:50 -0800 From: Pethaiyan Madhan To: devel@edk2.groups.io Cc: "Pethaiyan, Madhan" , Liming Gao , Michael D Kinney , Wei6 Xu Subject: [edk2-devel] [PATCH V2] FmpDevicePkg: GetImageInfo Add missing condition Date: Mon, 8 Jan 2024 12:12:39 +0530 Message-Id: <2d53b710572890495a268f208027c8de1e9b7fea.1704696138.git.madhan.pethaiyan@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,madhan.pethaiyan@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: uctqIncTtUBDpsIN2prcoDHOx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1704812700112100001 Content-Type: text/plain; charset="utf-8" From: "Pethaiyan, Madhan" UEFI Spec 2.10 , 23.1 Firmware Management Protocol , Added missing conditio= n check under GetImageInfo function, if the PackageVersionName is NULL return EFI_INVALID_PARAMETER Signed-off-by: Pethaiyan Madhan Cc: Liming Gao Cc: Michael D Kinney Cc: Wei6 Xu Reviewed-by: Michael D Kinney --- FmpDevicePkg/FmpDxe/FmpDxe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/FmpDevicePkg/FmpDxe/FmpDxe.c b/FmpDevicePkg/FmpDxe/FmpDxe.c index 1e7ec4a09e..e87094f84c 100644 --- a/FmpDevicePkg/FmpDxe/FmpDxe.c +++ b/FmpDevicePkg/FmpDxe/FmpDxe.c @@ -495,7 +495,7 @@ GetTheImageInfo ( // Confirm that buffer isn't null // if ( (ImageInfo =3D=3D NULL) || (DescriptorVersion =3D=3D NULL) || (Des= criptorCount =3D=3D NULL) || (DescriptorSize =3D=3D NULL) - || (PackageVersion =3D=3D NULL)) + || (PackageVersion =3D=3D NULL) || (PackageVersionName =3D=3D NULL)) { DEBUG ((DEBUG_ERROR, "FmpDxe(%s): GetImageInfo() - Pointer Parameter i= s NULL.\n", mImageIdName)); Status =3D EFI_INVALID_PARAMETER; --=20 2.38.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113453): https://edk2.groups.io/g/devel/message/113453 Mute This Topic: https://groups.io/mt/103620853/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-