Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
Old SMM stack size was 0x2000 which was not enough for Windows 10 16299 version. Because this version OS needs larger SMM stack size to set variable.
Changed SMM stack size from 0x2000 to 0x4000 to fix this issue.
https://bugzilla.tianocore.org/show_bug.cgi?id=964
Cc: Wei David <david.wei@intel.com>
Cc: Xuemin Yuan <xuemin.yuan@intel.com>
Signed-off-by: Guo Mang <mang.guo@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
---
Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
index 6ebbb66..cbbae31 100644
--- a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
+++ b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
@@ -1437,7 +1437,10 @@ $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/IA32/fTPMInitPeim.inf
#
MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf
MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf
- UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf
+ UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf {
+ <PcdsFixedAtBuild>
+ gUefiCpuPkgTokenSpaceGuid.PcdCpuSmmStackSize|0x4000
+ }
UefiCpuPkg/CpuIo2Smm/CpuIo2Smm.inf
MdeModulePkg/Universal/LockBox/SmmLockBox/SmmLockBox.inf
UefiCpuPkg/CpuS3DataDxe/CpuS3DataDxe.inf
--
2.10.1.windows.1
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Please also change the size for 32-bit BIOS. Reviewed-by: David Wei <david.wei@intel.com> Thanks, David Wei Intel SSG/STO/UEFI BIOS -----Original Message----- From: Guo, Mang Sent: Thursday, May 31, 2018 2:44 PM To: edk2-devel@lists.01.org Cc: Wei, David <david.wei@intel.com>; Yuan, Xuemin <xuemin.yuan@intel.com> Subject: [Patch][edk2-platforms/devel-MinnowBoardMax-UDK2017] Vlv2TbltDevicePkg: Change SMM stack size Old SMM stack size was 0x2000 which was not enough for Windows 10 16299 version. Because this version OS needs larger SMM stack size to set variable. Changed SMM stack size from 0x2000 to 0x4000 to fix this issue. https://bugzilla.tianocore.org/show_bug.cgi?id=964 Cc: Wei David <david.wei@intel.com> Cc: Xuemin Yuan <xuemin.yuan@intel.com> Signed-off-by: Guo Mang <mang.guo@intel.com> Contributed-under: TianoCore Contribution Agreement 1.1 --- Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc index 6ebbb66..cbbae31 100644 --- a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc +++ b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc @@ -1437,7 +1437,10 @@ $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/IA32/fTPMInitPeim.inf # MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf - UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf + UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf { + <PcdsFixedAtBuild> + gUefiCpuPkgTokenSpaceGuid.PcdCpuSmmStackSize|0x4000 + } UefiCpuPkg/CpuIo2Smm/CpuIo2Smm.inf MdeModulePkg/Universal/LockBox/SmmLockBox/SmmLockBox.inf UefiCpuPkg/CpuS3DataDxe/CpuS3DataDxe.inf -- 2.10.1.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
On 05/31/18 08:43, Guo, Mang wrote: > Old SMM stack size was 0x2000 which was not enough for Windows 10 16299 version. Because this version OS needs larger SMM stack size to set variable. > Changed SMM stack size from 0x2000 to 0x4000 to fix this issue. > > https://bugzilla.tianocore.org/show_bug.cgi?id=964 You can thank me for commit 509f8425b75d ;) (Obviously the credit goes to the folks that implemented the stack guard in the first place! Alas, its usefulness was much limited until we enabled it by default.) I'm happy you didn't have to track down the SMM stack overflow the hard way, like we needed to do before 509f8425b75d. Laszlo _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
© 2016 - 2024 Red Hat, Inc.