[v3] OvmfPkg/VirtNorFlashDxe: fix corruption + misc small improvements

[edk2-devel] [PATCH v3 0/6] OvmfPkg/VirtNorFlashDxe: fix corruption + misc small improvements

Posted by Gerd Hoffmann 3 months, 2 weeks ago

This is a little series containing the flash corruption fix sent
yesterday with an slightly improved commit message and some small
improvements on top of this.

v3:
 - fix diagram
 - fix DoErase control flow
 - pick up reviewed-by tags
v2:
 - drop broken bugfix, fix the bug when introducing Start+End variables
   instead.
 - add patch with UINTN and UINT32 casts.
 - add patch splitting the DoErase code path into a new function.
 - add the diagram sent by Laszlo.

Gerd Hoffmann (6):
  OvmfPkg/VirtNorFlashDxe: add casts to UINTN and UINT32
  OvmfPkg/VirtNorFlashDxe: clarify block write logic & fix shadowbuffer
    reads
  OvmfPkg/VirtNorFlashDxe: add a loop for NorFlashWriteBuffer calls.
  OvmfPkg/VirtNorFlashDxe: allow larger writes without block erase
  OvmfPkg/VirtNorFlashDxe: ValidateFvHeader: unwritten state is EOL too
  OvmfPkg/VirtNorFlashDxe: move DoErase code block into new function

 OvmfPkg/VirtNorFlashDxe/VirtNorFlash.h    |   2 +-
 OvmfPkg/VirtNorFlashDxe/VirtNorFlash.c    | 145 ++++++++++++++--------
 OvmfPkg/VirtNorFlashDxe/VirtNorFlashFvb.c |   5 +
 3 files changed, 101 insertions(+), 51 deletions(-)

-- 
2.43.0



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113915): https://edk2.groups.io/g/devel/message/113915
Mute This Topic: https://groups.io/mt/103766773/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v3 0/6] OvmfPkg/VirtNorFlashDxe: fix corruption + misc small improvements

Posted by Laszlo Ersek 3 months, 1 week ago

On 1/16/24 18:10, Gerd Hoffmann wrote:
> This is a little series containing the flash corruption fix sent
> yesterday with an slightly improved commit message and some small
> improvements on top of this.
> 
> v3:
>  - fix diagram
>  - fix DoErase control flow
>  - pick up reviewed-by tags
> v2:
>  - drop broken bugfix, fix the bug when introducing Start+End variables
>    instead.
>  - add patch with UINTN and UINT32 casts.
>  - add patch splitting the DoErase code path into a new function.
>  - add the diagram sent by Laszlo.
> 
> Gerd Hoffmann (6):
>   OvmfPkg/VirtNorFlashDxe: add casts to UINTN and UINT32
>   OvmfPkg/VirtNorFlashDxe: clarify block write logic & fix shadowbuffer
>     reads
>   OvmfPkg/VirtNorFlashDxe: add a loop for NorFlashWriteBuffer calls.
>   OvmfPkg/VirtNorFlashDxe: allow larger writes without block erase
>   OvmfPkg/VirtNorFlashDxe: ValidateFvHeader: unwritten state is EOL too
>   OvmfPkg/VirtNorFlashDxe: move DoErase code block into new function
> 
>  OvmfPkg/VirtNorFlashDxe/VirtNorFlash.h    |   2 +-
>  OvmfPkg/VirtNorFlashDxe/VirtNorFlash.c    | 145 ++++++++++++++--------
>  OvmfPkg/VirtNorFlashDxe/VirtNorFlashFvb.c |   5 +
>  3 files changed, 101 insertions(+), 51 deletions(-)
> 

Merged as commit range 59f024c76ee5..b481b00f593e, via
<https://github.com/tianocore/edk2/pull/5273>.

Thanks!
Laszlo



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114010): https://edk2.groups.io/g/devel/message/114010
Mute This Topic: https://groups.io/mt/103766773/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076/xyzzy [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v3 0/6] OvmfPkg/VirtNorFlashDxe: fix corruption + misc small improvements

Posted by Ard Biesheuvel 3 months, 1 week ago

On Thu, 18 Jan 2024 at 21:28, Laszlo Ersek <lersek@redhat.com> wrote:
>
> On 1/16/24 18:10, Gerd Hoffmann wrote:
> > This is a little series containing the flash corruption fix sent
> > yesterday with an slightly improved commit message and some small
> > improvements on top of this.
> >
> > v3:
> >  - fix diagram
> >  - fix DoErase control flow
> >  - pick up reviewed-by tags
> > v2:
> >  - drop broken bugfix, fix the bug when introducing Start+End variables
> >    instead.
> >  - add patch with UINTN and UINT32 casts.
> >  - add patch splitting the DoErase code path into a new function.
> >  - add the diagram sent by Laszlo.
> >
> > Gerd Hoffmann (6):
> >   OvmfPkg/VirtNorFlashDxe: add casts to UINTN and UINT32
> >   OvmfPkg/VirtNorFlashDxe: clarify block write logic & fix shadowbuffer
> >     reads
> >   OvmfPkg/VirtNorFlashDxe: add a loop for NorFlashWriteBuffer calls.
> >   OvmfPkg/VirtNorFlashDxe: allow larger writes without block erase
> >   OvmfPkg/VirtNorFlashDxe: ValidateFvHeader: unwritten state is EOL too
> >   OvmfPkg/VirtNorFlashDxe: move DoErase code block into new function
> >
> >  OvmfPkg/VirtNorFlashDxe/VirtNorFlash.h    |   2 +-
> >  OvmfPkg/VirtNorFlashDxe/VirtNorFlash.c    | 145 ++++++++++++++--------
> >  OvmfPkg/VirtNorFlashDxe/VirtNorFlashFvb.c |   5 +
> >  3 files changed, 101 insertions(+), 51 deletions(-)
> >
>
> Merged as commit range 59f024c76ee5..b481b00f593e, via
> <https://github.com/tianocore/edk2/pull/5273>.
>

Much appreciated! Thanks to the both of you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114029): https://edk2.groups.io/g/devel/message/114029
Mute This Topic: https://groups.io/mt/103766773/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-