From nobody Fri May 17 17:30:26 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+113365+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+113365+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1704698662; cv=none; d=zohomail.com; s=zohoarc; b=h0aTpaBHqgNxkTZAlA01z2DBb766UvcO3tp2hUcF5wYScgHvpm6g9Tbstb8kb0o+7+w1lCakMoEhhsn09x+XA8XauPuGEvEnaZFYL5dEE2yO1rK/82V+nI8jQLJaKF8Uw5qP7UMdklYoF83cCGOQc1rmDvMO3uLau1QlGesx0yA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1704698662; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=EmeurWK0BaRNrpS3Nog32QkW7937JEctpYPc6fgFTj8=; b=gPPGorhOFQEYucJM698VVybuAcXPt7Bdd3eikPSMUuTemmvpxlCHgaW/gXbq21Yy1Zshkj+UbBTiPuFpKJ6CEEHua7iaXcaPmQwW1lpysLtmhLEUGvxY+mYWZKSCUUO8AqKDWWcc1fqEmlYWUN7DmbiPJUdc2TpbIvQsF0u7yyo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+113365+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1704698662411502.6413031670977; Sun, 7 Jan 2024 23:24:22 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=0w4zOXLC0Q7QzSyUYNjc7MlQR6fz3QSyeeNveSh4/A4=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1704698662; v=1; b=pbmjMb/xz6yh9SftZuhYtyWHVGtGh6A4Mso46rRiYuUC8MiFIcBe10+qII1pW4GcLBVWaSEf +Yfp8VHkZX05nVK3pRiVZhNeOqR1UvvlYQIjXi+BYgdlDyxIpdOTRR8dmKCCZxR1QLS9qMfi2qx QoR14DPDzTRZjlDf1TVfxe3A= X-Received: by 127.0.0.2 with SMTP id kNDQYY1788612x5LcNXp5zwm; Sun, 07 Jan 2024 23:24:22 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web11.1893.1704698661416571558 for ; Sun, 07 Jan 2024 23:24:21 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10946"; a="464212697" X-IronPort-AV: E=Sophos;i="6.04,340,1695711600"; d="scan'208";a="464212697" X-Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jan 2024 23:24:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10946"; a="731028243" X-IronPort-AV: E=Sophos;i="6.04,340,1695711600"; d="scan'208";a="731028243" X-Received: from gchen29.sh.intel.com ([10.239.154.135]) by orsmga003.jf.intel.com with ESMTP; 07 Jan 2024 23:24:19 -0800 From: "Chen, Gang C" To: devel@edk2.groups.io Cc: gua.guo@intel.com, guo.dong@intel.com, james.lu@intel.com, sean@starlabs.systems, Gang Chen Subject: [edk2-devel] [PATCH 1/1] UefiPayloadPkg/UefiPayloadEntry: Remove SCI enabling check Date: Mon, 8 Jan 2024 15:25:31 +0800 Message-Id: <20240108072531.3344290-4-gang.c.chen@intel.com> In-Reply-To: <20240108072531.3344290-1-gang.c.chen@intel.com> References: <20240108072531.3344290-1-gang.c.chen@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,gang.c.chen@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: q2hnbbVI96DmCiglVJhnhNJAx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1704698664095100001 Content-Type: text/plain; charset="utf-8" It's too early to check the SCI enable status, which is set in the BDS phase ususally. Remove the check from UPL. Signed-off-by: Gang Chen Cc: Gua Guo Cc: Guo Dong Cc: James Lu Cc: Sean Rhodes Reviewed-by: Gua Guo Reviewed-by: James Lu --- UefiPayloadPkg/UefiPayloadEntry/AcpiTable.c | 38 --------------------- 1 file changed, 38 deletions(-) diff --git a/UefiPayloadPkg/UefiPayloadEntry/AcpiTable.c b/UefiPayloadPkg/U= efiPayloadEntry/AcpiTable.c index 1b9208b6d3..748728981a 100644 --- a/UefiPayloadPkg/UefiPayloadEntry/AcpiTable.c +++ b/UefiPayloadPkg/UefiPayloadEntry/AcpiTable.c @@ -134,44 +134,6 @@ Done: ASSERT (Fadt->Pm1aEvtBlk !=3D 0); ASSERT (Fadt->Gpe0Blk !=3D 0); =20 - DEBUG_CODE_BEGIN (); - BOOLEAN SciEnabled; - - // - // Check the consistency of SCI enabling - // - - // - // Get SCI_EN value - // - if (Fadt->Pm1CntLen =3D=3D 4) { - SciEnabled =3D (IoRead32 (Fadt->Pm1aCntBlk) & BIT0) ? TRUE : FALSE; - } else { - // - // if (Pm1CntLen =3D=3D 2), use 16 bit IO read; - // if (Pm1CntLen !=3D 2 && Pm1CntLen !=3D 4), use 16 bit IO read as a = fallback - // - SciEnabled =3D (IoRead16 (Fadt->Pm1aCntBlk) & BIT0) ? TRUE : FALSE; - } - - if (!(Fadt->Flags & EFI_ACPI_5_0_HW_REDUCED_ACPI) && - (Fadt->SmiCmd =3D=3D 0) && - !SciEnabled) - { - // - // The ACPI enabling status is inconsistent: SCI is not enabled but AC= PI - // table does not provide a means to enable it through FADT->SmiCmd - // - DEBUG (( - DEBUG_ERROR, - "ERROR: The ACPI enabling status is inconsistent: SCI is not" - " enabled but the ACPI table does not provide a means to enable it t= hrough FADT->SmiCmd." - " This may cause issues in OS.\n" - )); - } - - DEBUG_CODE_END (); - return RETURN_SUCCESS; } =20 --=20 2.40.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113365): https://edk2.groups.io/g/devel/message/113365 Mute This Topic: https://groups.io/mt/103593439/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri May 17 17:30:26 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+113363+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+113363+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1704698635; cv=none; d=zohomail.com; s=zohoarc; b=Axo5qnwfmD9XZZwU6Rwbomu/uZ0vfAkJgRcPFMWCdXbEhsmCEx8VN0Z+DtQOb29BxSq2P5VPDIGc5+BUgz02Cz7CIu9zw7mZj8O8qVkkmqjwORp6ZaM71NhVU04NYSIGp5W0ewvTsao6Gm/2JAAlIkAgIkTwRRHj3K32dNaizMY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1704698635; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=HJ+xuDfpIGMJkY4ZQhLEuxZ+nXs8F19MNKMtMxi0QDE=; b=bEFynhJHeDv8pDmFodHWj/hAaXJLw5irOcLK6YN8XIHmZfopucYigBDu2D3vfLYfc7e1sw1ECm/eBteK0WWzmIDixNrbiMjQYRnG+1stSMD5JGee+nnMVDlNASkGjA5c9/wOAo3dy45cbmcELqgla2G/aW0xUCc92pprX9VgEnA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+113363+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1704698635392298.1145617360346; Sun, 7 Jan 2024 23:23:55 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=xs2b0+FDsIIkhNt8Iq9MqWW4I86PrT/De+rRwVwOxCI=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1704698635; v=1; b=nMuNW+z+S3HFMhs1ron2BIMxQrt71wKr3uJLi6+vyEjDfVpXCuU/i9jvEEHr8D4Eo4In1tqf ajoItEPeLejYj5iOeYppXnQW+Y1YFeOLYrQLSMSkYnaFnovYCRG5Op4GuTcSBHfjU2/bQYatWoM tYO638/sWaZM/W/ubEmrvzVg= X-Received: by 127.0.0.2 with SMTP id dI9vYY1788612xC8nIGNHp72; Sun, 07 Jan 2024 23:23:55 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web10.1906.1704698634279040144 for ; Sun, 07 Jan 2024 23:23:54 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10946"; a="464212646" X-IronPort-AV: E=Sophos;i="6.04,340,1695711600"; d="scan'208";a="464212646" X-Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jan 2024 23:23:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10946"; a="731027898" X-IronPort-AV: E=Sophos;i="6.04,340,1695711600"; d="scan'208";a="731027898" X-Received: from gchen29.sh.intel.com ([10.239.154.135]) by orsmga003.jf.intel.com with ESMTP; 07 Jan 2024 23:23:52 -0800 From: "Chen, Gang C" To: devel@edk2.groups.io Cc: gua.guo@intel.com, guo.dong@intel.com, james.lu@intel.com, sean@starlabs.systems, Gang Chen Subject: [edk2-devel] [PATCH 1/1] UefiPayloadPkg/UefiPayloadEntry: Remove SCI enabling check Date: Mon, 8 Jan 2024 15:25:29 +0800 Message-Id: <20240108072531.3344290-2-gang.c.chen@intel.com> In-Reply-To: <20240108072531.3344290-1-gang.c.chen@intel.com> References: <20240108072531.3344290-1-gang.c.chen@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,gang.c.chen@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: FhnqXrsZzdMuVfxVe5jaR5Zqx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1704698635951100001 Content-Type: text/plain; charset="utf-8" It's too early to check the SCI enable status, which is set in the BDS phase ususally. Remove the check from UPL. Signed-off-by: Gang Chen Cc: Gua Guo Cc: Guo Dong Cc: James Lu Cc: Sean Rhodes --- UefiPayloadPkg/UefiPayloadEntry/AcpiTable.c | 38 --------------------- 1 file changed, 38 deletions(-) diff --git a/UefiPayloadPkg/UefiPayloadEntry/AcpiTable.c b/UefiPayloadPkg/U= efiPayloadEntry/AcpiTable.c index 1b9208b6d3..748728981a 100644 --- a/UefiPayloadPkg/UefiPayloadEntry/AcpiTable.c +++ b/UefiPayloadPkg/UefiPayloadEntry/AcpiTable.c @@ -134,44 +134,6 @@ Done: ASSERT (Fadt->Pm1aEvtBlk !=3D 0); ASSERT (Fadt->Gpe0Blk !=3D 0); =20 - DEBUG_CODE_BEGIN (); - BOOLEAN SciEnabled; - - // - // Check the consistency of SCI enabling - // - - // - // Get SCI_EN value - // - if (Fadt->Pm1CntLen =3D=3D 4) { - SciEnabled =3D (IoRead32 (Fadt->Pm1aCntBlk) & BIT0) ? TRUE : FALSE; - } else { - // - // if (Pm1CntLen =3D=3D 2), use 16 bit IO read; - // if (Pm1CntLen !=3D 2 && Pm1CntLen !=3D 4), use 16 bit IO read as a = fallback - // - SciEnabled =3D (IoRead16 (Fadt->Pm1aCntBlk) & BIT0) ? TRUE : FALSE; - } - - if (!(Fadt->Flags & EFI_ACPI_5_0_HW_REDUCED_ACPI) && - (Fadt->SmiCmd =3D=3D 0) && - !SciEnabled) - { - // - // The ACPI enabling status is inconsistent: SCI is not enabled but AC= PI - // table does not provide a means to enable it through FADT->SmiCmd - // - DEBUG (( - DEBUG_ERROR, - "ERROR: The ACPI enabling status is inconsistent: SCI is not" - " enabled but the ACPI table does not provide a means to enable it t= hrough FADT->SmiCmd." - " This may cause issues in OS.\n" - )); - } - - DEBUG_CODE_END (); - return RETURN_SUCCESS; } =20 --=20 2.40.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113363): https://edk2.groups.io/g/devel/message/113363 Mute This Topic: https://groups.io/mt/103593438/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-