[v2] Update handling of interrupt node for SSDT Serial Port Fixup Library

[edk2-devel] [edk2][PATCH V2 0/2] Update handling of interrupt node for SSDT Serial Port Fixup Library

Himanshu Sharma posted 2 patches 3 months, 3 weeks ago

Diff against v1
Download series mbox

Failed in applying to current master (apply log)

DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPortFixupLib.inf |  3 +-
ArmPkg/Include/Library/ArmGicArchLib.h                                            | 14 ++++++
DynamicTablesPkg/Include/ArmNameSpaceObjects.h                                    |  6 ++-
DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPortFixupLib.c   | 49 ++++++++++++++------
DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPortTemplate.asl | 29 +++++++-----
5 files changed, 72 insertions(+), 29 deletions(-)

Expand all Fold all

[edk2-devel] [edk2][PATCH V2 0/2] Update handling of interrupt node for SSDT Serial Port Fixup Library

Posted by Himanshu Sharma 3 months, 3 weeks ago

Currently in the Dynamic Tables Framework, the interrupt node for the
AML description of the serial-ports is populated using the template
and so is mandatorily added even if the serial-port is enumerated as
a DBG2 port in the platform's configuration manager where the
interrupt is not mandatory. The proposed implementation adds the
interrupt node only if the interrupt defined for the serial-port is a
valid SPI or a valid extended SPI. So, in case of DBG2 ports, the
platforms with interrupt defined as SPI (like Morello) can have the
interrupt node added to the description and the platforms where it is
not defined (like N1SDP) can ignore the addition of the interrupt node.

The changes include adding the SPI range macros in ArmGicArchLib
(ArmPkg) which can be used by the SSDTSerialPortFixupLib
(DynamicTablesPkg) to put a check for generating the interrupt node
using AML Codegen API.

Change log:

V2:
  - Fix comments on V1
    - Add link to Arm GIC Specification.
    - Fix uncrustify errors.
    - Add a check more if the interrupt is 0,
      to be used when an interrupt is not wired to the serial port.
  - Update copyright year to 2024.
  - Link to branch with the patches in this series
    https://github.com/himsha01/edk2/tree/ssdt_serial_port_interrupt_v2

V1:
  - Link to branch with the patches in this series
    https://github.com/himsha01/edk2/tree/ssdt_serial_port_interrupt 

Himanshu Sharma (2):
  ArmPkg/ArmGicArchLib: Add macros for SPI and extended SPI ranges
  DynamicTablesPkg/SsdtSerialPortFixupLib: Add Interrupt node for SPIs only

 DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPortFixupLib.inf |  3 +-
 ArmPkg/Include/Library/ArmGicArchLib.h                                            | 14 ++++++
 DynamicTablesPkg/Include/ArmNameSpaceObjects.h                                    |  6 ++-
 DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPortFixupLib.c   | 49 ++++++++++++++------
 DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPortTemplate.asl | 29 +++++++-----
 5 files changed, 72 insertions(+), 29 deletions(-)

-- 
2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113140): https://edk2.groups.io/g/devel/message/113140
Mute This Topic: https://groups.io/mt/103518971/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-