[edk2-devel] [PATCH v3 0/16] Redfish related fixes and improvements

Mike Maslenkin posted 16 patches 4 months ago
Failed in applying to current master (apply log)
[edk2-devel] [PATCH v3 0/16] Redfish related fixes and improvements
Posted by Mike Maslenkin 4 months ago
This is an expanded version of the original set of 9 patches with
additional patch introducing brackets for IPv6 Redfish resource location
with required changes according to comments for the initial RFC patch.

PR: https://github.com/tianocore/edk2/pull/5149

diff from v2:
  added Abner's R-b
  refined copyrights
  added additional patches [13-14] deallocating stings stored in EFI_REDFISH_DISCOVERED_INFORMATION
  changed const to CONST in intermediate patches (patch 10)
  reworked Product and ProductVer strings handling in accordance with the comments
  removed IpAddress local variable in the last patch

diff from v1:
 fixed typo double "that that"
 removed variable declaration in block scope
 added patches 10-13
 removed unnecessary casts
 added checks for memory allocation result

Cc: Abner Chang <abner.chang@amd.com>
Cc: Nickle Wang <nicklew@nvidia.com>
Cc: Igor Kulchytskyy <igork@ami.com>
Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112859): https://edk2.groups.io/g/devel/message/112859
Mute This Topic: https://groups.io/mt/103354119/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v3 0/16] Redfish related fixes and improvements
Posted by Chang, Abner via groups.io 4 months ago
[AMD Official Use Only - General]

Hi Mike,
I had RB on this patch set. Please update PR with my RB. Also let me know when you reset it.

Thanks
Abner

> -----Original Message-----
> From: Mike Maslenkin <mike.maslenkin@gmail.com>
> Sent: Monday, December 25, 2023 6:59 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner <Abner.Chang@amd.com>; nicklew@nvidia.com;
> igork@ami.com; Mike Maslenkin <mike.maslenkin@gmail.com>
> Subject: [PATCH v3 0/16] Redfish related fixes and improvements
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> This is an expanded version of the original set of 9 patches with
> additional patch introducing brackets for IPv6 Redfish resource location
> with required changes according to comments for the initial RFC patch.
>
> PR: https://github.com/tianocore/edk2/pull/5149
>
> diff from v2:
>   added Abner's R-b
>   refined copyrights
>   added additional patches [13-14] deallocating stings stored in
> EFI_REDFISH_DISCOVERED_INFORMATION
>   changed const to CONST in intermediate patches (patch 10)
>   reworked Product and ProductVer strings handling in accordance with the
> comments
>   removed IpAddress local variable in the last patch
>
> diff from v1:
>  fixed typo double "that that"
>  removed variable declaration in block scope
>  added patches 10-13
>  removed unnecessary casts
>  added checks for memory allocation result
>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Nickle Wang <nicklew@nvidia.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112898): https://edk2.groups.io/g/devel/message/112898
Mute This Topic: https://groups.io/mt/103354119/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v3 0/16] Redfish related fixes and improvements
Posted by Mike Maslenkin 4 months ago
Hi Abner,

I added your RB to all patches in the set and updated PR.

Thanks,
Mike.

On Tue, Dec 26, 2023 at 4:41 AM Chang, Abner <Abner.Chang@amd.com> wrote:
>
> [AMD Official Use Only - General]
>
> Hi Mike,
> I had RB on this patch set. Please update PR with my RB. Also let me know when you reset it.
>
> Thanks
> Abner
>
> > -----Original Message-----
> > From: Mike Maslenkin <mike.maslenkin@gmail.com>
> > Sent: Monday, December 25, 2023 6:59 AM
> > To: devel@edk2.groups.io
> > Cc: Chang, Abner <Abner.Chang@amd.com>; nicklew@nvidia.com;
> > igork@ami.com; Mike Maslenkin <mike.maslenkin@gmail.com>
> > Subject: [PATCH v3 0/16] Redfish related fixes and improvements
> >
> > Caution: This message originated from an External Source. Use proper caution
> > when opening attachments, clicking links, or responding.
> >
> >
> > This is an expanded version of the original set of 9 patches with
> > additional patch introducing brackets for IPv6 Redfish resource location
> > with required changes according to comments for the initial RFC patch.
> >
> > PR: https://github.com/tianocore/edk2/pull/5149
> >
> > diff from v2:
> >   added Abner's R-b
> >   refined copyrights
> >   added additional patches [13-14] deallocating stings stored in
> > EFI_REDFISH_DISCOVERED_INFORMATION
> >   changed const to CONST in intermediate patches (patch 10)
> >   reworked Product and ProductVer strings handling in accordance with the
> > comments
> >   removed IpAddress local variable in the last patch
> >
> > diff from v1:
> >  fixed typo double "that that"
> >  removed variable declaration in block scope
> >  added patches 10-13
> >  removed unnecessary casts
> >  added checks for memory allocation result
> >
> > Cc: Abner Chang <abner.chang@amd.com>
> > Cc: Nickle Wang <nicklew@nvidia.com>
> > Cc: Igor Kulchytskyy <igork@ami.com>
> > Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
> >
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112926): https://edk2.groups.io/g/devel/message/112926
Mute This Topic: https://groups.io/mt/103354119/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v3 0/16] Redfish related fixes and improvements
Posted by Chang, Abner via groups.io 4 months ago
[AMD Official Use Only - General]

Merged.
Thanks
Abner

> -----Original Message-----
> From: Mike Maslenkin <mike.maslenkin@gmail.com>
> Sent: Wednesday, December 27, 2023 12:11 AM
> To: Chang, Abner <Abner.Chang@amd.com>
> Cc: devel@edk2.groups.io; nicklew@nvidia.com; igork@ami.com
> Subject: Re: [PATCH v3 0/16] Redfish related fixes and improvements
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> Hi Abner,
>
> I added your RB to all patches in the set and updated PR.
>
> Thanks,
> Mike.
>
> On Tue, Dec 26, 2023 at 4:41 AM Chang, Abner <Abner.Chang@amd.com>
> wrote:
> >
> > [AMD Official Use Only - General]
> >
> > Hi Mike,
> > I had RB on this patch set. Please update PR with my RB. Also let me know
> when you reset it.
> >
> > Thanks
> > Abner
> >
> > > -----Original Message-----
> > > From: Mike Maslenkin <mike.maslenkin@gmail.com>
> > > Sent: Monday, December 25, 2023 6:59 AM
> > > To: devel@edk2.groups.io
> > > Cc: Chang, Abner <Abner.Chang@amd.com>; nicklew@nvidia.com;
> > > igork@ami.com; Mike Maslenkin <mike.maslenkin@gmail.com>
> > > Subject: [PATCH v3 0/16] Redfish related fixes and improvements
> > >
> > > Caution: This message originated from an External Source. Use proper
> caution
> > > when opening attachments, clicking links, or responding.
> > >
> > >
> > > This is an expanded version of the original set of 9 patches with
> > > additional patch introducing brackets for IPv6 Redfish resource location
> > > with required changes according to comments for the initial RFC patch.
> > >
> > > PR: https://github.com/tianocore/edk2/pull/5149
> > >
> > > diff from v2:
> > >   added Abner's R-b
> > >   refined copyrights
> > >   added additional patches [13-14] deallocating stings stored in
> > > EFI_REDFISH_DISCOVERED_INFORMATION
> > >   changed const to CONST in intermediate patches (patch 10)
> > >   reworked Product and ProductVer strings handling in accordance with the
> > > comments
> > >   removed IpAddress local variable in the last patch
> > >
> > > diff from v1:
> > >  fixed typo double "that that"
> > >  removed variable declaration in block scope
> > >  added patches 10-13
> > >  removed unnecessary casts
> > >  added checks for memory allocation result
> > >
> > > Cc: Abner Chang <abner.chang@amd.com>
> > > Cc: Nickle Wang <nicklew@nvidia.com>
> > > Cc: Igor Kulchytskyy <igork@ami.com>
> > > Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
> > >
> >


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112929): https://edk2.groups.io/g/devel/message/112929
Mute This Topic: https://groups.io/mt/103354119/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-