From nobody Wed May 15 11:21:58 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112685+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1702960409177396.32938793791595; Mon, 18 Dec 2023 20:33:29 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=3Tl6nk0jCnlxdDhkOciDM+CidRV15zWX6Fgzmh7VrqM=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:From:To:CC:Subject:Date:Message-ID:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1702960408; v=1; b=EQVEqgwxzb2/4ikS4m5i69sHh8NvNMsLAhWqvBIH9E1PWIMwsOVuqww0N+hAwTJZ5/uce7hJ N2DugpSi7chgHOCXSMbXVioTQ4x8HLAZfoBVlma+T+gASZvIzBaGJ0qy0sbz88EvxbjwTKQojY2 Lor895RUqHyJXvhU+A2IRFNo= X-Received: by 127.0.0.2 with SMTP id TIQnYY1788612xQcibxo6nrp; Mon, 18 Dec 2023 20:33:28 -0800 X-Received: from NAM04-DM6-obe.outbound.protection.outlook.com (NAM04-DM6-obe.outbound.protection.outlook.com [40.107.102.71]) by mx.groups.io with SMTP id smtpd.web10.5522.1702960407980853385 for ; Mon, 18 Dec 2023 20:33:28 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cndVQdCEueUiDP41y8B0FYU7Cu5jmAQO4bOjhtvIVpPFOCP6RmgTKXJTji/i0iRDx9ziwSX5XycflSqxmFH7iWx5Mp7oi5Q89c1qpX7bRlY/2d9G6v5tSdw0oOQGa0FgMFRdvUALh2mFT+EqYvL7p8jOm+r3qDof8Jchuas6l7+LomNqFr3lZI4NtGSF+gObuEwAvFyhjq84R7169H7+B5fwEXFiko52R8yY1XWbBY7qZPeCSZqt+Aiy72bCto+m1U4B+QvZYtdhGtOrA7dIzkU6osnmJ0Npvz678k18h1M52XETQXbvUYrSboSkhCsis40WVpQe/W/M2z4pdTGvgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5u4pr3OPzAM9jQI0bX8t1pYM+P4ZibLyI+/3hSCv4gc=; b=LnXCWWexFi4eJqMNuvLvovUUstVPZV7ljG/du6hVNinqE35a8AP8p7VyBxohGzFpOA8pgRpZreIwpV45WKIlpS35gh7zpHQDr2yZ6zoio9r3O1IiM0zxRgxm7i29U2InA/+Pgxqup/bl3G8aeUu/HJfN66pYS+nc67mirZmw1h81zR427jGUcVPk2p9P4jQ6pJXul175ziArirbsRUpH64YjUuPdMqNvtxdlLN/sQfVfr8BCsTEasPkQpJ5OetnDl6+4qLlYsnK1yF4KBGcQjEMQnS4CCpN8LoLzdxHAAdDW5ZSxRR807zebAvgI1TH+OVxbXaWZnlr36A/HYrT7pQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) X-Received: from BLAP220CA0012.NAMP220.PROD.OUTLOOK.COM (2603:10b6:208:32c::17) by CH3PR12MB7524.namprd12.prod.outlook.com (2603:10b6:610:146::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.38; Tue, 19 Dec 2023 04:33:26 +0000 X-Received: from BL6PEPF0001AB4C.namprd04.prod.outlook.com (2603:10b6:208:32c:cafe::3a) by BLAP220CA0012.outlook.office365.com (2603:10b6:208:32c::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.38 via Frontend Transport; Tue, 19 Dec 2023 04:33:25 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+112685+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C X-Received: from SATLEXMB04.amd.com (165.204.84.17) by BL6PEPF0001AB4C.mail.protection.outlook.com (10.167.242.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7113.14 via Frontend Transport; Tue, 19 Dec 2023 04:33:25 +0000 X-Received: from TPE-L1-ABNCHANG.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Mon, 18 Dec 2023 22:32:57 -0600 From: "Chang, Abner via groups.io" To: CC: Nickle Wang , Igor Kulchytskyy , Mike Maslenkin Subject: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg: Add debug messages Date: Tue, 19 Dec 2023 12:32:41 +0800 Message-ID: <20231219043241.2011-1-abner.chang@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0001AB4C:EE_|CH3PR12MB7524:EE_ X-MS-Office365-Filtering-Correlation-Id: a0e1a520-c74d-476d-1e10-08dc004ba44f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: EqU1dD6aJBwEJtio7MA2PpKCajGDOBR5ua3oyX6Ae3IPEgsCSLWM9YN83DTA25ViP77MquDCxvBo41daQwLg6wim44cTeyBj6F12iOe2TfVGcAo8HPd51IuH5rcVWB1tjhrpTKyn/znGT8l6bw85w5zjl7HUgGgZ8wQ2/EbX5whxok1/EUV0Zi7uWPbzk+3x5c8+0MaSQDsZQvNSn97yl0KSInrOChMSsGB9GOB1zJuYkpvAnb6mhTVXW48uW28fdMX/enH5nuVwCN4nESI/AMQgiDDoq7fYhzsus9EPQH3Er/9wngFWjo7oJ6NsOJ+UMxsicDWKdwArwPnJ0+eyRlQLLuNcxCrZQdRVTj3c4L3NwxgCXoIoAUUevhCDDRfPy8zHv9K6L3kNnq9c2JJscGIf4YkNkQ8p0mDAW9JA6eiPcfSq4UYBnT/qm2k/NQmvXttwIkoVjIjmSybikOwaAK7H3JHNW7F8grgUIjT8gmcpUKUo93S5sg8erIy2ljVDgIuGMnOqDO3ExHi89FaNXvzHHMgLnYZG2B71aaKRuYfR6X0V0zWUpTyR5oLyPQ6xcUyOrRgu1+BuDldSmw/AhlRB/y2sbDZSN6fjRQn7FzQObXvcGmrD9dmgI901kSvtA5gKYufmtUYTb0fWZjguKiK5uBtKeK+Bb+ocf50HPw1Ktm7OHyiJWu5nfVlNavfzSrj5NGaor6uMRRLqTejxF7zRrve5GbYANibE3yXOLyK4dVBsNjVNE/JfGgttq/AT9x32qGUTpKABRwrFgHJWfQ== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Dec 2023 04:33:25.8494 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a0e1a520-c74d-476d-1e10-08dc004ba44f X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0001AB4C.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7524 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: zKFFhx2VgqQT4RbCXwcXbcyCx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1702960410017100003 Content-Type: text/plain; charset="utf-8" From: Abner Chang Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Cc: Mike Maslenkin Reviewed-by: Nickle Wang --- .../ComputerSystemCollectionDxe.c | 3 ++- .../EdkIIRedfishResourceConfigLib.c | 7 ++++++- .../Library/RedfishVersionLib/RedfishVersionLib.c | 2 ++ .../RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c | 10 ++++++++++ 4 files changed, 20 insertions(+), 2 deletions(-) diff --git a/RedfishClientPkg/Features/ComputerSystemCollectionDxe/Computer= SystemCollectionDxe.c b/RedfishClientPkg/Features/ComputerSystemCollectionD= xe/ComputerSystemCollectionDxe.c index 595a960300..74003406ef 100644 --- a/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSystemC= ollectionDxe.c +++ b/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSystemC= ollectionDxe.c @@ -107,7 +107,7 @@ HandleResource ( DEBUG ((REDFISH_DEBUG_TRACE, "%a provision for %s\n", __func__, Uri)); Status =3D EdkIIRedfishResourceConfigProvisioning (&SchemaInfo, Uri, P= rivate->InformationExchange, FALSE); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a: failed to provision with GET mode: %r\n", = __func__, Status)); + DEBUG ((DEBUG_ERROR, "%a: failed to provision with PATCH mode: %r\n"= , __func__, Status)); } =20 return Status; @@ -385,6 +385,7 @@ RedfishCollectionFeatureCallback ( =20 StrCatS (ResourceUri, MAX_URI_LENGTH, Private->RedfishVersion); StrCatS (ResourceUri, MAX_URI_LENGTH, InformationExchange->SendInformati= on.FullUri); + DEBUG ((DEBUG_MANAGEABILITY, "%a: Redfish collection resource URI - %s\n= ", __func__, ResourceUri)); =20 // // Initialize collection path diff --git a/RedfishClientPkg/Library/EdkIIRedfishResourceConfigLib/EdkIIRe= dfishResourceConfigLib.c b/RedfishClientPkg/Library/EdkIIRedfishResourceCon= figLib/EdkIIRedfishResourceConfigLib.c index 7a7bb4dece..09ae3921e3 100644 --- a/RedfishClientPkg/Library/EdkIIRedfishResourceConfigLib/EdkIIRedfishRe= sourceConfigLib.c +++ b/RedfishClientPkg/Library/EdkIIRedfishResourceConfigLib/EdkIIRedfishRe= sourceConfigLib.c @@ -78,7 +78,12 @@ GetRedfishSchemaInfo ( &Header ); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a, ToStructure() failed: %r\n", __func__, Statu= s)); + if (Status =3D=3D EFI_UNSUPPORTED) { + DEBUG ((DEBUG_ERROR, "%a, No proper JSON to C structure converter fo= r this Redfish resource.\n", __func__)); + } else { + DEBUG ((DEBUG_ERROR, "%a, ToStructure() failed: %r\n", __func__, Sta= tus)); + } + return Status; } =20 diff --git a/RedfishClientPkg/Library/RedfishVersionLib/RedfishVersionLib.c= b/RedfishClientPkg/Library/RedfishVersionLib/RedfishVersionLib.c index 45e156ca94..bcaca3c745 100644 --- a/RedfishClientPkg/Library/RedfishVersionLib/RedfishVersionLib.c +++ b/RedfishClientPkg/Library/RedfishVersionLib/RedfishVersionLib.c @@ -140,6 +140,7 @@ RedfishGetVersion ( =20 if (VersionString !=3D NULL) { CacheVersion (Service, VersionString); + DEBUG ((DEBUG_MANAGEABILITY, "%a: Redfish version - %s\n", __func__, V= ersionString)); return VersionString; } =20 @@ -150,6 +151,7 @@ ON_ERROR: VersionString =3D REDFISH_VERSION_DEFAULT_STRING; } =20 + DEBUG ((DEBUG_MANAGEABILITY, "%a: Redfish version - %s\n", __func__, Ver= sionString)); return AllocateCopyPool (StrSize (VersionString), VersionString); } =20 diff --git a/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c= b/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c index c0c3ec476f..dce83a8a98 100644 --- a/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c +++ b/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c @@ -135,6 +135,12 @@ StartUpFeatureDriver ( return; } =20 + if (CurrentConfigLanguageUri !=3D NULL) { + DEBUG ((DEBUG_MANAGEABILITY, "%a: Current Config Language URI - %s\n",= __func__, CurrentConfigLanguageUri)); + } else { + DEBUG ((DEBUG_MANAGEABILITY, "%a: Current Config Language URI - Servie= Root\n", __func__)); + } + NextParentUri =3D (EFI_STRING)AllocateZeroPool (MaxParentUriLength * siz= eof (CHAR16)); if (NextParentUri =3D=3D NULL) { DEBUG ((DEBUG_ERROR, "%a: Fail to allocate memory for parent configure= language.\n", __func__)); @@ -151,6 +157,10 @@ StartUpFeatureDriver ( ThisList->InformationExchange =3D mInformationExchange; Status =3D SetupExchangeInformationInfo (This= List, NextParentUri); if (!EFI_ERROR (Status)) { + DEBUG ((DEBUG_MANAGEABILITY, "%a: Sender exchange information for = Collection Feature Driver:\n", __func__)); + DEBUG ((DEBUG_MANAGEABILITY, " Parent URI : %s\n", ThisList->In= formationExchange->SendInformation.ParentUri)); + DEBUG ((DEBUG_MANAGEABILITY, " Property name: %s\n", ThisList->In= formationExchange->SendInformation.PropertyName)); + DEBUG ((DEBUG_MANAGEABILITY, " Full URI : %s\n", ThisList->In= formationExchange->SendInformation.FullUri)); Status =3D ThisList->Callback ( StartupContext->This, StartupContext->Action, --=20 2.37.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112685): https://edk2.groups.io/g/devel/message/112685 Mute This Topic: https://groups.io/mt/103257786/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-