From nobody Tue May 14 11:57:02 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+112574+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112574+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1702598661; cv=none; d=zohomail.com; s=zohoarc; b=Bl+aTL5SnVkF6XPQH3y8rbh8I4VsTMMdZYbdaPOwOrRFNqj8vzjrw5iPPedCpXalX+dEG8Muu5BlVacVyyiYQyfqCKtQPwO23vEm+64JkU/Hp7pdmZfyoyZkO6erj67W95rfovfcPsijmhPQCEhv5m190wF2a8ReM50X+NEACNE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1702598661; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=P6M8zkVVjMpSYgEI6N3/BDs4Jg+DoDPlQKgZEnOHLUI=; b=E9NU6IEQX8Il8vMxDUdMZqmCnOU0mIJhjulCe7o6y4i2bqxR5bLvHYC6ppk38xhzPuqyo1FsJg39VXyjD5pEFlsPw9/ZHG6PWOhdMJCV8Fg+abMnjfUUr7nk/3VbM117XnSc/BRP/NjTZUWSFYxxWq5Kc+26k6394gO0pAnfe68= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112574+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1702598661208572.9428362768299; Thu, 14 Dec 2023 16:04:21 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=+hgK6jDZaW9XxjFPF6I3WHFUd7E0P5bkvnGlKXMmuK8=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1702598660; v=1; b=ei9MaUwP1XoNMxF21qeuByP+5PDhK8E1W4ROUXGAiNKR06AD7qysN/ncRmcW53tF68H7NwnD F8HWYuifUuG3PIXzVyEcOk7O0Wl/jUmU/84yCN72RDgjpwMmwo+VHZYxhe7caqOdsL4tXtfC7FE mf7YyRhZwI+BIwq4hyaDWWEY= X-Received: by 127.0.0.2 with SMTP id vmtyYY1788612xna0m6Z8xAC; Thu, 14 Dec 2023 16:04:20 -0800 X-Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) by mx.groups.io with SMTP id smtpd.web10.45421.1702598660088474334 for ; Thu, 14 Dec 2023 16:04:20 -0800 X-Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-50e0ba402b4so72905e87.1 for ; Thu, 14 Dec 2023 16:04:19 -0800 (PST) X-Gm-Message-State: g3SBKQVV6lrJjm3jOYD7qTQ1x1787277AA= X-Google-Smtp-Source: AGHT+IFfXg6XxBrSMYsiS8nm7bLM3S5/9LhjbWjap8Tj9JA6IRPB8PIaM9gnd20mE25mzhXyvN9LxA== X-Received: by 2002:a05:6512:ad5:b0:50d:1eb3:7bfd with SMTP id n21-20020a0565120ad500b0050d1eb37bfdmr5877581lfu.13.1702598658246; Thu, 14 Dec 2023 16:04:18 -0800 (PST) X-Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id n11-20020a0565120acb00b0050be6038170sm1991256lfu.48.2023.12.14.16.04.17 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 14 Dec 2023 16:04:17 -0800 (PST) From: "Mike Maslenkin" To: devel@edk2.groups.io Cc: abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, Mike Maslenkin Subject: [edk2-devel] [edk2-redfish-client][PATCH 1/4] RedfishClientPkg: add check for NULL pointer to avoid ASSERT Date: Fri, 15 Dec 2023 03:03:57 +0300 Message-Id: <20231215000400.5311-2-mike.maslenkin@gmail.com> In-Reply-To: <20231215000400.5311-1-mike.maslenkin@gmail.com> References: <20231215000400.5311-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1702598662181100003 Content-Type: text/plain; charset="utf-8" Initially RedfishPlatformConfigGetConfigureLang could return success even if ConfigureLangList is empty. After fixing this condition, RedfishPlatformConfigGetConfigureLang returns an error, but this doesn't help to avoid ASSERT because the error path is the same as for non-empty list. Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nickle Wang Signed-off-by: Mike Maslenkin Reviewed-by: Nickle Wang --- .../RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatu= reUtilityLib.c b/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishF= eatureUtilityLib.c index 4cb7621c25c4..0f0b050d7eba 100644 --- a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtili= tyLib.c +++ b/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtili= tyLib.c @@ -3118,7 +3118,9 @@ LeaveFunction: FreePool (ConfigureLangBuffer); } =20 - FreePool (ConfigureLangList); + if (ConfigureLangList !=3D NULL) { + FreePool (ConfigureLangList); + } =20 *NumberOfValues =3D (UINT32)ListCount; return FirstEmptyPropKeyValueList; --=20 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112574): https://edk2.groups.io/g/devel/message/112574 Mute This Topic: https://groups.io/mt/103181638/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Tue May 14 11:57:02 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+112575+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112575+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1702598661; cv=none; d=zohomail.com; s=zohoarc; b=Jri/OWb3yXNWG+p1KaKpzfDdH5Q2rcoz7ekRn7FYu/hE3+ZvD3dGeXizpO8sB8Y42msP4eEEsP4aQ0baWBP2QfevEZhpSSqCtxLRfh1IoQ1+cv2TBXGdLiwWRKINXH6oVp7d+XPSrFhroRfGW+a52BJjwuIcXFVLn+E3v1oc1CE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1702598661; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=j/XFc0UYcSRusU/8aonqmu6eVuea7rgYCqG7LsrBzXM=; b=VxLD6LCk9oIA0awVTkQtsdHIsp1HhcrU5/XIdOWSBO//cs/jV/o0v9CSgmc3urU87R6EmC65JWfSEa9HDey7wrpYszoBhVzIblkfoGV8qSRf+iZYllYHOfWlljPSdUOrJ0knJ5ORPnd2JaaxEx7d6xEDpIJRMpW9/rl9Kp4ppoE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112575+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1702598661963770.5813043818481; Thu, 14 Dec 2023 16:04:21 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=y2UQwmPjwiHEouS9sIIH6rLKIvoqqGZmoK/X0NW1sI4=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1702598661; v=1; b=HcZ9T3S9CFETwvhMqSL31743bEDQHq+Z9LrXVdXqkj0bS+/u4exxi9fUYXn9iOqckY6YMegG GFV84QjVOQebPSWrH7FFrWcB+jjGm/0Bj9Pghy9jQhJWOzCqGYXbG3RWX7lUr1XXKqOgO/7e6XV BUZAInqVlmOPh28mmH4C/ink= X-Received: by 127.0.0.2 with SMTP id TrhDYY1788612xpn1QetoaX7; Thu, 14 Dec 2023 16:04:21 -0800 X-Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by mx.groups.io with SMTP id smtpd.web11.45726.1702598660789953839 for ; Thu, 14 Dec 2023 16:04:21 -0800 X-Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-50c222a022dso69980e87.1 for ; Thu, 14 Dec 2023 16:04:20 -0800 (PST) X-Gm-Message-State: oPgatl0kb3ncjuxEczRY2Oaqx1787277AA= X-Google-Smtp-Source: AGHT+IGFqdqknO1FvO57Q/4fNct2r2bniWTx8sgfH+DeRHesXcvJNTeE/L4i9WcbXVWYlPBQ1TFlHA== X-Received: by 2002:a05:6512:1310:b0:50e:707:1dfc with SMTP id x16-20020a056512131000b0050e07071dfcmr3395814lfu.72.1702598658921; Thu, 14 Dec 2023 16:04:18 -0800 (PST) X-Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id n11-20020a0565120acb00b0050be6038170sm1991256lfu.48.2023.12.14.16.04.18 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 14 Dec 2023 16:04:18 -0800 (PST) From: "Mike Maslenkin" To: devel@edk2.groups.io Cc: abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, Mike Maslenkin Subject: [edk2-devel] [edk2-redfish-client][PATCH 2/4] RedfishClientPkg: fix typo in EfiRestJsonStructureProtocolIsReady Date: Fri, 15 Dec 2023 03:03:58 +0300 Message-Id: <20231215000400.5311-3-mike.maslenkin@gmail.com> In-Reply-To: <20231215000400.5311-1-mike.maslenkin@gmail.com> References: <20231215000400.5311-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1702598662180100002 Content-Type: text/plain; charset="utf-8" Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nickle Wang Signed-off-by: Mike Maslenkin Reviewed-by: Nickle Wang --- RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c b/RedfishC= lientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c index 8b9bdc313832..85dc546120e2 100644 --- a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c +++ b/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c @@ -562,7 +562,7 @@ EDKII_REDFISH_CONFIG_HANDLER_PROTOCOL mRedfishConfigHa= ndler =3D { **/ VOID EFIAPI -EfiRestJasonStructureProtocolIsReady ( +EfiRestJsonStructureProtocolIsReady ( IN EFI_EVENT Event, IN VOID *Context ) @@ -829,7 +829,7 @@ RedfishResourceEntryPoint ( EfiCreateProtocolNotifyEvent ( &gEfiRestJsonStructureProtocolGuid, TPL_CALLBACK, - EfiRestJasonStructureProtocolIsReady, + EfiRestJsonStructureProtocolIsReady, NULL, &Registration ); --=20 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112575): https://edk2.groups.io/g/devel/message/112575 Mute This Topic: https://groups.io/mt/103181639/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Tue May 14 11:57:02 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+112576+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112576+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1702598662; cv=none; d=zohomail.com; s=zohoarc; b=R743P46lZ1ptnz20l+tKI9fparZz7S7K12YSgLrvG18xm94xlK3YbLn9ZRl0BDByJwgoqA1fd/oSrN/p1mrDtTK2iXWk0n76PiEtrVce+frSfkftCV6CR5KcJODtWSX6mWfVNESUbZOl+Fye0wzJ9IKoBuvrgQpbxrH/qO+J2KE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1702598662; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=hxwCLG50jfOCYSt6iLlTlk2sgj1QZFwlOk6Gw2MI4aI=; b=Z5Gm1eHsItMlz0eptYbPMwc+mlKqBZyoCz6we88ovZmNf8ezlKw3lEozGI4l6ynUKMl5FOD8koUsWDW+JDIBWyEx/NKah5Suvx4XVwivl/mNK2UXIMWIKUMZ3f8zZCHYEYGnvFGvoRAJjy4tDo/bF2/TLb4EmRAMPk17mhXZ9nY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112576+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1702598662767510.52930578748783; Thu, 14 Dec 2023 16:04:22 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=CuF1lct8owMVDgxpOdKPkhTDPCXwSaGpLymG7UXHGxk=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1702598662; v=1; b=AoDNyi+/JY3RVpfVWPmI0P8ZlK1qZH1whPgXSON2fnxHjG1Uc6UjKRY6dx0E4EYQCZTcaPBi Lp1TgtpZASAKOxEwSIL3pG9+yh3HCWil3CoxLosbbcNc1HU9Df9QasMIRiJfAbQ6OLsFWJGMPTf g1L+oH6xR2rap5idrFIhV+ug= X-Received: by 127.0.0.2 with SMTP id xWO3YY1788612x1Aob7N3HCV; Thu, 14 Dec 2023 16:04:22 -0800 X-Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by mx.groups.io with SMTP id smtpd.web11.45727.1702598661622297803 for ; Thu, 14 Dec 2023 16:04:21 -0800 X-Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-50bf898c43cso61186e87.1 for ; Thu, 14 Dec 2023 16:04:21 -0800 (PST) X-Gm-Message-State: 7vBvx9eScwqla6zRsiZGYSaJx1787277AA= X-Google-Smtp-Source: AGHT+IHIpsira2wq7VkXvQNtkxd0KpwaKEYY8CPd3kFJ4ldSNvfWr/AFye6zh5WWrVKNfKYWfpQpHA== X-Received: by 2002:a05:6512:2244:b0:50b:fc3e:db5e with SMTP id i4-20020a056512224400b0050bfc3edb5emr4058610lfu.131.1702598659678; Thu, 14 Dec 2023 16:04:19 -0800 (PST) X-Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id n11-20020a0565120acb00b0050be6038170sm1991256lfu.48.2023.12.14.16.04.19 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 14 Dec 2023 16:04:19 -0800 (PST) From: "Mike Maslenkin" To: devel@edk2.groups.io Cc: abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, Mike Maslenkin Subject: [edk2-devel] [edk2-redfish-client][PATCH 3/4] RedfishClientPkg: fix access to unitialized variable. Date: Fri, 15 Dec 2023 03:03:59 +0300 Message-Id: <20231215000400.5311-4-mike.maslenkin@gmail.com> In-Reply-To: <20231215000400.5311-1-mike.maslenkin@gmail.com> References: <20231215000400.5311-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1702598664154100013 Content-Type: text/plain; charset="utf-8" It is possible that at the time of accessing to AsciiLocation pointer the memory is not allocated. Also gcc version 4.8.5 20150623 (Red Hat 4.8.5-44) emits a warning for this case: RedfishFeatureUtilityLib.c:1889:37: error: 'AsciiLocation' may be used unin= itialized in this function [-Werror=3Dmaybe-uninitialized] *Location =3D StrAsciiToUnicode (AsciiLocation); Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nickle Wang Signed-off-by: Mike Maslenkin Reviewed-by: Nickle Wang --- .../RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatu= reUtilityLib.c b/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishF= eatureUtilityLib.c index 0f0b050d7eba..01c054ae3b70 100644 --- a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtili= tyLib.c +++ b/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtili= tyLib.c @@ -1856,7 +1856,8 @@ GetEtagAndLocation ( } =20 if (Location !=3D NULL) { - *Location =3D NULL; + *Location =3D NULL; + AsciiLocation =3D NULL; =20 if (*(Response->StatusCode) =3D=3D HTTP_STATUS_200_OK) { Header =3D HttpFindHeader (Response->HeaderCount, Response->Headers,= HTTP_HEADER_LOCATION); --=20 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112576): https://edk2.groups.io/g/devel/message/112576 Mute This Topic: https://groups.io/mt/103181640/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Tue May 14 11:57:02 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+112577+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112577+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1702598663; cv=none; d=zohomail.com; s=zohoarc; b=X9MRcHMV/WkVQ4sx9I31a6fhTIW2ixF/iIBmgUwaX4nYaWv4FsRxZSb/2P+05oUaxAm7yrhwcr1vDOojlDN/Sm50nPZK1xD8h6zuj+7zjmw4LEn8nyq2KO81ScccDFHbWkJpQrIHsmRxKFkLSE8XhTfj8lrJjwpOTwonkx3qVz4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1702598663; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=BYsKqokjMoKeV9rgKbQ9W/aGnXoH1O95ydjSb0dTJr4=; b=cVlBqAiWlQX8HRrT1PPxWq9H1vuKc9f3LeaMbgXPx98i7SU0iQ783H5MSUOo/utp3zgIIOYU8IF7gGAtGvVJj5vDdy5EQVxJpG7CVvdS3M6+wRjKAPXTvQ//nTzi8brm57F7uI413Tp5DE0ojKHZvGz1VQFWGT5ViMOFviZUqxU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112577+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1702598663470875.9544338078479; Thu, 14 Dec 2023 16:04:23 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=Uyaz3YU4XQewsTk/9dGnxBMC+hKXhxjnkeXsDpUYkQw=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1702598663; v=1; b=IFb7iZuFQqymMcmVcQVmJh0aanq4wIDYQ2rFxd7Jd52Xy2/jR2KGb0NFzuYs56kkhH6TiSYs /kZsPNp5Kh0p+8jbwOQy67O+2mQ0cYuN3owSQLv5ryVusSRTLDau7lGFyoAG1UT2eiZsqLV2fw/ ZujA376V83WiNP7ZJEnInQtQ= X-Received: by 127.0.0.2 with SMTP id xbOOYY1788612xb1SXJjR9yt; Thu, 14 Dec 2023 16:04:23 -0800 X-Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) by mx.groups.io with SMTP id smtpd.web11.45729.1702598662310690093 for ; Thu, 14 Dec 2023 16:04:22 -0800 X-Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-50c0f13ea11so55562e87.3 for ; Thu, 14 Dec 2023 16:04:21 -0800 (PST) X-Gm-Message-State: d8u49225P5Cvjmpookh8oBjkx1787277AA= X-Google-Smtp-Source: AGHT+IHVaOeJogghJTKiN+Nru+au9HMKQrWwkkL5l00c0I6d8fpNSGriRajz2OWNLoo28UrOR6E2Vg== X-Received: by 2002:a19:4311:0:b0:50d:ac3:45c6 with SMTP id q17-20020a194311000000b0050d0ac345c6mr4233635lfa.99.1702598660422; Thu, 14 Dec 2023 16:04:20 -0800 (PST) X-Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id n11-20020a0565120acb00b0050be6038170sm1991256lfu.48.2023.12.14.16.04.19 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 14 Dec 2023 16:04:20 -0800 (PST) From: "Mike Maslenkin" To: devel@edk2.groups.io Cc: abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, Mike Maslenkin Subject: [edk2-devel] [edk2-redfish-client][PATCH 4/4] RedfishClientPkg: use POST method while provisioning new property. Date: Fri, 15 Dec 2023 03:04:00 +0300 Message-Id: <20231215000400.5311-5-mike.maslenkin@gmail.com> In-Reply-To: <20231215000400.5311-1-mike.maslenkin@gmail.com> References: <20231215000400.5311-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1702598664156100014 Content-Type: text/plain; charset="utf-8" If EdkIIRedfishResourceConfigCheck fails according to the logic and comment: new resources should be provisioned, so the POST method must be used. Fourth parameter of EdkIIRedfishResourceConfigProvisioning is BOOLEAN HttpPostMode, so we pass TRUE here. Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nickle Wang Signed-off-by: Mike Maslenkin --- RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c b/Re= dfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c index a26a1083cd74..4fd4845f3420 100644 --- a/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c +++ b/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c @@ -818,9 +818,9 @@ HandleResource ( // The target property does not exist, do the provision to create prop= erty. // DEBUG ((REDFISH_DEBUG_TRACE, "%a provision for %s\n", __func__, Uri)); - Status =3D EdkIIRedfishResourceConfigProvisioning (&SchemaInfo, Uri, P= rivate->InformationExchange, FALSE); + Status =3D EdkIIRedfishResourceConfigProvisioning (&SchemaInfo, Uri, P= rivate->InformationExchange, TRUE); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a, failed to provision with GET mode: %r\n", = __func__, Status)); + DEBUG ((DEBUG_ERROR, "%a, failed to provision with POST mode: %r\n",= __func__, Status)); } =20 return Status; --=20 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112577): https://edk2.groups.io/g/devel/message/112577 Mute This Topic: https://groups.io/mt/103181641/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-