From nobody Wed May 15 13:04:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+112437+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112437+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1702392869; cv=none; d=zohomail.com; s=zohoarc; b=NIG7QJ36FDaKfOj38I/WJjXltWSq9xTnmlxBxFDHLgRU6YJx84gVFBxbnTCrI8aJFRh7luuZJT3nHuafmaiLGlIfbma3is1i/MRXtr4OiWORy7uC18saLVbSasrSfL+d2YWqRFzpVEJfq4ZNXFvmjZt++EZfF/cN6M8u/If/ev0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1702392869; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=rpRD60vLN1/Eo2rzhWQ8CoElzKn/yY8em9FogUnZ/Ms=; b=P1jHAHeflP6k0inLgHlVc0vFS3yBuyM6DFY22prRiQwLlX5O7aQViXY66SOeestFOtZN1tsSG6W8NCMpZRWqNY1SIXbTI9DeDKYFnUke+25UU7v46zsFgfHxT2HwRZOsbcH2+EtDM0/iyrhyMPRneyEn/DQeIfFepZ5hfdSQKpc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112437+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1702392869787207.8742741069592; Tue, 12 Dec 2023 06:54:29 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=s2tnoLvb9G+rLnmN2eKcSfzCLEUbEQoww+uvZUCMnM8=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1702392869; v=1; b=i6u83aHfkjGZjg8llhyvSOeTMsIdjIHlsRxhm+oXws4IUiK6iMOfBu5H/1OH2UFoeuVUoBH6 rwoDrtL2flmeh7s9zD5VDuftb4ULfRWR+Z0mhO7WSrGQMfPiHsmCUAboSBIAscoaVQy5aU7hW/k mxGCoX1vOH9MDB/tmt1GZj3g= X-Received: by 127.0.0.2 with SMTP id Z3lvYY1788612xFiYXA4gHoa; Tue, 12 Dec 2023 06:54:29 -0800 X-Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by mx.groups.io with SMTP id smtpd.web11.3454.1702392868359481281 for ; Tue, 12 Dec 2023 06:54:28 -0800 X-Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-50bf7bc38c0so6533837e87.2 for ; Tue, 12 Dec 2023 06:54:28 -0800 (PST) X-Gm-Message-State: cPfwIApHvI17dX4ERSU5obklx1787277AA= X-Google-Smtp-Source: AGHT+IHX5n6sKjWeiJZv1uX1bKAXK/5qw0RK95+TjJKB4urVXszAmIGVldR0uz7PgHg0w6awTkpoSQ== X-Received: by 2002:a05:6512:ad1:b0:50c:6b:f16b with SMTP id n17-20020a0565120ad100b0050c006bf16bmr3913414lfu.73.1702392866185; Tue, 12 Dec 2023 06:54:26 -0800 (PST) X-Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id m21-20020a0565120a9500b0050d1d8674d2sm952008lfu.292.2023.12.12.06.54.25 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 12 Dec 2023 06:54:25 -0800 (PST) From: "Mike Maslenkin" To: devel@edk2.groups.io Cc: abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, Mike Maslenkin Subject: [edk2-devel] [PATCH 1/9] RedfishPkg: fix RedfishPlatformHostInterfaceLib library class name typo. Date: Tue, 12 Dec 2023 17:54:04 +0300 Message-Id: <20231212145412.50434-2-mike.maslenkin@gmail.com> In-Reply-To: <20231212145412.50434-1-mike.maslenkin@gmail.com> References: <20231212145412.50434-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1702392871997100008 Content-Type: text/plain; charset="utf-8" PlatformHostInterfaceBmcUsbNicLib is the library instance name not the clas= s name. Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin Reviewed-by: Abner Chang --- .../PlatformHostInterfaceBmcUsbNicLib.inf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformH= ostInterfaceBmcUsbNicLib.inf b/RedfishPkg/Library/PlatformHostInterfaceBmcU= sbNicLib/PlatformHostInterfaceBmcUsbNicLib.inf index 838a1721a7ae..3660249a3588 100644 --- a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInte= rfaceBmcUsbNicLib.inf +++ b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInte= rfaceBmcUsbNicLib.inf @@ -14,7 +14,7 @@ FILE_GUID =3D C4837B58-225E-4352-8FDC-4C52A5D65891 MODULE_TYPE =3D DXE_DRIVER VERSION_STRING =3D 1.0 - LIBRARY_CLASS =3D PlatformHostInterfaceBmcUsbNicLib + LIBRARY_CLASS =3D RedfishPlatformHostInterfaceLib =20 [Sources] PlatformHostInterfaceBmcUsbNicLib.c --=20 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112437): https://edk2.groups.io/g/devel/message/112437 Mute This Topic: https://groups.io/mt/103130778/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Wed May 15 13:04:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+112438+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112438+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1702392870; cv=none; d=zohomail.com; s=zohoarc; b=V7I5C8wDdiEQZfWmDjuTWnOPRPDw75IFPAQrzYsAlLjI8cwbYH7eK0Ltbt4+/hhP8P9pb+x2Yp75z1KqxMcF/jE5kZBVhqtfuxnF+8EXUgCOsuCiVaHO+mX0QNHjANyr1AoEB0ItB6upgKjqBxfoCQXUXQ7qSOE4gqPwlOQki34= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1702392870; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=TupPqzq/hwbZcofKcrVURljIs4dcJH5k5FHkGpA+mU8=; b=bOJKWlNs/YIDQGRSPLNUXdF+rgocLpBrnrLz6Vs5Ta0ZBe1lQMyloOC8b/98Dm8ggTBaP6JoQ0wOmXD1Ps4ppOWSYC/dWpq9uLOL0ou5kz2Ca+/QkdGERmb3aB+goDsy2HFjKqq1fk9/91x9sQkAXGly2RGENZg0hqDKyBW9/RQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112438+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 17023928701711015.1247919623839; Tue, 12 Dec 2023 06:54:30 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=dyYNU2KFm0QzATFwQmHRKEnaM/9bbiYWbwDCZal3er8=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1702392869; v=1; b=lqndIg07Hz4PJBMThpxin3no2EAbIKTZ+dtMXeg9hb9vaX1AKIXgft5nhPqxdsNtyXLLrRvP igsG05186HA44pDkzDwX2XZtmT/++xq9RyxibOdg8YSnPYljiVUY3+QaPwwwi67YX9TWW2klwo2 2Uq5YKs7tZQYEUV23Jlpdv/Q= X-Received: by 127.0.0.2 with SMTP id 5d3uYY1788612xqhCzIADOov; Tue, 12 Dec 2023 06:54:29 -0800 X-Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by mx.groups.io with SMTP id smtpd.web10.3580.1702392868789138274 for ; Tue, 12 Dec 2023 06:54:29 -0800 X-Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-50bf3efe2cbso6635673e87.2 for ; Tue, 12 Dec 2023 06:54:28 -0800 (PST) X-Gm-Message-State: 1seGDHIxGvWY0DMZgM3i3cbhx1787277AA= X-Google-Smtp-Source: AGHT+IF1/dwepmjHF4C4pRtEKcextuXIaQZAekBMO4/GpBccnQC0RgiFGCsPnTJuvm1ApiT/wa/CLg== X-Received: by 2002:a05:6512:104f:b0:50b:c534:83af with SMTP id c15-20020a056512104f00b0050bc53483afmr1732985lfb.28.1702392866919; Tue, 12 Dec 2023 06:54:26 -0800 (PST) X-Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id m21-20020a0565120a9500b0050d1d8674d2sm952008lfu.292.2023.12.12.06.54.26 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 12 Dec 2023 06:54:26 -0800 (PST) From: "Mike Maslenkin" To: devel@edk2.groups.io Cc: abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, Mike Maslenkin Subject: [edk2-devel] [PATCH 2/9] RedfishPkg: fix RedfishPlatformCredentialLib library class name typo. Date: Tue, 12 Dec 2023 17:54:05 +0300 Message-Id: <20231212145412.50434-3-mike.maslenkin@gmail.com> In-Reply-To: <20231212145412.50434-1-mike.maslenkin@gmail.com> References: <20231212145412.50434-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1702392872000100010 Content-Type: text/plain; charset="utf-8" RedfishPlatformCredentialIpmiLib is the library instance name not the class= name. Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin --- .../RedfishPlatformCredentialIpmiLib.inf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/RedfishPkg/Library/RedfishPlatformCredentialIpmiLib/RedfishPla= tformCredentialIpmiLib.inf b/RedfishPkg/Library/RedfishPlatformCredentialIp= miLib/RedfishPlatformCredentialIpmiLib.inf index 5c20ea22f894..935461e1dcd0 100644 --- a/RedfishPkg/Library/RedfishPlatformCredentialIpmiLib/RedfishPlatformCr= edentialIpmiLib.inf +++ b/RedfishPkg/Library/RedfishPlatformCredentialIpmiLib/RedfishPlatformCr= edentialIpmiLib.inf @@ -13,7 +13,7 @@ FILE_GUID =3D 9C45D622-4C66-417F-814C-F76246D97233 MODULE_TYPE =3D DXE_DRIVER VERSION_STRING =3D 1.0 - LIBRARY_CLASS =3D RedfishPlatformCredentialIpmiLib + LIBRARY_CLASS =3D RedfishPlatformCredentialLib =20 [Sources] RedfishPlatformCredentialIpmiLib.c --=20 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112438): https://edk2.groups.io/g/devel/message/112438 Mute This Topic: https://groups.io/mt/103130779/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Wed May 15 13:04:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+112439+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112439+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1702392870; cv=none; d=zohomail.com; s=zohoarc; b=TzvEDvigyRvVsui2CQGWER9rtknQDRrV9iUNjjKnqTFGPspxLyUQq8agXQYhV2LqDaF5DBM4DeOxpiVZ3oIOS8KtS89gNiOTOOWRSijStNeg9n0bihDPiCP6GPqY7zwnwMboJBszO7CZBAa2ujkSFwr2mTGsUQN97JcszRV9uxs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1702392870; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=yrSp7QqN2HBd6nTANTtcd8ckNZRuyyO45lHrJk5xHVA=; b=ARcnTsebyDiNYnuuJIeojPT9e7IxQhHlarjhntmPwTc/mSJmtQeTlzkt6DWQOlYqJQT3JS+8uC9nN5e48tOJTOUGEuiujtJVRTt3iveV3wF+53QtTwOquGlAgEbfCbX643KJVlvhab8yjyaGNMuS8+yllQo5YjY+7BiUF3ELsW8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112439+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1702392870936809.2529240123528; Tue, 12 Dec 2023 06:54:30 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=W57EpAsu18uE4ZK2SiUaT9hTt+9YmIKVM8abL8IQaU8=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1702392870; v=1; b=aW212iNvLqkWp2fBoflZcncQQYHvdUeg4Pq9JdHhFg2miqxZJGQnN5hkFtnZjugpcIc9VRdq biKF766+5wWziZ5SFbDo0jO1kGlZ6iLQ0+lWtsqcBFkuY5713VM9Ss6NrlYhScyqwxmW2r4ZCVM ZnLHzSR6XWzV2j2267uA+cQE= X-Received: by 127.0.0.2 with SMTP id FJBnYY1788612x9KALA2yuue; Tue, 12 Dec 2023 06:54:30 -0800 X-Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) by mx.groups.io with SMTP id smtpd.web11.3455.1702392869736822255 for ; Tue, 12 Dec 2023 06:54:30 -0800 X-Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-50c02628291so6073801e87.0 for ; Tue, 12 Dec 2023 06:54:29 -0800 (PST) X-Gm-Message-State: cSksexOk5dCZJVSeeTLdVW5Kx1787277AA= X-Google-Smtp-Source: AGHT+IF6zxln6qQJnyt0Oqz3UDaPIRdRwCpdTlRlkv7WNLy2WXtzpxzbZkA55DM17aGdB58c1hZ7UQ== X-Received: by 2002:a05:6512:3491:b0:50d:1b84:7ad2 with SMTP id v17-20020a056512349100b0050d1b847ad2mr2541698lfr.40.1702392867728; Tue, 12 Dec 2023 06:54:27 -0800 (PST) X-Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id m21-20020a0565120a9500b0050d1d8674d2sm952008lfu.292.2023.12.12.06.54.27 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 12 Dec 2023 06:54:27 -0800 (PST) From: "Mike Maslenkin" To: devel@edk2.groups.io Cc: abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, Mike Maslenkin Subject: [edk2-devel] [PATCH 3/9] RedfishPkg: get rid of unused definitions from RedfishCrtLib.h Date: Tue, 12 Dec 2023 17:54:06 +0300 Message-Id: <20231212145412.50434-4-mike.maslenkin@gmail.com> In-Reply-To: <20231212145412.50434-1-mike.maslenkin@gmail.com> References: <20231212145412.50434-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1702392871996100007 Content-Type: text/plain; charset="utf-8" It seems that initial implementation of this header file is based on CrtLibSupport.h from CryptoPkg. But uid, euid, gid, egid and sa_family_t sre not used in RedfishPkg. So remove them. Also take "true" and "false" definition from MdePkg's LibFdtSupport.h header file, that also seems based on a header mentioned above. Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin --- RedfishPkg/Include/Library/RedfishCrtLib.h | 45 ++++++---------------- 1 file changed, 11 insertions(+), 34 deletions(-) diff --git a/RedfishPkg/Include/Library/RedfishCrtLib.h b/RedfishPkg/Includ= e/Library/RedfishCrtLib.h index ac6c5162ad6a..0c51a03d0e1a 100644 --- a/RedfishPkg/Include/Library/RedfishCrtLib.h +++ b/RedfishPkg/Include/Library/RedfishCrtLib.h @@ -69,20 +69,17 @@ // // Basic types mapping // -typedef UINTN size_t; -typedef INTN ssize_t; -typedef INT32 time_t; -typedef UINT8 __uint8_t; -typedef UINT8 sa_family_t; -typedef UINT32 uid_t; -typedef UINT32 gid_t; -typedef INT32 int32_t; -typedef UINT32 uint32_t; -typedef UINT16 uint16_t; -typedef UINT8 uint8_t; -typedef enum { - false, true -} bool; +typedef UINTN size_t; +typedef INTN ssize_t; +typedef INT32 time_t; +typedef INT32 int32_t; +typedef UINT32 uint32_t; +typedef UINT16 uint16_t; +typedef UINT8 uint8_t; +typedef BOOLEAN bool; + +#define true (1 =3D=3D 1) +#define false (1 =3D=3D 0) =20 // // File operations are not required for EFI building, @@ -343,26 +340,6 @@ fgetc ( FILE *_File ); =20 -uid_t -getuid ( - void - ); - -uid_t -geteuid ( - void - ); - -gid_t -getgid ( - void - ); - -gid_t -getegid ( - void - ); - void qsort ( void *, --=20 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112439): https://edk2.groups.io/g/devel/message/112439 Mute This Topic: https://groups.io/mt/103130781/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Wed May 15 13:04:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+112440+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112440+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1702392871; cv=none; d=zohomail.com; s=zohoarc; b=F02nqHViS2yX/Kj3CFiHgXUEl9lEeLkkBXkoZjcYxgH19OGw6Q6xoC4fVcCu8GamMzbNwa6dX3mOGrQkR4VpPFsYAxpoiQNhqx6tUS9dxQgbx60/nhJNyhaJ8sJ2/kcG7CRyqE28FrUtZ0/7U/PCzy/XCjXwCYVWs5CjBnpBZ1g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1702392871; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=RSk4+v1qYsh8xGmNgxnXxMTpfhf8iSu6XJcDTXYvaOQ=; b=LStK7w4RT94ktedLXKjtxIOtxrDSYBepVFxbQ5HgXVCaM8YCc1L6IQ+P6pn7ZZiHkxxErpDC2pufrSQe7RIV4qD7sylvR55gcOFiog2xZpO+fzqcK8JlDGBIjKNcVKYAdcYTFA+/QmDQ7d31KhUzorPJdF59QjOJ3PjEhu6BWy0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112440+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1702392871573590.9185732738979; Tue, 12 Dec 2023 06:54:31 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=8twMeQo8IVIf446o4PixLOERfohCgNu+0tQLEMmKDfE=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1702392871; v=1; b=dlTDjRKG0TkFPMILotubWxEUJFGvFp8jUnGZLHOgwpolWN72htp0v2ZXVVe40SdQRFdKA3Xv yk2HmGXt1hgo3vIowq3tVGXLy74trdCm0f+8zIYYxsbeYIkhQDa2tFxQ/9jnHGbYGLiDccnnGEf Jq+AqfeImPos2n/FmLfwHaXY= X-Received: by 127.0.0.2 with SMTP id w662YY1788612xIagyBavyDn; Tue, 12 Dec 2023 06:54:31 -0800 X-Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by mx.groups.io with SMTP id smtpd.web10.3582.1702392870436785729 for ; Tue, 12 Dec 2023 06:54:30 -0800 X-Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-50bffb64178so6810385e87.2 for ; Tue, 12 Dec 2023 06:54:30 -0800 (PST) X-Gm-Message-State: wH2nJAOLlWCjg48dwPtk9pd9x1787277AA= X-Google-Smtp-Source: AGHT+IHQU44NGOThNxrQ419wh6rHRVm9Zz5YVFNc9VdKAlyYtC9JdjzwhEY1e5WFhMl2eEkxxDy1Sw== X-Received: by 2002:ac2:4e14:0:b0:50c:d6b:885e with SMTP id e20-20020ac24e14000000b0050c0d6b885emr3945837lfr.22.1702392868473; Tue, 12 Dec 2023 06:54:28 -0800 (PST) X-Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id m21-20020a0565120a9500b0050d1d8674d2sm952008lfu.292.2023.12.12.06.54.27 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 12 Dec 2023 06:54:28 -0800 (PST) From: "Mike Maslenkin" To: devel@edk2.groups.io Cc: abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, Mike Maslenkin Subject: [edk2-devel] [PATCH 4/9] RedfishPkg: RedfishPlatformConfigDxe: reduce memory allocations Date: Tue, 12 Dec 2023 17:54:07 +0300 Message-Id: <20231212145412.50434-5-mike.maslenkin@gmail.com> In-Reply-To: <20231212145412.50434-1-mike.maslenkin@gmail.com> References: <20231212145412.50434-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1702392871998100009 Content-Type: text/plain; charset="utf-8" It's unclear why the new string is allocated as copy of the original string if its pointer is stored in an array and the original string is released immediately after the copy is created. All data allocated in the same pool. Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin --- .../RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c= b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c index cbc65ba59408..f970e317b3f6 100644 --- a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c +++ b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c @@ -2057,9 +2057,7 @@ RedfishPlatformConfigProtocolGetConfigureLang ( TmpString =3D HiiGetRedfishString (StatementRef->Statement->Parent= Form->ParentFormset->HiiHandle, FullSchema, StatementRef->Statement->Descri= ption); ASSERT (TmpString !=3D NULL); if (TmpString !=3D NULL) { - TmpConfigureLangList[Index] =3D AllocateCopyPool (StrSize (TmpSt= ring), TmpString); - ASSERT (TmpConfigureLangList[Index] !=3D NULL); - FreePool (TmpString); + TmpConfigureLangList[Index] =3D TmpString; ++Index; } } --=20 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112440): https://edk2.groups.io/g/devel/message/112440 Mute This Topic: https://groups.io/mt/103130782/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Wed May 15 13:04:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+112441+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112441+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1702392872; cv=none; d=zohomail.com; s=zohoarc; b=V25eHFQ2U2o+XYzS3KQ3UVb3UXmsqfgulH+phFMQ34UD2xbiPcGBuRMu24GlJeGxR4neZhIzBRPg4webI04U4SDFBcW0xv1HwP7YJSVDoOtg2HADkGCLBeui7P/TTVKaAqWX96O5Nw7BR2v6F77E9yuERILvpOKSoX6TndudCjw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1702392872; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=ADJt/aPjJ9NUAEvzDFZLWYOID3N+1jjn9Q7d2qeCQO0=; b=MfHwznINish27P3n3h4KRFOIUWjnIzXpU5OHMr6O/0xnWq/PfjJmj8g8aeWkSHihgQo5cB39RZ5lvBsEOHKml75QaVqhZPQFcLC0h9GtfrmdKdJ2T9BrpYiSC29AOiCVf/Jpi28GMwSFu7KVlR8gR1PbqRd885MOCwmXgtNP6U4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112441+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1702392872678261.020544246324; Tue, 12 Dec 2023 06:54:32 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=5UxGuIkiQsX8GOD6rQmmkTWyXgHZKzq41ekUvxrz+EE=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1702392872; v=1; b=mxaOQUJW0ucFCD9q8uGlgFkWhvF/PqeUVxo/U0wIaeLtTcrLbWBY1ZG8F3QOEz7Jw1B91Fgp Td0KtrUvYbyqV0OwPmNOXDp5caQa+aA0Y/q/JJ/Dp3wkCXagMBuLQPhZ5GbHwNrRsDTb7Y5v5SG CdrjZA/xtBfg7W4kwY1WU7Bw= X-Received: by 127.0.0.2 with SMTP id s8LZYY1788612xCi7sk6NW5M; Tue, 12 Dec 2023 06:54:32 -0800 X-Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) by mx.groups.io with SMTP id smtpd.web11.3456.1702392871279363608 for ; Tue, 12 Dec 2023 06:54:31 -0800 X-Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-50bfa7f7093so7423727e87.0 for ; Tue, 12 Dec 2023 06:54:31 -0800 (PST) X-Gm-Message-State: bG7TLlT6Oj3tXuhYhiaVW2vKx1787277AA= X-Google-Smtp-Source: AGHT+IEUs6IrcNqtIAyVJY+UjYkO3bjCUDal6u57H7bO/AlkN+kvZ9RkxhutinSc9bACWw1/plzppA== X-Received: by 2002:a05:6512:3191:b0:50d:1a1e:31ee with SMTP id i17-20020a056512319100b0050d1a1e31eemr4211022lfe.88.1702392869268; Tue, 12 Dec 2023 06:54:29 -0800 (PST) X-Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id m21-20020a0565120a9500b0050d1d8674d2sm952008lfu.292.2023.12.12.06.54.28 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 12 Dec 2023 06:54:28 -0800 (PST) From: "Mike Maslenkin" To: devel@edk2.groups.io Cc: abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, Mike Maslenkin Subject: [edk2-devel] [PATCH 5/9] RedfishPkg: RedfishDiscoverDxe: fix memory leak on error path. Date: Tue, 12 Dec 2023 17:54:08 +0300 Message-Id: <20231212145412.50434-6-mike.maslenkin@gmail.com> In-Reply-To: <20231212145412.50434-1-mike.maslenkin@gmail.com> References: <20231212145412.50434-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1702392874071100021 Content-Type: text/plain; charset="utf-8" Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin --- RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c b/RedfishPk= g/RedfishDiscoverDxe/RedfishDiscoverDxe.c index 833ae2b969ff..d77af66cb479 100644 --- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c @@ -862,6 +862,10 @@ AddAndSignalNewRedfishService ( } while (TRUE); } =20 + if (Char16Uuid !=3D NULL) { + FreePool ((VOID *)Char16Uuid); + } + if (NewFound || InfoRefresh) { if (!InfoRefresh) { DiscoveredList =3D (EFI_REDFISH_DISCOVERED_INTERNAL_LIST *)AllocateZ= eroPool (sizeof (EFI_REDFISH_DISCOVERED_INTERNAL_LIST)); @@ -940,10 +944,6 @@ AddAndSignalNewRedfishService ( } } =20 - if (Char16Uuid !=3D NULL) { - FreePool ((VOID *)Char16Uuid); - } - Status =3D EFI_SUCCESS; if (NewFound || InfoRefresh) { // --=20 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112441): https://edk2.groups.io/g/devel/message/112441 Mute This Topic: https://groups.io/mt/103130783/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Wed May 15 13:04:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+112442+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112442+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1702392873; cv=none; d=zohomail.com; s=zohoarc; b=fvqlx4YLtNfpCYs/Mo9R0AYLL0aTIpoXt1DjeFrSJw/gwgwUX6xrw3rf/MXH7p47TdWIC2mqirsKXVI15mn2ysGem5fwOxd4tpTebwT1we9ZlfI5NtilqxBqw/K+lFvqO5kgTDtB3lGoqSzklV2Ry24c1VIV0r0pU6S36/umJuQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1702392873; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=iUlsLPTo3K7NoEreRtX00nbb6d92YQLLE+GPevYpj+g=; b=YZh3Bll65ryRyNqs9EX0M/onaO9LP61xf0nbhC5Jt+7FPB+RGWSWQHOIAjZp2gwtCvDANUORLD62H9lcuFfKxNRZaY4yJLJOFPfz/NzUAlp28ebtM7o0uYq0lYxIoh11xFZGExG5MpXyMkMJ0cmxXWn2dRwctIRC5yu6NcIH0VY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112442+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 170239287325848.41054026107747; Tue, 12 Dec 2023 06:54:33 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=dykUYrSh+E+MUKJJmHBswCXaN2/1OuOr9ryEp3F9oRg=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1702392872; v=1; b=BxOQOqvawkg0E4NB7gFMDMfEbbRXJ7EDtZtBEp+0monrTvtlO4eJGi5d9lqd8F2gkpE8Dfjl ts1X0OjgW0i9aoRaewLsvkZ3+hU/b8ff4ms5v6j33BW6Zr4D6vyPjLPqKyuXIzHBkZJBJwZ0mMn 5lrNB33krtULc/yP+mrNoWm8= X-Received: by 127.0.0.2 with SMTP id NQULYY1788612x2zwArdifxT; Tue, 12 Dec 2023 06:54:32 -0800 X-Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) by mx.groups.io with SMTP id smtpd.web11.3458.1702392871990856660 for ; Tue, 12 Dec 2023 06:54:32 -0800 X-Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-50c05ea5805so6834201e87.0 for ; Tue, 12 Dec 2023 06:54:31 -0800 (PST) X-Gm-Message-State: y7A0iBqGv1Cvun6A2q7Kvrjfx1787277AA= X-Google-Smtp-Source: AGHT+IGsw0rmsk9JNsNTj43KQwfUcq9UteT+ZVw+hAciTW2rCoW5XHukf9xFNK0Y6PCUCMyjWs61Iw== X-Received: by 2002:ac2:46f7:0:b0:50b:fd8c:ac4f with SMTP id q23-20020ac246f7000000b0050bfd8cac4fmr2650379lfo.32.1702392870127; Tue, 12 Dec 2023 06:54:30 -0800 (PST) X-Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id m21-20020a0565120a9500b0050d1d8674d2sm952008lfu.292.2023.12.12.06.54.29 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 12 Dec 2023 06:54:29 -0800 (PST) From: "Mike Maslenkin" To: devel@edk2.groups.io Cc: abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, Mike Maslenkin Subject: [edk2-devel] [PATCH 6/9] RedfishPkg: add Component Name protocols to RedfishConfigHandler driver Date: Tue, 12 Dec 2023 17:54:09 +0300 Message-Id: <20231212145412.50434-7-mike.maslenkin@gmail.com> In-Reply-To: <20231212145412.50434-1-mike.maslenkin@gmail.com> References: <20231212145412.50434-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1702392874103100022 Content-Type: text/plain; charset="utf-8" Currently there is no description for RedfishConfigHandler driver. This leads to in the "DRIVER NAME" column of a `drivers` command for example. Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin --- .../RedfishConfigHandler/ComponentName.c | 216 ++++++++++++++++++ .../RedfishConfigHandlerDriver.c | 10 +- .../RedfishConfigHandlerDriver.h | 4 +- .../RedfishConfigHandlerDriver.inf | 1 + 4 files changed, 228 insertions(+), 3 deletions(-) create mode 100644 RedfishPkg/RedfishConfigHandler/ComponentName.c diff --git a/RedfishPkg/RedfishConfigHandler/ComponentName.c b/RedfishPkg/R= edfishConfigHandler/ComponentName.c new file mode 100644 index 000000000000..e85d42ebdccd --- /dev/null +++ b/RedfishPkg/RedfishConfigHandler/ComponentName.c @@ -0,0 +1,216 @@ +/** @file + Implementation of EFI_COMPONENT_NAME_PROTOCOL and EFI_COMPONENT_NAME2_PR= OTOCOL protocol + for EFI Refish Config Handler Protocol + + SPDX-License-Identifier: BSD-2-Clause-Patent + +**/ + +#include "RedfishConfigHandlerCommon.h" + +// +// EFI Component Name Functions +// + +/** + Retrieves a Unicode string that is the user-readable name of the EFI Dri= ver. + + @param[in] This A pointer to the EFI_COMPONENT_NAME_PROTOCOL inst= ance. + @param[in] Language A pointer to a three-character ISO 639-2 language= identifier. + This is the language of the driver name that that= the caller + is requesting, and it must match one of the langu= ages specified + in SupportedLanguages. The number of languages s= upported by a + driver is up to the driver writer. + @param[out] DriverName A pointer to the Unicode string to return. This = Unicode string + is the name of the driver specified by This in th= e language + specified by Language. + + @retval EFI_SUCCESS The Unicode string for the Driver specifie= d by This + and the language specified by Language was= returned + in DriverName. + @retval EFI_INVALID_PARAMETER Language is NULL. + @retval EFI_INVALID_PARAMETER DriverName is NULL. + @retval EFI_UNSUPPORTED The driver specified by This does not supp= ort the + language specified by Language. + +**/ +EFI_STATUS +EFIAPI +RedfishConfigHandlerComponentNameGetDriverName ( + IN EFI_COMPONENT_NAME_PROTOCOL *This, + IN CHAR8 *Language, + OUT CHAR16 **DriverName + ); + +/** + Retrieves a Unicode string that is the user readable name of the control= ler + that is being managed by an EFI Driver. + + @param[in] This A pointer to the EFI_COMPONENT_NAME_PROTOCO= L instance. + @param[in] ControllerHandle The handle of a controller that the driver = specified by + This is managing. This handle specifies th= e controller + whose name is to be returned. + @param[in] ChildHandle The handle of the child controller to retri= eve the name + of. This is an optional parameter that may= be NULL. It + will be NULL for device drivers. It will a= lso be NULL + for a bus drivers that wish to retrieve the= name of the + bus controller. It will not be NULL for a = bus driver + that wishes to retrieve the name of a child= controller. + @param[in] Language A pointer to a three character ISO 639-2 la= nguage + identifier. This is the language of the co= ntroller name + that the caller is requesting, and it must = match one + of the languages specified in SupportedLang= uages. The + number of languages supported by a driver i= s up to the + driver writer. + @param[out] ControllerName A pointer to the Unicode string to return. = This Unicode + string is the name of the controller specif= ied by + ControllerHandle and ChildHandle in the lan= guage specified + by Language, from the point of view of the = driver specified + by This. + + @retval EFI_SUCCESS The Unicode string for the user-readable n= ame in the + language specified by Language for the dri= ver + specified by This was returned in DriverNa= me. + @retval EFI_INVALID_PARAMETER ControllerHandle is NULL. + @retval EFI_INVALID_PARAMETER ChildHandle is not NULL and it is not a va= lid EFI_HANDLE. + @retval EFI_INVALID_PARAMETER Language is NULL. + @retval EFI_INVALID_PARAMETER ControllerName is NULL. + @retval EFI_UNSUPPORTED The driver specified by This is not curren= tly managing + the controller specified by ControllerHand= le and + ChildHandle. + @retval EFI_UNSUPPORTED The driver specified by This does not supp= ort the + language specified by Language. + +**/ +EFI_STATUS +EFIAPI +RedfishConfigHandlerComponentNameGetControllerName ( + IN EFI_COMPONENT_NAME_PROTOCOL *This, + IN EFI_HANDLE ControllerHandle, + IN EFI_HANDLE ChildHandle OPTIONAL, + IN CHAR8 *Language, + OUT CHAR16 **ControllerName + ); + +/// +/// Component Name Protocol instance +/// +GLOBAL_REMOVE_IF_UNREFERENCED +EFI_COMPONENT_NAME_PROTOCOL gRedfishConfigHandlerComponentName =3D { + RedfishConfigHandlerComponentNameGetDriverName, + RedfishConfigHandlerComponentNameGetControllerName, + "eng" +}; + +/// +/// Component Name 2 Protocol instance +/// +GLOBAL_REMOVE_IF_UNREFERENCED +EFI_COMPONENT_NAME2_PROTOCOL gRedfishConfigHandlerComponentName2 =3D { + (EFI_COMPONENT_NAME2_GET_DRIVER_NAME)RedfishConfigHandlerComponentNameGe= tDriverName, + (EFI_COMPONENT_NAME2_GET_CONTROLLER_NAME)RedfishConfigHandlerComponentNa= meGetControllerName, + "en" +}; + +/// +/// Table of driver names +/// +GLOBAL_REMOVE_IF_UNREFERENCED +EFI_UNICODE_STRING_TABLE mRedfishConfigHandlerDriverNameTable[] =3D { + { "eng;en", (CHAR16 *)L"Redfish Configuration UEFI Driver" }, + { NULL, NULL } +}; + +GLOBAL_REMOVE_IF_UNREFERENCED EFI_UNICODE_STRING_TABLE *gRedfishConfigHan= dlerControllerNameTable =3D NULL; + +/** + Retrieves a Unicode string that is the user-readable name of the EFI Dri= ver. + + @param[in] This A pointer to the EFI_COMPONENT_NAME_PROTOCOL ins= tance. + @param[in] Language A pointer to a three-character ISO 639-2 languag= e identifier. + This is the language of the driver name that tha= t the caller + is requesting, and it must match one of the lang= uages specified + in SupportedLanguages. The number of languages = supported by a + driver is up to the driver writer. + @param[out] DriverName A pointer to the Unicode string to return. This= Unicode string + is the name of the driver specified by This in t= he language + specified by Language. + + @retval EFI_SUCCESS The Unicode string for the Driver specifie= d by This + and the language specified by Language was= returned + in DriverName. + @retval EFI_INVALID_PARAMETER Language is NULL. + @retval EFI_INVALID_PARAMETER DriverName is NULL. + @retval EFI_UNSUPPORTED The driver specified by This does not supp= ort the + language specified by Language. + +**/ +EFI_STATUS +EFIAPI +RedfishConfigHandlerComponentNameGetDriverName ( + IN EFI_COMPONENT_NAME_PROTOCOL *This, + IN CHAR8 *Language, + OUT CHAR16 **DriverName + ) +{ + return LookupUnicodeString2 ( + Language, + This->SupportedLanguages, + mRedfishConfigHandlerDriverNameTable, + DriverName, + (BOOLEAN)(This =3D=3D &gRedfishConfigHandlerComponentName) + ); +} + +/** + Retrieves a Unicode string that is the user readable name of the control= ler + that is being managed by an EFI Driver. + + @param[in] This A pointer to the EFI_COMPONENT_NAME_PROTOCO= L instance. + @param[in] ControllerHandle The handle of a controller that the driver = specified by + This is managing. This handle specifies th= e controller + whose name is to be returned. + @param[in] ChildHandle The handle of the child controller to retri= eve the name + of. This is an optional parameter that may= be NULL. It + will be NULL for device drivers. It will a= lso be NULL + for a bus drivers that wish to retrieve the= name of the + bus controller. It will not be NULL for a = bus driver + that wishes to retrieve the name of a child= controller. + @param[in] Language A pointer to a three character ISO 639-2 la= nguage + identifier. This is the language of the co= ntroller name + that the caller is requesting, and it must = match one + of the languages specified in SupportedLang= uages. The + number of languages supported by a driver i= s up to the + driver writer. + @param[out] ControllerName A pointer to the Unicode string to return. = This Unicode + string is the name of the controller specif= ied by + ControllerHandle and ChildHandle in the lan= guage specified + by Language, from the point of view of the = driver specified + by This. + + @retval EFI_SUCCESS The Unicode string for the user-readable n= ame in the + language specified by Language for the dri= ver + specified by This was returned in DriverNa= me. + @retval EFI_INVALID_PARAMETER ControllerHandle is NULL. + @retval EFI_INVALID_PARAMETER ChildHandle is not NULL and it is not a va= lid EFI_HANDLE. + @retval EFI_INVALID_PARAMETER Language is NULL. + @retval EFI_INVALID_PARAMETER ControllerName is NULL. + @retval EFI_UNSUPPORTED The driver specified by This is not curren= tly managing + the controller specified by ControllerHand= le and + ChildHandle. + @retval EFI_UNSUPPORTED The driver specified by This does not supp= ort the + language specified by Language. + +**/ +EFI_STATUS +EFIAPI +RedfishConfigHandlerComponentNameGetControllerName ( + IN EFI_COMPONENT_NAME_PROTOCOL *This, + IN EFI_HANDLE ControllerHandle, + IN EFI_HANDLE ChildHandle OPTIONAL, + IN CHAR8 *Language, + OUT CHAR16 **ControllerName + ) +{ + return EFI_UNSUPPORTED; +} diff --git a/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.c b= /RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.c index 2d0170d88614..5e03132695d6 100644 --- a/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.c +++ b/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.c @@ -601,11 +601,17 @@ RedfishConfigHandlerDriverEntryPoint ( // // Install UEFI Driver Model protocol(s). // - Status =3D EfiLibInstallDriverBinding ( + Status =3D EfiLibInstallAllDriverProtocols2 ( ImageHandle, SystemTable, &gRedfishConfigDriverBinding, - ImageHandle + ImageHandle, + &gRedfishConfigHandlerComponentName, + &gRedfishConfigHandlerComponentName2, + NULL, + NULL, + NULL, + NULL ); if (EFI_ERROR (Status)) { gBS->CloseEvent (gEndOfDxeEvent); diff --git a/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.h b= /RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.h index 07214875bd5a..51701c05c697 100644 --- a/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.h +++ b/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.h @@ -24,7 +24,9 @@ // // Protocol instances // -extern EFI_DRIVER_BINDING_PROTOCOL gRedfishConfigDriverBinding; +extern EFI_DRIVER_BINDING_PROTOCOL gRedfishConfigDriverBinding; +extern EFI_COMPONENT_NAME_PROTOCOL gRedfishConfigHandlerComponentName; +extern EFI_COMPONENT_NAME2_PROTOCOL gRedfishConfigHandlerComponentName2; =20 extern REDFISH_CONFIG_DRIVER_DATA gRedfishConfigData; extern EDKII_REDFISH_CREDENTIAL_PROTOCOL *gCredential; diff --git a/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.inf= b/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.inf index aed93f570cf9..40ce0561379f 100644 --- a/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.inf +++ b/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.inf @@ -30,6 +30,7 @@ RedfishPkg/RedfishPkg.dec =20 [Sources] + ComponentName.c RedfishConfigHandlerDriver.h RedfishConfigHandlerDriver.c RedfishConfigHandlerCommon.h --=20 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112442): https://edk2.groups.io/g/devel/message/112442 Mute This Topic: https://groups.io/mt/103130784/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Wed May 15 13:04:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+112443+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112443+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1702392874; cv=none; d=zohomail.com; s=zohoarc; b=KGwb6Xr3uzgJV3w24X494Wn5AgaoLPg/pidWLkErn7OZPjVxSbIbU8RTNJVW9UQwszYCT/vMr87FxCW0ghMQl2BwJJln+twn7KQrcF5iRzee72BoH4MJVWA8QTNeTqkuaJ7REWehh7NLZdzOHKpcHQ9sJ1BjsdNRwqFJwgZ1F+8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1702392874; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=2YcyDbWj0Q8RY0XkFkv/x53JMDa+0cvqMeFegEH1EUc=; b=W6ay5iFMiFGQI6pmcFYg/25mdPzaZfHHHbKElN/AV5rxGPpKXTZ8Hafu9m4uOkODNdQ2qO91Ht38KFBe1Sxbd9Djp+CD5h4dXVykgzJXwmrRpYlGrZMEp2ohfTTb04jsMusQqudaY7Lg/w+ZSB9bjSvjn1+NnyH0wihLC3qDOZw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112443+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1702392874147837.9451161960344; Tue, 12 Dec 2023 06:54:34 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=8xITqyL1oqOKSU08HHaKSWmtnLiHk5HLUAW8/ExRHRM=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1702392873; v=1; b=TNEFxs422+DHFb5xXwV+MKkqB0S4X+LfZj3YWKKTPJ8EPFsyUOTxff6ySvJklhm6B76Z4sfM GoqLx4wDj770Oc73LJxPdofS7Zm8EBjzQ9pECzCi9DJ9s4bB98zz3Lx5ssqZDjUtcYsjfjyjrpZ tT3KAV55TZGivS/DMQlLFmhY= X-Received: by 127.0.0.2 with SMTP id HJIKYY1788612xV9Ko21ue67; Tue, 12 Dec 2023 06:54:33 -0800 X-Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) by mx.groups.io with SMTP id smtpd.web10.3584.1702392873062825927 for ; Tue, 12 Dec 2023 06:54:33 -0800 X-Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-50be10acaf9so5691815e87.1 for ; Tue, 12 Dec 2023 06:54:32 -0800 (PST) X-Gm-Message-State: iOsgoTPdInTPVRl7AwfnI2y3x1787277AA= X-Google-Smtp-Source: AGHT+IG/9vJElDTe5DMGqqwQmUUl4RDSbKWpL3qeWgn4dJV9htzdZxaiC3fBTSj2dEIBZhjzVFraUg== X-Received: by 2002:a19:5e1d:0:b0:50b:f03c:1eb2 with SMTP id s29-20020a195e1d000000b0050bf03c1eb2mr2898719lfb.20.1702392870972; Tue, 12 Dec 2023 06:54:30 -0800 (PST) X-Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id m21-20020a0565120a9500b0050d1d8674d2sm952008lfu.292.2023.12.12.06.54.30 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 12 Dec 2023 06:54:30 -0800 (PST) From: "Mike Maslenkin" To: devel@edk2.groups.io Cc: abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, Mike Maslenkin Subject: [edk2-devel] [PATCH 7/9] RedfishPkg: add proper initialization of IPMI request Date: Tue, 12 Dec 2023 17:54:10 +0300 Message-Id: <20231212145412.50434-8-mike.maslenkin@gmail.com> In-Reply-To: <20231212145412.50434-1-mike.maslenkin@gmail.com> References: <20231212145412.50434-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1702392876016100031 Content-Type: text/plain; charset="utf-8" All fields of IPMI_CHANNEL_INFO_CHANNEL_NUMBER union must be initialized to avoid error condition on BMC side. Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin --- .../PlatformHostInterfaceBmcUsbNicLib.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformH= ostInterfaceBmcUsbNicLib.c b/RedfishPkg/Library/PlatformHostInterfaceBmcUsb= NicLib/PlatformHostInterfaceBmcUsbNicLib.c index 7f295fe7f1c0..c73e76df5791 100644 --- a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInte= rfaceBmcUsbNicLib.c +++ b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInte= rfaceBmcUsbNicLib.c @@ -616,9 +616,10 @@ HostInterfaceIpmiCheckMacAddress ( } =20 // Initial the get MAC address request. - GetLanConfigReq.SetSelector =3D 0; - GetLanConfigReq.BlockSelector =3D 0; - GetLanConfigReq.ParameterSelector =3D IpmiLanMacAddress; + GetLanConfigReq.ChannelNumber.Uint8 =3D 0; + GetLanConfigReq.SetSelector =3D 0; + GetLanConfigReq.BlockSelector =3D 0; + GetLanConfigReq.ParameterSelector =3D IpmiLanMacAddress; =20 ExitStatus =3D EFI_NOT_FOUND; for (ChannelNum =3D IPMI_CHANNEL_NUMBER_IMPLEMENTATION_SPECIFIC_1; @@ -640,6 +641,7 @@ HostInterfaceIpmiCheckMacAddress ( } else { DEBUG ((DEBUG_REDFISH_HOST_INTERFACE, " No cached IPMI LAN info\n")= ); DEBUG ((DEBUG_REDFISH_HOST_INTERFACE, " Send NetFn =3D App, Command= =3D 0x42 to channel %d\n", ChannelNum)); + GetChanelInfoRequest.ChannelNumber.Uint8 =3D 0; GetChanelInfoRequest.ChannelNumber.Bits.ChannelNo =3D (UINT8)Channel= Num; Status =3D IpmiGetChannel= Info ( &GetChanelInfo= Request, --=20 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112443): https://edk2.groups.io/g/devel/message/112443 Mute This Topic: https://groups.io/mt/103130785/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Wed May 15 13:04:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+112444+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112444+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1702392874; cv=none; d=zohomail.com; s=zohoarc; b=a4iS9ts0Jd5crA9FXsq5MiQMfh1JuqnL+gpLysO576uaymxlRB9iqHmoWefGmIfQ6asZbCoLwFlhjtXkdfPULI9h1pFaBJw2Yj9HmiG02QhO8m5L4W+hCiXP/rp9U9WJP78qt3lfJyTu+eJ798JzGV2u1GXmyI8cP8QL9RK2BmU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1702392874; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=CX+YwtztKk6/IGUNfSc6kYQ1/RfMCLNpvqL+rOrbHEA=; b=itplKMXdvgf3qIyhTOAfY0jmsaaZ/Lf0QfROWnb1Fn8mOQKJeuwko50yw2DokRXjTZUaiy1lymrVnw0A+v2RzeLH+OUNOcLtmSLfELrPhzzHyg4B9YUGuvz45KagXU8iAUlLhm5Oh/ftuT6EPnArTP7M7FUdllSnv4DR4JkoG6o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112444+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1702392874906533.674683049762; Tue, 12 Dec 2023 06:54:34 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=QO3/M2ZGKWjhuPWv/t/vd5Plbb42LurykLuDjNO5Ht8=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1702392874; v=1; b=JOXmP/yfnHqkzPAFhkoNLCOyIKxlsIy3iK+nOJWRfI3Pw6KPrFqq4Jg4vjMr07OgeWfJ6TgZ kzKv/f/LaizfNw/le3fEzjwXJab/jI3QTb3DApv0csL7OHpv5325AWrTTEF20TUHJu8pfvcvY94 CVB8mKJ/ujG28EO9ARhKWyUQ= X-Received: by 127.0.0.2 with SMTP id WoAsYY1788612xHY0alKeheD; Tue, 12 Dec 2023 06:54:34 -0800 X-Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) by mx.groups.io with SMTP id smtpd.web11.3463.1702392873569482572 for ; Tue, 12 Dec 2023 06:54:33 -0800 X-Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-50e0ba402b4so729985e87.1 for ; Tue, 12 Dec 2023 06:54:33 -0800 (PST) X-Gm-Message-State: pKJRtVt7r0swOhoMxZmMfTGwx1787277AA= X-Google-Smtp-Source: AGHT+IEaJDB2xMX3RYlsOAwtpVfOBNnXO5WzUxe2slzTUQf8EiA+H2DXe/kw8gCBjL6Kt3P5NxcYAg== X-Received: by 2002:a19:7512:0:b0:50e:626:cc56 with SMTP id y18-20020a197512000000b0050e0626cc56mr721080lfe.9.1702392871707; Tue, 12 Dec 2023 06:54:31 -0800 (PST) X-Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id m21-20020a0565120a9500b0050d1d8674d2sm952008lfu.292.2023.12.12.06.54.31 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 12 Dec 2023 06:54:31 -0800 (PST) From: "Mike Maslenkin" To: devel@edk2.groups.io Cc: abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, Mike Maslenkin Subject: [edk2-devel] [PATCH 8/9] EmulatorPkg: fix typo. PcdRedfishServie -> PcdRedfishService Date: Tue, 12 Dec 2023 17:54:11 +0300 Message-Id: <20231212145412.50434-9-mike.maslenkin@gmail.com> In-Reply-To: <20231212145412.50434-1-mike.maslenkin@gmail.com> References: <20231212145412.50434-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1702392876053100033 Content-Type: text/plain; charset="utf-8" Cc: Abner Chang Cc: Nickle Wang Signed-off-by: Mike Maslenkin --- EmulatorPkg/EmulatorPkg.dec | 8 ++++---- .../RedfishPlatformCredentialLib.c | 12 ++++++------ .../RedfishPlatformCredentialLib.inf | 8 ++++---- 3 files changed, 14 insertions(+), 14 deletions(-) diff --git a/EmulatorPkg/EmulatorPkg.dec b/EmulatorPkg/EmulatorPkg.dec index fe81652b0478..c2a92923e9b7 100644 --- a/EmulatorPkg/EmulatorPkg.dec +++ b/EmulatorPkg/EmulatorPkg.dec @@ -77,15 +77,15 @@ ## Platform level Redfish Service control PCD # These PCDs are used to stop the Redfish sevice when secure boot is dis= abled # or exit boot service. - gEmulatorPkgTokenSpaceGuid.PcdRedfishServieStopIfSecureBootDisabled|TRUE= |BOOLEAN|0x00001020 - gEmulatorPkgTokenSpaceGuid.PcdRedfishServieStopIfExitbootService|TRUE|BO= OLEAN|0x00001021 + gEmulatorPkgTokenSpaceGuid.PcdRedfishServiceStopIfSecureBootDisabled|TRU= E|BOOLEAN|0x00001020 + gEmulatorPkgTokenSpaceGuid.PcdRedfishServiceStopIfExitbootService|TRUE|B= OOLEAN|0x00001021 ## # edk2 Redfish implementation on Emulator package is designed to access # to Redfish simulator. # https://github.com/DMTF/Redfish-Profile-Simulator # The user ID and password are fixed as below. - gEmulatorPkgTokenSpaceGuid.PcdRedfishServieUserId|"admin"|VOID*|0x000010= 22 - gEmulatorPkgTokenSpaceGuid.PcdRedfishServiePassword|"pwd123456"|VOID*|0x= 00001023 + gEmulatorPkgTokenSpaceGuid.PcdRedfishServiceUserId|"admin"|VOID*|0x00001= 022 + gEmulatorPkgTokenSpaceGuid.PcdRedfishServicePassword|"pwd123456"|VOID*|0= x00001023 gEmulatorPkgTokenSpaceGuid.PcdPersistentMemorySize|0x4000000|UINT32|0x00= 001024 =20 [PcdsFixedAtBuild, PcdsPatchableInModule] diff --git a/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatfo= rmCredentialLib.c b/EmulatorPkg/Library/RedfishPlatformCredentialLib/Redfis= hPlatformCredentialLib.c index 614eaebb0d0e..5c167fcdea56 100644 --- a/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCrede= ntialLib.c +++ b/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCrede= ntialLib.c @@ -57,8 +57,8 @@ GetRedfishCredential ( // // User ID and Password. // - UserIdSize =3D AsciiStrSize ((CHAR8 *)PcdGetPtr (PcdRedfishServieUserI= d)); - PasswordSize =3D AsciiStrSize ((CHAR8 *)PcdGetPtr (PcdRedfishServiePassw= ord)); + UserIdSize =3D AsciiStrSize ((CHAR8 *)PcdGetPtr (PcdRedfishServiceUser= Id)); + PasswordSize =3D AsciiStrSize ((CHAR8 *)PcdGetPtr (PcdRedfishServicePass= word)); if ((UserIdSize =3D=3D 0) || (PasswordSize =3D=3D 0)) { DEBUG ((DEBUG_ERROR, "Incorrect string of UserID or Password for REdfi= sh service.\n")); return EFI_INVALID_PARAMETER; @@ -69,7 +69,7 @@ GetRedfishCredential ( return EFI_OUT_OF_RESOURCES; } =20 - CopyMem (*UserId, (CHAR8 *)PcdGetPtr (PcdRedfishServieUserId), UserIdSiz= e); + CopyMem (*UserId, (CHAR8 *)PcdGetPtr (PcdRedfishServiceUserId), UserIdSi= ze); =20 *Password =3D AllocateZeroPool (PasswordSize); if (*Password =3D=3D NULL) { @@ -77,7 +77,7 @@ GetRedfishCredential ( return EFI_OUT_OF_RESOURCES; } =20 - CopyMem (*Password, (CHAR8 *)PcdGetPtr (PcdRedfishServiePassword), Passw= ordSize); + CopyMem (*Password, (CHAR8 *)PcdGetPtr (PcdRedfishServicePassword), Pass= wordSize); return EFI_SUCCESS; } =20 @@ -177,7 +177,7 @@ LibStopRedfishService ( // Check platform PCD to determine the action for stopping // Redfish service due to secure boot is disabled. // - if (!PcdGetBool (PcdRedfishServieStopIfSecureBootDisabled)) { + if (!PcdGetBool (PcdRedfishServiceStopIfSecureBootDisabled)) { return EFI_UNSUPPORTED; } else { // @@ -198,7 +198,7 @@ LibStopRedfishService ( // Check platform PCD to determine the action for stopping // Redfish service due to exit boot service. // - if (PcdGetBool (PcdRedfishServieStopIfExitbootService)) { + if (PcdGetBool (PcdRedfishServiceStopIfExitbootService)) { return EFI_UNSUPPORTED; } else { mStopRedfishService =3D TRUE; diff --git a/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatfo= rmCredentialLib.inf b/EmulatorPkg/Library/RedfishPlatformCredentialLib/Redf= ishPlatformCredentialLib.inf index 41c389c4a292..9d151f14ee17 100644 --- a/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCrede= ntialLib.inf +++ b/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCrede= ntialLib.inf @@ -36,10 +36,10 @@ UefiLib =20 [Pcd] - gEmulatorPkgTokenSpaceGuid.PcdRedfishServieStopIfSecureBootDisabled ## C= ONSUMES - gEmulatorPkgTokenSpaceGuid.PcdRedfishServieStopIfExitbootService ## C= ONSUMES - gEmulatorPkgTokenSpaceGuid.PcdRedfishServieUserId ## C= ONSUMES - gEmulatorPkgTokenSpaceGuid.PcdRedfishServiePassword ## C= ONSUMES + gEmulatorPkgTokenSpaceGuid.PcdRedfishServiceStopIfSecureBootDisabled ## = CONSUMES + gEmulatorPkgTokenSpaceGuid.PcdRedfishServiceStopIfExitbootService ## = CONSUMES + gEmulatorPkgTokenSpaceGuid.PcdRedfishServiceUserId ## = CONSUMES + gEmulatorPkgTokenSpaceGuid.PcdRedfishServicePassword ## = CONSUMES =20 [Guids] gEfiGlobalVariableGuid --=20 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112444): https://edk2.groups.io/g/devel/message/112444 Mute This Topic: https://groups.io/mt/103130786/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Wed May 15 13:04:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+112445+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112445+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1702392875; cv=none; d=zohomail.com; s=zohoarc; b=Ec5n5Eezr+o09Mt4SesDy6JBvvHAF2GgW/zhNHFr9lx0r44SLGB7dK2qcWYLLQcWhzyfwRFcsqoflY2WveGsnSl8B13q6aZe6KCdatUuA59YFkqKmYKU9AYkvTkTeK4N2xZ+YJAotiN2BtwjHRXy28RUntrYUaDjSir1sq/cAvo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1702392875; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=K56DulOx103423HA4ySTdRie/SH9apNuVUE1uGn8zTs=; b=IRP1TIaGIN6lypBieFqR8mRSYorjFfFpcg6Uj5Qyt+hXNXlBqshKPbeHvUqta+/2RxDXG0jYW9AmxV03MRm8t5nHuN3KGDIT80nuI/UJfb3zJ7z11ElcZZxUSBkpTadVzxlkR71bgyrohGzFcMo8s3g4eLhDusQpZxufLRH4nLY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112445+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1702392875590666.2742393675686; Tue, 12 Dec 2023 06:54:35 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=7i9bFz1QiHsbmyKBTQfqZMutjrTHBo49vVY1aT/XBuw=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1702392875; v=1; b=A1O0qClXp1a6bcvOqaveQYAkOIFpVuv7FbqkoOFxdNSiYmCP8f+OE04kyN95j+lm1/6sQn2N HjWy8/oXLhnu383/auvWitrVOZZQXqVMi9a7IwvykMup7cylEZwFXfJAJPTCby3sMVlZk16C9h6 wJ0MWLEnp+y1hzXKu4kyo4P0= X-Received: by 127.0.0.2 with SMTP id vbCLYY1788612xkqaQrbpf7m; Tue, 12 Dec 2023 06:54:35 -0800 X-Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) by mx.groups.io with SMTP id smtpd.web10.3587.1702392874341170127 for ; Tue, 12 Dec 2023 06:54:34 -0800 X-Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-50bfa7f7093so7423817e87.0 for ; Tue, 12 Dec 2023 06:54:34 -0800 (PST) X-Gm-Message-State: ThSsRBmzdZwjoPFA2X5gh1fJx1787277AA= X-Google-Smtp-Source: AGHT+IGMfuYv2dOZ+01PSsXw/xJK77gG/XhCW0PLmGW8ImKDRXPbsM9PMcjlcHwuviDam0aV/fyh9A== X-Received: by 2002:a05:6512:ea3:b0:50b:f1e9:c478 with SMTP id bi35-20020a0565120ea300b0050bf1e9c478mr4104902lfb.75.1702392872497; Tue, 12 Dec 2023 06:54:32 -0800 (PST) X-Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id m21-20020a0565120a9500b0050d1d8674d2sm952008lfu.292.2023.12.12.06.54.31 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 12 Dec 2023 06:54:32 -0800 (PST) From: "Mike Maslenkin" To: devel@edk2.groups.io Cc: abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, Mike Maslenkin Subject: [edk2-devel] [PATCH 9/9] EmulatorPkg: RedfishPlatformHostInterfaceLib: get rid of unused variable Date: Tue, 12 Dec 2023 17:54:12 +0300 Message-Id: <20231212145412.50434-10-mike.maslenkin@gmail.com> In-Reply-To: <20231212145412.50434-1-mike.maslenkin@gmail.com> References: <20231212145412.50434-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1702392876018100032 Content-Type: text/plain; charset="utf-8" Cc: Abner Chang Cc: Nickle Wang Signed-off-by: Mike Maslenkin --- .../RedfishPlatformHostInterfaceLib.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/EmulatorPkg/Library/RedfishPlatformHostInterfaceLib/RedfishPla= tformHostInterfaceLib.c b/EmulatorPkg/Library/RedfishPlatformHostInterfaceL= ib/RedfishPlatformHostInterfaceLib.c index 4332caa71016..71b3dfc64358 100644 --- a/EmulatorPkg/Library/RedfishPlatformHostInterfaceLib/RedfishPlatformHo= stInterfaceLib.c +++ b/EmulatorPkg/Library/RedfishPlatformHostInterfaceLib/RedfishPlatformHo= stInterfaceLib.c @@ -42,12 +42,10 @@ GetMacAddressInformation ( OUT EFI_MAC_ADDRESS *MacAddress ) { - MAC_ADDR_DEVICE_PATH *Mac; REST_EX_SERVICE_DEVICE_PATH_DATA *RestExServiceDevicePathData; EFI_DEVICE_PATH_PROTOCOL *RestExServiceDevicePath; MAC_ADDR_DEVICE_PATH *MacAddressDevicePath; =20 - Mac =3D NULL; RestExServiceDevicePathData =3D NULL; RestExServiceDevicePath =3D NULL; =20 --=20 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112445): https://edk2.groups.io/g/devel/message/112445 Mute This Topic: https://groups.io/mt/103130787/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-