From nobody Tue May 21 09:40:16 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112303+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1702306755510789.5118934770688; Mon, 11 Dec 2023 06:59:15 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=a5iqq1GL+Foo3d22gZjza0Ubz9jTZb490/uGSHbf8z0=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:From:To:CC:Subject:Date:Message-ID:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1702306755; v=1; b=rHupEnptBzsb/LH2KY4gNUmWPpHGJ4F3EtU5v/A8elHrx0I68ibNpgyDIgkktBWcM5768YFk fRiZfbjZMyOd1NX7OMUC6sdnV6Svw6+sX1bkvj19uRVrhlmgUVxWBSLxlnMKO4gogGPx9d8MaQg Jix0BwAhlebvIgl7Vo4B3uxo= X-Received: by 127.0.0.2 with SMTP id iczYYY1788612x0HBw9PnJUy; Mon, 11 Dec 2023 06:59:15 -0800 X-Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.74]) by mx.groups.io with SMTP id smtpd.web11.10308.1702306754174283584 for ; Mon, 11 Dec 2023 06:59:14 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S+Xc/mrFLra3aAN4kB5IFJwXIKIA/K6lj/lXyjH2bYPMZfsC+2rrqKKjJzGR9/6WyaJGrfipjAQhgtANgDiDg+IDC7PhgXpVU/r0jQ6153Zs8iKWX0FELlWX62C32tfAtetbfeWSJ91AteQDRWEPeWFoLi7O7DpsolwVmu/fC6q3MImI+pxRAhHbWSQiPFNgRyfNeaf+mo+fVAkFFFBZ5H7Et96lV6d+MSFaNrhPOdzJ543uEA2lUpFrj2VXAY+K9WvX3O6CBKE/6zStNgMNXwTn6L1SmcG4qy1s2tY08R7CCQ+LFt+KJdIYdVjm/Q1kJnXsEtgIOh3kitd/WteLfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uBq0PawdSXTcpmkLU021Nrinya2oCqVuCzZ0Axhxpig=; b=XHdIwB362PD28++WIPR2WbOsuVEI1lN8pMP2hI++DShgrYdPTxzl+V7Kmm3Tq/fcRL1xzdUOpfu+IZn/6pY/OlkfWJFkyfbSJwC3kS+f7XEtiEjWnEsGSQgNeGU5/PMpaeixPDBy3j0uL4A19aun5sYpX3inEIVpGwXthTSJCYwgVSH0+K8Mlhz1AKTB+hStloRSVi514ZwjlsXZFL7EYa4iEfxNOXKPokwGKAb85wRVIhT0SV2zDFTUK/O6XmVr71+Aykhz8nm37f/C6RtQSeIM3APvqiaD+zkglFa/OjJOZc50CmiGQEWPeqSM7MyU0K9bKN+10MZNL1nGhMZ3pw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) X-Received: from CY5P221CA0020.NAMP221.PROD.OUTLOOK.COM (2603:10b6:930:b::19) by PH7PR12MB6444.namprd12.prod.outlook.com (2603:10b6:510:1f8::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.32; Mon, 11 Dec 2023 14:59:11 +0000 X-Received: from CY4PEPF0000EDD5.namprd03.prod.outlook.com (2603:10b6:930:b:cafe::ce) by CY5P221CA0020.outlook.office365.com (2603:10b6:930:b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.33 via Frontend Transport; Mon, 11 Dec 2023 14:59:10 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+112303+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C X-Received: from SATLEXMB04.amd.com (165.204.84.17) by CY4PEPF0000EDD5.mail.protection.outlook.com (10.167.241.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7091.18 via Frontend Transport; Mon, 11 Dec 2023 14:59:10 +0000 X-Received: from TPE-L1-ABNCHANG.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Mon, 11 Dec 2023 08:59:08 -0600 From: "Chang, Abner via groups.io" To: CC: Nickle Wang , Igor Kulchytskyy , Mike Maslenkin Subject: [edk2-devel] [PATCH V2] RedfishPkg/RedfishDicovery: Remedy Redfish service discovery flow Date: Mon, 11 Dec 2023 22:58:50 +0800 Message-ID: <20231211145850.1553-1-abner.chang@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EDD5:EE_|PH7PR12MB6444:EE_ X-MS-Office365-Filtering-Correlation-Id: 49468247-639b-46b2-d340-08dbfa59bb7e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: gT+YhSkJ4NK9zFDqyBXim7fUfCIGUvxLZ75jqSc6BkKOkBv/lAHmAJHOA+5fKNZAEG45EEdYE9nZuwvM4XvB5Yjp7qumNHSfV9SS/NiY9ERK32Ty0zFMiDPKQ2ICwO+PGd2+xxAEx8dmccGGaKAZgkiwFMpub0p8naYnBJ2lSxbrIW41bRCz556UV6FssSGzpqX4fO95Gh2QkJrsJBSsMtzymHkG8q8DrtBbl7vE+9wI/F1xuRS/Yz5Ro5yDPAlvu7Ctu6TKeBczYHYnp/Ufs1wfU3IqDVmcWs2i/T3j8DCtRKaJixku0C4ctaMczfKQxb37zyMjGH8Bk3amcNdit/jgnqcKY1NSl4tdRsmBmEVG7u+WIh9gaJiAAV1G2TsNA84uhk+4gXryxGoxgaDAeLNZRYe9PIOmt3EDxMKNCqEIxfEPG3BTCzUJB7Epcz4u45+6UuyMxtAFZ2Uxcn74y+FqzPOElZoPSHFQrKlGSIrNDsrMO4tWQDaoaGswcsmoJTNN55wOez1mIkwRCNzYrGGAnDB7czrR+z33jNWnZCiokJs6eZTHitiGgDU2QbvMQgECHmW5n2ph3rg1i9zXZOVnq1EBRHJLtUR2q11JmFbjYd75KnbL9bbNzq3BvGmepdtwosc6Ct+Sj3gS/RDZbqt+6c3ujAei1dSmY8DLzqD9Ju8Fr2CJQ5G+GwESPCU5YnZeFYPFX+Df2AMm61+LLpo60FGiIt9stt3zI8MppyHSa2Zj5lAYmga9s979yMNLO2FLqzc3Fp79+6XqFLJi2g== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Dec 2023 14:59:10.6647 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 49468247-639b-46b2-d340-08dbfa59bb7e X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EDD5.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6444 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: e6EtSkjItOfQtB7NL5C5U7vMx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1702306756226100001 Content-Type: text/plain; charset="utf-8" From: Abner Chang Remedy Redfish service discovery flow changes made in commit 8736b8fd. The above fix creates the dependency with SMBIOS 42h record, which has a problem as SMBIOS 42h may not be created when RedfishDiscovery.Supported() is invoked even all of the required protocols are ready on the ControllerHandle. We can=E2=80=99t guarantee SMBIOS 42 structure will be always created before ConnectController(). USB NIC maybe detected late and it means PlatformHostInterfaceBmcUsbNicLib can populate SMBIOS 42h information late as well. Calling to RedfishServiceGetNetworkInterface with the previous fix may result in no network interface for BMC-exposed NIC as SMBIOS 42h is not ready yet.This is the first issue. Second, to skip the network interface when NetworkInterfaceGetSubnetInfo() returns a failure also has problem, as the NIC may be configured via RestEx->Configure(). This happens after the Host interface is discovered, as at this moment we have the sufficient network information to configure BMC-exposed NIC. Base on Redfish spec in 31.1.5.2, =E2=80=9CEFI Redfish Client may provide selection UI of network interfaces for Redfish service discovery.", This means edk2 Redfish client gets all network interfaces through RedfishServiceGetNetworkInterface and choose the desired network interface at its discretion for Redfish service. So the fix here is: 1. In BuildNetworkInterface(), we don=E2=80=99t skip any network interface. In RedfishServiceGetNetworkInterface, we don=E2=80=99t skip any network interface even the subnet information is not retrieved. We will still return all of network interfaces to client. 2. In RedfishServiceAcquireService for EFI_REDFISH_RISCOVER_HOST_INTERFACE case, we don=E2=80=99t skip any network interface even the subnet information is not retrieved. 3. Added some more debug information. Note: The subnet information is used for the scenario the system is managed by a centralized Redfish service (not on BMC), says the multiple Redfish computer system instances. As it mentions in 31.1.5.2, Redfish client they may have to know the subnet information so they can know the network domain the NIC is connected. There may have multiple subnets in the corporation network environment. So the subnet information provides client an idea when they choose the network interface, so does VLAN ID. Change-Id: Ibb38ddcd17459ad4b23fcb4fcd8a771a0f63987a Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Cc: Mike Maslenkin --- .../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 109 +++++++----------- 1 file changed, 39 insertions(+), 70 deletions(-) diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c b/RedfishPk= g/RedfishDiscoverDxe/RedfishDiscoverDxe.c index 833ae2b969f..06d8d00da7f 100644 --- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c @@ -487,43 +487,6 @@ CheckIsIpVersion6 ( return FALSE; } =20 -/** - This function returns the IP type supported by the Host Interface. - - @retval 00h is Unknown - 01h is Ipv4 - 02h is Ipv6 - -**/ -STATIC -UINT8 -GetHiIpProtocolType ( - VOID - ) -{ - EFI_STATUS Status; - REDFISH_OVER_IP_PROTOCOL_DATA *Data; - REDFISH_INTERFACE_DATA *DeviceDescriptor; - - Data =3D NULL; - DeviceDescriptor =3D NULL; - if (mSmbios =3D=3D NULL) { - Status =3D gBS->LocateProtocol (&gEfiSmbiosProtocolGuid, NULL, (VOID *= *)&mSmbios); - if (EFI_ERROR (Status)) { - return REDFISH_HOST_INTERFACE_HOST_IP_ADDRESS_FORMAT_UNKNOWN; - } - } - - Status =3D RedfishGetHostInterfaceProtocolData (mSmbios, &DeviceDescript= or, &Data); // Search for SMBIOS type 42h - if (!EFI_ERROR (Status) && (Data !=3D NULL) && - (Data->HostIpAssignmentType =3D=3D RedfishHostIpAssignmentStatic)) - { - return Data->HostIpAddressFormat; - } - - return REDFISH_HOST_INTERFACE_HOST_IP_ADDRESS_FORMAT_UNKNOWN; -} - /** Check if Network Protocol Type matches with SMBIOS Type 42 IP Address Ty= pe. =20 @@ -583,7 +546,10 @@ DiscoverRedfishHostInterface ( } =20 Status =3D RedfishGetHostInterfaceProtocolData (mSmbios, &DeviceDescript= or, &Data); // Search for SMBIOS type 42h - if (!EFI_ERROR (Status) && (Data !=3D NULL) && (DeviceDescriptor !=3D NU= LL)) { + if (EFI_ERROR (Status) || (Data =3D=3D NULL) || (DeviceDescriptor =3D=3D= NULL)) { + DEBUG ((DEBUG_ERROR, "%a: RedfishGetHostInterfaceProtocolData is faile= d.\n", __func__)); + return Status; + } else { // Check IP Type and skip an unnecessary network protocol if does not = match if (FilterProtocol (Instance->NetworkInterface->NetworkProtocolType, D= ata->HostIpAddressFormat)) { return EFI_UNSUPPORTED; @@ -675,6 +641,9 @@ DiscoverRedfishHostInterface ( IsHttps =3D FALSE; if (Data->RedfishServiceIpPort =3D=3D 443) { IsHttps =3D TRUE; + DEBUG ((DEBUG_MANAGEABILITY, "Redfish service port: 443\n")); + } else { + DEBUG ((DEBUG_MANAGEABILITY, "Redfish service port: 80\n")); } =20 StrSize =3D sizeof (UuidStr); @@ -737,8 +706,6 @@ DiscoverRedfishHostInterface ( IsHttps ); } - } else { - DEBUG ((DEBUG_ERROR, "%a: RedfishGetHostInterfaceProtocolData is faile= d.\n", __func__)); } =20 return Status; @@ -1015,9 +982,11 @@ AddAndSignalNewRedfishService ( (EFI_REST_EX_CONFIG_DATA)(UINT8 *)RestExHttpConfi= gData ); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a:REST EX configured..\n", __func__)); + DEBUG ((DEBUG_ERROR, "%a: REST EX is not configured..\n", __func__= )); DeleteRestEx =3D TRUE; goto EXIT_FREE_ALL; + } else { + DEBUG ((DEBUG_MANAGEABILITY, "%a: REST EX is configured..\n", __fu= nc__)); } =20 // @@ -1207,6 +1176,8 @@ RedfishServiceGetNetworkInterface ( EFI_REDFISH_DISCOVER_NETWORK_INTERFACE *ThisNetworkInterface; EFI_REDFISH_DISCOVER_REST_EX_INSTANCE_INTERNAL *RestExInstance; =20 + DEBUG ((DEBUG_MANAGEABILITY, "%a: Entry.\n", __func__)); + if ((This =3D=3D NULL) || (NetworkIntfInstances =3D=3D NULL) || (NumberO= fNetworkIntfs =3D=3D NULL) || (ImageHandle =3D=3D NULL)) { @@ -1242,31 +1213,27 @@ RedfishServiceGetNetworkInterface ( =20 ThisNetworkInterfaceIntn =3D (EFI_REDFISH_DISCOVER_NETWORK_INTERFACE_INT= ERNAL *)GetFirstNode (&mEfiRedfishDiscoverNetworkInterface); while (TRUE) { - // If Get Subnet Info failed then skip this interface - Status =3D NetworkInterfaceGetSubnetInfo (ThisNetworkInterfaceIntn, Im= ageHandle); // Get subnet info - if (EFI_ERROR (Status)) { - if (IsNodeAtEnd (&mEfiRedfishDiscoverNetworkInterface, &ThisNetworkI= nterfaceIntn->Entry)) { - break; - } - - ThisNetworkInterfaceIntn =3D (EFI_REDFISH_DISCOVER_NETWORK_INTERFACE= _INTERNAL *)GetNextNode (&mEfiRedfishDiscoverNetworkInterface, &ThisNetwork= InterfaceIntn->Entry); - continue; - } - ThisNetworkInterface->IsIpv6 =3D FALSE; if (CheckIsIpVersion6 (ThisNetworkInterfaceIntn)) { ThisNetworkInterface->IsIpv6 =3D TRUE; } =20 CopyMem ((VOID *)&ThisNetworkInterface->MacAddress, &ThisNetworkInterf= aceIntn->MacAddress, ThisNetworkInterfaceIntn->HwAddressSize); - if (!ThisNetworkInterface->IsIpv6) { - IP4_COPY_ADDRESS (&ThisNetworkInterface->SubnetId.v4, &ThisNetworkIn= terfaceIntn->SubnetAddr.v4); // IPv4 subnet information. - } else { - IP6_COPY_ADDRESS (&ThisNetworkInterface->SubnetId.v6, &ThisNetworkIn= terfaceIntn->SubnetAddr.v6); // IPv6 subnet information in IPv6 address inf= ormation. + // + // If Get Subnet Info failed then skip this interface + // + Status =3D NetworkInterfaceGetSubnetInfo (ThisNetworkInterfaceIntn, Im= ageHandle); // Get subnet info + if (!EFI_ERROR (Status)) { + if (!ThisNetworkInterface->IsIpv6) { + IP4_COPY_ADDRESS (&ThisNetworkInterface->SubnetId.v4, &ThisNetwork= InterfaceIntn->SubnetAddr.v4); // IPv4 subnet information. + } else { + IP6_COPY_ADDRESS (&ThisNetworkInterface->SubnetId.v6, &ThisNetwork= InterfaceIntn->SubnetAddr.v6); // IPv6 subnet information in IPv6 address i= nformation. + } + + ThisNetworkInterface->SubnetPrefixLength =3D ThisNetworkInterfaceInt= n->SubnetPrefixLength; } =20 - ThisNetworkInterface->SubnetPrefixLength =3D ThisNetworkInterfaceIntn-= >SubnetPrefixLength; - ThisNetworkInterface->VlanId =3D ThisNetworkInterfaceIntn-= >VlanId; + ThisNetworkInterface->VlanId =3D ThisNetworkInterfaceIntn->VlanId; RestExInstance->NumberOfNetworkInterfaces++; if (IsNodeAtEnd (&mEfiRedfishDiscoverNetworkInterface, &ThisNetworkInt= erfaceIntn->Entry)) { break; @@ -1378,9 +1345,16 @@ RedfishServiceAcquireService ( // Status1 =3D NetworkInterfaceGetSubnetInfo (TargetNetworkInterfaceInt= ernal, ImageHandle); if (EFI_ERROR (Status1)) { - DEBUG ((DEBUG_ERROR, "%a: Get subnet information fail.\n", __func_= _)); - FreePool (Instance); - continue; + // + // Get subnet information could be failed for EFI_REDFISH_DISCOVER= _HOST_INTERFACE case. + // We will configure network in AddAndSignalNewRedfishService. So = don't skip this + // target network interface. + // + if ((Flags & EFI_REDFISH_DISCOVER_HOST_INTERFACE) =3D=3D 0) { + DEBUG ((DEBUG_ERROR, "%a: Get subnet information fail.\n", __fun= c__)); + FreePool (Instance); + continue; + } } =20 NewInstance =3D TRUE; @@ -1448,6 +1422,7 @@ RedfishServiceAbortAcquire ( IN EFI_REDFISH_DISCOVER_NETWORK_INTERFACE *TargetNetworkInterface OPTIO= NAL ) { + DEBUG ((DEBUG_MANAGEABILITY, "%a: Entry.\n", __func__)); // This function is used to abort Redfish service discovery through SSDP // on the network interface. SSDP is optionally suppoted by EFI_REDFISH_= DISCOVER_PROTOCOL, // we dont have implementation for SSDP now. @@ -1477,6 +1452,8 @@ RedfishServiceReleaseService ( EFI_REDFISH_DISCOVERED_INSTANCE *ThisRedfishInstance; EFI_REDFISH_DISCOVERED_INTERNAL_LIST *DiscoveredRedfishInstance; =20 + DEBUG ((DEBUG_MANAGEABILITY, "%a: Entry.\n", __func__)); + if (IsListEmpty (&mRedfishInstanceList)) { DEBUG ((DEBUG_ERROR, "%a:No any discovered Redfish service.\n", __func= __)); return EFI_NOT_FOUND; @@ -1723,22 +1700,13 @@ BuildupNetworkInterface ( EFI_REDFISH_DISCOVER_REST_EX_INSTANCE_INTERNAL *RestExInstance; EFI_TPL OldTpl; BOOLEAN NewNetworkInterfaceInst= alled; - UINT8 IpType; UINTN ListCount; =20 ListCount =3D (sizeof (mRequiredProtocol) / sizeof (R= EDFISH_DISCOVER_REQUIRED_PROTOCOL)); NewNetworkInterfaceInstalled =3D FALSE; Index =3D 0; =20 - // Get IP Type to filter out unnecessary network protocol if possible - IpType =3D GetHiIpProtocolType (); - for (Index =3D 0; Index < ListCount; Index++) { - // Check IP Type and skip an unnecessary network protocol if does not = match - if (FilterProtocol (mRequiredProtocol[Index].ProtocolType, IpType)) { - continue; - } - Status =3D gBS->OpenProtocol ( // Already in list? ControllerHandle, @@ -2164,6 +2132,7 @@ RedfishDiscoverDriverBindingStart ( IN EFI_DEVICE_PATH_PROTOCOL *RemainingDevicePath OPTIONAL ) { + DEBUG ((DEBUG_MANAGEABILITY, "%a:Entry.\n", __func__)); return BuildupNetworkInterface (This, ControllerHandle); } =20 --=20 2.37.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112303): https://edk2.groups.io/g/devel/message/112303 Mute This Topic: https://groups.io/mt/103109949/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-