1. Patchew
  2. EDK2
  3. View series

[edk2-devel] [PATCH 0/4] Add DEBUG_MANAGEABILITY to debug level comments

Rebecca Cran via groups.io posted 4 patches 4 months, 3 weeks ago
Failed in applying to current master (apply log)
MdePkg/MdePkg.dec                 |  1 +
ArmVirtPkg/ArmVirt.dsc.inc        | 42 ++++++++++----------
MdePkg/Include/Library/DebugLib.h |  4 +-
MdePkg/MdePkg.uni                 |  2 +
4 files changed, 27 insertions(+), 22 deletions(-)
[edk2-devel] [PATCH 0/4] Add DEBUG_MANAGEABILITY to debug level comments
Posted by Rebecca Cran via groups.io 4 months, 3 weeks ago 
Add the new DEBUG_MANAGEABILITY debug level to MdePkg.dec and MdePkg.uni.

Improve the wording of the description of the DEBUG_MANAGEABILITY level in
DebugLib.h.

Update the comment block in ArmVirtPkg.dsc.inc with the new list and updated
formatting.


Rebecca Cran (4):
  MdePkg: Improve wording of manageability debug level comment
  MdePkg: Add manageability debug level to PcdFixedDebugPrintErrorLevel
  MdePkg: Update MdePkg.uni with manageability debug level
  ArmVirtPkg: Sync debug level comments in ArmVirt.dsc.inc

 MdePkg/MdePkg.dec                 |  1 +
 ArmVirtPkg/ArmVirt.dsc.inc        | 42 ++++++++++----------
 MdePkg/Include/Library/DebugLib.h |  4 +-
 MdePkg/MdePkg.uni                 |  2 +
 4 files changed, 27 insertions(+), 22 deletions(-)

-- 
2.34.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112243): https://edk2.groups.io/g/devel/message/112243
Mute This Topic: https://groups.io/mt/103066384/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 0/4] Add DEBUG_MANAGEABILITY to debug level comments
Posted by Michael D Kinney 4 months, 3 weeks ago 
Series Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>


> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca
> Cran via groups.io
> Sent: Friday, December 8, 2023 4:20 PM
> To: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>; Ard
> Biesheuvel <ardb+tianocore@kernel.org>; Laszlo Ersek
> <lersek@redhat.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Sami
> Mujawar <sami.mujawar@arm.com>; Gerd Hoffmann <kraxel@redhat.com>
> Cc: Rebecca Cran <rebecca@os.amperecomputing.com>; devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH 0/4] Add DEBUG_MANAGEABILITY to debug level
> comments
> 
> Add the new DEBUG_MANAGEABILITY debug level to MdePkg.dec and
> MdePkg.uni.
> 
> Improve the wording of the description of the DEBUG_MANAGEABILITY level
> in
> DebugLib.h.
> 
> Update the comment block in ArmVirtPkg.dsc.inc with the new list and
> updated
> formatting.
> 
> 
> Rebecca Cran (4):
>   MdePkg: Improve wording of manageability debug level comment
>   MdePkg: Add manageability debug level to PcdFixedDebugPrintErrorLevel
>   MdePkg: Update MdePkg.uni with manageability debug level
>   ArmVirtPkg: Sync debug level comments in ArmVirt.dsc.inc
> 
>  MdePkg/MdePkg.dec                 |  1 +
>  ArmVirtPkg/ArmVirt.dsc.inc        | 42 ++++++++++----------
>  MdePkg/Include/Library/DebugLib.h |  4 +-
>  MdePkg/MdePkg.uni                 |  2 +
>  4 files changed, 27 insertions(+), 22 deletions(-)
> 
> --
> 2.34.1
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112247): https://edk2.groups.io/g/devel/message/112247
Mute This Topic: https://groups.io/mt/103066384/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076/xyzzy [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 0/4] Add DEBUG_MANAGEABILITY to debug level comments
Posted by Rebecca Cran via groups.io 4 months, 3 weeks ago 
On 12/8/2023 5:19 PM, Rebecca Cran wrote:
> Add the new DEBUG_MANAGEABILITY debug level to MdePkg.dec and MdePkg.uni.
> 
> Improve the wording of the description of the DEBUG_MANAGEABILITY level in
> DebugLib.h.
> 
> Update the comment block in ArmVirtPkg.dsc.inc with the new list and updated
> formatting.

PR: https://github.com/tianocore/edk2/pull/5127

-- 
Rebecca Cran


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112246): https://edk2.groups.io/g/devel/message/112246
Mute This Topic: https://groups.io/mt/103066384/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 0/4] Add DEBUG_MANAGEABILITY to debug level comments
Posted by Laszlo Ersek 4 months, 2 weeks ago 
On 12/9/23 01:33, Rebecca Cran via groups.io wrote:
> On 12/8/2023 5:19 PM, Rebecca Cran wrote:
>> Add the new DEBUG_MANAGEABILITY debug level to MdePkg.dec and MdePkg.uni.
>>
>> Improve the wording of the description of the DEBUG_MANAGEABILITY
>> level in
>> DebugLib.h.
>>
>> Update the comment block in ArmVirtPkg.dsc.inc with the new list and
>> updated
>> formatting.
> 
> PR: https://github.com/tianocore/edk2/pull/5127

... commenting only because I was CC'd:

Please confirm on the list whenever a series is merged; it saves time
for reviewers.

(This problem should disappear once we move reviews to github.com, but
until then, a short confirmation on-list can prevent wasted time.)

For the record: commit range
5b5481526fc9b89e5f3843d9bb3d6c4f5ce41060..aa2f32cefa567133d94d574672a4479e004211ee.

Thanks!
Laszlo



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112351): https://edk2.groups.io/g/devel/message/112351
Mute This Topic: https://groups.io/mt/103066384/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076/xyzzy [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 0/4] Add DEBUG_MANAGEABILITY to debug level comments
Posted by Rebecca Cran 4 months, 2 weeks ago 
On 12/11/2023 6:17 PM, Laszlo Ersek wrote:
> On 12/9/23 01:33, Rebecca Cran via groups.io wrote:
>> On 12/8/2023 5:19 PM, Rebecca Cran wrote:
>>> Add the new DEBUG_MANAGEABILITY debug level to MdePkg.dec and MdePkg.uni.
>>>
>>> Improve the wording of the description of the DEBUG_MANAGEABILITY
>>> level in
>>> DebugLib.h.
>>>
>>> Update the comment block in ArmVirtPkg.dsc.inc with the new list and
>>> updated
>>> formatting.
>>
>> PR: https://github.com/tianocore/edk2/pull/5127
> 
> ... commenting only because I was CC'd:
> 
> Please confirm on the list whenever a series is merged; it saves time
> for reviewers.
> 
> (This problem should disappear once we move reviews to github.com, but
> until then, a short confirmation on-list can prevent wasted time.)
> 
> For the record: commit range
> 5b5481526fc9b89e5f3843d9bb3d6c4f5ce41060..aa2f32cefa567133d94d574672a4479e004211ee.

Oh, thanks! I was meaning to do that but forgot between setting the 
'push' label and waiting for CI to complete.


-- 
Rebecca Cran


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112352): https://edk2.groups.io/g/devel/message/112352
Mute This Topic: https://groups.io/mt/103066384/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.