From nobody Mon May 13 08:02:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+111922+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+111922+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1701386336; cv=none; d=zohomail.com; s=zohoarc; b=Rz3hfAuwm/VZARffv5ZGhz4cgZ+uItU43ITudf5Fr1JYMuQpzP3vIH8tG94rUFySJFlE2AQH3IahDilCb1iYwsMNqP3vjCiOZILzJRdwTCdixl3s19Xo8cTg6jSWVjpcIezxgz9zqJLJJn7sQ9PWsFpfkcX2b92BrnLVIXXr/+I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1701386336; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=jqrbwJmR1cqP+3ybHs+qFqRB3/LFmbtaYGIIv75sSPs=; b=g6i1R4vBsAKlRQz0S8mdYsI3lRzVrIHfHiSeJisElfpZ7YL0AEIzsXT5mcPZhF2vXnQwxRwkSXHq0c/MlYcMSP/KfQ44FtpeN/ltqdps+CpUB3WD0qwvh+0kVjggnd6Yrccz5Vk/zAjIs9MUzXHymlLbHREPuNRJ8nBJFJ0KrQM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+111922+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1701386336955553.3961640072687; Thu, 30 Nov 2023 15:18:56 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=jqrbwJmR1cqP+3ybHs+qFqRB3/LFmbtaYGIIv75sSPs=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1701386336; v=1; b=M9ZurqaSyg691Nq5PNQzrbIEzGJQ4jnio3KnMWmZ84jUQK4RqxwY9lGn9F6IqR0cjrzcKIO9 tVYCa81jLJbaxKlR4yZwcUwQoN4e6i6XUCAelc6YpPB9/oXAeyx+Az2Q9yRnY5DaSzL/G0Rdazf gQWnPEn14PhonpT803gOyBhE= X-Received: by 127.0.0.2 with SMTP id 80ljYY1788612xRDbNs7qg3x; Thu, 30 Nov 2023 15:18:56 -0800 X-Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) by mx.groups.io with SMTP id smtpd.web11.10070.1701386335525631379 for ; Thu, 30 Nov 2023 15:18:55 -0800 X-Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-50bca79244fso2149201e87.3 for ; Thu, 30 Nov 2023 15:18:55 -0800 (PST) X-Gm-Message-State: szrvhZ7nUlLrBKvBXJfbsLYvx1787277AA= X-Google-Smtp-Source: AGHT+IHIZk9lM6nqCp2CSlyo9rd7KLKLdXhISpgDNkPp9aAmITBEIGAR4l4pi/Zzwd3FMmqZG5X5RA== X-Received: by 2002:a05:6512:48ce:b0:50b:d764:76f0 with SMTP id er14-20020a05651248ce00b0050bd76476f0mr173529lfb.127.1701386333566; Thu, 30 Nov 2023 15:18:53 -0800 (PST) X-Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id x8-20020ac24888000000b0050bc1cc5f62sm272430lfc.174.2023.11.30.15.18.52 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 30 Nov 2023 15:18:53 -0800 (PST) From: "Mike Maslenkin" To: devel@edk2.groups.io Cc: abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com Subject: [edk2-devel] [PATCH 1/3] RedfishClientPkg: fix misleading texts in debug traces. Date: Fri, 1 Dec 2023 02:18:42 +0300 Message-Id: <20231130231844.22397-2-mike.maslenkin@gmail.com> In-Reply-To: <20231130231844.22397-1-mike.maslenkin@gmail.com> References: <20231130231844.22397-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1701386338965000013 Content-Type: text/plain; charset="utf-8" Update debug traces with the correct function names. Signed-off-by: Mike Maslenkin Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Reviewed-by: Nickle Wang --- RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c | 4 ++-- .../ComputerSystem/v1_5_0/Common/ComputerSystemCommon.c | 4 ++-- RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.c | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c b/Re= dfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c index ea2740184160..a26a1083cd74 100644 --- a/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c +++ b/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c @@ -553,7 +553,7 @@ RedfishCheckResourceCommon ( =20 Status =3D RedfishPlatformConfigGetConfigureLang (RESOURCE_SCHEMA, RESOU= RCE_SCHEMA_VERSION, REDPATH_ARRAY_PATTERN, &ConfigureLangList, &Count); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a, BiosConfigToRedfishGetConfigureLangRegex fai= led: %r\n", __func__, Status)); + DEBUG ((DEBUG_ERROR, "%a, RedfishPlatformConfigGetConfigureLang failed= : %r\n", __func__, Status)); return Status; } =20 @@ -720,7 +720,7 @@ RedfishIdentifyResourceCommon ( if (Supported) { Status =3D RedfishFeatureGetUnifiedArrayTypeConfigureLang (RESOURCE_SC= HEMA, RESOURCE_SCHEMA_VERSION, REDPATH_ARRAY_PATTERN, &ConfigLangList); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a, BiosConfigToRedfishGetConfigureLangRegex f= ailed: %r\n", __func__, Status)); + DEBUG ((DEBUG_ERROR, "%a, RedfishFeatureGetUnifiedArrayTypeConfigure= Lang failed: %r\n", __func__, Status)); return Status; } =20 diff --git a/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Common/Compute= rSystemCommon.c b/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Common/Co= mputerSystemCommon.c index 78beb5cb32b3..979d49f79234 100644 --- a/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Common/ComputerSystem= Common.c +++ b/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Common/ComputerSystem= Common.c @@ -1457,7 +1457,7 @@ RedfishCheckResourceCommon ( =20 Status =3D RedfishPlatformConfigGetConfigureLang (RESOURCE_SCHEMA, RESOU= RCE_SCHEMA_VERSION, REDPATH_ARRAY_PATTERN, &ConfigureLangList, &Count); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a, BiosConfigToRedfishGetConfigureLangRegex fai= led: %r\n", __func__, Status)); + DEBUG ((DEBUG_ERROR, "%a, RedfishPlatformConfigGetConfigureLang failed= : %r\n", __func__, Status)); return Status; } =20 @@ -1591,7 +1591,7 @@ RedfishIdentifyResourceCommon ( if (Supported) { Status =3D RedfishFeatureGetUnifiedArrayTypeConfigureLang (RESOURCE_SC= HEMA, RESOURCE_SCHEMA_VERSION, REDPATH_ARRAY_PATTERN, &ConfigLangList); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a, BiosConfigToRedfishGetConfigureLangRegex f= ailed: %r\n", __func__, Status)); + DEBUG ((DEBUG_ERROR, "%a, RedfishFeatureGetUnifiedArrayTypeConfigure= Lang failed: %r\n", __func__, Status)); return Status; } =20 diff --git a/RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.c = b/RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.c index 44325ddb21c4..14c263011c2a 100644 --- a/RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.c +++ b/RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.c @@ -2373,7 +2373,7 @@ RedfishCheckResourceCommon ( =20 Status =3D RedfishPlatformConfigGetConfigureLang (RESOURCE_SCHEMA, RESOU= RCE_SCHEMA_VERSION, REDPATH_ARRAY_PATTERN, &ConfigureLangList, &Count); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a, BiosConfigToRedfishGetConfigureLangRegex fai= led: %r\n", __func__, Status)); + DEBUG ((DEBUG_ERROR, "%a, RedfishPlatformConfigGetConfigureLang failed= : %r\n", __func__, Status)); return Status; } =20 @@ -2507,7 +2507,7 @@ RedfishIdentifyResourceCommon ( if (Supported) { Status =3D RedfishFeatureGetUnifiedArrayTypeConfigureLang (RESOURCE_SC= HEMA, RESOURCE_SCHEMA_VERSION, REDPATH_ARRAY_PATTERN, &ConfigLangList); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a, BiosConfigToRedfishGetConfigureLangRegex f= ailed: %r\n", __func__, Status)); + DEBUG ((DEBUG_ERROR, "%a, RedfishFeatureGetUnifiedArrayTypeConfigure= Lang failed: %r\n", __func__, Status)); return Status; } =20 --=20 2.32.0 (Apple Git-132) From nobody Mon May 13 08:02:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+111923+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+111923+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1701386337; cv=none; d=zohomail.com; s=zohoarc; b=gpEGc3C/KCok5izEN8IBm0lCywQ2GWDmGlfxST6EJnncHtHyji/S+7hVdlNklZCBSD/dwZOy9vl+p+RYf4HauT7sa9Qnc264xs6zsQpk1UrKYWRcvLrNpmTyHWZrIA2DhKzMObCP/9zsL6FLWjQkFRxneoGSP3KzZOS0JIOEWqM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1701386337; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=5XcXa8iIxkBuMY8RREUePJn7MJi/urbuurM2t+RdSnY=; b=cSVcRI5jwUMo42QCrgTYOy5OS9xj2mJmN73ndXNsAJS4eDnfXBHF2yoRbALMit39n8ofyBwH/WP2sv0/QFQ9slFmP6MPU4G8jGq4qG9Pwu+saOp2MM9BpckZALVs9ggctTlTKrHijIv7xZKGMX16tIcJ4f0Y83ww1899B97iRGQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+111923+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1701386337623481.52760217741286; Thu, 30 Nov 2023 15:18:57 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=5XcXa8iIxkBuMY8RREUePJn7MJi/urbuurM2t+RdSnY=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1701386337; v=1; b=vr9Pe0DSviBRxYkT0jl4KznYtj5tXZHLd8BzoczrkGeT9mBKEYkYeg0LXJNXoAdp2M19l+yD 2OZs6vkZLoA4mhSBVIQQNE7xHZD7+grIEmmv/HqLtvai73Mex6yrYeerzJNLA5K2T5AuhKZa+/f xLtDM05wBzeuzXTYnAApMpos= X-Received: by 127.0.0.2 with SMTP id nev9YY1788612x97ENdy1wmZ; Thu, 30 Nov 2023 15:18:57 -0800 X-Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) by mx.groups.io with SMTP id smtpd.web10.10213.1701386336294550132 for ; Thu, 30 Nov 2023 15:18:56 -0800 X-Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-50bbef0e5d5so2082338e87.1 for ; Thu, 30 Nov 2023 15:18:56 -0800 (PST) X-Gm-Message-State: d9YT9yJOgDrucygPf9ahCY9Cx1787277AA= X-Google-Smtp-Source: AGHT+IEIwkiuchDue/Sqt6lCFszncN+KPVW/qKemtXgatZpwhVhAqVndKdEjJmbx+oy48UBq2ovCtA== X-Received: by 2002:ac2:5585:0:b0:50b:d764:64b9 with SMTP id v5-20020ac25585000000b0050bd76464b9mr179353lfg.110.1701386334349; Thu, 30 Nov 2023 15:18:54 -0800 (PST) X-Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id x8-20020ac24888000000b0050bc1cc5f62sm272430lfc.174.2023.11.30.15.18.53 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 30 Nov 2023 15:18:54 -0800 (PST) From: "Mike Maslenkin" To: devel@edk2.groups.io Cc: abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com Subject: [edk2-devel] [PATCH 2/3] RedfishClientPkg: fix format specifier in DEBUG macro Date: Fri, 1 Dec 2023 02:18:43 +0300 Message-Id: <20231130231844.22397-3-mike.maslenkin@gmail.com> In-Reply-To: <20231130231844.22397-1-mike.maslenkin@gmail.com> References: <20231130231844.22397-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1701386338948000011 Content-Type: text/plain; charset="utf-8" Signed-off-by: Mike Maslenkin Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Reviewed-by: Nickle Wang --- .../Features/MemoryCollectionDxe/MemoryCollectionDxe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/RedfishClientPkg/Features/MemoryCollectionDxe/MemoryCollection= Dxe.c b/RedfishClientPkg/Features/MemoryCollectionDxe/MemoryCollectionDxe.c index dc1ee5ca4143..bebc605dce34 100644 --- a/RedfishClientPkg/Features/MemoryCollectionDxe/MemoryCollectionDxe.c +++ b/RedfishClientPkg/Features/MemoryCollectionDxe/MemoryCollectionDxe.c @@ -45,7 +45,7 @@ HandleResource ( // Check and see if this is target resource that we want to handle. // Some resource is handled by other provider so we have to make sure th= is first. // - DEBUG ((REDFISH_DEBUG_TRACE, "%s Identify for %s\n", __func__, Uri)); + DEBUG ((REDFISH_DEBUG_TRACE, "%a Identify for %s\n", __func__, Uri)); ConfigLang =3D RedfishGetConfigLanguage (Uri); if (ConfigLang =3D=3D NULL) { Status =3D EdkIIRedfishResourceConfigIdentify (&SchemaInfo, Uri, Priva= te->InformationExchange); --=20 2.32.0 (Apple Git-132) From nobody Mon May 13 08:02:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+111924+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+111924+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1701386338; cv=none; d=zohomail.com; s=zohoarc; b=IYM7JJcv4Rqqv0wQHgx24esfPABdC+Zo6OgiwHgMniOt4CnQ3FVG5ch7JmGnnjZj7eywR+TDYE+CsBqD4mE7RvLoIygyHRsPILQGiMrcm6IZlo/ug1nhs1ujC0obpo3vlfBKTLVFiPBf1tng0NSLDz8m6dlRLOw3WZ3izPCoLMk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1701386338; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=4DeGOSXQeL4GI7b+/o/3n2LWzPDuwilEe07d7Gy8Hvw=; b=e5WlHjcvlvcBv5zeg+4PSjSZTtxZHpc3k6Hcqt4ZwoZGdVIpsbBk+PXzlsz8opT2Zanul5A0z+mvWdiMwUBN7G14cqMjj0B3e6G0OCW/zXG8sb02tbKS24BMp4LktWNXogHYuL0utsjfkRdbMBURDUvUnQcLK+Tc4kHgv+ZwN1c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+111924+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1701386338226155.16145779286376; Thu, 30 Nov 2023 15:18:58 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=4DeGOSXQeL4GI7b+/o/3n2LWzPDuwilEe07d7Gy8Hvw=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1701386337; v=1; b=OmRi+I34lFM2RFNq6xnmQ0zhHf5zPiJngelRxn4ekL5hl7Bq4TnaATvr0+znbj/XzwNexQBE IoeKPYae5ZQtem/j7Gm2PLuA5Oq6UkDPaybv2jc3eWQhl5RSaDGu4CxeXZL+i5ID9Sf8RNuiixI MOMgEOl1XeJtuyWAHq0kr0Mw= X-Received: by 127.0.0.2 with SMTP id 5FJ8YY1788612xiwCdXZ9MNu; Thu, 30 Nov 2023 15:18:57 -0800 X-Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) by mx.groups.io with SMTP id smtpd.web11.10071.1701386336950744143 for ; Thu, 30 Nov 2023 15:18:57 -0800 X-Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-50bccc2e3efso1812168e87.0 for ; Thu, 30 Nov 2023 15:18:56 -0800 (PST) X-Gm-Message-State: wnlfoyqyxGk7HhShfPLFbPbDx1787277AA= X-Google-Smtp-Source: AGHT+IE8GqlnoqRTHAt3sLVGjoLGyrdDKjMI67czCtQ/4ZLkq6hGNZt5pOy1HGRQkJDF9K4CNUh8XA== X-Received: by 2002:a05:6512:50e:b0:50b:d763:fe36 with SMTP id o14-20020a056512050e00b0050bd763fe36mr148045lfb.81.1701386335074; Thu, 30 Nov 2023 15:18:55 -0800 (PST) X-Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id x8-20020ac24888000000b0050bc1cc5f62sm272430lfc.174.2023.11.30.15.18.54 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 30 Nov 2023 15:18:54 -0800 (PST) From: "Mike Maslenkin" To: devel@edk2.groups.io Cc: abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com Subject: [edk2-devel] [PATCH 3/3] RedfishClientPkg: warn user about reboot if allowed. Date: Fri, 1 Dec 2023 02:18:44 +0300 Message-Id: <20231130231844.22397-4-mike.maslenkin@gmail.com> In-Reply-To: <20231130231844.22397-1-mike.maslenkin@gmail.com> References: <20231130231844.22397-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1701386338950000012 Content-Type: text/plain; charset="utf-8" Warn user about system reboot only if it has not been rejected by callbacks executed as result of EdkiiRedfishPhaseBeforeReboot notification Signed-off-by: Mike Maslenkin Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Reviewed-by: Nickle Wang --- .../RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c= b/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c index 51d0387ce867..f3188ddfde2c 100644 --- a/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c +++ b/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c @@ -296,9 +296,6 @@ RedfishFeatureDriverStartup ( // If system configuration is changed, reboot system. // if (PcdGetBool (PcdRedfishSystemRebootRequired)) { - Print (L"System configuration is changed from RESTful interface. Reboo= t system in %d seconds...\n", RebootTimeout); - gBS->Stall (RebootTimeout * 1000000U); - // // Call override protocol to notify platform that Redfish is processed // and about to reboot system. @@ -312,9 +309,14 @@ RedfishFeatureDriverStartup ( Status =3D RedfishOverride->NotifyPhase (RedfishOverride, EdkiiRedfi= shPhaseBeforeReboot); if (EFI_ERROR (Status)) { DEBUG ((DEBUG_ERROR, "%a: abort the reboot because NotifyPhase() r= eturns failure: %r\n", __func__, Status)); - return; + PcdSetBoolS (PcdRedfishSystemRebootRequired, FALSE); } } + } + + if (PcdGetBool (PcdRedfishSystemRebootRequired)) { + Print (L"System configuration is changed from RESTful interface. Reboo= t system in %d seconds...\n", RebootTimeout); + gBS->Stall (RebootTimeout * 1000000U); =20 gRT->ResetSystem (EfiResetCold, EFI_SUCCESS, 0, NULL); CpuDeadLoop (); --=20 2.32.0 (Apple Git-132)