From nobody Mon May 13 10:55:28 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+111796+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1701149259232842.2150130663003; Mon, 27 Nov 2023 21:27:39 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=pDa7LXXvPtRFkM7EDkoWKpOAY02R4TdDhkUHFcy1XdQ=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:From:To:CC:Subject:Date:Message-ID:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1701149258; v=1; b=d3mzhrPsQ59XQx/bD0aAH21M4F508dVegA2wVtJv0uzjq/i/Pwd13oDm1qJ1tK4fwa6yQuCH PKfHLJWfS+jJh+hl2DL6KLYRllqMoSyQ0Z923F/GJGXRfSgI6Uvrk1rSxqu22+7l8CMi1/TjOGN y+FcHykF3T78phQXqM7GTB0o= X-Received: by 127.0.0.2 with SMTP id SdJtYY1788612xuD8NuJy7iM; Mon, 27 Nov 2023 21:27:38 -0800 X-Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.43]) by mx.groups.io with SMTP id smtpd.web10.26287.1701149258060697939 for ; Mon, 27 Nov 2023 21:27:38 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J+lQVTO01lpJ30uKczoFEYNDGigVzLvIj5eVY32mmZYTxDyxycUjW+nSFDBNeZxHujhmBNQvMTskNJMtFEwT/IpoL6pWBWWtK2sF4HlVwY1hTFos1EATXSIAUG9ZHz+/ASVufObuS35i57E36A5PZfYZQOp4kroQ5Z7fIzXNdSUcObmfAxMsJo462oLvrVHims64wdUQkBW0UEeiaWNmfhmn9bC8BqMFDNjFE6Yt936+fErp3d7ijpSIaA8BZrIwkTjzj99/oxsjp0tKU/k/ufOtxemlGVrIvPJX5tSdvHRoQ/PGNWjMI285plMKckG95YcFxFTks7kGyCBXhfZFXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NOlE2jQ+MZZy8SVk5/fPQzgNL8d+37Hvef2SpxmL0ls=; b=W1vdVUN2ZA7av1Cdp7HuREy9xjva0MgIaoGjXgk0dil+pxq0G3IsAwQ6BAdcUzkQvaq9CXM4W1D/4Q/rPbK3R4g9+Mq6dX/uNOABUbgXR+/Z7Y6ujBbkIC4N96YZ12DjSQDfGDAKzaHOZhzHO7XqSo8d3H/4HyMjLORRksvetN8i7DpoQMD5cL/YhlIRos8B/r6Xavoc3ET5hekDun6emF4BsBPvXi0JYIutiJ/rkjo69hPv5PJ/6HhDjDuIdKtAqjKoUWhIIBU6TC4qcp0Wy6Dw7A3FeWDeUE3FuGc+EQnSl4VEOsNqSVIdPA0e/Ft21vxqk/i36A+5ybJGSJBF1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) X-Received: from DM6PR04CA0003.namprd04.prod.outlook.com (2603:10b6:5:334::8) by MN2PR12MB4567.namprd12.prod.outlook.com (2603:10b6:208:263::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.29; Tue, 28 Nov 2023 05:27:35 +0000 X-Received: from DS1PEPF0001708E.namprd03.prod.outlook.com (2603:10b6:5:334:cafe::57) by DM6PR04CA0003.outlook.office365.com (2603:10b6:5:334::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.29 via Frontend Transport; Tue, 28 Nov 2023 05:27:35 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+111796+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C X-Received: from SATLEXMB04.amd.com (165.204.84.17) by DS1PEPF0001708E.mail.protection.outlook.com (10.167.17.134) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7046.17 via Frontend Transport; Tue, 28 Nov 2023 05:27:35 +0000 X-Received: from TPE-L1-ABNCHANG.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Mon, 27 Nov 2023 23:27:03 -0600 From: "Chang, Abner via groups.io" To: CC: Nickle Wang , Igor Kulchytskyy , Mike Maslenkin Subject: [edk2-devel] [PATCH] RedfishPkg/HostInterfaceBmcUsbNic: Set default Redfish service port Date: Tue, 28 Nov 2023 13:26:09 +0800 Message-ID: <20231128052609.1232-1-abner.chang@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF0001708E:EE_|MN2PR12MB4567:EE_ X-MS-Office365-Filtering-Correlation-Id: 55568123-243c-4c79-f751-08dbefd2ba8d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: mJy6Xy7I50qE8p0fLU262ytQMxfxL1X90r7yLTxuQgutIMw98pG01wwKzemNJVqGGku2IuG0KogWeBbHfLooDAuYZf5gAeqU5WEToUu80wr3sb7aML3qeqeZbL3nZJ0XXZ8RgPAlKlaGb3XzEFWe+m751OIWVKtOyTmIKk92nzkzr22lI/xT3mHjmJAkSTQyvSKUvQ+M74nK+QN099EQQUPXshVz1G8a1kxB6Ed46fVJWcTYIH+ndKvFlVwqQXN1Iay5jIchVv51xwjAUR/bTld7nkYrhhmThdu/bN5ERmrVOPc+S8SFVgTvclOVM1OqC+pskw5MVswLvkkqsPC8SzpHyjneWQgzeTUZTrjafIbo4KsTncXQ7we/ZhVD8vG+IaJVIaMbVS9DSIcSrjxcmF8MuUcUtg4UqEn6wE/AtZLkowlC7QS1arSM3P2j++Vn/0jEUYO+/jHsqxQhWCAMKi0wnf5SpkFR7/tuWbv7+hYME77BBw56wQB+/vTdGRx2coqLDLZEupUN7SE9dFwtxRRcOq0t2dySkW/8gBOAaLxNqFYFdC6K36e3TlB6oj3qiGGF3jZTM3DJNxvwNbHCY6Utp+e1/gs72+lIl8XJ40wybYNsFL7YtAQ7k8xTcxHeROaKLLfHSptqVeINMyFwcATaqPJeXD2P+75/oepPhZnHzwNK15qPBKx3pj4GrACd48L9JtIxFVdC0LK5wruO1EkzBoDe6qwSmMqHwNZTAqD5HHD/I6THgra3Yd7kFPdr4LHJl/R81OMBilJpZpQc2Lr8u+AEsp06bS8BhnC9z9E= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2023 05:27:35.4313 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 55568123-243c-4c79-f751-08dbefd2ba8d X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF0001708E.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4567 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Lxm2uQArh9GHt5O4Kge1Iz5fx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1701149259564000001 Content-Type: text/plain; charset="utf-8" From: Abner Chang BZ #4607 Create a PCD for the default Redfish service port. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Cc: Mike Maslenkin --- RedfishPkg/RedfishPkg.dec | 8 ++++++-- .../PlatformHostInterfaceBmcUsbNicLib.inf | 1 + .../PlatformHostInterfaceBmcUsbNicLib.c | 2 +- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/RedfishPkg/RedfishPkg.dec b/RedfishPkg/RedfishPkg.dec index e40538247c2..3ea9ff3ef7f 100644 --- a/RedfishPkg/RedfishPkg.dec +++ b/RedfishPkg/RedfishPkg.dec @@ -141,12 +141,16 @@ # specification for that. # gEfiRedfishPkgTokenSpaceGuid.PcdRedfishServiceUuid|L"00000000-0000-0000-= 0000-000000000000"|VOID*|0x00001006 + # Use PCD to declare the Redfish service port, default set to port 443. + # Platform can overide this value in platform DSC file. + # + gEfiRedfishPkgTokenSpaceGuid.PcdRedfishServicePort|443|UINT16|0x00001007 # # This PCD indicates that if BMC bootstrap credential service will be di= sabled by BIOS or not. # - gEfiRedfishPkgTokenSpaceGuid.PcdRedfishDisableBootstrapCredentialService= |FALSE|BOOLEAN|0x00001007 + gEfiRedfishPkgTokenSpaceGuid.PcdRedfishDisableBootstrapCredentialService= |FALSE|BOOLEAN|0x00001008 # # The EFI_REST_EX_HTTP_CONFIG_DATA.SendReceiveTimeout value that Redfish= DiscoverDxe driver # set to EFI_REST_EX_PROTOCOL. # - gEfiRedfishPkgTokenSpaceGuid.PcdRedfishSendReceiveTimeout|5000|UINT32|0x= 00001008 + gEfiRedfishPkgTokenSpaceGuid.PcdRedfishSendReceiveTimeout|5000|UINT32|0x= 00001009 diff --git a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformH= ostInterfaceBmcUsbNicLib.inf b/RedfishPkg/Library/PlatformHostInterfaceBmcU= sbNicLib/PlatformHostInterfaceBmcUsbNicLib.inf index f2c7d7fec89..838a1721a7a 100644 --- a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInte= rfaceBmcUsbNicLib.inf +++ b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInte= rfaceBmcUsbNicLib.inf @@ -43,6 +43,7 @@ [Pcd] gEfiRedfishPkgTokenSpaceGuid.PcdRedfishHostName ## CONSUMED gEfiRedfishPkgTokenSpaceGuid.PcdRedfishServiceUuid ## CONSUMED + gEfiRedfishPkgTokenSpaceGuid.PcdRedfishServicePort ## CONSUMED =20 [Depex] gIpmiProtocolGuid diff --git a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformH= ostInterfaceBmcUsbNicLib.c b/RedfishPkg/Library/PlatformHostInterfaceBmcUsb= NicLib/PlatformHostInterfaceBmcUsbNicLib.c index 2938d54da65..7f295fe7f1c 100644 --- a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInte= rfaceBmcUsbNicLib.c +++ b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInte= rfaceBmcUsbNicLib.c @@ -244,7 +244,7 @@ RedfishPlatformHostInterfaceProtocolData ( ); =20 // RedfishServiceIpPort - RedfishOverIpData->RedfishServiceIpPort =3D 0; + RedfishOverIpData->RedfishServiceIpPort =3D PcdGet16 (PcdRedfishServ= icePort); =20 // RedfishServiceVlanId RedfishOverIpData->RedfishServiceVlanId =3D ThisInstance->VLanId; --=20 2.37.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111796): https://edk2.groups.io/g/devel/message/111796 Mute This Topic: https://groups.io/mt/102845949/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-