From nobody Sun May 12 00:22:36 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+111669+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 170074880940878.25879274080933; Thu, 23 Nov 2023 06:13:29 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=FysYmX0xKXScPeZEgNORab9kjZiweqIbyez4Pn2Qf2k=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:From:To:CC:Subject:Date:Message-ID:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1700748808; v=1; b=gTJbZOvVmo+KAeuim/+VdtTnUccDKeIWWU01hUcRaITbPIBJ5tMo9z2hUwXyU4+pZcUSd4KK tOT4a4VfVCrjwEzmq0pYMkbX8ykXO2wBJvhSDM7SoNMfm/jWQHBw0tpcZ6wPpVXOHiofRl0LiDi sQqdZSvUf9e4DpVeBu5tmxN4= X-Received: by 127.0.0.2 with SMTP id 4iTBYY1788612x9LYPZTUEDW; Thu, 23 Nov 2023 06:13:28 -0800 X-Received: from NAM11-DM6-obe.outbound.protection.outlook.com (NAM11-DM6-obe.outbound.protection.outlook.com [40.107.223.64]) by mx.groups.io with SMTP id smtpd.web11.91819.1700748808214684299 for ; Thu, 23 Nov 2023 06:13:28 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JIW6XX2cQNyN2ONxNnMpkgv2TvMr5JUmChXIcYrgPVrsKwBXqbnjVD83Thz2E+7bE1t1cDQ0w4fFkyTGHbArpqmjd1naF8OgTcD8WI+dX5vnhlAjYyTxkOBycsXeilZme37XNB9vNMII90eTa232/Jck+8Y5tunzOXFVWSKevXFLjeU93kriMhJQA76cxnwLsu/f+OmQOnIRG8Hk2khaeE+2gleVxMrqkQjm4S1rRuRMKTrcjl+0PGnIv/GNeBHXrI1m+xz092CuhLNaw2K98qx8FzrwjTFxK2RzbY7MIkCNIEzoiFvi4mCmoKKvZJM6DNDFz8Jnv8v7KxH+mFvsgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pSnxHER6CqiNMl8HtTsH+umma4x/qvlGZiAbTl6GygA=; b=KF+IltazIFEPESXPsRigaIzOR+YjjCAMZBWDXxaIDj7UaZ0nWbQSZtrV0JNAfSZmgE+lpQOezWJakIJuA+S1gefNhYQ9BQ7dbJju56EWhKSjhsk468Y++TqYgTUzuIzsrPhBXX5lCwFNH3+gk8Q5uaqyt/CNl9g3Oh+TN718FXqyGrURJ6xHkiWb9wriJX+dfS6bt6+YAFNI+JXbJvxQAJgMATT95r94b+tEqRGe4bKgn8imVH8WfoAa3gufzs0pLVtcuxO2IGnlbpms0RWb9Etw9K4NxgEMBZHAa6ps7KbqTTJk5GewmkHSFaGoxtTuVKcrrA8udP68LQhr3HQ26w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) X-Received: from CYZPR20CA0001.namprd20.prod.outlook.com (2603:10b6:930:a2::26) by SA3PR12MB7784.namprd12.prod.outlook.com (2603:10b6:806:317::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.18; Thu, 23 Nov 2023 14:13:24 +0000 X-Received: from CY4PEPF0000E9DC.namprd05.prod.outlook.com (2603:10b6:930:a2:cafe::47) by CYZPR20CA0001.outlook.office365.com (2603:10b6:930:a2::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.20 via Frontend Transport; Thu, 23 Nov 2023 14:13:23 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+111669+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C X-Received: from mail.nvidia.com (216.228.117.161) by CY4PEPF0000E9DC.mail.protection.outlook.com (10.167.241.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.12 via Frontend Transport; Thu, 23 Nov 2023 14:13:23 +0000 X-Received: from rnnvmail205.nvidia.com (10.129.68.10) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Thu, 23 Nov 2023 06:13:10 -0800 X-Received: from rnnvmail203.nvidia.com (10.129.68.9) by rnnvmail205.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Thu, 23 Nov 2023 06:13:09 -0800 X-Received: from NV-CL38DL3.nvidia.com (10.127.8.12) by mail.nvidia.com (10.129.68.9) with Microsoft SMTP Server id 15.2.986.41 via Frontend Transport; Thu, 23 Nov 2023 06:13:08 -0800 From: "Nickle Wang via groups.io" To: CC: Abner Chang , Igor Kulchytskyy , "Nick Ramirez" Subject: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/ComputerSystemCollectionDxe: handle more scenarios Date: Thu, 23 Nov 2023 22:13:07 +0800 Message-ID: <20231123141307.32052-1-nicklew@nvidia.com> MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9DC:EE_|SA3PR12MB7784:EE_ X-MS-Office365-Filtering-Correlation-Id: 54ea4112-cb4d-49de-38dd-08dbec2e5ac3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: 5j3MiK54tWtm/+MG5kAxyb3UcJkTqXKUO/UcNYAkxdCWxV9xZ0lGeDwNNar8z9layNuUsOCotWbxZ26waVYv1lA/TsJG+sOXkuF1gWFhNblz0/A3pxU7kaw1t13OdRjjexCe6KsVpmPoAeuoRg2Ff1FYfJD3USCuerPAjS3s8FhDsxw6tc223lhZpQFrC6DPlFVo7/4swhssJ16m3hgoRoxTTYEVqXxBV5m9KvSisGHK74Z1UwnGA1ANnKxEUPihy2E8G5rDhekx4W4ljhYifFYNotLHGRrDsrNHYdzzuQniHs5/F6TZ7ZKcePWmY0gViFSpw+Rn3MR3F5NQYRhEZUbIq/0/YD0qst4WJuvoA6cCF7c04eINP3+1Gg5oCk9aRK8PSs1lbs/kpEcxVjeBFnQHNuvTthSsdW23jKloYnX/BkcPza+0Ju7evQulCAk9wJ4BgujDHmE4FaOsAxGofgFv+ulKjwZmVLxmcCXXd/u8fMM0dbZpZjHeIALXdzXJQBeu8Cq5BUR7sXinIjejfAgGPf6Nz6IdbStq278QOEjXnA8AzMIa8JUi4+jvH7ZeDtuyO1bnYO0Zl07Jvgsn1xR/1H9F26B7nkSjxfFibojlGmDugeKMlBvTN8vk4Mg62OptR50GjbvHSgdD1k8b/OiZT33QGW9+TfO94+1qjCzUQgQRGm4m2//5bUTi6SmmuzwFIgWeMUhng83YltkwOWjUEnj5lCN3No8jUG/uJF9TaxqT6jhQIbcnoYaZYIi1 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2023 14:13:23.6888 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 54ea4112-cb4d-49de-38dd-08dbec2e5ac3 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9DC.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB7784 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nicklew@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 4zf76bcLwm5q6W5gK4iNzZF7x1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1700748810005100001 Content-Type: text/plain; charset="utf-8" This change defines two more error returns and allow feature driver to handle the scenarios while 1) the resource is not owned by feature driver. 2) feature driver owns this resource but there is nothing to manage on this resource now. Detail changes are: - Use "%a:" instead of "%a," in debug macro. - Add two error return from EdkIIRedfishResourceConfigIdentify(). - EFI_UNSUPPORTED: this resource is not owned by feature driver. Caller should ignore this resource. - EFI_NOT_FOUND: this resource is owned by feature driver but there is nothing to handle now. Caller may ignore rest of operations and proceed to next Redfish resource. - Add error return from EdkIIRedfishResourceConfigCheck(). - EFI_UNSUPPORTED: this resource it not owned by feature driver. Caller should ignore this URI. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Reviewed-by: Abner Chang --- .../Library/EdkIIRedfishResourceConfigLib.h | 9 ++- .../ComputerSystemCollectionDxe.c | 59 +++++++++++-------- 2 files changed, 43 insertions(+), 25 deletions(-) diff --git a/RedfishClientPkg/Include/Library/EdkIIRedfishResourceConfigLib= .h b/RedfishClientPkg/Include/Library/EdkIIRedfishResourceConfigLib.h index a7856033..8999868a 100644 --- a/RedfishClientPkg/Include/Library/EdkIIRedfishResourceConfigLib.h +++ b/RedfishClientPkg/Include/Library/EdkIIRedfishResourceConfigLib.h @@ -77,6 +77,8 @@ EdkIIRedfishResourceConfigUpdate ( @param[in] Uri The target URI to consume. =20 @retval EFI_SUCCESS Value is returned successfully. + @retval EFI_UNSUPPORTED This resource is not owned by feature d= river. + Caller should ignore this resource. @retval Others Some error happened. =20 **/ @@ -94,7 +96,12 @@ EdkIIRedfishResourceConfigCheck ( @param[in] InformationExchange Pointer to RESOURCE_INFORMATION_EXCHANG= E. =20 @retval EFI_SUCCESS This is target resource which we want t= o handle. - @retval EFI_UNSUPPORTED This is not the target resource. + @retval EFI_UNSUPPORTED This resource is not owned by feature d= river. + Caller should ignore this resource. + @retval EFI_NOT_FOUND This resource is owned by feature drive= r but there + is nothing to handle now. Caller may ig= nore the + rest of operations like check(), provis= ioning(), + consume() and update(). @retval Others Some error happened. =20 **/ diff --git a/RedfishClientPkg/Features/ComputerSystemCollectionDxe/Computer= SystemCollectionDxe.c b/RedfishClientPkg/Features/ComputerSystemCollectionD= xe/ComputerSystemCollectionDxe.c index 1e362d49..111f8212 100644 --- a/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSystemC= ollectionDxe.c +++ b/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSystemC= ollectionDxe.c @@ -3,6 +3,7 @@ Redfish feature driver implementation - ComputerSystemCollection =20 (C) Copyright 2020-2022 Hewlett Packard Enterprise Development LP
+ Copyright (c) 2022-2023, NVIDIA CORPORATION & AFFILIATES. All rights res= erved. =20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -32,11 +33,11 @@ HandleResource ( // Resource match // =20 - DEBUG ((REDFISH_DEBUG_TRACE, "%a, process resource for: %s\n", __func__,= Uri)); + DEBUG ((REDFISH_DEBUG_TRACE, "%a: process resource for: %s\n", __func__,= Uri)); =20 Status =3D GetRedfishSchemaInfo (Private->RedfishService, Private->JsonS= tructProtocol, Uri, &SchemaInfo); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a, failed to get schema information from: %s %r= \n", __func__, Uri, Status)); + DEBUG ((DEBUG_ERROR, "%a: failed to get schema information from: %s %r= \n", __func__, Uri, Status)); return Status; } =20 @@ -50,15 +51,19 @@ HandleResource ( Status =3D EdkIIRedfishResourceConfigIdentify (&SchemaInfo, Uri, Priva= te->InformationExchange); if (EFI_ERROR (Status)) { if (Status =3D=3D EFI_UNSUPPORTED) { - DEBUG ((DEBUG_MANAGEABILITY, "%a, \"%s\" is not handled by us\n", = __func__, Uri)); + DEBUG ((DEBUG_MANAGEABILITY, "%a: \"%s\" is not handled by us\n", = __func__, Uri)); + return EFI_SUCCESS; + } else if (Status =3D=3D EFI_NOT_FOUND) { + DEBUG ((DEBUG_MANAGEABILITY, "%a: \"%s\" has nothing to handle\n",= __func__, Uri)); + RedfisSetRedfishUri (L"/Systems/{1}", Uri); return EFI_SUCCESS; } =20 - DEBUG ((DEBUG_ERROR, "%a, fail to identify resource: \"%s\": %r\n", = __func__, Uri, Status)); + DEBUG ((DEBUG_ERROR, "%a: fail to identify resource: \"%s\": %r\n", = __func__, Uri, Status)); return Status; } } else { - DEBUG ((REDFISH_DEBUG_TRACE, "%a, history record found: %s\n", __func_= _, ConfigLang)); + DEBUG ((REDFISH_DEBUG_TRACE, "%a: history record found: %s\n", __func_= _, ConfigLang)); // // Set exchange information // @@ -70,7 +75,7 @@ HandleResource ( AllocateZeroPool (sizeof (REDFISH_FEATURE_ARRAY_TYPE_CONFIG_LANG)); =20 if (Private->InformationExchange->ReturnedInformation.ConfigureLangu= ageList.List =3D=3D NULL) { - DEBUG ((DEBUG_ERROR, "%a, Fail to allocate memory for REDFISH_FEAT= URE_ARRAY_TYPE_CONFIG_LANG.\n", __func__)); + DEBUG ((DEBUG_ERROR, "%a: Fail to allocate memory for REDFISH_FEAT= URE_ARRAY_TYPE_CONFIG_LANG.\n", __func__)); return EFI_OUT_OF_RESOURCES; } =20 @@ -78,7 +83,7 @@ HandleResource ( Private->InformationExchange->ReturnedInformation.ConfigureLanguageL= ist.List[0].ConfigureLang =3D (EFI_STRING)AllocateCopyPool (StrSize (ReturnedConfigLang), (VOID = *)ReturnedConfigLang); } else { - DEBUG ((DEBUG_ERROR, "%a, GetArrayIndexFromArrayTypeConfigureLang fa= il: %r\n", __func__, Status)); + DEBUG ((DEBUG_ERROR, "%a: GetArrayIndexFromArrayTypeConfigureLang fa= il: %r\n", __func__, Status)); } =20 FreePool (ConfigLang); @@ -91,13 +96,18 @@ HandleResource ( DEBUG ((REDFISH_DEBUG_TRACE, "%a Check for %s\n", __func__, Uri)); Status =3D EdkIIRedfishResourceConfigCheck (&SchemaInfo, Uri); if (EFI_ERROR (Status)) { + if (Status =3D=3D EFI_UNSUPPORTED) { + DEBUG ((REDFISH_DEBUG_TRACE, "%a: \"%s\" is not handled by us\n", __= func__, Uri)); + return EFI_SUCCESS; + } + // // The target property does not exist, do the provision to create prop= erty. // DEBUG ((REDFISH_DEBUG_TRACE, "%a provision for %s\n", __func__, Uri)); Status =3D EdkIIRedfishResourceConfigProvisionging (&SchemaInfo, Uri, = Private->InformationExchange, FALSE); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a, failed to provision with GET mode: %r\n", = __func__, Status)); + DEBUG ((DEBUG_ERROR, "%a: failed to provision with GET mode: %r\n", = __func__, Status)); } =20 return Status; @@ -109,7 +119,7 @@ HandleResource ( DEBUG ((REDFISH_DEBUG_TRACE, "%a consume for %s\n", __func__, Uri)); Status =3D EdkIIRedfishResourceConfigConsume (&SchemaInfo, Uri); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a, failed to consume resource for: %s: %r\n", _= _func__, Uri, Status)); + DEBUG ((DEBUG_ERROR, "%a: failed to consume resource for: %s: %r\n", _= _func__, Uri, Status)); } =20 // @@ -118,7 +128,7 @@ HandleResource ( DEBUG ((REDFISH_DEBUG_TRACE, "%a update for %s\n", __func__, Uri)); Status =3D EdkIIRedfishResourceConfigUpdate (&SchemaInfo, Uri); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a, failed to update resource for: %s: %r\n", __= func__, Uri, Status)); + DEBUG ((DEBUG_ERROR, "%a: failed to update resource for: %s: %r\n", __= func__, Uri, Status)); } =20 return Status; @@ -145,7 +155,7 @@ HandleCollectionResource ( return EFI_NOT_READY; } =20 - DEBUG ((REDFISH_DEBUG_TRACE, "%a, process collection for: %s\n", __func_= _, Private->CollectionUri)); + DEBUG ((REDFISH_DEBUG_TRACE, "%a: process collection for: %s\n", __func_= _, Private->CollectionUri)); =20 // // Convert JSON text to C structure. @@ -157,7 +167,7 @@ HandleCollectionResource ( (EFI_REST_JSON_STRUCTURE_HEADER = **)&Collection ); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a, ToStructure() failed: %r\n", __func__, Statu= s)); + DEBUG ((DEBUG_ERROR, "%a: ToStructure() failed: %r\n", __func__, Statu= s)); return Status; } =20 @@ -182,7 +192,7 @@ HandleCollectionResource ( if (MemberUri !=3D NULL) { Status =3D HandleResource (Private, MemberUri); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a, process ComputerSystemCollection resou= rce: %a failed: %r\n", __func__, UriData->Uri, Status)); + DEBUG ((DEBUG_ERROR, "%a: process ComputerSystemCollection resou= rce: %a failed: %r\n", __func__, UriData->Uri, Status)); } =20 FreePool (MemberUri); @@ -216,19 +226,19 @@ CreateCollectionResource ( return EFI_INVALID_PARAMETER; } =20 - DEBUG ((REDFISH_DEBUG_TRACE, "%a, create resource for collection for: %s= \n", __func__, Private->CollectionUri)); + DEBUG ((REDFISH_DEBUG_TRACE, "%a: create resource for collection for: %s= \n", __func__, Private->CollectionUri)); =20 Status =3D GetSupportedSchemaVersion (REDFISH_SCHEMA_NAME, &SchemaInfo); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a, failed to find supported schema from HII dat= abase: %r\n", __func__, Status)); + DEBUG ((DEBUG_ERROR, "%a: failed to find supported schema from HII dat= abase: %r\n", __func__, Status)); return Status; } =20 - DEBUG ((REDFISH_DEBUG_TRACE, "%a, supported schema: %a %a.%a.%a\n", __fu= nc__, SchemaInfo.Schema, SchemaInfo.Major, SchemaInfo.Minor, SchemaInfo.Err= ata)); + DEBUG ((REDFISH_DEBUG_TRACE, "%a: supported schema: %a %a.%a.%a\n", __fu= nc__, SchemaInfo.Schema, SchemaInfo.Major, SchemaInfo.Minor, SchemaInfo.Err= ata)); =20 Status =3D EdkIIRedfishResourceConfigProvisionging (&SchemaInfo, Private= ->CollectionUri, Private->InformationExchange, TRUE); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a, failed to create resource for: %s: %r\n", __= func__, Private->CollectionUri, Status)); + DEBUG ((DEBUG_ERROR, "%a: failed to create resource for: %s: %r\n", __= func__, Private->CollectionUri, Status)); } =20 return Status; @@ -283,14 +293,14 @@ CollectionHandler ( return EFI_INVALID_PARAMETER; } =20 - DEBUG ((REDFISH_DEBUG_TRACE, "%a, collection handler for %s\n", __func__= , Private->CollectionUri)); + DEBUG ((REDFISH_DEBUG_TRACE, "%a: collection handler for %s\n", __func__= , Private->CollectionUri)); =20 // // Query collection from Redfish service. // Status =3D GetResourceByUri (Private->RedfishService, Private->Collectio= nUri, &Private->RedResponse); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a, unable to get resource from: %s :%r\n", __fu= nc__, Private->CollectionUri, Status)); + DEBUG ((DEBUG_ERROR, "%a: unable to get resource from: %s :%r\n", __fu= nc__, Private->CollectionUri, Status)); goto ON_RELEASE; } =20 @@ -350,6 +360,7 @@ RedfishCollectionFeatureCallback ( =20 RedfishService =3D Private->RedfishService; if (RedfishService =3D=3D NULL) { + DEBUG ((DEBUG_ERROR, "%a: no Redfish service configured\n", __func__)); return EFI_NOT_READY; } =20 @@ -368,7 +379,7 @@ RedfishCollectionFeatureCallback ( // ResourceUri =3D (EFI_STRING)AllocateZeroPool (MAX_URI_LENGTH * sizeof (C= HAR16)); if (ResourceUri =3D=3D NULL) { - DEBUG ((DEBUG_ERROR, "%a, Fail to allocate memory for full URI.\n", __= func__)); + DEBUG ((DEBUG_ERROR, "%a: Fail to allocate memory for full URI.\n", __= func__)); return EFI_OUT_OF_RESOURCES; } =20 @@ -386,7 +397,7 @@ RedfishCollectionFeatureCallback ( =20 Status =3D CollectionHandler (Private); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a, CollectionHandler failure: %r\n", __func__, = Status)); + DEBUG ((DEBUG_ERROR, "%a: CollectionHandler failure: %r\n", __func__, = Status)); } =20 return EFI_SUCCESS; @@ -492,7 +503,7 @@ EfiRestJasonStructureProtocolIsReady ( (VOID **)&mRedfishCollectionPrivate->JsonStructProtocol ); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a, failed to locate gEfiRestJsonStructureProtoc= olGuid: %r\n", __func__, Status)); + DEBUG ((DEBUG_ERROR, "%a: failed to locate gEfiRestJsonStructureProtoc= olGuid: %r\n", __func__, Status)); } =20 gBS->CloseEvent (Event); @@ -528,7 +539,7 @@ EdkIIRedfishFeatureProtocolIsReady ( (VOID **)&FeatureProtocol ); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a, failed to locate gEdkIIRedfishFeatureProtoco= lGuid: %r\n", __func__, Status)); + DEBUG ((DEBUG_ERROR, "%a: failed to locate gEdkIIRedfishFeatureProtoco= lGuid: %r\n", __func__, Status)); gBS->CloseEvent (Event); return; } @@ -540,7 +551,7 @@ EdkIIRedfishFeatureProtocolIsReady ( (VOID *)mRedfishCollectionPrivate ); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a, failed to register %s: %r\n", __func__, REDF= ISH_MANAGED_URI, Status)); + DEBUG ((DEBUG_ERROR, "%a: failed to register %s: %r\n", __func__, REDF= ISH_MANAGED_URI, Status)); } =20 mRedfishCollectionPrivate->FeatureProtocol =3D FeatureProtocol; --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111669): https://edk2.groups.io/g/devel/message/111669 Mute This Topic: https://groups.io/mt/102767203/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-