When make or nmake fails to build the basetools, Edk2ToolsBuild.py
currently prints a generic error message "Failed to build." and 
raises an exception. This has two issues: The first is that it raises
an exception, which leads people to believe it is a python issue, and
not a build issue. The second is that users don't necessarily know to
check the build log if this error occurs. 

This has been reported many times through many different avenues:

https://github.com/tianocore/edk2/discussions/4611
https://stackoverflow.com/questions/77421168/edkii-base-tools-fails-to-build
https://github.com/tianocore/edk2-pytool-extensions/issues/180
https://github.com/tianocore/edk2-pytool-extensions/issues/207

This patch series changes the exception to a error log so that the invocable
completes and returns a non-zero exit code and also logs a more descriptive
error that informs the user to review the build log, and where to find it.

Joey Vagedes (1):
  BaseTools: Edk2ToolsBuild.py: Clarify make error

 BaseTools/Source/C/Common/BinderFuncs.c | 2 +-
 BaseTools/Edk2ToolsBuild.py             | 8 ++++++--
 2 files changed, 7 insertions(+), 3 deletions(-)

-- 
2.34.1

What is the random data at the end of your path emails???

Thanks,

Mike

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Joey
> Vagedes via groups.io
> Sent: Monday, November 6, 2023 12:09 PM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH v1 0/1] Edk2ToolsBuild.py: Clarify make
> error
> 
> When make or nmake fails to build the basetools, Edk2ToolsBuild.py
> currently prints a generic error message "Failed to build." and
> raises an exception. This has two issues: The first is that it raises
> an exception, which leads people to believe it is a python issue, and
> not a build issue. The second is that users don't necessarily know to
> check the build log if this error occurs.
> 
> This has been reported many times through many different avenues:
> 
> https://github.com/tianocore/edk2/discussions/4611
> https://stackoverflow.com/questions/77421168/edkii-base-tools-fails-
> to-build
> https://github.com/tianocore/edk2-pytool-extensions/issues/180
> https://github.com/tianocore/edk2-pytool-extensions/issues/207
> 
> This patch series changes the exception to a error log so that the
> invocable
> completes and returns a non-zero exit code and also logs a more
> descriptive
> error that informs the user to review the build log, and where to find
> it.
> 
> Joey Vagedes (1):
>   BaseTools: Edk2ToolsBuild.py: Clarify make error
> 
>  BaseTools/Source/C/Common/BinderFuncs.c | 2 +-
>  BaseTools/Edk2ToolsBuild.py             | 8 ++++++--
>  2 files changed, 7 insertions(+), 3 deletions(-)
> 
> --
> 2.34.1
> 
> ®‹©²*
> Šy,b‹«yÇ¢½æ¥–g¬±¨²Ç§¶Ú-†+ ®‹©V'°ý©—#§–)Þ×];çˆm¶›?ýçdÚ
> 躛"£ø?uëÞ—
> ùž²Æ {ýuÓ¾x2ë^N¬NŠbrm¦Ïÿ‚º.¦È¨þk×M¸ÛÎüïýzã~=èj躓°êÝz÷¥úŒ'z·“h+¢ê
> lŠ…'²æìr¸›zm¦ÏÿyÙ6‚º.¦È¨þÝz÷¥þéì¹¹¢rž•Ù"žw²Š{^•Ê&


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110761): https://edk2.groups.io/g/devel/message/110761
Mute This Topic: https://groups.io/mt/102428787/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076/xyzzy [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

I made a recent change to how I use git send-email:

I follow Laszlo's unkempt git guide for edk2 contributors and maintainers. There was a recent update to add --transfer-encoding=base64 to the git send-email command. My guess is that caused the random data. I do not see that data on the "send" side in my outbox, however.

https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers/_compare/385073186afb8dd7cb8af4c9fcd96d86423fd9d3

Joey

-----Original Message-----
From: Kinney, Michael D <michael.d.kinney@intel.com> 
Sent: Monday, November 6, 2023 1:54 PM
To: devel@edk2.groups.io; Joey Vagedes <joeyvagedes@microsoft.com>
Cc: Kinney, Michael D <michael.d.kinney@intel.com>
Subject: [EXTERNAL] RE: [edk2-devel] [PATCH v1 0/1] Edk2ToolsBuild.py: Clarify make error

What is the random data at the end of your path emails???

Thanks,

Mike

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Joey 
> Vagedes via groups.io
> Sent: Monday, November 6, 2023 12:09 PM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH v1 0/1] Edk2ToolsBuild.py: Clarify make 
> error
> 
> When make or nmake fails to build the basetools, Edk2ToolsBuild.py 
> currently prints a generic error message "Failed to build." and raises 
> an exception. This has two issues: The first is that it raises an 
> exception, which leads people to believe it is a python issue, and not 
> a build issue. The second is that users don't necessarily know to 
> check the build log if this error occurs.
> 
> This has been reported many times through many different avenues:
> 
> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith
> ub.com%2Ftianocore%2Fedk2%2Fdiscussions%2F4611&data=05%7C01%7Cjoeyvage
> des%40microsoft.com%7C271dfa9b91c844696b5808dbdf12e82c%7C72f988bf86f14
> 1af91ab2d7cd011db47%7C1%7C0%7C638349044524508743%7CUnknown%7CTWFpbGZsb
> 3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%
> 7C3000%7C%7C%7C&sdata=5aewZruHiYbB9dBtbVegXeJmDdMre5oWasFWCnSmYDc%3D&r
> eserved=0
> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fstac
> koverflow.com%2Fquestions%2F77421168%2Fedkii-base-tools-fails-&data=05
> %7C01%7Cjoeyvagedes%40microsoft.com%7C271dfa9b91c844696b5808dbdf12e82c
> %7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638349044524515634%7CUnk
> nown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWw
> iLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=P2GDkAZrpm1pZHE9Vl4RKLszDTEzAGW7
> xF5Wh%2Byakkw%3D&reserved=0
> to-build
> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith
> ub.com%2Ftianocore%2Fedk2-pytool-extensions%2Fissues%2F180&data=05%7C0
> 1%7Cjoeyvagedes%40microsoft.com%7C271dfa9b91c844696b5808dbdf12e82c%7C7
> 2f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638349044524521511%7CUnknown
> %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJ
> XVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=uahh%2FKPyyLsf19R0WLszjkWGRg6x3jVLq7
> GDGuBdS4o%3D&reserved=0
> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith
> ub.com%2Ftianocore%2Fedk2-pytool-extensions%2Fissues%2F207&data=05%7C0
> 1%7Cjoeyvagedes%40microsoft.com%7C271dfa9b91c844696b5808dbdf12e82c%7C7
> 2f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638349044524526191%7CUnknown
> %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJ
> XVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=MvX3P5bYPvwI7z%2BDiy%2Bbezj0kBEx51RQ
> GTkoS6WUiDI%3D&reserved=0
> 
> This patch series changes the exception to a error log so that the 
> invocable completes and returns a non-zero exit code and also logs a 
> more descriptive error that informs the user to review the build log, 
> and where to find it.
> 
> Joey Vagedes (1):
>   BaseTools: Edk2ToolsBuild.py: Clarify make error
> 
>  BaseTools/Source/C/Common/BinderFuncs.c | 2 +-
>  BaseTools/Edk2ToolsBuild.py             | 8 ++++++--
>  2 files changed, 7 insertions(+), 3 deletions(-)
> 
> --
> 2.34.1
> 
> ®‹©²*
> Šy,b‹«yÇ¢½æ¥–g¬±¨²Ç§¶Ú-†+ ®‹©V'°ý©—#§–)Þ×];çˆm¶›?ýçdÚ èº›"£ø?uëÞ— 
> ùž²Æ {ýuÓ¾x2ë^N¬NŠbrm¦Ïÿ‚º.¦È¨þk×M¸ÛÎüïýzã~=èj躓°êÝz÷¥úŒ'z·“h+¢ê
> lŠ…'²æìr¸›zm¦ÏÿyÙ6‚º.¦È¨þÝz÷¥þéì¹¹¢rž•Ù"žw²Š{^•Ê&


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110769): https://edk2.groups.io/g/devel/message/110769
Mute This Topic: https://groups.io/mt/102428787/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Q2xhcmlmeSB0byB1c2VycyB0aGF0IHRoZXkgc2hvdWxkIHJldmlldyB0aGUgYnVpbGQgbG9nIHdoZW4gbWFrZQooUE9TSVgtbGlrZSBzeXN0ZW0pIG9yIG5tYWtlIChXaW5kb3dzKSBmYWlscyB0byBjb21waWxlIGJhc2V0b29scy4KCkNjOiBSZWJlY2NhIENyYW4gPHJlYmVjY2FAYnNkaW8uY29tPgpDYzogTGltaW5nIEdhbyA8Z2FvbGltaW5nQGJ5b3NvZnQuY29tLmNuPgpDYzogQm9iIEZlbmcgPGJvYi5jLmZlbmdAaW50ZWwuY29tPgpDYzogWXV3ZWkgQ2hlbiA8eXV3ZWkuY2hlbkBpbnRlbC5jb20+ClNpZ25lZC1vZmYtYnk6IEpvZXkgVmFnZWRlcyA8am9leXZhZ2VkZXNAZ21haWwuY29tPgotLS0KIEJhc2VUb29scy9Tb3VyY2UvQy9Db21tb24vQmluZGVyRnVuY3MuYyB8IDIgKy0KIEJhc2VUb29scy9FZGsyVG9vbHNCdWlsZC5weSAgICAgICAgICAgICB8IDggKysrKysrLS0KIDIgZmlsZXMgY2hhbmdlZCwgNyBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL0Jhc2VUb29scy9Tb3VyY2UvQy9Db21tb24vQmluZGVyRnVuY3MuYyBiL0Jhc2VUb29scy9Tb3VyY2UvQy9Db21tb24vQmluZGVyRnVuY3MuYwppbmRleCBkZTgzNTI4N2U5NWMuLjhjMDhiZWY3YTBmMCAxMDA2NDQKLS0tIGEvQmFzZVRvb2xzL1NvdXJjZS9DL0NvbW1vbi9CaW5kZXJGdW5jcy5jCisrKyBiL0Jhc2VUb29scy9Tb3VyY2UvQy9Db21tb24vQmluZGVyRnVuY3MuYwpAQCAtMjEsNyArMjEsNyBAQCBDb21tb25MaWJCaW5kZXJBbGxvY2F0ZSAoCiAgICkNCiB7DQogICByZXR1cm4gKFZPSUQgKikgbWFsbG9jIChTaXplKTsNCi19DQorfWFzZGYNCiANCiBWT0lEDQogQ29tbW9uTGliQmluZGVyRnJlZSAoDQpkaWZmIC0tZ2l0IGEvQmFzZVRvb2xzL0VkazJUb29sc0J1aWxkLnB5IGIvQmFzZVRvb2xzL0VkazJUb29sc0J1aWxkLnB5CmluZGV4IDQyNWJiMWI2Mzk2My4uNDc3NmM1ODMwODBmIDEwMDY0NAotLS0gYS9CYXNlVG9vbHMvRWRrMlRvb2xzQnVpbGQucHkKKysrIGIvQmFzZVRvb2xzL0VkazJUb29sc0J1aWxkLnB5CkBAIC0xNDEsNyArMTQxLDkgQEAgY2xhc3MgRWRrMlRvb2xzQnVpbGQoQmFzZUFic3RyYWN0SW52b2NhYmxlKToKICAgICAgICAgICAgIGZvciBsZXZlbCwgcHJvYmxlbSBpbiBwcm9ibGVtczoNCiAgICAgICAgICAgICAgICAgbG9nZ2luZy5sb2cobGV2ZWwsIHByb2JsZW0pDQogICAgICAgICAgICAgaWYgcmV0ICE9IDA6DQotICAgICAgICAgICAgICAgIHJhaXNlIEV4Y2VwdGlvbigiRmFpbGVkIHRvIGJ1aWxkLiIpDQorICAgICAgICAgICAgICAgIGUgPSAiRmFpbGVkIHRvIHJ1biBubWFrZS5leGUuIFJldmlldyBCdWlsZGxvZyBhdCBCYXNlVG9vbHMvQmFzZVRvb2xzQnVpbGQvQkFTRVRPT0xTX0JVSUxELnR4dCBmb3Igbm1ha2UuZXhlIGVycm9yLiINCisgICAgICAgICAgICAgICAgbG9nZ2luZy5lcnJvcihlKQ0KKyAgICAgICAgICAgICAgICByZXR1cm4gcmV0DQogDQogICAgICAgICAgICAgc2VsZi5Xcml0ZVBhdGhFbnZGaWxlKHNlbGYuT3V0cHV0RGlyKQ0KICAgICAgICAgICAgIHJldHVybiByZXQNCkBAIC0xNTYsNyArMTU4LDkgQEAgY2xhc3MgRWRrMlRvb2xzQnVpbGQoQmFzZUFic3RyYWN0SW52b2NhYmxlKToKICAgICAgICAgICAgIGZvciBsZXZlbCwgcHJvYmxlbSBpbiBwcm9ibGVtczoNCiAgICAgICAgICAgICAgICAgbG9nZ2luZy5sb2cobGV2ZWwsIHByb2JsZW0pDQogICAgICAgICAgICAgaWYgcmV0ICE9IDA6DQotICAgICAgICAgICAgICAgIHJhaXNlIEV4Y2VwdGlvbigiRmFpbGVkIHRvIGJ1aWxkLiIpDQorICAgICAgICAgICAgICAgIGUgPSAiRmFpbGVkIHRvIHJ1biBtYWtlLiBSZXZpZXcgQnVpbGRsb2cgYXQgQmFzZVRvb2xzL0Jhc2VUb29sc0J1aWxkL0JBU0VUT09MU19CVUlMRC50eHQgZm9yIG1ha2UgZXJyb3IuIg0KKyAgICAgICAgICAgICAgICBsb2dnaW5nLmVycm9yKGUpDQorICAgICAgICAgICAgICAgIHJldHVybiByZXQNCiANCiAgICAgICAgICAgICBzZWxmLk91dHB1dERpciA9IG9zLnBhdGguam9pbigNCiAgICAgICAgICAgICAgICAgc2hlbGxfZW52LmdldF9zaGVsbF92YXIoIkVES19UT09MU19QQVRIIiksICJTb3VyY2UiLCAiQyIsICJiaW4iKQ0KLS0gCjIuMzQuMQoK-=-=-=-=-=-=-=-=-=-=-=-Groups.io Links: You receive all messages sent to this group.View/Reply Online (#110755): https://edk2.groups.io/g/devel/message/110755Mute This Topic: https://groups.io/mt/102428788/1787277Group Owner: devel+owner@edk2.groups.ioUnsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]-=-=-=-=-=-=-=-=-=-=-=-