From nobody Wed May 15 02:32:51 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+110289+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 169864635534733.35904671317189; Sun, 29 Oct 2023 23:12:35 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=MnwOAX4BwfPXqk8bWcMLmgFQ9C774s6VaT1YnYUXJGo=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:From:To:CC:Subject:Date:Message-ID:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1698646354; v=1; b=eQZNQZAtQVkqWvSlzqo6VgBUnG3fet3MyuLOaurrnIqtOYq44TWy/0Wz1k54RTpXaJOvgf8v GUG6I4BTU9VykEOj0qyUZUG0YU4zSjlt/e5479z69apoiQgXZZKDSAu0rfKwj7bdGrt77wLyvqI E48AJpvRTzPs2xDdSAy71/T0= X-Received: by 127.0.0.2 with SMTP id Y6ZKYY1788612xaDIyI9SzPG; Sun, 29 Oct 2023 23:12:34 -0700 X-Received: from NAM04-MW2-obe.outbound.protection.outlook.com (NAM04-MW2-obe.outbound.protection.outlook.com [40.107.101.80]) by mx.groups.io with SMTP id smtpd.web10.143072.1698646354242045960 for ; Sun, 29 Oct 2023 23:12:34 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XHh+ajbmn2RbIJ661TWl4cP5J45UoKInJnMUkKvjzPpPeT+jjB9NiuelVne3v3azP6lGpvHK/uwdthrM1gQfY4QP2vjprr1r3b9bKv82GIx+6g/h9WnuTNvjFE9KHEi605O0kG0Z225yMTEvalv22mKsKtVK/UK/a7Fye5Poc+DsgsQb7bJBoMNAkG6raB1yxdIOOCfpbWD/haFqWWzm2Fmfwe+MlIXhcGYBMsrq83FvIstSF4l+TO4xBIOFdQW+7Sf9lxFftoQpDuUKbowdC+tByUUK/NA3ZVvhJLyzzttraL1zk/irR+cTpXx4PLbjVE7+e3xUl12Hl3JHGlCOiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qy1q0gNx1hrgSReW02CF3H4+ceOB2IyrqvIPo9p3axM=; b=E15+AlSYLKYHHw9e5ew8f6+rKO8S2xa1aZtvWJNMXEvgGej3aZxd9LG0P0Iv2a9fbIXhh9/V2hRmMSfugJPKs4Yl3x8UFEdpBrDA3Iv0fy09e4FNcOjP7BSBb7t2ugZqUN0IeAlzeDxsBQqPDiQty4fODhVgfCanVBRm/n1QtjJRZFb4Oghp2Qm0cVLq5Z7nWP3nUaGKrY/dv0OBNOGigAMozWihArL1P6WMZRACZ8K/UZqd9+oJ2Kcwap3WKMm+2Hlrn4tan1k9emDUAqioCPqnaE/+s13xH1zbYizEQl/nhKcZ/rNUK7AK6EEZDSCKPmm6/sOkT2YGNuGph31LLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) X-Received: from MW4PR03CA0237.namprd03.prod.outlook.com (2603:10b6:303:b9::32) by DM4PR12MB5183.namprd12.prod.outlook.com (2603:10b6:5:396::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.28; Mon, 30 Oct 2023 06:12:31 +0000 X-Received: from MWH0EPF000989E5.namprd02.prod.outlook.com (2603:10b6:303:b9:cafe::96) by MW4PR03CA0237.outlook.office365.com (2603:10b6:303:b9::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.27 via Frontend Transport; Mon, 30 Oct 2023 06:12:31 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+110289+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C X-Received: from SATLEXMB04.amd.com (165.204.84.17) by MWH0EPF000989E5.mail.protection.outlook.com (10.167.241.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6933.15 via Frontend Transport; Mon, 30 Oct 2023 06:12:31 +0000 X-Received: from TPE-L-HSIENLIN.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Mon, 30 Oct 2023 01:12:29 -0500 From: "Jacque Lin via groups.io" To: CC: Jacque Lin , Abdul Lateef Attar , Abner Chang Subject: [edk2-devel] [PATCH] UefiCpuPkg/MmSaveStateLib: Remove checking Smm Rev ID in AMD MmSaveStateLib Date: Mon, 30 Oct 2023 14:12:03 +0800 Message-ID: <20231030061203.1166-1-hsienchieh.lin@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000989E5:EE_|DM4PR12MB5183:EE_ X-MS-Office365-Filtering-Correlation-Id: 9161bd76-2fff-4303-959b-08dbd90f3350 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: 3XGhp3ubknt2F9avY7RjGG2otG/Cx9XB0VCp3VF+FoQP5JtfkUBUr5M6z0mSXc0DVOMn0zqYpTkkO0SJR9h1kMXdVvadNvcWY7Cc+uGHhOf9uyeMzonfGj8RZ/Xg25S2BlnSYjzbd2Re31yt8Dxv1PwTkbHlsCXVolu/1F+rJmSPi1lt++idmcNDLFpIam3AmXrFPhPJY0wHq2qGHc1P9egMd1wkoxYpbnBKuNk7JCeJPDPLoBhMKRnS9JzyjrY4jUlQxeOlRjSeVBjseISESorBxTt5DPs3h9UbTdiWd/89maW4bXMHUTZuIw0/Vi9Sn+NcOiSulisbYJq/u4FblDZb883OSijKPbijFtiHXX7H6SXQ0uuoI/p6ul4E2Q8g1744Q38nURHWKZw+YlvOcSuImxcffXJZyZRskbNP/Z/rERs235xQQctyxcnNVgmkWeBBmVgn2YaPOJb6UmEYVT2uRCB5RpN/YBfQGAFNBTfuiut+W6T1s/wOGcrJ1FQF0wXsOU5vTXdBwNcu6B7LgI141iJcHnM1LXTBjnfQ9utURxdhsJYgD1XxvxflDWeK6LZXbCVMV/UXyKTSV25/fQ4YxQ9aLCxV70dAMsr7TKg1hAP6lHsjoqBPvZtwdioHoAB2b2sxntUQw1vYgqVq6kRImGYblAiZHZBY77mxRzsuyMiDtnuI2qJc005N3DZxR7SX5gNd5JYnL0pGUs+yGVyIV3VC+tO5BwrExSDI+4cV+qzYELPPnQB1tD/g5YV96nEKqOCD59bZtoiwHfNj9A== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Oct 2023 06:12:31.0306 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9161bd76-2fff-4303-959b-08dbd90f3350 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000989E5.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5183 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,hsienchieh.lin@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: PtBzXg9hsuZEOWXAuuG1TTchx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1698646357684100003 Content-Type: text/plain; charset="utf-8" Remove checking SMM Rev ID in AMD Save State lib when reading Save State Register EFI_MM_SAVE_STATE_REGISTER_IO. For AMD, it is not necessary to check SmmRevId when reading Save State Register EFI_MM_SAVE_STATE_REGISTER_IO. Cc: Abdul Lateef Attar Cc: Abner Chang Signed-off-by: Jacque Lin Acked-by: Abner Chang --- UefiCpuPkg/Library/MmSaveStateLib/AmdMmSaveState.c | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/UefiCpuPkg/Library/MmSaveStateLib/AmdMmSaveState.c b/UefiCpuPk= g/Library/MmSaveStateLib/AmdMmSaveState.c index 3315a6cc44..c4bf6ad4bb 100644 --- a/UefiCpuPkg/Library/MmSaveStateLib/AmdMmSaveState.c +++ b/UefiCpuPkg/Library/MmSaveStateLib/AmdMmSaveState.c @@ -102,7 +102,6 @@ MmSaveStateReadRegister ( OUT VOID *Buffer ) { - UINT32 SmmRevId; EFI_MM_SAVE_STATE_IO_INFO *IoInfo; AMD_SMRAM_SAVE_STATE_MAP *CpuSaveState; UINT8 DataWidth; @@ -124,18 +123,6 @@ MmSaveStateReadRegister ( =20 // Check for special EFI_MM_SAVE_STATE_REGISTER_IO if (Register =3D=3D EFI_MM_SAVE_STATE_REGISTER_IO) { - // - // Get SMM Revision ID - // - MmSaveStateReadRegisterByIndex (CpuIndex, AMD_MM_SAVE_STATE_REGISTER_S= MMREVID_INDEX, sizeof (SmmRevId), &SmmRevId); - - // - // See if the CPU supports the IOMisc register in the save state - // - if (SmmRevId < AMD_SMM_MIN_REV_ID_X64) { - return EFI_NOT_FOUND; - } - // Check if IO Restart Dword [IO Trap] is valid or not using bit 1. if (!(CpuSaveState->x64.IO_DWord & 0x02u)) { return EFI_NOT_FOUND; --=20 2.36.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110289): https://edk2.groups.io/g/devel/message/110289 Mute This Topic: https://groups.io/mt/102269908/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-