From nobody Tue May 14 20:17:19 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+110203+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1698407303331597.4981793276887; Fri, 27 Oct 2023 04:48:23 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=DSSdQt6/tL41VaF1XnKGC3UJOo9ToQxBsC+SucVJG1E=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:From:To:CC:Subject:Date:Message-ID:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1698407303; v=1; b=iPnEcC9VjtAWMx93fzFPo/rPvwwQH7VtHy9mGLI/h/HtTr5LYOs+9nyVpRanE/iSmOc6q7Pr 4JIoyM43teJQ4ClkiyTvWzXunH8UQ02s90yfhXHtOKQMBBMtEjXOabbie4t4adfdCT+Uh66NtNU H/S03jEXEJgTNDFbnLrNfb5s= X-Received: by 127.0.0.2 with SMTP id igLZYY1788612xcnVkteLo1H; Fri, 27 Oct 2023 04:48:23 -0700 X-Received: from NAM04-DM6-obe.outbound.protection.outlook.com (NAM04-DM6-obe.outbound.protection.outlook.com [40.107.102.85]) by mx.groups.io with SMTP id smtpd.web10.836.1698385005063391410 for ; Thu, 26 Oct 2023 22:36:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KxDpJcu0oGKbEIuiGRY9J88drdbX9rWsxo8Psn630p3gWh0edcpeirwS0XlCYFyD+Zx6Y07StPW/aLHxJapTfI/AokL07Gy43OPtyXxQfKQjFmPvNlnllOsHLHw2E4QAKR+19eD/JQwM1IwtUaWQitjZTVw+Yhum3zv9bbgICFxmjxESZfRBk4PLyaYY0k7H70LHdgrSN87iGvdJMKNK0CCUjCtm3LVncwXiB8+6QfLlzRFN26cteBQ1WgfTkeJX2BqWXVPY4F9oUEnudneg71t+5ToVt2iaOW+6y+jHxnI3styaAS1VjS/H7KsOTDlPMtohhvrX4ulgVOXUeUiXxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ICnBJlJxIxioiL2B4R/bBIF+kGtQZkXmfhos1aP0N94=; b=VkfCYTNDLlfWU9r15u/v4OhgVWwzD1vkn4/8E4HioE1Z46LEIXS+Tf1pxLOnxZvEhgZ4gCXQ9a6Y6MVGs/Tf39RSsRtnIBlZv4XC31PG0QmbRsg9apkgo1oUBm7FMgGMXJ0YkAhH1kd+boHcisKXKuFt6uT5rsaj6onZFRx+iyheJnsA1ODGhPmGqIBnAv2+NpmosunpbceEIGFH7FGtOldLdbkR6AjbbFmsSURHHD24ws6Er/4q1z3F7fl4UGN95OJXq1NmdyyMFtsLpQiWYzd+VtG9yYnimLipCVwQxH2Hz3v53dBuSRIXDVEdG/wOMRW6Mp21TlX0CzzZjgquhw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) X-Received: from SN7PR04CA0019.namprd04.prod.outlook.com (2603:10b6:806:f2::24) by SA0PR12MB4447.namprd12.prod.outlook.com (2603:10b6:806:9b::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.33; Fri, 27 Oct 2023 05:36:42 +0000 X-Received: from SN1PEPF0002636C.namprd02.prod.outlook.com (2603:10b6:806:f2:cafe::67) by SN7PR04CA0019.outlook.office365.com (2603:10b6:806:f2::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.22 via Frontend Transport; Fri, 27 Oct 2023 05:36:42 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+110203+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C X-Received: from SATLEXMB04.amd.com (165.204.84.17) by SN1PEPF0002636C.mail.protection.outlook.com (10.167.241.137) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6933.15 via Frontend Transport; Fri, 27 Oct 2023 05:36:42 +0000 X-Received: from TPE-L-HSIENLIN.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Fri, 27 Oct 2023 00:36:41 -0500 From: "Jacque Lin via groups.io" To: CC: Jacque Lin Subject: [edk2-devel] [PATCH] Remove checking Smm Rev ID in AMD Save State lib when Reading Save State Register EFI_MM_SAVE_STATE_REGISTER_IO Date: Fri, 27 Oct 2023 13:36:19 +0800 Message-ID: <20231027053619.1609-1-hsienchieh.lin@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF0002636C:EE_|SA0PR12MB4447:EE_ X-MS-Office365-Filtering-Correlation-Id: a148571f-dd5d-462c-a98d-08dbd6aeb38b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: ZFOuABl4tleG5toqVbEmzlEQpokFIZ35gUNtRCqEDGbX1PHW/mQParAaA8r/lOh+iP2jK2PfIeRQhzJGnE+EZw31zfcMnuEtwkUQFZGeq5ShvybIWFqQmC0j8a6VmSIq/pWex0jiybmVfAekhSXRs3Ww3Tw9DQ0MkqAHO0LfmcPcx7NwcYl+dxhAAzoX+O8+l/G+JfXz9frtjr8eWvLdfORzxPqD2A1Omyk3auaFAxoNmXOjwZHe+GKWRYME8a9tXpi1Hx0arJrdYV161sF0iAMf3BUTkOt322/+uMSeSVeobwWFamcC5QE1IRXHPovmp/t9TU7n0JWBPI5FvHSs2rLuL7rb1EmBHoGJ0Grwh8qxCkCga5OqzdOo5bUKQjTSwDu5UoNGLFrvGMDhPW6kZEOZRo0RLkAUwBj8i1KE6B8bu6oiuNkLcm7rzL2nSmOQZu6xT9GbFHdNWejpy9NqyuVfe6tklOBQLwljfZZkzmjdN4Gx8joRLmKKFaxsdEknFeIXKDdy7QkpvRkbqfmGgKawvsUw7LqsZJ4so4IqTbMvLs/ngshMuVctiDVcXXsNkKRWFj6hG/K/zwQ1hbxUcgiRoK0sycHnCB1u2P/xO27Uwph1oR9K7FCNiaot82Wo3jT8RhROi9tFWvdVtKgC+QI1Ao26Gc7q8YnxE18FF0iX7DowHF/De+/nNGWU3IKBN9TScCcoTlzc217Q4PrTwMMf325WTvsk/IG6IRxB+MclgvOnZrcG1NXSURHk1OU73MOzY7rtYSwTQsUQ7FdVgQ== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2023 05:36:42.7360 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a148571f-dd5d-462c-a98d-08dbd6aeb38b X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF0002636C.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4447 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,hsienchieh.lin@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: tyaDPKRi1gnwKaZDUCzmUdiwx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1698407303953100001 Content-Type: text/plain; charset="utf-8" --- UefiCpuPkg/Library/MmSaveStateLib/AmdMmSaveState.c | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/UefiCpuPkg/Library/MmSaveStateLib/AmdMmSaveState.c b/UefiCpuPk= g/Library/MmSaveStateLib/AmdMmSaveState.c index 3315a6cc44..c4bf6ad4bb 100644 --- a/UefiCpuPkg/Library/MmSaveStateLib/AmdMmSaveState.c +++ b/UefiCpuPkg/Library/MmSaveStateLib/AmdMmSaveState.c @@ -102,7 +102,6 @@ MmSaveStateReadRegister ( OUT VOID *Buffer ) { - UINT32 SmmRevId; EFI_MM_SAVE_STATE_IO_INFO *IoInfo; AMD_SMRAM_SAVE_STATE_MAP *CpuSaveState; UINT8 DataWidth; @@ -124,18 +123,6 @@ MmSaveStateReadRegister ( =20 // Check for special EFI_MM_SAVE_STATE_REGISTER_IO if (Register =3D=3D EFI_MM_SAVE_STATE_REGISTER_IO) { - // - // Get SMM Revision ID - // - MmSaveStateReadRegisterByIndex (CpuIndex, AMD_MM_SAVE_STATE_REGISTER_S= MMREVID_INDEX, sizeof (SmmRevId), &SmmRevId); - - // - // See if the CPU supports the IOMisc register in the save state - // - if (SmmRevId < AMD_SMM_MIN_REV_ID_X64) { - return EFI_NOT_FOUND; - } - // Check if IO Restart Dword [IO Trap] is valid or not using bit 1. if (!(CpuSaveState->x64.IO_DWord & 0x02u)) { return EFI_NOT_FOUND; --=20 2.36.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110203): https://edk2.groups.io/g/devel/message/110203 Mute This Topic: https://groups.io/mt/102219140/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-