From nobody Wed May 15 04:44:47 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+110079+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 169830758963912.487439927772243; Thu, 26 Oct 2023 01:06:29 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=eLIud21V/6k6D09PQuMs26zGEvBJ7j81853SDBXXAko=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:From:To:CC:Subject:Date:Message-ID:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1698307588; v=1; b=Cmqtes/rvkPfI5zJB8qs5D/UVwHNTQ7Ko+xZhI7x7BomXM/pXpk6iov0ZOiClhS+x2L7qZdy 0LROVh+EfpzOvNCUeTpmzJAU9WD7Jgh6/jjPhTbCNjgMsxfDJrCU13DkZNOJdvdfT5hzMTYcley wsXY4BXPsTySo1zuJxr4I/Ho= X-Received: by 127.0.0.2 with SMTP id WFhVYY1788612x9KoPl2kbcz; Thu, 26 Oct 2023 01:06:28 -0700 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.64]) by mx.groups.io with SMTP id smtpd.web10.195128.1698307587989372433 for ; Thu, 26 Oct 2023 01:06:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HNflNx244O+jSPabJMLqOb/yvo9i2FECiC28qLhKc/L/N/vIX7kocce5pWHdwv+FBRAMHE1nzSBG1igZwcmYKhFqg1S+vuAuk+ey10QFkb+SVj0anAHqjXXZ3626j6UK0vKMhoYjuPpoFHdY0z4Ce5eYtNaoB9JdioUbttQGbRAobH9RzgZXUricaGzxLaK9nsBdMfRzmIUpaAvyHEezrLC0EixdynitaNBWpplAHOTMaeC7vlATN5txrrdHfbxosCvAm9jzKJEQpaYWuB5B5D8kfNLWygKAxsGSrv5c0dV0070BRH9Nszb4+dwtfmut12xJzgBHImEr5B5VfxY3Ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=poH2qCEvtgWK2qk2N20xdqBgDk0uBgajpLgP2nQCiqk=; b=O33tuo3Hm7PFSjISGDeafNU5KMioM6U+PS3HIldjOWzUAcCDZ1DdbDxhHSyiOsXN7zsGYM/lNP28FDIxQXeT1rTgSp78+6Dk9fQCfqWHE4aQgeBkoLb60UkANOCxDFTWXUOO8588CUKnCIfFPmabEnV3sgFWEFzyaspsd3J3y4r3KI9RlP2RehxME9JoWnRjkoKa95tX5ZPAPg6bg9gWXJ9Tknsq1y4E+ltD+V5lg/zkzUfyRrSGsDu4FwdaNaNUwaaDogx9K+hAAqzmukG6w5pBPGcst+/TyYD4madAv/6YV7r9PA6tZ8WjtsPOT0wBQTL35dMc5Geysc1XqAwWPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none X-Received: from MW4PR04CA0071.namprd04.prod.outlook.com (2603:10b6:303:6b::16) by DM6PR12MB4483.namprd12.prod.outlook.com (2603:10b6:5:2a2::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.19; Thu, 26 Oct 2023 08:06:25 +0000 X-Received: from CO1PEPF000042AD.namprd03.prod.outlook.com (2603:10b6:303:6b:cafe::d8) by MW4PR04CA0071.outlook.office365.com (2603:10b6:303:6b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.21 via Frontend Transport; Thu, 26 Oct 2023 08:06:24 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+110079+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C X-Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1PEPF000042AD.mail.protection.outlook.com (10.167.243.42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6933.15 via Frontend Transport; Thu, 26 Oct 2023 08:06:23 +0000 X-Received: from TPE-L1-ABNCHANG.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Thu, 26 Oct 2023 03:06:21 -0500 From: "Chang, Abner via groups.io" To: CC: Abdul Lateef Attar , Nickle Wang , Konstantin Aladyshev Subject: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: Uncrustify on C source files Date: Thu, 26 Oct 2023 16:06:07 +0800 Message-ID: <20231026080607.1904-1-abner.chang@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000042AD:EE_|DM6PR12MB4483:EE_ X-MS-Office365-Filtering-Correlation-Id: 25445faf-1846-4e32-cffe-08dbd5fa725b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: LOGlS92bw3VBl00WnWS0OiL6lBAynelKsBHNvaclLxfIteVXNWXDnu4sDcWYF2+zqZuaR/71qsN/JAFhK1Hz2akgqx3Wnkk4olE2PL+Qefn43ombbDf0nObQSkn00JCMCU+hz8yfvadRKu7PDTHrXm+R0H35EWkSI7nDSeGHKwpq8jjw2ePJUXXyDlsjrePJy2XzFobDBpH3fg+qZZj+0MD2rOOOPysKHefgeAVdsJaXe9DZomVP66NWsoAxou47sc4vUlsPAVYpLtnMJz6ki5B7eFPOi6ckUeZ4aq56nJYAlZYFjUXkrLoG+geHrgKzr2Y3poQ8gUKLZO4k8F0HvMReRRKnnDOpHXBx5nMBT09m/gz9euz8Vurt+uVsCPMivX/5ukHtlSZQQoGFxhel7PHMFKqlQ4kz4w/83VyVn57zggrxhigPHo9ugWZsVYcE9c3bcZoNWLhTnNvAW+oN8ygPA5s4Tx+OXPQyPt7oIfOa85wqdibxMYKrFBX5PUX2naOGNaCYqFcylquVT42j7ndaQuqx6hF+yWexAyLsAHfMlOMz7rH+MKMRJipYWsuHf/8TBIqiCHCDZ+Q3wl7vQZ79nxDomC/k57HstARu0SD27qOfuW+t2ZUc4ScKT+4wdnK5kBkMXGLJEfOPPRX5GWW8VU3MvpSSpnk7fjW9Lw9jcfD0ZUr51GDB30AQvnP3RWxKTLvUJHccqlXUlS7KQ2875LAkvpyQOJYlskPrXybxhGMuz760GJm2buZsbzhBtmHszMC6/v0RplQYH5d0ew== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2023 08:06:23.8654 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 25445faf-1846-4e32-cffe-08dbd5fa725b X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000042AD.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4483 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: XmDJ5wyrxOVDtfWgDU1Av8box1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1698307592919100003 Content-Type: text/plain; charset="utf-8" From: Abner Chang Run Uncrustify on the C source files those were modified in commit ID from 3f4c4384 to 28ff8f29. Signed-off-by: Abner Chang Cc: Abdul Lateef Attar Cc: Nickle Wang Cc: Konstantin Aladyshev Acked-by: Laszlo Ersek Reviewed-by: Nickle Wang --- .../Include/Library/BasePldmProtocolLib.h | 6 ++--- .../PldmProtocol/Common/PldmProtocolCommon.h | 4 ++-- .../Common/KcsCommon.c | 2 +- .../PldmProtocolLibrary/Dxe/PldmProtocolLib.c | 10 ++++----- .../MctpProtocol/Common/MctpProtocolCommon.c | 22 ++++++++++++------- .../Universal/MctpProtocol/Dxe/MctpProtocol.c | 6 +++-- .../PldmProtocol/Common/PldmProtocolCommon.c | 12 +++++----- .../Universal/PldmProtocol/Dxe/PldmProtocol.c | 8 +++---- .../PldmSmbiosTransferDxe.c | 2 +- 9 files changed, 40 insertions(+), 32 deletions(-) diff --git a/Features/ManageabilityPkg/Include/Library/BasePldmProtocolLib.= h b/Features/ManageabilityPkg/Include/Library/BasePldmProtocolLib.h index a698197263..404474a023 100644 --- a/Features/ManageabilityPkg/Include/Library/BasePldmProtocolLib.h +++ b/Features/ManageabilityPkg/Include/Library/BasePldmProtocolLib.h @@ -21,9 +21,9 @@ **/ EFI_STATUS PldmSetTerminus ( - IN UINT8 SourceId, - IN UINT8 DestinationId -); + IN UINT8 SourceId, + IN UINT8 DestinationId + ); =20 /** This service enables submitting commands via EDKII PLDM protocol. diff --git a/Features/ManageabilityPkg/Universal/PldmProtocol/Common/PldmPr= otocolCommon.h b/Features/ManageabilityPkg/Universal/PldmProtocol/Common/Pl= dmProtocolCommon.h index eb273c4f46..30f4d95847 100644 --- a/Features/ManageabilityPkg/Universal/PldmProtocol/Common/PldmProtocolC= ommon.h +++ b/Features/ManageabilityPkg/Universal/PldmProtocol/Common/PldmProtocolC= ommon.h @@ -12,8 +12,8 @@ #include #include =20 -#define GET_PLDM_MESSAGE_PAYLOAD_SIZE(PayloadSize) (PayloadSize - sizeof (= PLDM_RESPONSE_HEADER)) -#define GET_PLDM_MESSAGE_PAYLOAD_PTR(PayloadPtr) ((UINT8 *)PayloadPtr + si= zeof (PLDM_RESPONSE_HEADER)) +#define GET_PLDM_MESSAGE_PAYLOAD_SIZE(PayloadSize) (PayloadSize - sizeof = (PLDM_RESPONSE_HEADER)) +#define GET_PLDM_MESSAGE_PAYLOAD_PTR(PayloadPtr) ((UINT8 *)PayloadPtr += sizeof (PLDM_RESPONSE_HEADER)) =20 typedef struct { UINT8 PldmType; diff --git a/Features/ManageabilityPkg/Library/ManageabilityTransportKcsLib= /Common/KcsCommon.c b/Features/ManageabilityPkg/Library/ManageabilityTransp= ortKcsLib/Common/KcsCommon.c index 4f7e7d450f..d80267cb57 100644 --- a/Features/ManageabilityPkg/Library/ManageabilityTransportKcsLib/Common= /KcsCommon.c +++ b/Features/ManageabilityPkg/Library/ManageabilityTransportKcsLib/Common= /KcsCommon.c @@ -496,7 +496,6 @@ KcsReadResponseHeader ( =20 *ResponseHeader =3D NULL; if (CompareGuid (&gManageabilityProtocolMctpGuid, mSingleSessionToken->T= oken.ManageabilityProtocolSpecification)) { - // For MCTP over KCS ExpectedHeaderSize =3D sizeof (MANAGEABILITY_MCTP_KCS_HEADER); DEBUG (( @@ -711,6 +710,7 @@ KcsTransportSendCommand ( =20 *ResponseDataSize =3D ((MANAGEABILITY_MCTP_KCS_HEADER *)RspHeader)->= ByteCount; } + FreePool (RspHeader); =20 ExpectedResponseDataSize =3D *ResponseDataSize; diff --git a/Features/ManageabilityPkg/Library/PldmProtocolLibrary/Dxe/Pldm= ProtocolLib.c b/Features/ManageabilityPkg/Library/PldmProtocolLibrary/Dxe/P= ldmProtocolLib.c index 37231b0756..9e1e664d6b 100644 --- a/Features/ManageabilityPkg/Library/PldmProtocolLibrary/Dxe/PldmProtoco= lLib.c +++ b/Features/ManageabilityPkg/Library/PldmProtocolLibrary/Dxe/PldmProtoco= lLib.c @@ -29,9 +29,9 @@ UINT8 mDestinationPldmTerminusId =3D 0; **/ EFI_STATUS PldmSetTerminus ( - IN UINT8 SourceId, - IN UINT8 DestinationId -) + IN UINT8 SourceId, + IN UINT8 DestinationId + ) { mSourcePldmTerminusId =3D SourceId; mDestinationPldmTerminusId =3D DestinationId; @@ -111,6 +111,7 @@ PldmSubmitCommand ( =20 return Status; } + /** =20 Initialize mSourcePldmTerminusId and mDestinationPldmTerminusId. @@ -128,7 +129,6 @@ PldmProtocolLibConstructor ( IN EFI_SYSTEM_TABLE *SystemTable ) { - - PldmSetTerminus (PcdGet8(PcdPldmSourceTerminusId), PcdGet8(PcdPldmDestin= ationEndpointId)); + PldmSetTerminus (PcdGet8 (PcdPldmSourceTerminusId), PcdGet8 (PcdPldmDest= inationEndpointId)); return EFI_SUCCESS; } diff --git a/Features/ManageabilityPkg/Universal/MctpProtocol/Common/MctpPr= otocolCommon.c b/Features/ManageabilityPkg/Universal/MctpProtocol/Common/Mc= tpProtocolCommon.c index 3709ab16eb..5509ed5ada 100644 --- a/Features/ManageabilityPkg/Universal/MctpProtocol/Common/MctpProtocolC= ommon.c +++ b/Features/ManageabilityPkg/Universal/MctpProtocol/Common/MctpProtocolC= ommon.c @@ -129,11 +129,11 @@ SetupMctpRequestTransportPacket ( OUT UINT16 *PacketTrailerSize ) { - MANAGEABILITY_MCTP_KCS_HEADER *MctpKcsHeader; - MCTP_TRANSPORT_HEADER *MctpTransportHeader; - MCTP_MESSAGE_HEADER *MctpMessageHeader; - MANAGEABILITY_MCTP_KCS_TRAILER *MctpKcsTrailer; - UINT8 *ThisPackage; + MANAGEABILITY_MCTP_KCS_HEADER *MctpKcsHeader; + MCTP_TRANSPORT_HEADER *MctpTransportHeader; + MCTP_MESSAGE_HEADER *MctpMessageHeader; + MANAGEABILITY_MCTP_KCS_TRAILER *MctpKcsTrailer; + UINT8 *ThisPackage; =20 if ((PacketHeader =3D=3D NULL) || (PacketHeaderSize =3D=3D NULL) || (PacketBody =3D=3D NULL) || (PacketBodySize =3D=3D NULL) || @@ -462,7 +462,7 @@ CommonMctpSubmitMessage ( ); =20 *AdditionalTransferError =3D TransferToken.TransportAdditionalStatus; - Status =3D TransferToken.TransferStatus; + Status =3D TransferToken.TransferStatus; if (EFI_ERROR (Status)) { DEBUG ((DEBUG_ERROR, "%a: Failed to send MCTP command over %s: %r\n", = __func__, mTransportName, Status)); return Status; @@ -480,6 +480,7 @@ CommonMctpSubmitMessage ( FreePool (ResponseBuffer); return EFI_DEVICE_ERROR; } + if (MctpTransportResponseHeader->Bits.MessageTag !=3D MCTP_MESSAGE_TAG) { DEBUG (( DEBUG_ERROR, @@ -491,6 +492,7 @@ CommonMctpSubmitMessage ( FreePool (ResponseBuffer); return EFI_DEVICE_ERROR; } + if (MctpTransportResponseHeader->Bits.TagOwner !=3D MCTP_MESSAGE_TAG_OWN= ER_RESPONSE) { DEBUG (( DEBUG_ERROR, @@ -502,6 +504,7 @@ CommonMctpSubmitMessage ( FreePool (ResponseBuffer); return EFI_DEVICE_ERROR; } + if (MctpTransportResponseHeader->Bits.SourceEndpointId !=3D MctpDestinat= ionEndpointId) { DEBUG (( DEBUG_ERROR, @@ -513,6 +516,7 @@ CommonMctpSubmitMessage ( FreePool (ResponseBuffer); return EFI_DEVICE_ERROR; } + if (MctpTransportResponseHeader->Bits.DestinationEndpointId !=3D MctpSou= rceEndpointId) { DEBUG (( DEBUG_ERROR, @@ -524,9 +528,11 @@ CommonMctpSubmitMessage ( FreePool (ResponseBuffer); return EFI_DEVICE_ERROR; } + if ((MctpTransportResponseHeader->Bits.StartOfMessage !=3D 1) || (MctpTransportResponseHeader->Bits.EndOfMessage !=3D 1) || - (MctpTransportResponseHeader->Bits.PacketSequence !=3D 0)) { + (MctpTransportResponseHeader->Bits.PacketSequence !=3D 0)) + { DEBUG (( DEBUG_ERROR, "%a: Error! Multiple-packet MCTP responses are not supported by the = current driver\n", @@ -561,7 +567,7 @@ CommonMctpSubmitMessage ( return EFI_DEVICE_ERROR; } =20 - *ResponseDataSize =3D TransferToken.ReceivePackage.ReceiveSizeInB= yte - sizeof (MCTP_TRANSPORT_HEADER) - sizeof (MCTP_MESSAGE_HEADER); + *ResponseDataSize =3D TransferToken.ReceivePackage.ReceiveSizeInByte - s= izeof (MCTP_TRANSPORT_HEADER) - sizeof (MCTP_MESSAGE_HEADER); CopyMem (ResponseData, ResponseBuffer + sizeof (MCTP_TRANSPORT_HEADER) += sizeof (MCTP_MESSAGE_HEADER), *ResponseDataSize); FreePool (ResponseBuffer); =20 diff --git a/Features/ManageabilityPkg/Universal/MctpProtocol/Dxe/MctpProto= col.c b/Features/ManageabilityPkg/Universal/MctpProtocol/Dxe/MctpProtocol.c index 73445bf816..a133341906 100644 --- a/Features/ManageabilityPkg/Universal/MctpProtocol/Dxe/MctpProtocol.c +++ b/Features/ManageabilityPkg/Universal/MctpProtocol/Dxe/MctpProtocol.c @@ -105,14 +105,16 @@ MctpSubmitMessage ( // if ((SourceEid >=3D MCTP_RESERVED_ENDPOINT_START_ID) && (SourceEid <=3D MCTP_RESERVED_ENDPOINT_END_ID) - ) { + ) + { DEBUG ((DEBUG_ERROR, "%a: The value of MCTP source EID (%x) is reserve= d.\n", __func__, MctpSourceEndpointId)); return EFI_INVALID_PARAMETER; } =20 if ((DestinationEid >=3D MCTP_RESERVED_ENDPOINT_START_ID) && (DestinationEid <=3D MCTP_RESERVED_ENDPOINT_END_ID) - ) { + ) + { DEBUG ((DEBUG_ERROR, "%a: The value of MCTP destination EID (%x) is re= served.\n", __func__, MctpDestinationEndpointId)); return EFI_INVALID_PARAMETER; } diff --git a/Features/ManageabilityPkg/Universal/PldmProtocol/Common/PldmPr= otocolCommon.c b/Features/ManageabilityPkg/Universal/PldmProtocol/Common/Pl= dmProtocolCommon.c index 2f2f76603e..bb38520ec0 100644 --- a/Features/ManageabilityPkg/Universal/PldmProtocol/Common/PldmProtocolC= ommon.c +++ b/Features/ManageabilityPkg/Universal/PldmProtocol/Common/PldmProtocolC= ommon.c @@ -231,7 +231,7 @@ CommonPldmSubmitCommand ( TransferToken.TransmitPackage.TransmitTimeoutInMillisecond =3D MANAGEABI= LITY_TRANSPORT_NO_TIMEOUT; =20 // Set receive packet. - if (ResponseData =3D=3D NULL && *ResponseDataSize =3D=3D 0) { + if ((ResponseData =3D=3D NULL) && (*ResponseDataSize =3D=3D 0)) { FullPacketResponseDataSize =3D sizeof (PLDM_RESPONSE_HEADER); } else { FullPacketResponseDataSize =3D *ResponseDataSize + sizeof (PLDM_RESPON= SE_HEADER); @@ -326,16 +326,16 @@ CommonPldmSubmitCommand ( goto ErrorExit; } =20 - if (*ResponseDataSize < GET_PLDM_MESSAGE_PAYLOAD_SIZE(TransferToken.Rece= ivePackage.ReceiveSizeInByte)) { + if (*ResponseDataSize < GET_PLDM_MESSAGE_PAYLOAD_SIZE (TransferToken.Rec= eivePackage.ReceiveSizeInByte)) { DEBUG ((DEBUG_ERROR, " The size of response is not matched to Request= DataSize assigned by caller.\n")); DEBUG (( DEBUG_ERROR, "Caller expects %d, the response size minus PLDM_RESPONSE_HEADER siz= e is %d, Completion Code %d.\n", *ResponseDataSize, - GET_PLDM_MESSAGE_PAYLOAD_SIZE(TransferToken.ReceivePackage.ReceiveSi= zeInByte), + GET_PLDM_MESSAGE_PAYLOAD_SIZE (TransferToken.ReceivePackage.ReceiveS= izeInByte), ResponseHeader->PldmCompletionCode )); - HelperManageabilityDebugPrint ((VOID *)FullPacketResponseData, GET_PLD= M_MESSAGE_PAYLOAD_SIZE(TransferToken.ReceivePackage.ReceiveSizeInByte), "Fa= iled response payload\n"); + HelperManageabilityDebugPrint ((VOID *)FullPacketResponseData, GET_PLD= M_MESSAGE_PAYLOAD_SIZE (TransferToken.ReceivePackage.ReceiveSizeInByte), "F= ailed response payload\n"); Status =3D EFI_DEVICE_ERROR; goto ErrorExit; } @@ -345,10 +345,10 @@ CommonPldmSubmitCommand ( =20 // Copy response data (without header) to caller's buffer. if ((ResponseData !=3D NULL) && (*ResponseDataSize !=3D 0)) { - *ResponseDataSize =3D GET_PLDM_MESSAGE_PAYLOAD_SIZE(TransferToken.Rece= ivePackage.ReceiveSizeInByte); + *ResponseDataSize =3D GET_PLDM_MESSAGE_PAYLOAD_SIZE (TransferToken.Rec= eivePackage.ReceiveSizeInByte); CopyMem ( (VOID *)ResponseData, - GET_PLDM_MESSAGE_PAYLOAD_PTR(FullPacketResponseData), + GET_PLDM_MESSAGE_PAYLOAD_PTR (FullPacketResponseData), *ResponseDataSize ); } diff --git a/Features/ManageabilityPkg/Universal/PldmProtocol/Dxe/PldmProto= col.c b/Features/ManageabilityPkg/Universal/PldmProtocol/Dxe/PldmProtocol.c index 058f98e677..fce8029b9c 100644 --- a/Features/ManageabilityPkg/Universal/PldmProtocol/Dxe/PldmProtocol.c +++ b/Features/ManageabilityPkg/Universal/PldmProtocol/Dxe/PldmProtocol.c @@ -63,7 +63,7 @@ PldmSubmitCommand ( // // Check the given input parameters. // - if (RequestData =3D=3D NULL && RequestDataSize !=3D 0) { + if ((RequestData =3D=3D NULL) && (RequestDataSize !=3D 0)) { DEBUG (( DEBUG_ERROR, "%a: RequestDataSize !=3D 0, however RequestData is NULL for PLDM ty= pe: 0x%x, Command: 0x%x.\n", @@ -74,7 +74,7 @@ PldmSubmitCommand ( return EFI_INVALID_PARAMETER; } =20 - if (RequestData !=3D NULL && RequestDataSize =3D=3D 0) { + if ((RequestData !=3D NULL) && (RequestDataSize =3D=3D 0)) { DEBUG (( DEBUG_ERROR, "%a: RequestDataSize =3D=3D 0, however RequestData is not NULL for P= LDM type: 0x%x, Command: 0x%x.\n", @@ -85,7 +85,7 @@ PldmSubmitCommand ( return EFI_INVALID_PARAMETER; } =20 - if (ResponseData =3D=3D NULL && *ResponseDataSize !=3D 0) { + if ((ResponseData =3D=3D NULL) && (*ResponseDataSize !=3D 0)) { DEBUG (( DEBUG_ERROR, "%a: *ResponseDataSize !=3D 0, however ResponseData is NULL for PLDM= type: 0x%x, Command: 0x%x.\n", @@ -96,7 +96,7 @@ PldmSubmitCommand ( return EFI_INVALID_PARAMETER; } =20 - if (ResponseData !=3D NULL && *ResponseDataSize =3D=3D 0) { + if ((ResponseData !=3D NULL) && (*ResponseDataSize =3D=3D 0)) { DEBUG (( DEBUG_ERROR, "%a: *ResponseDataSize =3D=3D 0, however ResponseData is not NULL fo= r PLDM type: 0x%x, Command: 0x%x.\n", diff --git a/Features/ManageabilityPkg/Universal/PldmSmbiosTransferDxe/Pldm= SmbiosTransferDxe.c b/Features/ManageabilityPkg/Universal/PldmSmbiosTransfe= rDxe/PldmSmbiosTransferDxe.c index 357a7d49e4..81e9adf571 100644 --- a/Features/ManageabilityPkg/Universal/PldmSmbiosTransferDxe/PldmSmbiosT= ransferDxe.c +++ b/Features/ManageabilityPkg/Universal/PldmSmbiosTransferDxe/PldmSmbiosT= ransferDxe.c @@ -49,7 +49,7 @@ SetPldmSmbiosTransferTerminusId ( IN UINT8 DestinationId ) { - return PldmSetTerminus(SourceId, DestinationId); + return PldmSetTerminus (SourceId, DestinationId); } =20 /** --=20 2.37.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110079): https://edk2.groups.io/g/devel/message/110079 Mute This Topic: https://groups.io/mt/102195867/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-