1. Patchew
  2. EDK2
  3. View series

[edk2-devel] [PATCH 0/2] MdeModulePkg/Core/Dxe: Fix memory leak issues

Mike Maslenkin posted 2 patches 8 months ago
Failed in applying to current master (apply log)
[edk2-devel] [PATCH 0/2] MdeModulePkg/Core/Dxe: Fix memory leak issues
Posted by Mike Maslenkin 8 months ago 
Please, find trivial memory leak fixes on error path.

The only question: is it required to use FreePool() or CoreFreePool()
from DXE core code? Patch 2/2 is made in accordance with existing code.

Cc: Dandan Bi <dandan.bi@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108220): https://edk2.groups.io/g/devel/message/108220
Mute This Topic: https://groups.io/mt/101085561/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 0/2] MdeModulePkg/Core/Dxe: Fix memory leak issues
Posted by Michael D Kinney 7 months, 3 weeks ago 
Series Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>


> -----Original Message-----
> From: Mike Maslenkin <mike.maslenkin@gmail.com>
> Sent: Thursday, August 31, 2023 5:11 PM
> To: devel@edk2.groups.io
> Cc: Bi, Dandan <dandan.bi@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Kinney, Michael D <michael.d.kinney@intel.com>;
> Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Mike Maslenkin
> <mike.maslenkin@gmail.com>
> Subject: [PATCH 0/2] MdeModulePkg/Core/Dxe: Fix memory leak issues
> 
> Please, find trivial memory leak fixes on error path.
> 
> The only question: is it required to use FreePool() or CoreFreePool()
> from DXE core code? Patch 2/2 is made in accordance with existing code.
> 
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108463): https://edk2.groups.io/g/devel/message/108463
Mute This Topic: https://groups.io/mt/101085561/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076/xyzzy [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 0/2] MdeModulePkg/Core/Dxe: Fix memory leak issues
Posted by Michael D Kinney 7 months, 3 weeks ago 
Hi Mike,

I have created a PR to run EDK II CI while we wait for a 
review from one of the DXE Core Maintainers

https://github.com/tianocore/edk2/pull/4815

Mike


> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: Friday, September 8, 2023 2:40 PM
> To: Mike Maslenkin <mike.maslenkin@gmail.com>; devel@edk2.groups.io
> Cc: Bi, Dandan <dandan.bi@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: RE: [PATCH 0/2] MdeModulePkg/Core/Dxe: Fix memory leak issues
> 
> Series Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> 
> 
> > -----Original Message-----
> > From: Mike Maslenkin <mike.maslenkin@gmail.com>
> > Sent: Thursday, August 31, 2023 5:11 PM
> > To: devel@edk2.groups.io
> > Cc: Bi, Dandan <dandan.bi@intel.com>; Gao, Liming
> > <gaoliming@byosoft.com.cn>; Kinney, Michael D
> <michael.d.kinney@intel.com>;
> > Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Mike Maslenkin
> > <mike.maslenkin@gmail.com>
> > Subject: [PATCH 0/2] MdeModulePkg/Core/Dxe: Fix memory leak issues
> >
> > Please, find trivial memory leak fixes on error path.
> >
> > The only question: is it required to use FreePool() or CoreFreePool()
> > from DXE core code? Patch 2/2 is made in accordance with existing code.
> >
> > Cc: Dandan Bi <dandan.bi@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> > Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
> >



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108466): https://edk2.groups.io/g/devel/message/108466
Mute This Topic: https://groups.io/mt/101085561/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076/xyzzy [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
回复: [edk2-devel] [PATCH 0/2] MdeModulePkg/Core/Dxe: Fix memory leak issues
Posted by gaoliming via groups.io 7 months, 3 weeks ago 
Fort this patch set, Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Michael D
> Kinney
> 发送时间: 2023年9月9日 5:50
> 收件人: Mike Maslenkin <mike.maslenkin@gmail.com>;
> devel@edk2.groups.io
> 抄送: Bi, Dandan <dandan.bi@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Wang, Jian J <jian.j.wang@intel.com>;
> Kinney, Michael D <michael.d.kinney@intel.com>
> 主题: Re: [edk2-devel] [PATCH 0/2] MdeModulePkg/Core/Dxe: Fix memory
> leak issues
> 
> Hi Mike,
> 
> I have created a PR to run EDK II CI while we wait for a
> review from one of the DXE Core Maintainers
> 
> https://github.com/tianocore/edk2/pull/4815
> 
> Mike
> 
> 
> > -----Original Message-----
> > From: Kinney, Michael D <michael.d.kinney@intel.com>
> > Sent: Friday, September 8, 2023 2:40 PM
> > To: Mike Maslenkin <mike.maslenkin@gmail.com>; devel@edk2.groups.io
> > Cc: Bi, Dandan <dandan.bi@intel.com>; Gao, Liming
> > <gaoliming@byosoft.com.cn>; Desimone, Nathaniel L
> > <nathaniel.l.desimone@intel.com>; Kinney, Michael D
> > <michael.d.kinney@intel.com>
> > Subject: RE: [PATCH 0/2] MdeModulePkg/Core/Dxe: Fix memory leak issues
> >
> > Series Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> >
> >
> > > -----Original Message-----
> > > From: Mike Maslenkin <mike.maslenkin@gmail.com>
> > > Sent: Thursday, August 31, 2023 5:11 PM
> > > To: devel@edk2.groups.io
> > > Cc: Bi, Dandan <dandan.bi@intel.com>; Gao, Liming
> > > <gaoliming@byosoft.com.cn>; Kinney, Michael D
> > <michael.d.kinney@intel.com>;
> > > Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Mike
> Maslenkin
> > > <mike.maslenkin@gmail.com>
> > > Subject: [PATCH 0/2] MdeModulePkg/Core/Dxe: Fix memory leak issues
> > >
> > > Please, find trivial memory leak fixes on error path.
> > >
> > > The only question: is it required to use FreePool() or CoreFreePool()
> > > from DXE core code? Patch 2/2 is made in accordance with existing
code.
> > >
> > > Cc: Dandan Bi <dandan.bi@intel.com>
> > > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> > > Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
> > >
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108470): https://edk2.groups.io/g/devel/message/108470
Mute This Topic: https://groups.io/mt/101284117/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 0/2] MdeModulePkg/Core/Dxe: Fix memory leak issues
Posted by Michael D Kinney 7 months, 3 weeks ago 
Merged: https://github.com/tianocore/edk2/pull/4815


> -----Original Message-----
> From: gaoliming <gaoliming@byosoft.com.cn>
> Sent: Sunday, September 10, 2023 5:55 PM
> To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>;
> 'Mike Maslenkin' <mike.maslenkin@gmail.com>
> Cc: Bi, Dandan <dandan.bi@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Wang, Jian J <jian.j.wang@intel.com>
> Subject: 回复: [edk2-devel] [PATCH 0/2] MdeModulePkg/Core/Dxe: Fix memory
> leak issues
> 
> Fort this patch set, Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> 
> > -----邮件原件-----
> > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Michael D
> > Kinney
> > 发送时间: 2023年9月9日 5:50
> > 收件人: Mike Maslenkin <mike.maslenkin@gmail.com>;
> > devel@edk2.groups.io
> > 抄送: Bi, Dandan <dandan.bi@intel.com>; Gao, Liming
> > <gaoliming@byosoft.com.cn>; Desimone, Nathaniel L
> > <nathaniel.l.desimone@intel.com>; Wang, Jian J <jian.j.wang@intel.com>;
> > Kinney, Michael D <michael.d.kinney@intel.com>
> > 主题: Re: [edk2-devel] [PATCH 0/2] MdeModulePkg/Core/Dxe: Fix memory
> > leak issues
> >
> > Hi Mike,
> >
> > I have created a PR to run EDK II CI while we wait for a
> > review from one of the DXE Core Maintainers
> >
> > https://github.com/tianocore/edk2/pull/4815
> >
> > Mike
> >
> >
> > > -----Original Message-----
> > > From: Kinney, Michael D <michael.d.kinney@intel.com>
> > > Sent: Friday, September 8, 2023 2:40 PM
> > > To: Mike Maslenkin <mike.maslenkin@gmail.com>; devel@edk2.groups.io
> > > Cc: Bi, Dandan <dandan.bi@intel.com>; Gao, Liming
> > > <gaoliming@byosoft.com.cn>; Desimone, Nathaniel L
> > > <nathaniel.l.desimone@intel.com>; Kinney, Michael D
> > > <michael.d.kinney@intel.com>
> > > Subject: RE: [PATCH 0/2] MdeModulePkg/Core/Dxe: Fix memory leak issues
> > >
> > > Series Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> > >
> > >
> > > > -----Original Message-----
> > > > From: Mike Maslenkin <mike.maslenkin@gmail.com>
> > > > Sent: Thursday, August 31, 2023 5:11 PM
> > > > To: devel@edk2.groups.io
> > > > Cc: Bi, Dandan <dandan.bi@intel.com>; Gao, Liming
> > > > <gaoliming@byosoft.com.cn>; Kinney, Michael D
> > > <michael.d.kinney@intel.com>;
> > > > Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Mike
> > Maslenkin
> > > > <mike.maslenkin@gmail.com>
> > > > Subject: [PATCH 0/2] MdeModulePkg/Core/Dxe: Fix memory leak issues
> > > >
> > > > Please, find trivial memory leak fixes on error path.
> > > >
> > > > The only question: is it required to use FreePool() or CoreFreePool()
> > > > from DXE core code? Patch 2/2 is made in accordance with existing
> code.
> > > >
> > > > Cc: Dandan Bi <dandan.bi@intel.com>
> > > > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> > > > Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
> > > >
> >
> >
> >
> > 
> >
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108473): https://edk2.groups.io/g/devel/message/108473
Mute This Topic: https://groups.io/mt/101285586/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076/xyzzy [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.