From nobody Wed May 15 07:44:00 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+108079+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+108079+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1693296082; cv=none; d=zohomail.com; s=zohoarc; b=F2o8G5+TCnIZrgEeQlGsLQy0GN7NH4Bn4so5/ln77m7fLzKkQNIAEJB5y/UungfqsZbeiiOidVLwbLMXnLqNptIxgo5ukv2ZMDrNUQ1lsY/7vuuZ0zx8PS7NA7rVQbnXa+tvfmVQSGdXY8Jpsy/jAOCqpFn5kj04VVtlyXcPldc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1693296082; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=6fg0BzG0s4WYdbf/wFaXbjwT0/Wf++Bl5ZBqMxorFmI=; b=MA61RCjdzIgZMu1lIomAKc2aY8YySM50NYWdanAL4evMi/lRlr8lXJ08POB8M5Ro4xZVed0vtp+4AmoOE5u+D4gDgYT+hf3uIleECUSDM/UJnBpEBUuhuKuCBF4sRK8zLzmeCCCsbBH1hRLf9kA8FNx72eHmfRE/cmgOuzCztBU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+108079+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1693296082110286.10507763985026; Tue, 29 Aug 2023 01:01:22 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=nl/8k8zuSnObXE4o3xmQgoGOZHpJXSoFJkxkhi8at3U=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1693296081; v=1; b=FwM99M4SdKTguTt0NdGtP57j9AdlAIdxMkDn7lR/58x5i3XiZyrouwTvTNxzwux8HpZuzQYL 3lzBn7G5s+qETLSIdXn6Zv0/ouYsL124w9uw1F5m3COwOVAgQSvp6rhO2QHpfKySBIkvHjDOYby E5ItbYXyzyw8OgfVnX2DK7vE= X-Received: by 127.0.0.2 with SMTP id sU3SYY1788612xzZ0ERf0S2T; Tue, 29 Aug 2023 01:01:21 -0700 X-Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) by mx.groups.io with SMTP id smtpd.web11.12653.1693296081009871383 for ; Tue, 29 Aug 2023 01:01:21 -0700 X-Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-2bbad32bc79so60726401fa.0 for ; Tue, 29 Aug 2023 01:01:20 -0700 (PDT) X-Gm-Message-State: fnwndwqBWcLtXPcKbFnnCAKIx1787277AA= X-Google-Smtp-Source: AGHT+IEo4sRybueHqYc4KvYyLsPU1W9jELnSdyxDxMHew7z3C9DIfmmpx6IkhU61WcFVlOBaLzLNmw== X-Received: by 2002:a05:651c:210e:b0:2bc:ffe5:54a1 with SMTP id a14-20020a05651c210e00b002bcffe554a1mr7573125ljq.32.1693296079058; Tue, 29 Aug 2023 01:01:19 -0700 (PDT) X-Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id h10-20020a2e900a000000b002ba130e9a29sm2077325ljg.76.2023.08.29.01.01.18 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 29 Aug 2023 01:01:18 -0700 (PDT) From: "Mike Maslenkin" To: devel@edk2.groups.io Cc: abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, Mike Maslenkin Subject: [edk2-devel] [PATCH v2 1/6] RedfishClientPkg: fix crash on access to uninialized list variable. Date: Tue, 29 Aug 2023 11:01:07 +0300 Message-Id: <20230829080112.12748-2-mike.maslenkin@gmail.com> In-Reply-To: <20230829080112.12748-1-mike.maslenkin@gmail.com> References: <20230829080112.12748-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1693296082966100001 Content-Type: text/plain; charset="utf-8" Signed-off-by: Mike Maslenkin Reviewed-by: Nickle Wang > Reviewed-by: Nickle Wang --- RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c b/Re= dfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c index b9c799e07684..a1738de46fdf 100644 --- a/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c +++ b/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c @@ -97,6 +97,8 @@ RedfishConsumeResourceCommon ( if (BiosCs->Attributes =3D=3D NULL) { BiosCs->Attributes =3D AllocateZeroPool (sizeof (RedfishBios_V1_0_9_At= tributes_CS)); ASSERT (BiosCs->Attributes !=3D NULL); + // initialize list + BiosCs->Attributes->Prop.ForwardLink =3D &BiosCs->Attributes->Prop; } =20 // --=20 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108079): https://edk2.groups.io/g/devel/message/108079 Mute This Topic: https://groups.io/mt/101027003/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Wed May 15 07:44:00 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+108080+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+108080+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1693296083; cv=none; d=zohomail.com; s=zohoarc; b=gdMeQYcLQLVk4lAJBFQyNtg2EgpIPyU1mDoeCpNqAAcDrLJMjf/sdwnHzCFzVbzzAuiOgltDg/6zpWdqq2n4okLzLZaf91CzFqTQTlx+D1Fv2oV3AjT44TmUTMksc6TecuxkLyv8MGmBHb3PM/DwC7KoyhZno6bLr5j5mGcAfBo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1693296083; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=8mO0e3Z7RmtsplwwCCzWF93qHd/05sNAGt12KlWKhLM=; b=iLcN9DBorPywnto1DZodW8i2yLg+MS4vqRBP+9GFLWRjdqRjrY0+OPnyi/UFeWkWRMBJZiKv/2aSmIiedwFEOsg7L72Pf/fLGWJA28YfyFxB0hiyEnPD6g5E1P/a7RYkapkRspj+uArE01gMokb59J+MnJCDzgeZgi3GURY4SJo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+108080+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1693296083275500.89417895433576; Tue, 29 Aug 2023 01:01:23 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=U9Zap57HBktiGr7YQmmMFfCOOyjuENU0iz5qoOyGOl8=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1693296082; v=1; b=FLY+3OhqSuarO75/EjKljhgG9fuvZdLCQc9Fllrba5wDCDcYyGcIX6bs0D8i2RdS7f+dDpCV 9LDpOPfRX6zOhDYuK7jcysQ7emhRWqB574UyUZMmMlcu5anv/GVpADy9JjkcfMS7yXlP0QYauLy 2ueKu2C7JhTKClq+AYEf1pf8= X-Received: by 127.0.0.2 with SMTP id zIKSYY1788612xJQKxZuYkUG; Tue, 29 Aug 2023 01:01:22 -0700 X-Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) by mx.groups.io with SMTP id smtpd.web11.12654.1693296082114030428 for ; Tue, 29 Aug 2023 01:01:22 -0700 X-Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-2bd0bc8b429so30822281fa.2 for ; Tue, 29 Aug 2023 01:01:21 -0700 (PDT) X-Gm-Message-State: 8IfPz30zTfipmSEhh3qcr7TZx1787277AA= X-Google-Smtp-Source: AGHT+IHOcq0a/RcNwj+X59r7Q3tXoHLoHkKoPjoaKDBiRn6R28LF+bCaGLTB/IxyEDvUa4a1gq26Zg== X-Received: by 2002:a2e:3812:0:b0:2bc:b8f5:aaf1 with SMTP id f18-20020a2e3812000000b002bcb8f5aaf1mr17589945lja.35.1693296080037; Tue, 29 Aug 2023 01:01:20 -0700 (PDT) X-Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id h10-20020a2e900a000000b002ba130e9a29sm2077325ljg.76.2023.08.29.01.01.19 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 29 Aug 2023 01:01:19 -0700 (PDT) From: "Mike Maslenkin" To: devel@edk2.groups.io Cc: abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, Mike Maslenkin Subject: [edk2-devel] [PATCH v2 2/6] RedfishClientPkg: fix access to uninitialized variable Date: Tue, 29 Aug 2023 11:01:08 +0300 Message-Id: <20230829080112.12748-3-mike.maslenkin@gmail.com> In-Reply-To: <20230829080112.12748-1-mike.maslenkin@gmail.com> References: <20230829080112.12748-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1693296085440100011 Content-Type: text/plain; charset="utf-8" This patch fixes access to uninitialized variable, causing ASSERT from FreePool at least. Before this patch RedfishSettingsResponse was initialized by GetResourceByUri under 'if (JsonValue !=3D NULL)' condition. But freed under 'if (Private->Payload !=3D NULL)' condition. Thus uninitialized pointers caused ASSERT on attempt to free memory. Signed-off-by: Mike Maslenkin Reviewed-by: Nickle Wang --- RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c b/RedfishC= lientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c index e7ac8779581c..f5562fb49cab 100644 --- a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c +++ b/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c @@ -128,6 +128,8 @@ RedfishResourceConsumeResource ( return Status; } =20 + ZeroMem (&RedfishSettingsResponse, sizeof (REDFISH_RESPONSE)); + ExpectedResponse =3D &Response; RedfishSettingsUri =3D NULL; JsonValue =3D RedfishJsonInPayload (Response.Payload); --=20 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108080): https://edk2.groups.io/g/devel/message/108080 Mute This Topic: https://groups.io/mt/101027004/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Wed May 15 07:44:00 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+108081+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+108081+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1693296084; cv=none; d=zohomail.com; s=zohoarc; b=UkJo8rkJI/lijMWi4jzJgxtCDaN+wii9+e+cCX7ofujwIlmWE7/EBsl8yfG6GpO9C7+N8gNT9N/krnhuoO+ubbF1CFbDxsrjJTrd26Oj1e95z7zYp2yGjT1Tj4tBivteL/EpnjzbO9W5A/ZUBTPVzTNYeEm9iCydXw3r2Plviz8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1693296084; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=dLWDp9Hl1oJmERianA0Z+b8E8xGZekmtM6iXnsFSwSI=; b=FlSrG/Yrb6QIuGXR0NkE5qRoufKkv1s3tpUGYsCeShMLaFeEQGCmea2uY2P4jk1g/lGG56VPiClrlZTIvA7nRE/4gsJRFO1b87cHrRLTbhFIm4etjO6PsRu85jiZXYIQqJk6RklZH8fmFwg+PoSwyQBcF28EJED0z1H5/WnL/i8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+108081+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1693296084407385.28213220716725; Tue, 29 Aug 2023 01:01:24 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=MO3xOoCsq0erGQF1Wu49l/cY56hB/jJqnQ5y/R+3Ce0=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1693296084; v=1; b=SokbwcBikRoh1Xl80e1mSpI6GNa4KbkWwOZnVeV5N+IpjcOzSmxgTx3JKS4OP25JEy9sRlfZ d7ySScLU68BZI1QY6V8NoB+wisy04wgdS3jJ9VLE4ETGHs8ymIclq+1Ans5Go1Jk3E+f4CpPsDZ NPVr1ETzd/EnRvkV3GXrCHC8= X-Received: by 127.0.0.2 with SMTP id 7PT2YY1788612xvPAqRoLMQP; Tue, 29 Aug 2023 01:01:24 -0700 X-Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) by mx.groups.io with SMTP id smtpd.web11.12655.1693296083132047584 for ; Tue, 29 Aug 2023 01:01:23 -0700 X-Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-2bcb50e194dso61921461fa.3 for ; Tue, 29 Aug 2023 01:01:22 -0700 (PDT) X-Gm-Message-State: UGZlx6ttrw16sZWEPmMYxg9Mx1787277AA= X-Google-Smtp-Source: AGHT+IExhTXTKl/NMvFSvJo3X+2+tLmNsN0vZXlnIwRcGyiOp6MOoO5ajdWGfTQEhRT3ZesLiaujQw== X-Received: by 2002:a2e:8687:0:b0:2bc:d993:bdaa with SMTP id l7-20020a2e8687000000b002bcd993bdaamr14370585lji.18.1693296081020; Tue, 29 Aug 2023 01:01:21 -0700 (PDT) X-Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id h10-20020a2e900a000000b002ba130e9a29sm2077325ljg.76.2023.08.29.01.01.20 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 29 Aug 2023 01:01:20 -0700 (PDT) From: "Mike Maslenkin" To: devel@edk2.groups.io Cc: abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, Mike Maslenkin Subject: [edk2-devel] [PATCH v2 3/6] RedfishClientPkg: fix leak of allocated Etag data Date: Tue, 29 Aug 2023 11:01:09 +0300 Message-Id: <20230829080112.12748-4-mike.maslenkin@gmail.com> In-Reply-To: <20230829080112.12748-1-mike.maslenkin@gmail.com> References: <20230829080112.12748-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1693296085682100015 Content-Type: text/plain; charset="utf-8" Signed-off-by: Mike Maslenkin Reviewed-by: Nickle Wang --- RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c | 4 ++++ .../Features/ComputerSystem/v1_5_0/Dxe/ComputerSystemDxe.c | 4 ++++ RedfishClientPkg/Features/Memory/V1_7_1/Dxe/MemoryDxe.c | 4 ++++ 3 files changed, 12 insertions(+) diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c b/RedfishC= lientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c index f5562fb49cab..32dca964aa0a 100644 --- a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c +++ b/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c @@ -220,6 +220,10 @@ RedfishResourceConsumeResource ( Private->Json =3D NULL; } =20 + if (Etag !=3D NULL) { + FreePool (Etag); + } + return Status; } =20 diff --git a/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Dxe/ComputerSy= stemDxe.c b/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Dxe/ComputerSys= temDxe.c index 91968dbe488f..5c2a4eadf2f4 100644 --- a/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Dxe/ComputerSystemDxe= .c +++ b/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Dxe/ComputerSystemDxe= .c @@ -164,6 +164,10 @@ RedfishResourceConsumeResource ( Private->Json =3D NULL; } =20 + if (Etag !=3D NULL) { + FreePool (Etag); + } + return Status; } =20 diff --git a/RedfishClientPkg/Features/Memory/V1_7_1/Dxe/MemoryDxe.c b/Redf= ishClientPkg/Features/Memory/V1_7_1/Dxe/MemoryDxe.c index c55a6848c74e..f34f3266f1ee 100644 --- a/RedfishClientPkg/Features/Memory/V1_7_1/Dxe/MemoryDxe.c +++ b/RedfishClientPkg/Features/Memory/V1_7_1/Dxe/MemoryDxe.c @@ -164,6 +164,10 @@ RedfishResourceConsumeResource ( Private->Json =3D NULL; } =20 + if (Etag !=3D NULL) { + FreePool (Etag); + } + return Status; } =20 --=20 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108081): https://edk2.groups.io/g/devel/message/108081 Mute This Topic: https://groups.io/mt/101027005/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Wed May 15 07:44:00 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+108082+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+108082+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1693296084; cv=none; d=zohomail.com; s=zohoarc; b=IfFHnBpfYwI2E8MKrrWkl0+t5XgpiGdLNX0WUPUG6UhSrIvUcVAcqe3jJY2TzELfuOV7UO315XxtuIgdfPscC41YyhrUGhlUC+xdZjx047j9C9XZoukyaHXFvtHoDngnZN1xZPYjyDEidwJ/9a6D/U9okadLjnl6O/+pUyKc4ko= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1693296084; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=cYhwdvsphzHAke8nzkqVawumNNhtDpVIvLmSY+blGIk=; b=Fltzd4zfxauCL5MEmKUgFW6hLUfySO+UABr5bIq9X4RL2GyeP7N4LvxAvV5fxVBEz7f8qYMHrqhRfBMf+ccJ4lSUmQOgKdMPO73vCHZCHBnQigARi0NR+gk6YiOPo26UlmFOsU/koRRI3Uo9RWSxGgTn4MRlWSRL27eMSorqTG4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+108082+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1693296084969678.2276424157855; Tue, 29 Aug 2023 01:01:24 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=jifU8DDx4IurjN8MF7lVhgj4EJt/CP98H+Um1/uHvzY=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1693296084; v=1; b=YTx46dLHZA1xfOYvANv13HmsDWzTleh+6xgRfKy+tH2oY4zQwJD7olmsZIEwakLDUgpqr0uW I0TpVOurWHR2x0yJsbZOTvkTjnr+Nfsi8o5wYup9T2FQNsnlE0EeCHJ40FouqE2NdEzNMDS/TAi mYbNbJAOLr7FhJ7TB0VQMH0Q= X-Received: by 127.0.0.2 with SMTP id StE4YY1788612x0j3JJfufkf; Tue, 29 Aug 2023 01:01:24 -0700 X-Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) by mx.groups.io with SMTP id smtpd.web10.12621.1693296083788169896 for ; Tue, 29 Aug 2023 01:01:24 -0700 X-Received: by mail-lj1-f171.google.com with SMTP id 38308e7fff4ca-2b9c907bc68so60355541fa.2 for ; Tue, 29 Aug 2023 01:01:23 -0700 (PDT) X-Gm-Message-State: gaMBYuv4690W3OmCHkoWpWhMx1787277AA= X-Google-Smtp-Source: AGHT+IH2rktwKF+UKHLuxCc50Q2d2ZPqod6PYdnMw30CUjj+aoBZPGJ5l29+6AfG8zliIhiwzFpUVw== X-Received: by 2002:a2e:988d:0:b0:2b9:4413:864e with SMTP id b13-20020a2e988d000000b002b94413864emr20318792ljj.53.1693296081799; Tue, 29 Aug 2023 01:01:21 -0700 (PDT) X-Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id h10-20020a2e900a000000b002ba130e9a29sm2077325ljg.76.2023.08.29.01.01.21 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 29 Aug 2023 01:01:21 -0700 (PDT) From: "Mike Maslenkin" To: devel@edk2.groups.io Cc: abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, Mike Maslenkin Subject: [edk2-devel] [PATCH v2 4/6] RedfishClientPkg: fix memory leak during EFI variables write. Date: Tue, 29 Aug 2023 11:01:10 +0300 Message-Id: <20230829080112.12748-5-mike.maslenkin@gmail.com> In-Reply-To: <20230829080112.12748-1-mike.maslenkin@gmail.com> References: <20230829080112.12748-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1693296085483100012 Content-Type: text/plain; charset="utf-8" Signed-off-by: Mike Maslenkin Reviewed-by: Nickle Wang --- .../RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.c | 6 +++++- RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c | 6 +++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/RedfishClientPkg/RedfishConfigLangMapDxe/RedfishConfigLangMapD= xe.c b/RedfishClientPkg/RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.c index 86684cc72e1e..6a72afed8715 100644 --- a/RedfishClientPkg/RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.c +++ b/RedfishClientPkg/RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.c @@ -424,7 +424,11 @@ SaveConfigLangMapList ( gRT->SetVariable (VariableName, &gEfiRedfishClientVariableGuid, VARIAB= LE_ATTRIBUTE_NV_BS, 0, NULL); } =20 - return gRT->SetVariable (VariableName, &gEfiRedfishClientVariableGuid, V= ARIABLE_ATTRIBUTE_NV_BS, VarSize, (VOID *)VarData); + Status =3D gRT->SetVariable (VariableName, &gEfiRedfishClientVariableGui= d, VARIABLE_ATTRIBUTE_NV_BS, VarSize, (VOID *)VarData); + + FreePool (VarData); + + return Status; } =20 /** diff --git a/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c b/RedfishClie= ntPkg/RedfishETagDxe/RedfishETagDxe.c index 7ac6e885dea6..a892ced984c8 100644 --- a/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c +++ b/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c @@ -411,7 +411,11 @@ SaveETagList ( gRT->SetVariable (VariableName, &gEfiRedfishClientVariableGuid, VARIAB= LE_ATTRIBUTE_NV_BS, 0, NULL); } =20 - return gRT->SetVariable (VariableName, &gEfiRedfishClientVariableGuid, V= ARIABLE_ATTRIBUTE_NV_BS, VarSize, (VOID *)VarData); + Status =3D gRT->SetVariable (VariableName, &gEfiRedfishClientVariableGui= d, VARIABLE_ATTRIBUTE_NV_BS, VarSize, (VOID *)VarData); + + FreePool (VarData); + + return Status; } =20 /** --=20 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108082): https://edk2.groups.io/g/devel/message/108082 Mute This Topic: https://groups.io/mt/101027006/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Wed May 15 07:44:00 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+108083+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+108083+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1693296086; cv=none; d=zohomail.com; s=zohoarc; b=Wl2rV1jpiugpXAV5wGlX6smI9q5+EH7pBP97Zjs9iPNN9e1I/QrnFIv6rN1uxfg+/gkPzHtMY7jXw5ydBi1xY+EgHclSvjes2UAKlb21lpqmbxVm9bKc/RcxKZ1baeJdeq4saHMC00u4twp/2mF4k0ZOJbtp2nh7Ije3du6Ewy4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1693296086; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=Kx6Lb3VOsRs+X+aeh78oCih+s9Hd/gPXeAOfOY/wdGA=; b=M3s3Z4bAD7I92Z04M2mlHoKUaHF7sDfnajS0Pah874PSgLQOpQwkQbSSRramgIlHw7UI4tpvfJ7Uwk5qJvZgq6I4srLAcJS04JQAkf1GRAWNidBiZGIJ85SF5ZLaPjgNThnni5qmDPu4TybkZO0xCYeHx13hAYCQwJ3TR4oNSns= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+108083+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1693296086124781.7392389825051; Tue, 29 Aug 2023 01:01:26 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=Kx6Lb3VOsRs+X+aeh78oCih+s9Hd/gPXeAOfOY/wdGA=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1693296085; v=1; b=r6Yz3zPF/8Q/LZURNe3cZ762SEkJ/9TNKt1kaTPUTNF45FwDIkjmZMFBLle3oDkJIP8/SMsd BGJh7yaORD+U8uQKkEhL/X+bK7+TD2/YQTQ0Q0BetVLSpPUYFMZeNz03Ojyfl7uv8KIhpgeDQEm lv98g98hrhRfJoTEWuG70Dkc= X-Received: by 127.0.0.2 with SMTP id 2NimYY1788612xfn7kU5iD7T; Tue, 29 Aug 2023 01:01:25 -0700 X-Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) by mx.groups.io with SMTP id smtpd.web11.12656.1693296085004114113 for ; Tue, 29 Aug 2023 01:01:25 -0700 X-Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-2b974031aeaso62212941fa.0 for ; Tue, 29 Aug 2023 01:01:24 -0700 (PDT) X-Gm-Message-State: pdgTvVHcmasnV94hWfIpkOGPx1787277AA= X-Google-Smtp-Source: AGHT+IHfpTKMf/e1PD5w1bZlbHmww57wxswx8kw9+dWNlxaQTKvhhnceEZmuQfYmeBOu0sD2CDFCKg== X-Received: by 2002:a2e:6a11:0:b0:2bc:d097:2b72 with SMTP id f17-20020a2e6a11000000b002bcd0972b72mr15197117ljc.48.1693296083095; Tue, 29 Aug 2023 01:01:23 -0700 (PDT) X-Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id h10-20020a2e900a000000b002ba130e9a29sm2077325ljg.76.2023.08.29.01.01.21 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 29 Aug 2023 01:01:22 -0700 (PDT) From: "Mike Maslenkin" To: devel@edk2.groups.io Cc: abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, Mike Maslenkin Subject: [edk2-devel] [PATCH v2 5/6] RedfishClientPkg: fix misprints in Readme.md Date: Tue, 29 Aug 2023 11:01:11 +0300 Message-Id: <20230829080112.12748-6-mike.maslenkin@gmail.com> In-Reply-To: <20230829080112.12748-1-mike.maslenkin@gmail.com> References: <20230829080112.12748-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1693296086574100019 Content-Type: text/plain; charset="utf-8" Signed-off-by: Mike Maslenkin Reviewed-by: Nickle Wang --- RedfishClientPkg/Readme.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/RedfishClientPkg/Readme.md b/RedfishClientPkg/Readme.md index 18a27633cf45..0aec0580aa5c 100644 --- a/RedfishClientPkg/Readme.md +++ b/RedfishClientPkg/Readme.md @@ -40,7 +40,7 @@ Below are the block diagrams of UEFI Redfish Client EDK2 = Implementation. ![UEFI Redfish Client Implementation](https://github.com/changab/edk2-stag= ing/blob/edk2-redfish-client/RedfishClientPkg/Documents/Media/RedfishClient= DriverStack.svg?raw=3Dtrue) =20 ## EFI EDK2 Redfish Client Framework -The functionality of each block in the diagrams are described in belwo sec= tions, +The functionality of each block in the diagrams are described in below sec= tions, =20 ### EDK2 Redfish Foundation ***[[1]](#[0])*** EDK2 Redfish Redfish Foundation provides the facilities of communicating w= ith @@ -68,7 +68,7 @@ project. =20 ### EDK2 Redfish JSON Schema to C Structure Convertor ***[[3]](#[0])*** This is the script auto-generated EDK2 drivers and libraries that provide = the -Redfish schema naming based JSON to C structure and vise versa converters.= C +Redfish schema naming based JSON to C structure and vice versa converters.= C structure is another representation of Redfish properties other than JSON = and CSDL(XML). The higher layer Redfish client application can deal with C str= ucture instead of using JSON library to manipulate Redfish properties. The script @@ -85,7 +85,7 @@ sits between **JSON Schema to C Structure converters** an= d **EFI Platform Configuration to Redfish Protocol**. The Redfish feature driver gets and s= ets the platform configuration and incorporates it with Redfish JSON schema C structure to manipulate Redfish JSON resources. Then applies the settings = from -Redfish service to platform configurations, or vise versa to update platfo= rm +Redfish service to platform configurations, or vice versa to update platfo= rm configurations to Redfish service. Both EDK2 Redfish Non-Collection and Collection Feature drivers are script auto-generated base on Redfish schema naming. The EDK2 Redfish Non-Collection feature driver manages the resourc= e of --=20 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108083): https://edk2.groups.io/g/devel/message/108083 Mute This Topic: https://groups.io/mt/101027007/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Wed May 15 07:44:00 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+108084+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+108084+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1693296087; cv=none; d=zohomail.com; s=zohoarc; b=NQGZ08MVWUncL8uFxodLVMbpt9ZM/FLZ/uRZlNBCyUqMoa+GPn0pvXS+sAKRH54pBGmj5YGF3p6ejdfeLfqjbEXRyUlLFdLPcq3HiEbzw8Flyc6wIpCCZfIbjXF5sNmg5GFBJ9DD4vXNwLw1ytGWYbVkJGzGYEo66IH6G6e8PPU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1693296087; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=mlqNyy3UyBC7aJafsYzoPQxZR7dwlA/3ZfMix1UCYNk=; b=ABtaVW2hoxsaRIxFY3FyUgNlzPgtKyYb2m9cqr1aP5iL2H84gZXdeSPVl7bnkwMAl8X+wpY4fb3Su4sAoBA0sJBQAq9jo5ME8+cvzc9tSmdpm5GZYn81JtENPGYtIcvLFX0GJU0TQh2Fi2ounQ3auE+JvTldGWHXmHiUWRRTIXo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+108084+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1693296087019216.32030472844576; Tue, 29 Aug 2023 01:01:27 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=lpht3dCdz2HmQk/KoyKiSNZXbAX+m8o8ejRO+gZ7N6I=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1693296086; v=1; b=HE8gYY0HpmvrobG4pd/mQ1XP444KUMB5xo4vfse9IlcfTbzoW3uxnuYRnEZleTozYt4lZeKX sxU366bYC0zArzVA8y33YzdIMqPxC7Aua1AxDwyJXhtl2lIga99EzaFnKh91MOkQ5Wb5upvtqhb MBMOWV38qL9d8c0TxW6A8XaY= X-Received: by 127.0.0.2 with SMTP id zsn9YY1788612xedetDGXwUe; Tue, 29 Aug 2023 01:01:26 -0700 X-Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) by mx.groups.io with SMTP id smtpd.web10.12622.1693296085893047818 for ; Tue, 29 Aug 2023 01:01:26 -0700 X-Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-2bcd7a207f7so59897701fa.3 for ; Tue, 29 Aug 2023 01:01:25 -0700 (PDT) X-Gm-Message-State: xmGFQccxUlBaS1bkJYS93jNbx1787277AA= X-Google-Smtp-Source: AGHT+IExpvOL/fDUmYAFJG4wYK8VlSVdV+laCzn+ZvFIyNLk/qCrDlWq6JtOAOK9tTYjs79OQceBTA== X-Received: by 2002:a2e:b164:0:b0:2bb:bfa5:b72c with SMTP id a4-20020a2eb164000000b002bbbfa5b72cmr20100640ljm.15.1693296083983; Tue, 29 Aug 2023 01:01:23 -0700 (PDT) X-Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id h10-20020a2e900a000000b002ba130e9a29sm2077325ljg.76.2023.08.29.01.01.23 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 29 Aug 2023 01:01:23 -0700 (PDT) From: "Mike Maslenkin" To: devel@edk2.groups.io Cc: abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, Mike Maslenkin Subject: [edk2-devel] [PATCH v2 6/6] RedfishClientPkg: spelling fixes Date: Tue, 29 Aug 2023 11:01:12 +0300 Message-Id: <20230829080112.12748-7-mike.maslenkin@gmail.com> In-Reply-To: <20230829080112.12748-1-mike.maslenkin@gmail.com> References: <20230829080112.12748-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1693296087504100024 Content-Type: text/plain; charset="utf-8" Signed-off-by: Mike Maslenkin Reviewed-by: Igor Kulchytskyy Reviewed-by: Nickle Wang --- RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c | 4 ++-- .../ComputerSystemCollectionDxe.c | 6 +++--- .../Features/MemoryCollectionDxe/MemoryCollectionDxe.c | 6 +++--- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c b/Re= dfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c index a1738de46fdf..a969557ddfdb 100644 --- a/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c +++ b/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c @@ -831,7 +831,7 @@ HandleResource ( DEBUG ((REDFISH_DEBUG_TRACE, "%a consume for %s\n", __func__, Uri)); Status =3D EdkIIRedfishResourceConfigConsume (&SchemaInfo, Uri); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a, failed to consume resoruce for: %s: %r\n", _= _func__, Uri, Status)); + DEBUG ((DEBUG_ERROR, "%a, failed to consume resource for: %s: %r\n", _= _func__, Uri, Status)); } =20 // @@ -840,7 +840,7 @@ HandleResource ( DEBUG ((REDFISH_DEBUG_TRACE, "%a update for %s\n", __func__, Uri)); Status =3D EdkIIRedfishResourceConfigUpdate (&SchemaInfo, Uri); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a, failed to update resoruce for: %s: %r\n", __= func__, Uri, Status)); + DEBUG ((DEBUG_ERROR, "%a, failed to update resource for: %s: %r\n", __= func__, Uri, Status)); } =20 return Status; diff --git a/RedfishClientPkg/Features/ComputerSystemCollectionDxe/Computer= SystemCollectionDxe.c b/RedfishClientPkg/Features/ComputerSystemCollectionD= xe/ComputerSystemCollectionDxe.c index 8f2054e1e161..1e362d49cbb6 100644 --- a/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSystemC= ollectionDxe.c +++ b/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSystemC= ollectionDxe.c @@ -109,7 +109,7 @@ HandleResource ( DEBUG ((REDFISH_DEBUG_TRACE, "%a consume for %s\n", __func__, Uri)); Status =3D EdkIIRedfishResourceConfigConsume (&SchemaInfo, Uri); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a, failed to consume resoruce for: %s: %r\n", _= _func__, Uri, Status)); + DEBUG ((DEBUG_ERROR, "%a, failed to consume resource for: %s: %r\n", _= _func__, Uri, Status)); } =20 // @@ -118,7 +118,7 @@ HandleResource ( DEBUG ((REDFISH_DEBUG_TRACE, "%a update for %s\n", __func__, Uri)); Status =3D EdkIIRedfishResourceConfigUpdate (&SchemaInfo, Uri); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a, failed to update resoruce for: %s: %r\n", __= func__, Uri, Status)); + DEBUG ((DEBUG_ERROR, "%a, failed to update resource for: %s: %r\n", __= func__, Uri, Status)); } =20 return Status; @@ -228,7 +228,7 @@ CreateCollectionResource ( =20 Status =3D EdkIIRedfishResourceConfigProvisionging (&SchemaInfo, Private= ->CollectionUri, Private->InformationExchange, TRUE); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a, failed to create resoruce for: %s: %r\n", __= func__, Private->CollectionUri, Status)); + DEBUG ((DEBUG_ERROR, "%a, failed to create resource for: %s: %r\n", __= func__, Private->CollectionUri, Status)); } =20 return Status; diff --git a/RedfishClientPkg/Features/MemoryCollectionDxe/MemoryCollection= Dxe.c b/RedfishClientPkg/Features/MemoryCollectionDxe/MemoryCollectionDxe.c index b94ff2e86572..1b755cde0130 100644 --- a/RedfishClientPkg/Features/MemoryCollectionDxe/MemoryCollectionDxe.c +++ b/RedfishClientPkg/Features/MemoryCollectionDxe/MemoryCollectionDxe.c @@ -109,7 +109,7 @@ HandleResource ( DEBUG ((REDFISH_DEBUG_TRACE, "%a consume for %s\n", __func__, Uri)); Status =3D EdkIIRedfishResourceConfigConsume (&SchemaInfo, Uri); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a, failed to consume resoruce for: %s: %r\n", _= _func__, Uri, Status)); + DEBUG ((DEBUG_ERROR, "%a, failed to consume resource for: %s: %r\n", _= _func__, Uri, Status)); } =20 // @@ -118,7 +118,7 @@ HandleResource ( DEBUG ((REDFISH_DEBUG_TRACE, "%a update for %s\n", __func__, Uri)); Status =3D EdkIIRedfishResourceConfigUpdate (&SchemaInfo, Uri); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a, failed to update resoruce for: %s: %r\n", __= func__, Uri, Status)); + DEBUG ((DEBUG_ERROR, "%a, failed to update resource for: %s: %r\n", __= func__, Uri, Status)); } =20 return Status; @@ -228,7 +228,7 @@ CreateCollectionResource ( =20 Status =3D EdkIIRedfishResourceConfigProvisionging (&SchemaInfo, Private= ->CollectionUri, Private->InformationExchange, TRUE); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a, failed to create resoruce for: %s: %r\n", __= func__, Private->CollectionUri, Status)); + DEBUG ((DEBUG_ERROR, "%a, failed to create resource for: %s: %r\n", __= func__, Private->CollectionUri, Status)); } =20 return Status; --=20 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108084): https://edk2.groups.io/g/devel/message/108084 Mute This Topic: https://groups.io/mt/101027009/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-