From nobody Fri May 17 15:12:22 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+107140+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1690013910002446.76568106220896; Sat, 22 Jul 2023 01:18:30 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=Bycbjw1cqatcafwETXthOVlyWt/xMggxoDFLWgVsVbg=; c=relaxed/simple; d=groups.io; h=X-Received:X-Received:ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:X-Received:X-Received:X-MS-Exchange-Authentication-Results:Received-SPF:X-Received:X-Received:X-Received:X-Received:From:To:CC:Subject:Date:Message-ID:MIME-Version:X-NV-OnPremToCloud:X-EOPAttributedMessage:X-MS-PublicTrafficType:X-MS-TrafficTypeDiagnostic:X-MS-Office365-Filtering-Correlation-Id:X-MS-Exchange-SenderADCheck:X-MS-Exchange-AntiSpam-Relay:X-Microsoft-Antispam-Message-Info:X-OriginatorOrg:X-MS-Exchange-CrossTenant-OriginalArrivalTime:X-MS-Exchange-CrossTenant-Network-Message-Id:X-MS-Exchange-CrossTenant-Id:X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp:X-MS-Exchange-CrossTenant-AuthSource:X-MS-Exchange-CrossTenant-AuthAs:X-MS-Exchange-CrossTenant-FromEntityHeader:X-MS-Exchange-Transport-CrossTenantHeadersStamped:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:X-Gm-Message-State:Content-Transfer-Encoding:Content-Type; s=20140610; t=1690013909; v=1; b=v+m7GqJGPIqUIOFgjWdFGFTqkLZTWvoRQNHncfvB/nSY84fAPlPVbC7hQOaur+yFR8FzTRkl po0j3bcsZWjRSfgUKQsp25QqnYFkRGWcgT4hvExBBmWWkYoS2VHUpHRTPYX1LSR1Dzq3HWmHLNv ebKDtKv/Q6lhE+LHYv8vWnCQ= X-Received: by 127.0.0.2 with SMTP id i50JYY1788612xn2EHXTTyhz; Sat, 22 Jul 2023 01:18:29 -0700 X-Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.89]) by mx.groups.io with SMTP id smtpd.web11.1788.1690013908958175002 for ; Sat, 22 Jul 2023 01:18:29 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hgrSJ8Y4PxuoSWWkdDQs4XBdMsyPLRY4FgqO4oJWf1njhyFdDv/DGSHtWh20JJ12e3ZOHQ6aCcHvtc2DjYZjL4kWigQxxRuzEHIeYt8HRSm19DIrCqDaa3Fozb7xC/LgJSlAWqKQSRVOT/+Le8epK2Xed1Aq0u8ZJAlFGFxUDDEomceTQJ3u8CC0uODr89Bsi5PfwAbn6TWVQYRiSognV3baE/jSqE+DbBmeAxjtFk4+IDw99Z+LuM3eVYmua9dZGT70aZ3PjUjR0sp42YtoJgwRNQQTVFWPMvUfxHJiiLVAkNK+aO1yxFp36Z1xcZO5Fh7CRW8bu0RG9tq36RkiEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wUpxO3JI+VX91ee66/EzoIQ7kv1xpyzMOX48l0ViLpM=; b=iD9+9JdpLJOakPCnCoBvEk30PmkjG0nIFQAD9GJJYBfOiaKMpizQfKYQx9fvYSIQSapTxrE+QxG68NuXopUmiTOzptdvLMqdKJ5lgkALB5mIgwYGdICWYiakXxRvNXTJsaRstn11PJVbzR8wc69NQEH4arqf/g9+qBRmmj/pcW9kjEpF06p1EmvNNgcKFGfuvxpQijAAQb5wU7lw4w2jc+voEi20/GzuEaKIODXnSXWc3sDIZuWZBYDz0e6Bo0xw2T7yGl3r+3SmTYR13V6VNV+cUoPbuAW+3kSNxica7K03s3xT6gmcXPomGDGFUvUJB7pYiSLssm+l3BtHcxwmTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none X-Received: from SJ0PR03CA0178.namprd03.prod.outlook.com (2603:10b6:a03:338::33) by LV2PR12MB5966.namprd12.prod.outlook.com (2603:10b6:408:171::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.24; Sat, 22 Jul 2023 08:18:26 +0000 X-Received: from DM6NAM11FT046.eop-nam11.prod.protection.outlook.com (2603:10b6:a03:338:cafe::66) by SJ0PR03CA0178.outlook.office365.com (2603:10b6:a03:338::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.28 via Frontend Transport; Sat, 22 Jul 2023 08:18:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+107140+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C X-Received: from mail.nvidia.com (216.228.118.232) by DM6NAM11FT046.mail.protection.outlook.com (10.13.172.121) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.41 via Frontend Transport; Sat, 22 Jul 2023 08:18:25 +0000 X-Received: from drhqmail201.nvidia.com (10.126.190.180) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Sat, 22 Jul 2023 01:18:17 -0700 X-Received: from drhqmail202.nvidia.com (10.126.190.181) by drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Sat, 22 Jul 2023 01:18:17 -0700 X-Received: from NV-CL38DL3.nvidia.com (10.127.8.13) by mail.nvidia.com (10.126.190.181) with Microsoft SMTP Server id 15.2.986.37 via Frontend Transport; Sat, 22 Jul 2023 01:18:16 -0700 From: "Nickle Wang via groups.io" To: CC: Abner Chang , Igor Kulchytskyy , "Nick Ramirez" Subject: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformConfigDxe: fix can not set one-of option issue. Date: Sat, 22 Jul 2023 16:18:16 +0800 Message-ID: <20230722081816.212-1-nicklew@nvidia.com> MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT046:EE_|LV2PR12MB5966:EE_ X-MS-Office365-Filtering-Correlation-Id: cdc564f0-df74-4d8d-2656-08db8a8c3903 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: TdpF4iRWJLjDZNlbhCMQOondK99mthr1eYmPmhUdcS7gizBl8ApQ8N3ZESqyOtqPN6mTsPmlRI0UmmrvKI5r4/FX8koKjFm6QOqxQCvDImVZkoJ1YgJLqNkglEoRnOrdR5rIT2AVo5pi40MqYIy74zecoByBBkTAbq8TXik40rfitXJMtAit87pV/Cq101hlJta4BWJE6p5rSdhbov5GzWrYKuzTwJlOuNiJnoXNtTJvyJC/tG6d22XDGypZUJRQ/Uy04N7TixCe5k9G8hwQGGrf9b41iM0HnhjQsaVVXBxB9Q1CyafxetRH0fVG7xjdiCR/63jrxYE1iNjNCvHvNPDoOelBZxdaSTHPbfKCeIFcJRL1F8LDDQQs9MKkFw4G2GwFBZCAsOZQLNOIrw6aMgmKYLXgcoTmyiNJaxb8EdQ/3IBZvsWXmljuxtvsRFRuhbGADA7flLS3/s3eweddlgQ0A+ovBaI1F9ZPBmWACE1mumSzTt+Xk28obakCO2mEw64KtFpIJwa8nmzJ5dpJr4Mo+uI3pnyzy/7PI+Q6qRmNKuQ/2Rt8xFhZX9ytvO9qHL2N/Hj1DY90aENpXtyUSik348KcsFG+s0xFWk36uYD7iDWGeTFgwf9OBHKEf74iOkTrnS+TZOFWPmetg7KhcMB1lrY2JJRMdRwcNoWx7Y3TYWWTMqE7QfBg7Eo7XtNIk8kDsxPF/aHUGFe9R8HRPQ== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2023 08:18:25.8057 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cdc564f0-df74-4d8d-2656-08db8a8c3903 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.232];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT046.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB5966 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nicklew@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 9Rg3H1tI78ndD0bmGZYVBHX8x1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1690013911065100001 Content-Type: text/plain; charset="utf-8" StatementValue->Buffer is converted from ASCII to Unicode by caller already so we don't have to convert it again. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c= b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c index f2a8e77d9b00..648f3d2de7aa 100644 --- a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c +++ b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c @@ -1660,7 +1660,11 @@ RedfishPlatformConfigSetStatementCommon ( // in string format from HII point of view. Do a patch here. // if ((TargetStatement->HiiStatement->Operand =3D=3D EFI_IFR_ONE_OF_OP) = && (StatementValue->Type =3D=3D EFI_IFR_TYPE_STRING)) { - TempBuffer =3D StrToUnicodeStr ((CHAR8 *)StatementValue->Buffer); + // + // Make a copy of input buffer to TempBuffer because StatementValue = will be + // assigned in HiiStringToOneOfOptionValue(). + // + TempBuffer =3D AllocateCopyPool (StrSize ((EFI_STRING)StatementValue= ->Buffer), StatementValue->Buffer); if (TempBuffer =3D=3D NULL) { return EFI_OUT_OF_RESOURCES; } --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107140): https://edk2.groups.io/g/devel/message/107140 Mute This Topic: https://groups.io/mt/100292370/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-