From nobody Fri May 17 13:51:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+107000+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+107000+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1689670928; cv=none; d=zohomail.com; s=zohoarc; b=aMEsEdnNSqXR7H897yfuNmABU/sBf4cE63b9a5Er+MT0YuqM4up8MCjoF8FQWXYeP3HLoh3pcnOUnJF9Bo4om41qNgqggy/QLoPNQWQbY4PCU4Q8yQDouDXrfXtuRdZa7ovL0lp5psIkKnAepSQxaKtB2HfeQyNhfraJffUP9qY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1689670928; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=DABRK25PWUevTVmsbxr0Z4tgKlQyM1Lk9zTUXIEVQ3s=; b=Lkwyz0FOpVg4A6qS2ymx0g8XviOZXafD8Uf9gJziXbDxaRzpn2DX99+gr+/wW/AydkS/Vr2QVa5x9vL+F+1sO76tB/eJ0rX7erg9zG0iLuIv7gwyVc87zC04c66+oqT8Ql8fbamSL6UZksN9KRbijJCgmYKr/56/R7y87kyf2/I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+107000+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1689670928118974.556367943741; Tue, 18 Jul 2023 02:02:08 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=FURHbfACESDRKepPRjWzLdJgXQAkxR5ezDf1sR/IjvY=; c=relaxed/simple; d=groups.io; h=X-Received:X-Received:X-Received:X-Gm-Message-State:X-Google-Smtp-Source:X-Received:X-Received:From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Unsubscribe:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:Content-Transfer-Encoding; s=20140610; t=1689670927; v=1; b=KVEqf3sXjMGPApKwnoe8u73EkxTAEwiK2Adt7bglaUK7pzVwPHzRn+Mdhp6cze6lnREsJd6e dvKOlHvCURt46re7HBglsPO8di/64zgjW1amZlrod0+PU1hC69kFOdMeuzQSr8/vqmLQhm76SlC 9N/U+xXTABAdjpE4J+MTjDv0= X-Received: by 127.0.0.2 with SMTP id plBcYY1788612xUEzjnnCpG0; Tue, 18 Jul 2023 02:02:07 -0700 X-Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) by mx.groups.io with SMTP id smtpd.web11.6042.1689594014862113322 for ; Mon, 17 Jul 2023 04:40:14 -0700 X-Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-55bac17b442so3356470a12.3 for ; Mon, 17 Jul 2023 04:40:14 -0700 (PDT) X-Gm-Message-State: lVdS3VuyeeREk6GxZezXSc2Zx1787277AA= X-Google-Smtp-Source: APBJJlEH4D00CWKvJAaFmvprWHFcvQAm7Lw7vuv3VsoRZ7m0+N8xDJI9dYanvlGEV8ncOazQQ2hyfQ== X-Received: by 2002:a17:902:ecc3:b0:1bb:1494:f7f7 with SMTP id a3-20020a170902ecc300b001bb1494f7f7mr12894911plh.23.1689594014211; Mon, 17 Jul 2023 04:40:14 -0700 (PDT) X-Received: from user-Latitude-5420.dc1.ventanamicro.com ([2401:4900:1cbd:8dd2:c2bf:93e0:5979:e5e0]) by smtp.gmail.com with ESMTPSA id l3-20020a170902cf8300b001b9ce2c3baesm12544547ply.143.2023.07.17.04.40.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jul 2023 04:40:14 -0700 (PDT) From: Ranbir Singh To: devel@edk2.groups.io, rsingh@ventanamicro.com Cc: Hao A Wu , Ray Ni , Veeresh Sangolli Subject: [edk2-devel] [PATCH v1 1/1] MdeModulePkg/Bus/Pci/NvmExpressPei: Fix DEADCODE Coverity issue Date: Mon, 17 Jul 2023 17:10:08 +0530 Message-Id: <20230717114008.2290970-2-rsingh@ventanamicro.com> In-Reply-To: <20230717114008.2290970-1-rsingh@ventanamicro.com> References: <20230717114008.2290970-1-rsingh@ventanamicro.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,rsingh@ventanamicro.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1689671006078100005 Content-Type: text/plain; charset="utf-8" From: Ranbir Singh The code can reach line 65 only through the else path above at line 53. The else path already has the same NULL check at line 55 and hence the duplicate code lines are totally redundant which can be deleted. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4220 Cc: Hao A Wu Cc: Ray Ni Co-authored-by: Veeresh Sangolli Signed-off-by: Ranbir Singh Signed-off-by: Ranbir Singh Reviewed-by: Hao A Wu --- MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiS3.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiS3.c b/MdeModu= lePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiS3.c index d704c62eaab3..1d03d4964025 100644 --- a/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiS3.c +++ b/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiS3.c @@ -62,10 +62,6 @@ NvmeS3SkipThisController ( } } =20 - if (S3InitDevices =3D=3D NULL) { - return Skip; - } - // // Only need to initialize the controllers that exist in the device list. // --=20 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107000): https://edk2.groups.io/g/devel/message/107000 Mute This Topic: https://groups.io/mt/100212115/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-