[v4] MdeModulePkg/Bus/Ata/AtaAtapiPassThru: Fix

[edk2-devel] [PATCH v4 0/2] MdeModulePkg/Bus/Ata/AtaAtapiPassThru: Fix

Posted by Ranbir Singh 9 months, 2 weeks ago

v3 -> v4:
  - [Patch 2] Further update as per review comments
      - Status storage removal at call point
      - Error checks moved inside SetDriveParameters function 

v2 -> v3:
  - [Patch 2] Update as per review comments

v1 -> v2:
  - Retain outer cast
  - Add error check instead of Status storage removal

Ranbir Singh (2):
  MdeModulePkg/Bus/Ata/AtaAtapiPassThru: Fix SIGN_EXTENSION Coverity
    issue
  MdeModulePkg/Bus/Ata/AtaAtapiPassThru: Fix UNUSED_VALUE Coverity issue

 MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.c |  2 +-
 MdeModulePkg/Bus/Ata/AtaAtapiPassThru/IdeMode.c          | 12 ++++++++++--
 2 files changed, 11 insertions(+), 3 deletions(-)

-- 
2.34.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#106988): https://edk2.groups.io/g/devel/message/106988
Mute This Topic: https://groups.io/mt/100212103/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v4 0/2] MdeModulePkg/Bus/Ata/AtaAtapiPassThru: Fix

Posted by Wu, Hao A 9 months ago

Series pushed via:
PR - https://github.com/tianocore/edk2/pull/4707
Commits:
https://github.com/tianocore/edk2/commit/c7c1170a4568ecc0f63e14ca6a844d40f47519a9
https://github.com/tianocore/edk2/commit/d11968fcc56cbbffef7d906048b00faea9415447

Best Regards,
Hao Wu

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ranbir
> Singh
> Sent: Monday, July 17, 2023 12:25 PM
> To: devel@edk2.groups.io; rsingh@ventanamicro.com
> Subject: [edk2-devel] [PATCH v4 0/2]
> MdeModulePkg/Bus/Ata/AtaAtapiPassThru: Fix
> 
> v3 -> v4:
>   - [Patch 2] Further update as per review comments
>       - Status storage removal at call point
>       - Error checks moved inside SetDriveParameters function
> 
> v2 -> v3:
>   - [Patch 2] Update as per review comments
> 
> v1 -> v2:
>   - Retain outer cast
>   - Add error check instead of Status storage removal
> 
> Ranbir Singh (2):
>   MdeModulePkg/Bus/Ata/AtaAtapiPassThru: Fix SIGN_EXTENSION Coverity
>     issue
>   MdeModulePkg/Bus/Ata/AtaAtapiPassThru: Fix UNUSED_VALUE Coverity
> issue
> 
>  MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.c |  2 +-
>  MdeModulePkg/Bus/Ata/AtaAtapiPassThru/IdeMode.c          | 12
> ++++++++++--
>  2 files changed, 11 insertions(+), 3 deletions(-)
> 
> --
> 2.34.1
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107442): https://edk2.groups.io/g/devel/message/107442
Mute This Topic: https://groups.io/mt/100212103/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-