From nobody Fri May 10 20:51:05 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+106900+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1689240306; cv=none; d=zohomail.com; s=zohoarc; b=Ryk38rLzFkWFItdta5Mxw2LvnD/P8oB9Y8cOOXMd0gcFeYAOreGEfnqhFUABr799h3dRO/t8U3AyAJhULAXd7b0M/vzgqb+MvtmqAJodYly/uKNuPy27YzHZoOQkITjEKEZQlVsBBAb+q0xiZ1/pPTy3nKXiHNFG4Xw8Un3ULSc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1689240306; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=ZCkAMtd+gChsHtx5Tq+2Y1fd/kD5+DfY5Iry+JC60sE=; b=f90S4EinqUgOqWlv9fJHigj0JXlMRvecP7ZKn38ElXTU1UhNkBYkA0/zyH+PqyyuvGNHJP30wdd8CbW2hDe+lLig+83qRZPVwbfyfWoyPf2OfoGNF6sNlyHekGKNpiYIEfIrPw63MN1vUA/qN/oANL84FDcohBnsrHlJQW+dftU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+106900+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 16892403064301007.5176092340222; Thu, 13 Jul 2023 02:25:06 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=hASAKQcrxvFFWD0pdh8rQZ/7xgIMcVxrR5wMyJiG/90=; c=relaxed/simple; d=groups.io; h=X-Received:X-Received:ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:X-Received:X-Received:X-MS-Exchange-Authentication-Results:Received-SPF:X-Received:X-Received:X-Received:X-Received:From:To:CC:Subject:Date:Message-ID:MIME-Version:X-NV-OnPremToCloud:X-EOPAttributedMessage:X-MS-PublicTrafficType:X-MS-TrafficTypeDiagnostic:X-MS-Office365-Filtering-Correlation-Id:X-MS-Exchange-SenderADCheck:X-MS-Exchange-AntiSpam-Relay:X-Microsoft-Antispam-Message-Info:X-OriginatorOrg:X-MS-Exchange-CrossTenant-OriginalArrivalTime:X-MS-Exchange-CrossTenant-Network-Message-Id:X-MS-Exchange-CrossTenant-Id:X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp:X-MS-Exchange-CrossTenant-AuthSource:X-MS-Exchange-CrossTenant-AuthAs:X-MS-Exchange-CrossTenant-FromEntityHeader:X-MS-Exchange-Transport-CrossTenantHeadersStamped:Precedence:List-Unsubscribe:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:X-Gm-Message-State:Content-Transfer-Encoding:Content-Type; s=20140610; t=1689240306; v=1; b=UrnJUvAndTSrQwUsaigzjWnEGJwytl4S9ZLZa8QcSRZc6jAYjLhMLMfmImO0RgpocV7LGxkW 27rEsi3lolWbA8izw1UnyoMMiYO1HqcN2JDmuRC9uqMAlElmHmwTNWYz8I9X5OuNpEDJpNkxXf2 Tv5t9zMnMpatWb6uThZLBxyE= X-Received: by 127.0.0.2 with SMTP id cYZTYY1788612xJQNeZfDAUi; Thu, 13 Jul 2023 02:25:06 -0700 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.51]) by mx.groups.io with SMTP id smtpd.web11.4524.1689240305302612666 for ; Thu, 13 Jul 2023 02:25:05 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=awzGG5wVWXGevYBeoS9nsMsRokd2Km+XWQNleqj7hQv9V4GnDBFVmDZ0SZrW/A5JiOR+hF1Y7xH6BplQUGGDcyMgk2LoKgONDzuv/2HQ4n/2RwMs5lyANSC7w17plVWYTOl35n7t9cYE2yUrkNXcEHKTvJuGD4lYL2YXvM8eSSrL6eMCqYFWr50vU7c89NbrYavV6iIF4578bK6bOb3dgGaATdPl2MUyVq/aN5gbb1VnD3XjeNnLQSVOW1j6PlF/NRHjKfqj9Iru2ZEJ9BHAv5Z6XivMS+9KhA+3a9mVcZFAOA2qo1uBnJP6fpZFu2vqieBGL3jHIVanoz4AHkN6xQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p7ROZZR1fBq1gRHW40MBd9JdBuglQtgD+ILpbMkNxq4=; b=Lv7RmHEbKECbTR0HDuCot9XOJrc/YXUZVe8am8rhiyDAfssNkmbbPDhrNGUVm/oUQ3m6UIWVwMBpdeQCypd6FnFZ0L/ABvfTpso0HHckYRsDIO3Ef2QEZPfkXcvCL6HVFiVj92beevkFF/aE307uQgVPMGEPHqcgRhO3MBB/BqxP0+QbT1uyb7JmMhObWh5hHcp49Z5UUI30e+SRgc1HGZlTf1kR1uq+0J2t3tT+BI+W6h81vzhFdB+6z73GnAAgddqKHqwY3mPo0/HtXffE0mHBLDSNBAQTEXv3ZUMxrS7PGF4jBFgQARQ2QQXAzwV2hk1SQmmVSiu8ZxrAHO/kAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none X-Received: from BN9PR03CA0740.namprd03.prod.outlook.com (2603:10b6:408:110::25) by IA1PR12MB8336.namprd12.prod.outlook.com (2603:10b6:208:3fc::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.20; Thu, 13 Jul 2023 09:25:00 +0000 X-Received: from BN8NAM11FT049.eop-nam11.prod.protection.outlook.com (2603:10b6:408:110:cafe::77) by BN9PR03CA0740.outlook.office365.com (2603:10b6:408:110::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.25 via Frontend Transport; Thu, 13 Jul 2023 09:25:00 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+106900+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C X-Received: from mail.nvidia.com (216.228.117.160) by BN8NAM11FT049.mail.protection.outlook.com (10.13.177.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.24 via Frontend Transport; Thu, 13 Jul 2023 09:25:00 +0000 X-Received: from rnnvmail203.nvidia.com (10.129.68.9) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Thu, 13 Jul 2023 02:24:47 -0700 X-Received: from rnnvmail201.nvidia.com (10.129.68.8) by rnnvmail203.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Thu, 13 Jul 2023 02:24:47 -0700 X-Received: from NV-CL38DL3.nvidia.com (10.127.8.11) by mail.nvidia.com (10.129.68.8) with Microsoft SMTP Server id 15.2.986.37 via Frontend Transport; Thu, 13 Jul 2023 02:24:46 -0700 From: "Nickle Wang via groups.io" To: CC: Abner Chang , Igor Kulchytskyy , "Nick Ramirez" Subject: [edk2-devel] [PATCH] RedfishPkg/RedfishRestExDxe: reset session when TCP timeout happens Date: Thu, 13 Jul 2023 17:24:45 +0800 Message-ID: <20230713092446.14050-1-nicklew@nvidia.com> MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT049:EE_|IA1PR12MB8336:EE_ X-MS-Office365-Filtering-Correlation-Id: e26dd507-ad80-4277-5065-08db83830835 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: JgUah7m8RxhPq4LQlLIfLD5XHixAxGeVfw6OxyB3Q8+ZJn84Tqb4B/4lF3BQhJ2WXNCFQ8DG4lljoQvpi+hc/Kjmo6Yo438+JVFtiILt84UDrokrq3wZQSbdApdMdvcThIjKca0iNHXwK1yKY+Dk5v59jik1ZQLi3egRrr//loElu93aWcgt40EZO0lBgGifgJYZUv2pMaN6ZXn+NhyMnnS1c2W4NDfATZW++BIGvU3m9By3PqxqUVrJJQm4QzAb4pcnsU7BXNEppypHKihLtva/aq3KYsEfn+FhRS2wGNqlMiKwwbML38QBoQsGOn7V2fWTTWSMQ/NSoNtbORxKXt3vdUPHvC+UWJcpUCN0OsXJzxO6d4XAzsFTb1fbr/KDAFX6mnKi+5NVdzOS5ymM0lw9itxIqgnT7vSWfdcy2WdJtbl7DESWcNmKWLmcHrGtVeEwNch/hzd048yK0TuIB6K5QI4W9VU1VQ3mewhNFQ54QR/J9vePEGUxBcKb1htK+AKi+sz2Ogh2Qp1+I7APakT21aAi0/kvdw++rMIfSlce9xjo/+uTRXoIsaokLnSamVWyl8uCxA8QEtO2XLsiqEQ0Jx2sYJi/jkJDNF0FrTBw4JFUyoq24g69+xX8kr3nOji+b9YUS5G9XaS7UCtD0eS22NJFfM73ewliIKnii9KTM6kyaJMJLrKt1wpFW8k0a0g0TF8hnGSMkRyZ2Vc3jkVEnQYEOYjia0oonssnkDdWBwNIPjUsyIs9CIDmoX6X X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2023 09:25:00.2848 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e26dd507-ad80-4277-5065-08db83830835 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT049.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8336 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nicklew@nvidia.com X-Gm-Message-State: 9RwEhHoMxh3A4c5z4bppLEo9x1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1689240308261100003 Content-Type: text/plain; charset="utf-8" Call ResetHttpTslSession() to reset HTTP session when TCP timeout failure happens. So that application can perform retry to the same URI. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Reviewed-by: Abner Chang --- .../RedfishRestExDxe/RedfishRestExInternal.h | 14 ++++++++++++++ RedfishPkg/RedfishRestExDxe/RedfishRestExImpl.c | 4 ++-- .../RedfishRestExDxe/RedfishRestExProtocol.c | 4 ++++ 3 files changed, 20 insertions(+), 2 deletions(-) diff --git a/RedfishPkg/RedfishRestExDxe/RedfishRestExInternal.h b/RedfishP= kg/RedfishRestExDxe/RedfishRestExInternal.h index bca679e2ccc4..c146f4a647cb 100644 --- a/RedfishPkg/RedfishRestExDxe/RedfishRestExInternal.h +++ b/RedfishPkg/RedfishRestExDxe/RedfishRestExInternal.h @@ -55,6 +55,20 @@ RedfishCheckHttpReceiveStatus ( IN EFI_STATUS HttpIoReceiveStatus ); =20 +/** + Create a new TLS session because the previous one is closed. + + @param[in] Instance Pointer to EFI_REST_EX_PROTOCOL instance= for a particular + REST service. + @retval EFI_SUCCESS operation succeeded. + @retval EFI_ERROR Other errors. + +**/ +EFI_STATUS +ResetHttpTslSession ( + IN RESTEX_INSTANCE *Instance + ); + /** This function send the HTTP request without body to see if the write to URL is permitted by Redfish service. This function diff --git a/RedfishPkg/RedfishRestExDxe/RedfishRestExImpl.c b/RedfishPkg/R= edfishRestExDxe/RedfishRestExImpl.c index 838e24f7e7ef..b2961424de80 100644 --- a/RedfishPkg/RedfishRestExDxe/RedfishRestExImpl.c +++ b/RedfishPkg/RedfishRestExDxe/RedfishRestExImpl.c @@ -4,6 +4,7 @@ Copyright (c) 2019, Intel Corporation. All rights reserved.
(C) Copyright 2020 Hewlett Packard Enterprise Development LP
Copyright (c) 2023, American Megatrends International LLC. + Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved. =20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -12,8 +13,7 @@ #include "RedfishRestExInternal.h" =20 /** - Create a new TLS session becuase the previous on is closed. - status. + Create a new TLS session because the previous one is closed. =20 @param[in] Instance Pointer to EFI_REST_EX_PROTOCOL instance= for a particular REST service. diff --git a/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c b/RedfishP= kg/RedfishRestExDxe/RedfishRestExProtocol.c index d8f2c73f8ef0..90973619f2bc 100644 --- a/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c +++ b/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c @@ -188,6 +188,10 @@ ReSendRequest:; } =20 if (EFI_ERROR (Status)) { + // + // Communication failure happens. Reset the session. + // + ResetHttpTslSession (Instance); goto ON_EXIT; } =20 --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#106900): https://edk2.groups.io/g/devel/message/106900 Mute This Topic: https://groups.io/mt/100117117/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-