OvmfPkg/RiscVVirt/RiscVVirtQemu.fdf | 34 ++++++------------ BaseTools/Conf/tools_def.template | 53 +++++++++++++++++++++++++++++ OvmfPkg/RiscVVirt/README.md | 28 +++++++++++++-- OvmfPkg/RiscVVirt/Sec/SecEntry.S | 3 -- 4 files changed, 88 insertions(+), 30 deletions(-)
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4478 This series adds support for building RiscVVirtQemu EDK2 using CLANGDWARF toolchain. Adding this support helps people to use the same toolchain to build EDK2 for different architectures. Cc: Rebecca Cran <rebecca@bsdio.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Bob Feng <bob.c.feng@intel.com> Cc: Yuwei Chen <yuwei.chen@intel.com> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> Cc: Jiewen Yao <jiewen.yao@intel.com> Cc: Jordan Justen <jordan.l.justen@intel.com> Cc Gerd Hoffmann <kraxel@redhat.com> Cc: Andrei Warkentin <andrei.warkentin@intel.com> Cc: Heinrich Schuchardt <heinrich.schuchardt@canonical.com> Changes since v1: 1) Addressed Liming's comments in PATCH 3. Sunil V L (4): OvmfPkg/RiscVVirt: use 'auto' alignment and FIXED for XIP modules OvmfPkg/RiscVVirt: SecEntry: Remove unnecessary assembly directives BaseTools/tools_def: Add CLANGDWARF support for RISC-V OvmfPkg/RiscVVirt: Update README for CLANGDWARF support OvmfPkg/RiscVVirt/RiscVVirtQemu.fdf | 34 ++++++------------ BaseTools/Conf/tools_def.template | 53 +++++++++++++++++++++++++++++ OvmfPkg/RiscVVirt/README.md | 28 +++++++++++++-- OvmfPkg/RiscVVirt/Sec/SecEntry.S | 3 -- 4 files changed, 88 insertions(+), 30 deletions(-) -- 2.34.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#106813): https://edk2.groups.io/g/devel/message/106813 Mute This Topic: https://groups.io/mt/100081389/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Sunil: Do you use which CLANG version is used to verify this change? Thanks Liming > -----邮件原件----- > 发件人: Sunil V L <sunilvl@ventanamicro.com> > 发送时间: 2023年7月11日 23:44 > 收件人: devel@edk2.groups.io > 抄送: Sunil V L <sunilvl@ventanamicro.com>; Rebecca Cran > <rebecca@bsdio.com>; Liming Gao <gaoliming@byosoft.com.cn>; Bob Feng > <bob.c.feng@intel.com>; Yuwei Chen <yuwei.chen@intel.com>; Ard > Biesheuvel <ardb+tianocore@kernel.org>; Jiewen Yao > <jiewen.yao@intel.com>; Jordan Justen <jordan.l.justen@intel.com>; Andrei > Warkentin <andrei.warkentin@intel.com>; Heinrich Schuchardt > <heinrich.schuchardt@canonical.com> > 主题: [PATCH v2 0/4] OvmfPkg/RiscVVirt: Add CLANGDWARF toolchain > support > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4478 > > This series adds support for building RiscVVirtQemu EDK2 using > CLANGDWARF toolchain. Adding this support helps people to use > the same toolchain to build EDK2 for different architectures. > > Cc: Rebecca Cran <rebecca@bsdio.com> > Cc: Liming Gao <gaoliming@byosoft.com.cn> > Cc: Bob Feng <bob.c.feng@intel.com> > Cc: Yuwei Chen <yuwei.chen@intel.com> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> > Cc: Jiewen Yao <jiewen.yao@intel.com> > Cc: Jordan Justen <jordan.l.justen@intel.com> > Cc Gerd Hoffmann <kraxel@redhat.com> > Cc: Andrei Warkentin <andrei.warkentin@intel.com> > Cc: Heinrich Schuchardt <heinrich.schuchardt@canonical.com> > > Changes since v1: > 1) Addressed Liming's comments in PATCH 3. > > Sunil V L (4): > OvmfPkg/RiscVVirt: use 'auto' alignment and FIXED for XIP modules > OvmfPkg/RiscVVirt: SecEntry: Remove unnecessary assembly directives > BaseTools/tools_def: Add CLANGDWARF support for RISC-V > OvmfPkg/RiscVVirt: Update README for CLANGDWARF support > > OvmfPkg/RiscVVirt/RiscVVirtQemu.fdf | 34 ++++++------------ > BaseTools/Conf/tools_def.template | 53 > +++++++++++++++++++++++++++++ > OvmfPkg/RiscVVirt/README.md | 28 +++++++++++++-- > OvmfPkg/RiscVVirt/Sec/SecEntry.S | 3 -- > 4 files changed, 88 insertions(+), 30 deletions(-) > > -- > 2.34.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#106952): https://edk2.groups.io/g/devel/message/106952 Mute This Topic: https://groups.io/mt/100187566/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
On Mon, 17 Jul 2023 at 03:51, gaoliming via groups.io <gaoliming=byosoft.com.cn@groups.io> wrote: > > Sunil: > Do you use which CLANG version is used to verify this change? > For the series, Tested-by: Ard Biesheuvel <ardb@kernel.org> # Debian clang version 14.0.6 > > -----邮件原件----- > > 发件人: Sunil V L <sunilvl@ventanamicro.com> > > 发送时间: 2023年7月11日 23:44 > > 收件人: devel@edk2.groups.io > > 抄送: Sunil V L <sunilvl@ventanamicro.com>; Rebecca Cran > > <rebecca@bsdio.com>; Liming Gao <gaoliming@byosoft.com.cn>; Bob Feng > > <bob.c.feng@intel.com>; Yuwei Chen <yuwei.chen@intel.com>; Ard > > Biesheuvel <ardb+tianocore@kernel.org>; Jiewen Yao > > <jiewen.yao@intel.com>; Jordan Justen <jordan.l.justen@intel.com>; Andrei > > Warkentin <andrei.warkentin@intel.com>; Heinrich Schuchardt > > <heinrich.schuchardt@canonical.com> > > 主题: [PATCH v2 0/4] OvmfPkg/RiscVVirt: Add CLANGDWARF toolchain > > support > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4478 > > > > This series adds support for building RiscVVirtQemu EDK2 using > > CLANGDWARF toolchain. Adding this support helps people to use > > the same toolchain to build EDK2 for different architectures. > > > > Cc: Rebecca Cran <rebecca@bsdio.com> > > Cc: Liming Gao <gaoliming@byosoft.com.cn> > > Cc: Bob Feng <bob.c.feng@intel.com> > > Cc: Yuwei Chen <yuwei.chen@intel.com> > > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> > > Cc: Jiewen Yao <jiewen.yao@intel.com> > > Cc: Jordan Justen <jordan.l.justen@intel.com> > > Cc Gerd Hoffmann <kraxel@redhat.com> > > Cc: Andrei Warkentin <andrei.warkentin@intel.com> > > Cc: Heinrich Schuchardt <heinrich.schuchardt@canonical.com> > > > > Changes since v1: > > 1) Addressed Liming's comments in PATCH 3. > > > > Sunil V L (4): > > OvmfPkg/RiscVVirt: use 'auto' alignment and FIXED for XIP modules > > OvmfPkg/RiscVVirt: SecEntry: Remove unnecessary assembly directives > > BaseTools/tools_def: Add CLANGDWARF support for RISC-V > > OvmfPkg/RiscVVirt: Update README for CLANGDWARF support > > > > OvmfPkg/RiscVVirt/RiscVVirtQemu.fdf | 34 ++++++------------ > > BaseTools/Conf/tools_def.template | 53 > > +++++++++++++++++++++++++++++ > > OvmfPkg/RiscVVirt/README.md | 28 +++++++++++++-- > > OvmfPkg/RiscVVirt/Sec/SecEntry.S | 3 -- > > 4 files changed, 88 insertions(+), 30 deletions(-) > > > > -- > > 2.34.1 > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#106961): https://edk2.groups.io/g/devel/message/106961 Mute This Topic: https://groups.io/mt/100187566/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
On Mon, Jul 17, 2023 at 11:38:31AM +0200, Ard Biesheuvel wrote: > On Mon, 17 Jul 2023 at 03:51, gaoliming via groups.io > <gaoliming=byosoft.com.cn@groups.io> wrote: > > > > Sunil: > > Do you use which CLANG version is used to verify this change? > > > > For the series, > > Tested-by: Ard Biesheuvel <ardb@kernel.org> # Debian clang version 14.0.6 > Thanks!, Ard. Hi Liming, do you have any further feedback? Thanks! Sunil -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107120): https://edk2.groups.io/g/devel/message/107120 Mute This Topic: https://groups.io/mt/100187566/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
On Fri, 21 Jul 2023 at 06:52, Sunil V L <sunilvl@ventanamicro.com> wrote: > > On Mon, Jul 17, 2023 at 11:38:31AM +0200, Ard Biesheuvel wrote: > > On Mon, 17 Jul 2023 at 03:51, gaoliming via groups.io > > <gaoliming=byosoft.com.cn@groups.io> wrote: > > > > > > Sunil: > > > Do you use which CLANG version is used to verify this change? > > > > > > > For the series, > > > > Tested-by: Ard Biesheuvel <ardb@kernel.org> # Debian clang version 14.0.6 > > > Thanks!, Ard. > > Hi Liming, do you have any further feedback? > Could we make some progress here? I'm happy to go and merge this if i can get an ack on the basetools change -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107250): https://edk2.groups.io/g/devel/message/107250 Mute This Topic: https://groups.io/mt/100187566/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
On Tue, Jul 25, 2023 at 05:59:25PM +0200, Ard Biesheuvel wrote: > On Fri, 21 Jul 2023 at 06:52, Sunil V L <sunilvl@ventanamicro.com> wrote: > > > > On Mon, Jul 17, 2023 at 11:38:31AM +0200, Ard Biesheuvel wrote: > > > On Mon, 17 Jul 2023 at 03:51, gaoliming via groups.io > > > <gaoliming=byosoft.com.cn@groups.io> wrote: > > > > > > > > Sunil: > > > > Do you use which CLANG version is used to verify this change? > > > > > > > > > > For the series, > > > > > > Tested-by: Ard Biesheuvel <ardb@kernel.org> # Debian clang version 14.0.6 > > > > > Thanks!, Ard. > > > > Hi Liming, do you have any further feedback? > > > > Could we make some progress here? I'm happy to go and merge this if i > can get an ack on the basetools change Hi Liming, Could you please provide RB/ACK tag so that Ard can merge this? We would like to get this support added for upcoming stable release. Thanks! Sunil -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107322): https://edk2.groups.io/g/devel/message/107322 Mute This Topic: https://groups.io/mt/100187566/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
On Fri, 28 Jul 2023 at 07:32, Sunil V L <sunilvl@ventanamicro.com> wrote: > > On Tue, Jul 25, 2023 at 05:59:25PM +0200, Ard Biesheuvel wrote: > > On Fri, 21 Jul 2023 at 06:52, Sunil V L <sunilvl@ventanamicro.com> wrote: > > > > > > On Mon, Jul 17, 2023 at 11:38:31AM +0200, Ard Biesheuvel wrote: > > > > On Mon, 17 Jul 2023 at 03:51, gaoliming via groups.io > > > > <gaoliming=byosoft.com.cn@groups.io> wrote: > > > > > > > > > > Sunil: > > > > > Do you use which CLANG version is used to verify this change? > > > > > > > > > > > > > For the series, > > > > > > > > Tested-by: Ard Biesheuvel <ardb@kernel.org> # Debian clang version 14.0.6 > > > > > > > Thanks!, Ard. > > > > > > Hi Liming, do you have any further feedback? > > > > > > > Could we make some progress here? I'm happy to go and merge this if i > > can get an ack on the basetools change > > Hi Liming, > > Could you please provide RB/ACK tag so that Ard can merge this? We would > like to get this support added for upcoming stable release. > If nobody objects, I will merge this tomorrow with or without an ack from the BaseTools maintainers. Thanks, Ard. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107399): https://edk2.groups.io/g/devel/message/107399 Mute This Topic: https://groups.io/mt/100187566/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Sorry for the delay. I've just added my R-b. -- Rebecca On 7/31/23 04:29, Ard Biesheuvel wrote: > On Fri, 28 Jul 2023 at 07:32, Sunil V L <sunilvl@ventanamicro.com> wrote: >> On Tue, Jul 25, 2023 at 05:59:25PM +0200, Ard Biesheuvel wrote: >>> On Fri, 21 Jul 2023 at 06:52, Sunil V L <sunilvl@ventanamicro.com> wrote: >>>> On Mon, Jul 17, 2023 at 11:38:31AM +0200, Ard Biesheuvel wrote: >>>>> On Mon, 17 Jul 2023 at 03:51, gaoliming via groups.io >>>>> <gaoliming=byosoft.com.cn@groups.io> wrote: >>>>>> Sunil: >>>>>> Do you use which CLANG version is used to verify this change? >>>>>> >>>>> For the series, >>>>> >>>>> Tested-by: Ard Biesheuvel <ardb@kernel.org> # Debian clang version 14.0.6 >>>>> >>>> Thanks!, Ard. >>>> >>>> Hi Liming, do you have any further feedback? >>>> >>> Could we make some progress here? I'm happy to go and merge this if i >>> can get an ack on the basetools change >> Hi Liming, >> >> Could you please provide RB/ACK tag so that Ard can merge this? We would >> like to get this support added for upcoming stable release. >> > If nobody objects, I will merge this tomorrow with or without an ack > from the BaseTools maintainers. > > Thanks, > Ard. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107401): https://edk2.groups.io/g/devel/message/107401 Mute This Topic: https://groups.io/mt/100187566/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Thanks all. Merged now as #4701 On Mon, 31 Jul 2023 at 13:29, Rebecca Cran <rebecca@bsdio.com> wrote: > > Sorry for the delay. I've just added my R-b. > > > -- > > Rebecca > > > On 7/31/23 04:29, Ard Biesheuvel wrote: > > On Fri, 28 Jul 2023 at 07:32, Sunil V L <sunilvl@ventanamicro.com> wrote: > >> On Tue, Jul 25, 2023 at 05:59:25PM +0200, Ard Biesheuvel wrote: > >>> On Fri, 21 Jul 2023 at 06:52, Sunil V L <sunilvl@ventanamicro.com> wrote: > >>>> On Mon, Jul 17, 2023 at 11:38:31AM +0200, Ard Biesheuvel wrote: > >>>>> On Mon, 17 Jul 2023 at 03:51, gaoliming via groups.io > >>>>> <gaoliming=byosoft.com.cn@groups.io> wrote: > >>>>>> Sunil: > >>>>>> Do you use which CLANG version is used to verify this change? > >>>>>> > >>>>> For the series, > >>>>> > >>>>> Tested-by: Ard Biesheuvel <ardb@kernel.org> # Debian clang version 14.0.6 > >>>>> > >>>> Thanks!, Ard. > >>>> > >>>> Hi Liming, do you have any further feedback? > >>>> > >>> Could we make some progress here? I'm happy to go and merge this if i > >>> can get an ack on the basetools change > >> Hi Liming, > >> > >> Could you please provide RB/ACK tag so that Ard can merge this? We would > >> like to get this support added for upcoming stable release. > >> > > If nobody objects, I will merge this tomorrow with or without an ack > > from the BaseTools maintainers. > > > > Thanks, > > Ard. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107403): https://edk2.groups.io/g/devel/message/107403 Mute This Topic: https://groups.io/mt/100187566/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
On Mon, Jul 17, 2023 at 09:51:38AM +0800, gaoliming via groups.io wrote: > Sunil: > Do you use which CLANG version is used to verify this change? > Hi Liming, I tested with toolchain 13, 14, 15, 16 and latest 17. (Like clang-13, lld-13, llvm-*-13, ...). I didn't test prior to v13 considering the churn happening for RISC-V. Do you recommend any particular version I should test / support? Thanks, Sunil > Thanks > Liming > > -----邮件原件----- > > 发件人: Sunil V L <sunilvl@ventanamicro.com> > > 发送时间: 2023年7月11日 23:44 > > 收件人: devel@edk2.groups.io > > 抄送: Sunil V L <sunilvl@ventanamicro.com>; Rebecca Cran > > <rebecca@bsdio.com>; Liming Gao <gaoliming@byosoft.com.cn>; Bob Feng > > <bob.c.feng@intel.com>; Yuwei Chen <yuwei.chen@intel.com>; Ard > > Biesheuvel <ardb+tianocore@kernel.org>; Jiewen Yao > > <jiewen.yao@intel.com>; Jordan Justen <jordan.l.justen@intel.com>; Andrei > > Warkentin <andrei.warkentin@intel.com>; Heinrich Schuchardt > > <heinrich.schuchardt@canonical.com> > > 主题: [PATCH v2 0/4] OvmfPkg/RiscVVirt: Add CLANGDWARF toolchain > > support > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4478 > > > > This series adds support for building RiscVVirtQemu EDK2 using > > CLANGDWARF toolchain. Adding this support helps people to use > > the same toolchain to build EDK2 for different architectures. > > > > Cc: Rebecca Cran <rebecca@bsdio.com> > > Cc: Liming Gao <gaoliming@byosoft.com.cn> > > Cc: Bob Feng <bob.c.feng@intel.com> > > Cc: Yuwei Chen <yuwei.chen@intel.com> > > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> > > Cc: Jiewen Yao <jiewen.yao@intel.com> > > Cc: Jordan Justen <jordan.l.justen@intel.com> > > Cc Gerd Hoffmann <kraxel@redhat.com> > > Cc: Andrei Warkentin <andrei.warkentin@intel.com> > > Cc: Heinrich Schuchardt <heinrich.schuchardt@canonical.com> > > > > Changes since v1: > > 1) Addressed Liming's comments in PATCH 3. > > > > Sunil V L (4): > > OvmfPkg/RiscVVirt: use 'auto' alignment and FIXED for XIP modules > > OvmfPkg/RiscVVirt: SecEntry: Remove unnecessary assembly directives > > BaseTools/tools_def: Add CLANGDWARF support for RISC-V > > OvmfPkg/RiscVVirt: Update README for CLANGDWARF support > > > > OvmfPkg/RiscVVirt/RiscVVirtQemu.fdf | 34 ++++++------------ > > BaseTools/Conf/tools_def.template | 53 > > +++++++++++++++++++++++++++++ > > OvmfPkg/RiscVVirt/README.md | 28 +++++++++++++-- > > OvmfPkg/RiscVVirt/Sec/SecEntry.S | 3 -- > > 4 files changed, 88 insertions(+), 30 deletions(-) > > > > -- > > 2.34.1 > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#106956): https://edk2.groups.io/g/devel/message/106956 Mute This Topic: https://groups.io/mt/100187566/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
© 2016 - 2024 Red Hat, Inc.