From nobody Fri May 17 07:47:27 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+106452+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+106452+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1687914967; cv=none; d=zohomail.com; s=zohoarc; b=Tx2mPOQoMSe6BS3ml2F8BuFbz9x/QmQGBOJXS9cUNlfqWK9ndrYx6c5cFMOqQU75DDPKMU/5tKbNz06PyN81SAmiQcnsakVtrTy4sjOCbNHuiBwwJKxGuS1+nGYMgqWzAMqeW9ltwRyykUIcwjOw7SsQPaXgF6ad0boFrzjU7pk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1687914967; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=b+QcjorVMCbrzgGBDFsBsvwscvr3Yml7VsEwIhoBJcU=; b=kC9QGbpq2phBL7NZolNtFEcp3OPrVXLApQEudkS86/apgGN6J5gPbo+JTyGzVu7aRyzm8KRBd0ygLkVEz/xCvcKaBTeRwdiN5l58CQqW/YIzphJB2n/K7B5H+LPbr2UNNiILXJ/qwVrEqL8eaRCcGOBUBSdTOBC045XY9l8VV5o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+106452+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1687914967444127.7634340179178; Tue, 27 Jun 2023 18:16:07 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id sNsyYY1788612xUhymvuJvYt; Tue, 27 Jun 2023 18:16:07 -0700 X-Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by mx.groups.io with SMTP id smtpd.web10.6117.1687914966170238503 for ; Tue, 27 Jun 2023 18:16:06 -0700 X-Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-1b7e6512973so20483145ad.3 for ; Tue, 27 Jun 2023 18:16:06 -0700 (PDT) X-Gm-Message-State: 4yVHt3ZlJSdCtSIVYdY5SoJBx1787277AA= X-Google-Smtp-Source: ACHHUZ4EG2ns02gdD8jxnRDFJqqVdpZjbc4cb5l67CqsDl0ws8EafR5NzDO8vf93YMmHF4dKSfAGRg== X-Received: by 2002:a17:902:c40c:b0:1b2:450f:9b6 with SMTP id k12-20020a170902c40c00b001b2450f09b6mr10197131plk.8.1687914965239; Tue, 27 Jun 2023 18:16:05 -0700 (PDT) X-Received: from localhost.localdomain (c-174-50-177-95.hsd1.ca.comcast.net. [174.50.177.95]) by smtp.gmail.com with ESMTPSA id n13-20020a170903110d00b001b5656b0bf9sm6487599plh.286.2023.06.27.18.16.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Jun 2023 18:16:04 -0700 (PDT) From: "Tuan Phan" To: devel@edk2.groups.io Cc: sunilvl@ventanamicro.com, andrei.warkentin@intel.com, Tuan Phan Subject: [edk2-devel] [PATCH] UefiCpuPkg: CpuTimerDxeRiscV64: Fix timer event not working correctly Date: Tue, 27 Jun 2023 18:15:57 -0700 Message-Id: <20230628011557.4713-1-tphan@ventanamicro.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,tphan@ventanamicro.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1687914967; bh=p0/uld4uatqv0ZPooasdlEk/MxIuioNCcZXZs0kIUnU=; h=Cc:Date:From:Reply-To:Subject:To; b=xJXZ4GhOPZvh8isO1Uim/XvsvbmKMFPECKx++2cY/2X7YtcltjwD3/+/bxVkQ9BdIW5 dyKYxcc8Za0udBQ8twpfJ9Y2YSdCHpAygAVvGnN+BgNy0W0P3YbQJbzpa4Rt88GNjIxsb 8z48QSX6QD9ptVopYZnsWzx4MRqL1bD1j1U= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1687914968146100002 Content-Type: text/plain; charset="utf-8" The timer notify function should be called with timer period, not the value read from timer register. Signed-off-by: Tuan Phan Reviewed-by: Sunil V L --- UefiCpuPkg/CpuTimerDxeRiscV64/Timer.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/UefiCpuPkg/CpuTimerDxeRiscV64/Timer.c b/UefiCpuPkg/CpuTimerDxe= RiscV64/Timer.c index 358057e7c6a4..30e48061cd06 100644 --- a/UefiCpuPkg/CpuTimerDxeRiscV64/Timer.c +++ b/UefiCpuPkg/CpuTimerDxeRiscV64/Timer.c @@ -9,6 +9,7 @@ =20 #include #include +#include #include "Timer.h" =20 // @@ -71,7 +72,12 @@ TimerInterruptHandler ( // time to increment slower. So when we take an interrupt, // account for the actual time passed. // - mTimerNotifyFunction (PeriodStart - mLastPeriodStart); + mTimerNotifyFunction ( + DivU64x32 ( + EFI_TIMER_PERIOD_SECONDS (PeriodStart - mLastPeriodStart), + PcdGet64 (PcdCpuCoreCrystalClockFrequency) + ) + ); } =20 if (mTimerPeriod =3D=3D 0) { --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#106452): https://edk2.groups.io/g/devel/message/106452 Mute This Topic: https://groups.io/mt/99822131/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-