OvmfPkg/VirtioSerialDxe: Remove noisy debug print on supported() call

[edk2-devel] [PATCH] OvmfPkg/VirtioSerialDxe: Remove noisy debug print on supported() call

Posted by Ard Biesheuvel 10 months, 1 week ago

The UEFI driver model invokes the supported() method on every driver
every time a connection attempt is made on any handle, and so doing an
unconditional DEBUG() print inside this method produced a lot of noise.

So let's drop this DEBUG() call from the VirtioSerial driver's
Supported() method.

Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
---
 OvmfPkg/VirtioSerialDxe/VirtioSerial.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/OvmfPkg/VirtioSerialDxe/VirtioSerial.c b/OvmfPkg/VirtioSerialDxe/VirtioSerial.c
index df545c080e9d9212..fd34ad75a9a079ce 100644
--- a/OvmfPkg/VirtioSerialDxe/VirtioSerial.c
+++ b/OvmfPkg/VirtioSerialDxe/VirtioSerial.c
@@ -510,8 +510,6 @@ VirtioSerialDriverBindingSupported (
     Status = EFI_UNSUPPORTED;
   }
 
-  DEBUG ((DEBUG_INFO, "%a:%d: subsystem %d -> %r\n", __func__, __LINE__, VirtIo->SubSystemDeviceId, Status));
-
   //
   // We needed VirtIo access only transitorily, to see whether we support the
   // device or not.
-- 
2.39.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#106424): https://edk2.groups.io/g/devel/message/106424
Mute This Topic: https://groups.io/mt/99807185/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] OvmfPkg/VirtioSerialDxe: Remove noisy debug print on supported() call

Posted by Gerd Hoffmann 10 months, 1 week ago

On Tue, Jun 27, 2023 at 01:17:16PM +0200, Ard Biesheuvel wrote:
> The UEFI driver model invokes the supported() method on every driver
> every time a connection attempt is made on any handle, and so doing an
> unconditional DEBUG() print inside this method produced a lot of noise.
> 
> So let's drop this DEBUG() call from the VirtioSerial driver's
> Supported() method.
> 
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>

Acked-by: Gerd Hoffmann <kraxel@redhat.com>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#106428): https://edk2.groups.io/g/devel/message/106428
Mute This Topic: https://groups.io/mt/99807185/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-