From nobody Thu May 16 17:48:29 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+106223+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+106223+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1687296703; cv=none; d=zohomail.com; s=zohoarc; b=fZSEboL2omMmvzYh95lQJrrFVka+u7cTEH8pCNVh/xEWDmMYtmSvY/Icv7p0MS3etekgexXWiodMfXix41MPGhYDI8N0Cj5RqFDqTWpdMMT+QfGYZMaHuAduVK7yQdL91k0K/+DTJAIOUiNtrATnaDv/fFCUNjRn1Idsz9RK3/I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1687296703; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=fVYKFz6G1Ztrl9myx3E1u+qnYrZ+iykaXCCPqFEQ8fM=; b=YfFYdFnYb6qMIt700/beKR7u2jLuDYB0XiZlpou0giCmihiO0DBYYu6yMbEW9ZY6jlkGuNhvI+bNieqA3+Am5pbXOuWsTzKKZ3K+7frUD1bM5SwhUe9vfwSloTCCWouYoLODtqaj0P0HV5YT/sHT/oSbVli3tiiTuz4cti4Pe6U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+106223+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1687296703936633.2360114097802; Tue, 20 Jun 2023 14:31:43 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id vJW9YY1788612xXNkRRv4bci; Tue, 20 Jun 2023 14:31:43 -0700 X-Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) by mx.groups.io with SMTP id smtpd.web10.1975.1687296702473598337 for ; Tue, 20 Jun 2023 14:31:42 -0700 X-Received: by mail-lj1-f174.google.com with SMTP id 38308e7fff4ca-2b46b11051aso52653941fa.3 for ; Tue, 20 Jun 2023 14:31:42 -0700 (PDT) X-Gm-Message-State: zVEd0sxzFFwVVwupDVjzvQzxx1787277AA= X-Google-Smtp-Source: ACHHUZ7v1RqB9WIzfKqpWEI98aArLehtUNeKujqdzdKryHeQxiz9a2h5OGD9NWl+sNx0yD4QQd1CBg== X-Received: by 2002:a2e:7310:0:b0:2b4:76a8:bb8d with SMTP id o16-20020a2e7310000000b002b476a8bb8dmr4642089ljc.47.1687296700533; Tue, 20 Jun 2023 14:31:40 -0700 (PDT) X-Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id r9-20020a2e9949000000b002b2273431f3sm585039ljj.94.2023.06.20.14.31.39 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 20 Jun 2023 14:31:40 -0700 (PDT) From: "Mike Maslenkin" To: devel@edk2.groups.io Cc: abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, Mike Maslenkin Subject: [edk2-devel] [PATCH] [edk2-redfish-client] Remove reference to BaseSortLib library Date: Wed, 21 Jun 2023 00:31:37 +0300 Message-Id: <20230620213137.28235-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1687296703; bh=0h7UiD6lAbVFT5MX/ayjNN+ShOpY22sY8XWGwfllI6A=; h=Cc:Date:From:Reply-To:Subject:To; b=q/kfI3F4BN8MrOsYUNnEXFt6/20r+c8xuzIAaNjYtz+AveueI/dLG4zCZJ0aJGHPZpo bX6+1CBOqEhVxXwIyQWaX5GIq2DxHCOa6wZSscj1I3q9wQ8dDoYNlzrEtlDaL8rnNdHm7 nYhq7/fY4ZGCz9U8fMUSFgjP6ONtgh+jzYA= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1687296704353100001 Content-Type: text/plain; charset="utf-8" There are two problems with BaseSortLib reference: 1 BaseSortLib is the library instance name not the class name. 2 UefiSortLib instance from MdeModulePkg is also referenced below. Let's use only one reference to SortLib. Even though Redfish Client uses only quick sort for char* elements, UefiSortLib is preferred as it allows to sort DevicePath instances and wide strings. Signed-off-by: Mike Maslenkin Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Reviewed-by: Abner Chang --- RedfishClientPkg/RedfishClientPkg.dsc | 1 - 1 file changed, 1 deletion(-) diff --git a/RedfishClientPkg/RedfishClientPkg.dsc b/RedfishClientPkg/Redfi= shClientPkg.dsc index edc387ac72dc..e16c91b83196 100644 --- a/RedfishClientPkg/RedfishClientPkg.dsc +++ b/RedfishClientPkg/RedfishClientPkg.dsc @@ -36,7 +36,6 @@ JsonLib|RedfishPkg/Library/JsonLib/JsonLib.inf Ucs2Utf8Lib|RedfishPkg/Library/BaseUcs2Utf8Lib/BaseUcs2Utf8Lib.inf RedfishCrtLib|RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf - BaseSortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf UefiHiiServicesLib|MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiServic= esLib.inf UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManag= erLib.inf --=20 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#106223): https://edk2.groups.io/g/devel/message/106223 Mute This Topic: https://groups.io/mt/99664829/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-