[edk2-devel] [PATCH] IntelSiliconPkg/VTd: Fix wrong parameter type in VtdLog.c

Sheng Wei posted 1 patch 10 months, 3 weeks ago
Failed in applying to current master (apply log)
.../Intel/IntelSiliconPkg/Feature/VTd/IntelVTdCoreDxe/VtdLog.c  | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[edk2-devel] [PATCH] IntelSiliconPkg/VTd: Fix wrong parameter type in VtdLog.c
Posted by Sheng Wei 10 months, 3 weeks ago
Add (VOID **) for gBS->AllocatePool.

Cc: Ray Ni <ray.ni@intel.com>
Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
Cc: Jenny Huang <jenny.huang@intel.com>
Cc: Robert Kowalewski <robert.kowalewski@intel.com>
Signed-off-by: Sheng Wei <w.sheng@intel.com>
---
 .../Intel/IntelSiliconPkg/Feature/VTd/IntelVTdCoreDxe/VtdLog.c  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdCoreDxe/VtdLog.c b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdCoreDxe/VtdLog.c
index 0ac4758ff..91c27e2a1 100644
--- a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdCoreDxe/VtdLog.c
+++ b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdCoreDxe/VtdLog.c
@@ -326,7 +326,7 @@ VTdLogInitialize(
 
   TotalBufferSize = PcdGet32 (PcdVTdDxeLogBufferSize) + PcdGet32 (PcdVTdPeiPostMemLogBufferSize) + sizeof (VTDLOG_PEI_PRE_MEM_INFO) * VTD_LOG_PEI_PRE_MEM_BAR_MAX;
 
-  Status = gBS->AllocatePool (EfiBootServicesData, TotalBufferSize, &mVtdLogBuffer);
+  Status = gBS->AllocatePool (EfiBootServicesData, TotalBufferSize, (VOID **) &mVtdLogBuffer);
   if (EFI_ERROR (Status)) {
     return;
   }
-- 
2.26.2.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#106002): https://edk2.groups.io/g/devel/message/106002
Mute This Topic: https://groups.io/mt/99478714/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] IntelSiliconPkg/VTd: Fix wrong parameter type in VtdLog.c
Posted by Ni, Ray 10 months, 3 weeks ago
Reviewed-by: Ray Ni <ray.ni@intel.com>

________________________________________
From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf of Sheng Wei <w.sheng@intel.com>
Sent: Monday, June 12, 2023 16:17
To: devel@edk2.groups.io
Cc: Ni, Ray; Chaganty, Rangasai V; Huang, Jenny; Kowalewski, Robert
Subject: [edk2-devel] [PATCH] IntelSiliconPkg/VTd: Fix wrong parameter type in VtdLog.c

Add (VOID **) for gBS->AllocatePool.

Cc: Ray Ni <ray.ni@intel.com>
Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
Cc: Jenny Huang <jenny.huang@intel.com>
Cc: Robert Kowalewski <robert.kowalewski@intel.com>
Signed-off-by: Sheng Wei <w.sheng@intel.com>
---
 .../Intel/IntelSiliconPkg/Feature/VTd/IntelVTdCoreDxe/VtdLog.c  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdCoreDxe/VtdLog.c b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdCoreDxe/VtdLog.c
index 0ac4758ff..91c27e2a1 100644
--- a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdCoreDxe/VtdLog.c
+++ b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdCoreDxe/VtdLog.c
@@ -326,7 +326,7 @@ VTdLogInitialize(


   TotalBufferSize = PcdGet32 (PcdVTdDxeLogBufferSize) + PcdGet32 (PcdVTdPeiPostMemLogBufferSize) + sizeof (VTDLOG_PEI_PRE_MEM_INFO) * VTD_LOG_PEI_PRE_MEM_BAR_MAX;



-  Status = gBS->AllocatePool (EfiBootServicesData, TotalBufferSize, &mVtdLogBuffer);

+  Status = gBS->AllocatePool (EfiBootServicesData, TotalBufferSize, (VOID **) &mVtdLogBuffer);

   if (EFI_ERROR (Status)) {

     return;

   }

--
2.26.2.windows.1



-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#106002): https://edk2.groups.io/g/devel/message/106002
Mute This Topic: https://groups.io/mt/99478714/1712937
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [ray.ni@intel.com]
-=-=-=-=-=-=




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#106036): https://edk2.groups.io/g/devel/message/106036
Mute This Topic: https://groups.io/mt/99478714/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076/xyzzy [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-