From nobody Fri May 17 12:14:55 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+105640+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+105640+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; t=1685695907; cv=none; d=zohomail.com; s=zohoarc; b=YoJpuWnEVhpC19Lwxb/GWmxnuu5+uxnRuK675IoWiAgDGntHmkkNWeEWJmOFZ0iZVy7xRuyozRk57vcWvNWYmiqCrZ7MgVAnslqKMKVDDB4VcYW2aEoJceaRon/bwKHP4YgkSVpPG6BUQkGbXFLXsqV/yW1s1X1BgPGDdiYCpAc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1685695907; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=n5BrpjxYMqKf33AQ9mp4EWCkVeFlv/5EvUytpwK4lF0=; b=klkqXJTZ1+2VujhzNq7wPS7Ldx9+cvjOlmnlefQV+BjoWQLcosgnOkVFoBybBDw2EwF8A82YUaJBI7+P2USv/c0uWgoNQZ4RPVUgg5c/zVUA+M7P4uRMsy+ipw107EycY0FbXLn24vauJtxOFpkHYOdVNciccdvYWQ+taE2ZKjE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+105640+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1685695907666121.09044612753235; Fri, 2 Jun 2023 01:51:47 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id AuArYY1788612xVo2nFBxjAP; Fri, 02 Jun 2023 01:51:47 -0700 X-Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web11.8114.1685695906132912119 for ; Fri, 02 Jun 2023 01:51:46 -0700 X-Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A826A64D72; Fri, 2 Jun 2023 08:51:45 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id CEA85C4339B; Fri, 2 Jun 2023 08:51:43 +0000 (UTC) From: "Ard Biesheuvel" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Leif Lindholm , "Kinney, Michael D" , Michael Kubacki Subject: [edk2-devel] [RFC PATCH] ArmPkg: Enable AuditMode for Uncrustify CI checks Date: Fri, 2 Jun 2023 10:51:36 +0200 Message-Id: <20230602085136.3552790-1-ardb@kernel.org> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org X-Gm-Message-State: oQE6puiJz4r1loOGFOhTzoX3x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1685695907; bh=qW3NiXnDCjZE8yEoWyaUIBEWJ8eDXn2ZO0wfXDAPy00=; h=Cc:Date:From:Reply-To:Subject:To; b=j8K084Y3rCndJneLeZ93o52R3JjYtt063Q2ClrcxuvO3BCUDfRg4KkSMJDKHFP70bcX PrQ6GoKwy9X9ninCYkrt1a8jYQE6l3A5c3booehwiQy4st/k6+joDqChuMtkTEaMFRbLG /H2bmGpSdaWzZf2tvwQcRrnHYxJNbNiqp2U= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1685695909978100003 Content-Type: text/plain; charset="utf-8" Uncrustify checks are too rigid, making them counter-productive: - it leads to code that is arguably harder to parse visually (e.g., the changes to ArmPkg/Include/Chipset/AArch64Mmu.h in commit 429309e0c6b74792) - it forces indentation-only changes to code in the vicinity of actual changes, making the code history more bloated than necessary (see commit 7f198321eec0f520373 for an example) - finding out from the web UI what exactly Uncrustify objected to is not straight-forward. So let's enable AuditMode for ArmPkg, so that interested parties can see the uncrustify recommendations if desired, but without preventing the changes from being merged. This leaves it at the discretion of the ArmPkg maintainers to decide which level of conformance is required. Cc: Leif Lindholm Cc: "Kinney, Michael D" Cc: Michael Kubacki Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm --- ArmPkg/ArmPkg.ci.yaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/ArmPkg/ArmPkg.ci.yaml b/ArmPkg/ArmPkg.ci.yaml index 24db7425051388cf..d3124816118944cb 100644 --- a/ArmPkg/ArmPkg.ci.yaml +++ b/ArmPkg/ArmPkg.ci.yaml @@ -239,5 +239,10 @@ ], "AdditionalIncludePaths": [] # Additional paths to spell check # (wildcards supported) + }, + + # options defined in .pytool/Plugin/UncrustifyCheck + "UncrustifyCheck": { + "AuditOnly": True } } --=20 2.39.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#105640): https://edk2.groups.io/g/devel/message/105640 Mute This Topic: https://groups.io/mt/99282612/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-