From nobody Sat May 18 21:00:39 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+105360+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1685341453296357.27709476837083; Sun, 28 May 2023 23:24:13 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id r2zSYY1788612xxShbEdV1Eq; Sun, 28 May 2023 23:24:12 -0700 X-Received: from NAM02-DM3-obe.outbound.protection.outlook.com (NAM02-DM3-obe.outbound.protection.outlook.com [40.107.95.58]) by mx.groups.io with SMTP id smtpd.web11.44141.1685341451923815831 for ; Sun, 28 May 2023 23:24:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Welepkfcx9C3yOXItY7WZNWJpGBieDkcyikuOQwMstuC//AnHQaXqgNuJY2K9Uuelp+5b0Jg+4ySAJfbX3NnYYf5gooYuR1vJWk5xOTNGD5+7UcDjmGxb19moX31aG3CcjAaBVJzUIULlHL/2vMjLug/9XDkZbtKWn4WMoXSighq0YR3k+kz8nTi3nQNPiOYaiFbqTvIAB668DXLwNM5seT6mnRZ53nex1G4lIltbyjnv0zvqvtDTsddoTPTkFaQW0NpOjeJemwsyTqskGQ9RDTjTQc31ppLGbtAMqOU4Bo5fmFocO5jpAgggh0xxywP6mIpYB85DPz8H1P/L2M2gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yFoTDIZlphpyzIw0vMvrI7V3qNf5MMKPeWm6zuFT84g=; b=FFARkp2oDsd+ooeu3rR9hMgJEz3Gm1Pt2dA3lnxQioFM7JDF1VdNzszqdn68tLIqGZmiwjkJg6YhBGUQduM559+TDnVKcMtAhv+8DZzQD8Bj0RaPdcg95gmqiWSRoq8LzHL4MGEW5H4TIm/eeIyZUuRh4yrJ8e13sZr9CTMB3thX/iq1HSR9jj2EVDpNoKK5c4kFo0IhxPYlFl7pcls8t8BN78u8UH3hmMWOG6WKVTSrXxj9/1Oxkb1h881ipb3iDgcfylqZZeiLOnAeZbez6A4oNQuTqiom9SriiVDcTowAhgq8Sw54iqoHfIMjlVV2e9/CuimfI6mHwk1RgI9f+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none X-Received: from DS7PR03CA0325.namprd03.prod.outlook.com (2603:10b6:8:2b::34) by DS0PR12MB8788.namprd12.prod.outlook.com (2603:10b6:8:14f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.23; Mon, 29 May 2023 06:24:09 +0000 X-Received: from DM6NAM11FT045.eop-nam11.prod.protection.outlook.com (2603:10b6:8:2b:cafe::a6) by DS7PR03CA0325.outlook.office365.com (2603:10b6:8:2b::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.23 via Frontend Transport; Mon, 29 May 2023 06:24:09 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+105360+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C X-Received: from mail.nvidia.com (216.228.118.232) by DM6NAM11FT045.mail.protection.outlook.com (10.13.173.123) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.23 via Frontend Transport; Mon, 29 May 2023 06:24:09 +0000 X-Received: from drhqmail203.nvidia.com (10.126.190.182) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Sun, 28 May 2023 23:24:03 -0700 X-Received: from drhqmail202.nvidia.com (10.126.190.181) by drhqmail203.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Sun, 28 May 2023 23:24:02 -0700 X-Received: from NV-CL38DL3.nvidia.com (10.127.8.14) by mail.nvidia.com (10.126.190.181) with Microsoft SMTP Server id 15.2.986.37 via Frontend Transport; Sun, 28 May 2023 23:24:02 -0700 From: "Nickle Wang via groups.io" To: CC: Abner Chang , Igor Kulchytskyy Subject: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformConfigDxe: fix value type issue. Date: Mon, 29 May 2023 14:24:01 +0800 Message-ID: <20230529062401.1263-1-nicklew@nvidia.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT045:EE_|DS0PR12MB8788:EE_ X-MS-Office365-Filtering-Correlation-Id: 0bb49532-d3ba-4802-a987-08db600d5000 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: sXXQoZjSE6BMYuLzlZuRADUBYhdms0jeUC47l5ynUyydITjW/aiZmxkGHTbn9D238BFWLPiYLL0A+nZ6o5jjnbiKHKL0n1zTS9BuU8KyG4wEEjuOrk+QZHcLcgYHLSrbjrga+qS3LE924o9OF8s3/rkX5qq/vhVa7A3ZPoZTbaFDl2mtla7ynv6MjTYH4CXSutVjziJfwWY2jAtbN2zksYqUDL1vxnxIGuom0SFnIQaxZWUNnYBIS3qZxZjxvvsKEgfOe7NgxpkfuOdW9t3hMZDRstN5lJlD0WBEGukgp8jclgyJ89zPOB9qOihUTpNLAmzPrbCLZaSToCyQzii0gSHTYVf5wJ84rlyslTa5cocZ/+TNgwUEOsYS0j4rz/9j++i5HNW6f48Fc3lXxIzW5qaea915eqpC1hYbn7GHhJLMsXzla9tepqU89aEk17vA9MW4l1BdyQP6FytV50jfc0RY1ZMmc0ZvQuO4MchGVOHYeaRFScmfYeXojVunkcVXiPz75tjo3Vj9IoPs564LUk4GxxZyMP3rV/F8DVI8Nal4Tl63htu2YXJYnndrdkJTMjbtADaMcO/uO/+Y6b9zZyZnSt1oAPxRmwUz+5spcyOR47eyT3AQ1f7dOp8i1Ys6qztEcu5CeBV8ztZHfbM2EibpYV82VQKzQx8u9N+9J4Ex0DteQwQzsw7MfqGFYIgdRIE01eCC9ek+nM7skSAEAQjqWdldM7w16NLW3Vixdz8= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2023 06:24:09.4244 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0bb49532-d3ba-4802-a987-08db600d5000 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.232];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT045.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8788 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nicklew@nvidia.com X-Gm-Message-State: QKhtPZO4Pk6Iv6VHor7IU9C9x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1685341452; bh=2Zu99UeOQj+xzQLQQCkRhgfHFVchvOY1ifKjVQEPn+I=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=gggOdf1f/nIVDYBkV4oBCPrNWTL3QklbFoEM5iu56FSLuRNL9I6PtMwpiFPFo8Vtk98 T3HFtCNHAFt012l0+LNnJTUshj+1cyVAw7jwfV3wu3cae4IqSsmsxqTqSeLikw4bxbSuA c0zsOIMlvaX/Ov2eBTSziNTgB/pgN47CJXQ= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1685341454951100001 Content-Type: text/plain; charset="utf-8" Fix incorrect value type issue for checked-box op-code. When the variable for checked-box is defined as UINT8 in varstore structure, IFR compiler assign its value type to EFI_IFR_TYPE_NUM_SIZE_8 instead of EFI_IFR_TYPE_BOOLEAN. However, the value type for checked-box is boolean value. Redfish service may return error because of incorrect value type passed to BIOS attribute registry. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Reviewed-by: Abner Chang Reviewed-by: Igor Kulchytskyy --- .../RedfishPlatformConfigDxe.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c= b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c index 1172d1094b06..462f269f6a3f 100644 --- a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c +++ b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c @@ -1221,6 +1221,16 @@ HiiValueToRedfishValue ( RedfishValue->Type =3D RedfishValueTypeString; break; case EFI_IFR_CHECKBOX_OP: + // + // There is case where HII driver defines UINT8 for checked-box opco= de storage. + // IFR compiler will assign EFI_IFR_TYPE_NUM_SIZE_8 to its value typ= e instead of + // EFI_IFR_TYPE_BOOLEAN. We do a patch here and use boolean value ty= pe for this + // case. + // + if (Value->Type !=3D EFI_IFR_TYPE_BOOLEAN) { + Value->Type =3D EFI_IFR_TYPE_BOOLEAN; + } + case EFI_IFR_NUMERIC_OP: Status =3D HiiValueToRedfishNumeric (Value, RedfishValue); if (EFI_ERROR (Status)) { --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#105360): https://edk2.groups.io/g/devel/message/105360 Mute This Topic: https://groups.io/mt/99195197/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-