From nobody Sat May 18 21:00:39 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+105176+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=arm.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1684847086036276.1631729448802; Tue, 23 May 2023 06:04:46 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 5tm3YY1788612xjBTgA4hdaO; Tue, 23 May 2023 06:04:45 -0700 X-Received: from EUR05-AM6-obe.outbound.protection.outlook.com (EUR05-AM6-obe.outbound.protection.outlook.com [40.107.22.40]) by mx.groups.io with SMTP id smtpd.web11.21707.1684847084761988049 for ; Tue, 23 May 2023 06:04:45 -0700 X-Received: from AM6PR10CA0035.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:89::48) by PAVPR08MB9209.eurprd08.prod.outlook.com (2603:10a6:102:30a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.29; Tue, 23 May 2023 13:04:39 +0000 X-Received: from AM7EUR03FT059.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:89:cafe::6d) by AM6PR10CA0035.outlook.office365.com (2603:10a6:209:89::48) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.29 via Frontend Transport; Tue, 23 May 2023 13:04:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+105176+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT059.mail.protection.outlook.com (100.127.140.215) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.14 via Frontend Transport; Tue, 23 May 2023 13:04:39 +0000 X-Received: ("Tessian outbound 5154e9d36775:v136"); Tue, 23 May 2023 13:04:39 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: c3988114d93fdc1e X-CR-MTA-TID: 64aa7808 X-Received: from edad710837c9.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id E21155C3-EF89-425A-ABE2-C9BE79A4AA08.1; Tue, 23 May 2023 13:04:27 +0000 X-Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id edad710837c9.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 23 May 2023 13:04:27 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WDfIFpUuPWa7BPLWF6d6oMDZ9GxK7eVvAQeuEYgEMMyEa0lsRz4ieJhjOrpW9+g4pp9jE4YntcYbT684XLZ9nf8NtA693Kkh4QbhMiSeNILyU2kiOGyBfly/sswP93maUGyCq0shfDDyhN1GyGCJjZo9usaIIfqqgDWCGUrt0MnQz7po52tYX4acLSwAXs6RNv7gHa9Y3H3Q5PUjKBM1c35IVyz+tQ0g+2G/nwyBWHh+S/Z3Ick+tGAMNF+NK8xJrBo2OeNRnpEY2yyi0w0llVXEmHueJihLI9jZXNqsKTftnguTBuqHjgYIkh5+CZGGQwVkSFJl/YhbBYlLD+mpdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qcap7wSCGW9ORJiNCqTSydyFHZhoW/uapzZ67uK0Z1o=; b=OWBYmGP0YG753RnYrSERLTXNHCQWmcxS5i5NC+X9l7ej4F7UactNUsxsBIJ4KKIZN7SoKkwRWr0arUEtDUSNMPXkxrIHtxImQYOEUdIgppfyttgdK5hVAbukvstTT3FBD2EiVNi6Abg0/Op9Zs4VizD+cfRThr61sFbvlyxSmJE8C9ln//x2Abx1oQVpozJo9dKanKYUDugfQOvyMsGyAJ9m7qOKnZxgts/e3D2y1CDuJHP/t2jzHnIwp8JRsa8djGn+Vyn7O104gXDG/Ub8NplZSiGg+eRP/tcMmBJ1yRYQB2Na5rgVW4THLWgZDpoG+4gEMo8MyPbKQ2vb6em1NQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none X-Received: from AS8PR04CA0205.eurprd04.prod.outlook.com (2603:10a6:20b:2f3::30) by DB3PR08MB8985.eurprd08.prod.outlook.com (2603:10a6:10:43f::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.28; Tue, 23 May 2023 13:04:25 +0000 X-Received: from AM7EUR03FT004.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:2f3:cafe::26) by AS8PR04CA0205.outlook.office365.com (2603:10a6:20b:2f3::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.29 via Frontend Transport; Tue, 23 May 2023 13:04:25 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C X-Received: from nebula.arm.com (40.67.248.234) by AM7EUR03FT004.mail.protection.outlook.com (100.127.140.210) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6433.14 via Frontend Transport; Tue, 23 May 2023 13:04:24 +0000 X-Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 23 May 2023 13:04:23 +0000 X-Received: from E114225.Arm.com (10.1.196.36) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.23 via Frontend Transport; Tue, 23 May 2023 13:04:22 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , , , , , , Subject: [edk2-devel] [PATCH v1 01/12] ArmPkg: Fix data type used for GicDistributorBase Date: Tue, 23 May 2023 14:04:10 +0100 Message-ID: <20230523130421.10804-2-sami.mujawar@arm.com> In-Reply-To: <20230523130421.10804-1-sami.mujawar@arm.com> References: <20230523130421.10804-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: AM7EUR03FT004:EE_|DB3PR08MB8985:EE_|AM7EUR03FT059:EE_|PAVPR08MB9209:EE_ X-MS-Office365-Filtering-Correlation-Id: eefe0750-97a5-4f48-9c3b-08db5b8e4489 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: sLBhGF65ZlDvUjyFZ6m29qKHm+2+JM2KhQpgHi9b/inP0Ghk7XsYfHTnlULsySNyJbPLD+gTz/nM0psx6F+wZud3XrWMTUz8w8WKhurOsukG4k9I/xTQ5H3FaXAP3BKK6B1cmrZ2EwtOQP0neGd8G82S0P6UWC9gTA3hJNa+2dL9vewkeTgj2nzJMr6LkpVCo1FJQevZ7GrgkNDoQCQ12UCyS6AUPLqopuGCG2e9tYr+klFWFX3ZyeY2JojLuYiBwm+MZik3a9JmYGIg09h6uDlbbr7o8g3pzYuij9k6qNeBizAstNvZ/sUwK19PKLgPoYYaiCI1lcP/Tx4xs9R0KlBKKMzLVNI2bJuN1AvOPhZwns+uraxwHO3iwUrdPHRqs3flxLCASIMdb0jZEidvEWP7zJpU4dYte3dt35jk/dJzUNyMCAt4fNLycrH+SxAa7SPWTqqYffPPPxjBeJG4197UGzWpPSIIlVKRHZ8c+/C8yqvOwGS3sUsUQhPpEl0t54RxXgbtHFpuDw3JY1SpZ3r53U7XNrBprpmgzSqxnFd9uwYqhAYx64+rWQe0y6KgGZd+ebArNEA3p7KME0wsCuq3iwpYGv53pu2RHfdnmbITTbFIWoO9Cmcx2Ad7+BReM7XtN+Efg3jfSJQJJ6vqq9Sv4L1pi36TE4H6YECgsqsLUdW4svgspBBXIKz/axBIQ5BImgISxaYqAiWoW9peA+kf4DDmRnagW0MzCQZDRkilhNLM8+zDarwjvHcYqoMH X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(136003)(396003)(376002)(39860400002)(346002)(451199021)(36840700001)(46966006)(54906003)(82310400005)(41300700001)(7696005)(478600001)(19627235002)(316002)(4326008)(70586007)(6916009)(6666004)(70206006)(86362001)(5660300002)(8936002)(8676002)(44832011)(2906002)(1076003)(26005)(356005)(81166007)(82740400003)(186003)(426003)(336012)(83380400001)(40480700001)(2616005)(36756003)(36860700001)(47076005)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR08MB8985 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 2f20e5c6-952b-4015-1c80-08db5b8e3bcc X-Microsoft-Antispam-Message-Info: zNU6O/0fItmVU8aiihPfmWteTex7DuEnyjJPjfRqlb7dXdUznHWr9F+0ZB1wP0JVbZSSmc73RNbyoHCAbkBYAr/U9SA6f/YBSmqgLQ5VJXIBOAab3lvRhucFOsRnStwJBwA7Wt9xCdpzL/Oc4BNC6CelTaMryEpCZywYjKZdFP1BQXvRBRyqLsE7O3bHCB4U8Aed9QcTrUW+3MUgqR1VBS7qVteC+6+6HedD0OcLGMie4Z/+G1l8YkfGc2Mgy9ucKgF0x4a4Gcj7XmT5K+QoMA/T6GAb2lAOw/B2fRKSqcsUE3YqUE++iXW6y77BKbbUKIz5Z5xLzkGilaOH0Ij/v/WpAxrkqGIpPzOkR3xsWZxDJxOgplda4j1ge34XOeOw1K3z25oXBBrDjGzqcLjRrfhxgl/XeUEoI2j1N454wJuKDJSt9UIn8DYs9uMRyX/zGFKmDAGGGKRnE1BoRVBWbnNRUDhbLqmoeI6wGArkEEluNeDtiFOcWkQc9QtIFa1/x69kTWwMX8WP3nNWmG0DVl19GoDj/8LyPTzSWygchT4DxQDan5loipFD5S0eAR+tC4f5IlEN5FsQSxAW5vLsHk/Ags9owQzA67Q43/THF1Urj6lLDbCSXFFFKJOfKL1mpJNEwhiFSU9dlZoXmmmUTCHbo/5Tn1rlL4CR8qBXhQsxcTWbDtx430I+93QPY+clPAF2IlTPJlajaSq4BywUEo05e7bRL4mT1sVnv8OvuwFmXM4+lyWNN8TAsiJI46/E X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2023 13:04:39.4535 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: eefe0750-97a5-4f48-9c3b-08db5b8e4489 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9209 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com X-Gm-Message-State: 2WdjS8zmB2tgNkWprJxZo2olx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1684847085; bh=G71gxk6+oduuDniSnGnWnzOth+FUUOggFRji9IwkDIE=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=WDyCYngpYa5HpxKpAtSL646+jfytus6EVSNSADFMRHYQZsq3hNVOe3KJ7dCLmn4dC6w pgaGgD3Py3/17hfIzM5qsdo21cuVdTlvYxTU+BryYh9ljyCAu0xJscvioUMhEPP8xnOwV Xzgid0XtYYIc+hiZGlYKbt7wzYMYYET7QUA= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1684847087832100007 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The data type used by variables representing the GicDistributorBase has been inconsistently used in the ArmGic driver and the library. The PCD defined for the GIC Distributor base address is UINT64. However, the data types for the variables used is UINTN, INTN, and at some places UINT32. Therefore, update the data types to use UINTN and add necessary typecasts when reading values from the PCD. This should then be consistent across AArch32 and AArch64 builds. Signed-off-by: Sami Mujawar --- ArmPkg/Drivers/ArmGic/ArmGicCommonDxe.c | 4 ++-- ArmPkg/Drivers/ArmGic/ArmGicLib.c | 12 ++++++------ ArmPkg/Drivers/ArmGic/ArmGicNonSecLib.c | 4 ++-- ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c | 4 ++-- ArmPkg/Drivers/ArmGic/GicV3/ArmGicV3Dxe.c | 4 ++-- ArmPkg/Include/Library/ArmGicLib.h | 18 +++++++++--------- 6 files changed, 23 insertions(+), 23 deletions(-) diff --git a/ArmPkg/Drivers/ArmGic/ArmGicCommonDxe.c b/ArmPkg/Drivers/ArmGi= c/ArmGicCommonDxe.c index d560c42fc9f3d5e86c2aece504102f43cb841877..9ac073db36ce92fc14de71e9a26= 4059afd63d729 100644 --- a/ArmPkg/Drivers/ArmGic/ArmGicCommonDxe.c +++ b/ArmPkg/Drivers/ArmGic/ArmGicCommonDxe.c @@ -1,6 +1,6 @@ /*++ =20 -Copyright (c) 2013-2017, ARM Ltd. All rights reserved.
+Copyright (c) 2013-2021, Arm Ltd. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -61,7 +61,7 @@ GicGetDistributorIcfgBaseAndBit ( =20 RegIndex =3D Source / ARM_GIC_ICDICFR_F_STRIDE; // NOTE: truncation i= s significant Field =3D Source % ARM_GIC_ICDICFR_F_STRIDE; - *RegAddress =3D PcdGet64 (PcdGicDistributorBase) + *RegAddress =3D (UINTN)PcdGet64 (PcdGicDistributorBase) + ARM_GIC_ICDICFR + (ARM_GIC_ICDICFR_BYTES * RegIndex); *Config1Bit =3D ((Field * ARM_GIC_ICDICFR_F_WIDTH) diff --git a/ArmPkg/Drivers/ArmGic/ArmGicLib.c b/ArmPkg/Drivers/ArmGic/ArmG= icLib.c index dd3670c7ccbb18586bb28f4ac02514055471529f..6e44e89390fcdaa89302d6505f7= 5c43c84ce3535 100644 --- a/ArmPkg/Drivers/ArmGic/ArmGicLib.c +++ b/ArmPkg/Drivers/ArmGic/ArmGicLib.c @@ -117,7 +117,7 @@ ArmGicGetInterfaceIdentification ( UINTN EFIAPI ArmGicGetMaxNumInterrupts ( - IN INTN GicDistributorBase + IN UINTN GicDistributorBase ) { UINTN ItLines; @@ -133,10 +133,10 @@ ArmGicGetMaxNumInterrupts ( VOID EFIAPI ArmGicSendSgiTo ( - IN INTN GicDistributorBase, - IN INTN TargetListFilter, - IN INTN CPUTargetList, - IN INTN SgiId + IN UINTN GicDistributorBase, + IN INTN TargetListFilter, + IN INTN CPUTargetList, + IN INTN SgiId ) { MmioWrite32 ( @@ -390,7 +390,7 @@ ArmGicIsInterruptEnabled ( VOID EFIAPI ArmGicDisableDistributor ( - IN INTN GicDistributorBase + IN UINTN GicDistributorBase ) { // Disable Gic Distributor diff --git a/ArmPkg/Drivers/ArmGic/ArmGicNonSecLib.c b/ArmPkg/Drivers/ArmGi= c/ArmGicNonSecLib.c index aa4f0e2123929e0a86626b0f068d474065ca67fb..c17cbe041e8a9ceb8c8c3a6b953= ff88b75f6f206 100644 --- a/ArmPkg/Drivers/ArmGic/ArmGicNonSecLib.c +++ b/ArmPkg/Drivers/ArmGic/ArmGicNonSecLib.c @@ -1,6 +1,6 @@ /** @file * -* Copyright (c) 2011-2015, ARM Limited. All rights reserved. +* Copyright (c) 2011-2021, Arm Limited. All rights reserved. * * SPDX-License-Identifier: BSD-2-Clause-Patent * @@ -13,7 +13,7 @@ VOID EFIAPI ArmGicEnableDistributor ( - IN INTN GicDistributorBase + IN UINTN GicDistributorBase ) { ARM_GIC_ARCH_REVISION Revision; diff --git a/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c b/ArmPkg/Drivers/Arm= Gic/GicV2/ArmGicV2Dxe.c index 25290342bde4de907bef050d6f1bdd6e03f8dccc..b7d67d830e46b663e4054990e74= 56660fb22cda9 100644 --- a/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c +++ b/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c @@ -2,7 +2,7 @@ =20 Copyright (c) 2009, Hewlett-Packard Company. All rights reserved.
Portions copyright (c) 2010, Apple Inc. All rights reserved.
-Portions copyright (c) 2011-2017, ARM Ltd. All rights reserved.
+Portions copyright (c) 2011-2021, Arm Ltd. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -401,7 +401,7 @@ GicV2DxeInitialize ( ASSERT_PROTOCOL_ALREADY_INSTALLED (NULL, &gHardwareInterruptProtocolGuid= ); =20 mGicInterruptInterfaceBase =3D PcdGet64 (PcdGicInterruptInterfaceBase); - mGicDistributorBase =3D PcdGet64 (PcdGicDistributorBase); + mGicDistributorBase =3D (UINTN)PcdGet64 (PcdGicDistributorBase); mGicNumInterrupts =3D ArmGicGetMaxNumInterrupts (mGicDistributo= rBase); =20 for (Index =3D 0; Index < mGicNumInterrupts; Index++) { diff --git a/ArmPkg/Drivers/ArmGic/GicV3/ArmGicV3Dxe.c b/ArmPkg/Drivers/Arm= Gic/GicV3/ArmGicV3Dxe.c index b1f0cd48c752666e8b01eb5a25f8639e49213119..30c3fcbc3eee8e4f41f68a669cb= c59650c12ca89 100644 --- a/ArmPkg/Drivers/ArmGic/GicV3/ArmGicV3Dxe.c +++ b/ArmPkg/Drivers/ArmGic/GicV3/ArmGicV3Dxe.c @@ -1,6 +1,6 @@ /** @file * -* Copyright (c) 2011-2018, ARM Limited. All rights reserved. +* Copyright (c) 2011-2021, Arm Limited. All rights reserved. * * SPDX-License-Identifier: BSD-2-Clause-Patent * @@ -381,7 +381,7 @@ GicV3DxeInitialize ( // the system. ASSERT_PROTOCOL_ALREADY_INSTALLED (NULL, &gHardwareInterruptProtocolGuid= ); =20 - mGicDistributorBase =3D PcdGet64 (PcdGicDistributorBase); + mGicDistributorBase =3D (UINTN)PcdGet64 (PcdGicDistributorBase); mGicRedistributorsBase =3D PcdGet64 (PcdGicRedistributorsBase); mGicNumInterrupts =3D ArmGicGetMaxNumInterrupts (mGicDistributorBas= e); =20 diff --git a/ArmPkg/Include/Library/ArmGicLib.h b/ArmPkg/Include/Library/Ar= mGicLib.h index 4ab670967598f21852e46f72116bf4c78ca7dd44..72dbd1ca8d626c69d9bb8727d77= fd34b4ab3af28 100644 --- a/ArmPkg/Include/Library/ArmGicLib.h +++ b/ArmPkg/Include/Library/ArmGicLib.h @@ -121,7 +121,7 @@ VOID EFIAPI ArmGicSetupNonSecure ( IN UINTN MpId, - IN INTN GicDistributorBase, + IN UINTN GicDistributorBase, IN INTN GicInterruptInterfaceBase ); =20 @@ -148,28 +148,28 @@ ArmGicDisableInterruptInterface ( VOID EFIAPI ArmGicEnableDistributor ( - IN INTN GicDistributorBase + IN UINTN GicDistributorBase ); =20 VOID EFIAPI ArmGicDisableDistributor ( - IN INTN GicDistributorBase + IN UINTN GicDistributorBase ); =20 UINTN EFIAPI ArmGicGetMaxNumInterrupts ( - IN INTN GicDistributorBase + IN UINTN GicDistributorBase ); =20 VOID EFIAPI ArmGicSendSgiTo ( - IN INTN GicDistributorBase, - IN INTN TargetListFilter, - IN INTN CPUTargetList, - IN INTN SgiId + IN UINTN GicDistributorBase, + IN INTN TargetListFilter, + IN INTN CPUTargetList, + IN INTN SgiId ); =20 /* @@ -251,7 +251,7 @@ VOID EFIAPI ArmGicV2SetupNonSecure ( IN UINTN MpId, - IN INTN GicDistributorBase, + IN UINTN GicDistributorBase, IN INTN GicInterruptInterfaceBase ); =20 --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#105176): https://edk2.groups.io/g/devel/message/105176 Mute This Topic: https://groups.io/mt/99086452/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 18 21:00:39 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+105179+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=arm.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1684847089356286.6474778594775; Tue, 23 May 2023 06:04:49 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id DKSUYY1788612xsy59ypBsaY; Tue, 23 May 2023 06:04:49 -0700 X-Received: from EUR04-DB3-obe.outbound.protection.outlook.com (EUR04-DB3-obe.outbound.protection.outlook.com [40.107.6.61]) by mx.groups.io with SMTP id smtpd.web10.21866.1684847088044692149 for ; Tue, 23 May 2023 06:04:48 -0700 X-Received: from DUZPR01CA0281.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b9::9) by AS8PR08MB9244.eurprd08.prod.outlook.com (2603:10a6:20b:5a3::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.29; Tue, 23 May 2023 13:04:44 +0000 X-Received: from DBAEUR03FT028.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:4b9:cafe::93) by DUZPR01CA0281.outlook.office365.com (2603:10a6:10:4b9::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.29 via Frontend Transport; Tue, 23 May 2023 13:04:44 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+105179+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT028.mail.protection.outlook.com (100.127.142.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.14 via Frontend Transport; Tue, 23 May 2023 13:04:44 +0000 X-Received: ("Tessian outbound 5154e9d36775:v136"); Tue, 23 May 2023 13:04:44 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: e701691b83968c72 X-CR-MTA-TID: 64aa7808 X-Received: from d82ada020686.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F8CA9E3E-B876-48A8-ADB2-9307DD521391.1; Tue, 23 May 2023 13:04:33 +0000 X-Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d82ada020686.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 23 May 2023 13:04:33 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hnneqsJBzdNyuf2uxOlPFctCJsiPa76AxHD3qSyq6nUL3VhjHiL42RATXQk9RITS4qAFfP0lQUdeFfU17/gDRmSWYOlb2HXzWePHJIQVBOWbDr4ZFX+kNvAoJ5BEOh8XrV2fHr6ZiOVxwXQpJwkVgxTd1MYTLwYwKrxooEzU8QC9qJpV6XBsLU2HYtx04iI2jHqTqZ4sozBPPUlFhCzVAbZW9rDfDOkWLVtoH1eJNLZJvas7L0cLG8M3ErCv3I57FKA9XQBVkq1ALTBGbCmIxJ06uXJgxqYC8pjbBE3AHZlhr1UWUNPiO0ywY4ptKP4SaVSqMulOxgPeIgDgLUUAxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y8aJhuAl6ETi1Bx9hOwiSyXNzSbktUpFXHM0N6PVZlo=; b=ExkLxsZvtj2hAAvFDWQSyPPM5MoH9bO+C0bpxCQn1Dg9PqZvogk8U8FuYlMXscd47h7G1cEqDI46nuzJCprR+3OENNESYIsYSJsHglz0fpSmExThDfe/cFDnRc9dOEVostvCml3VvGaps11zD3Ep4dXfEdo7DB5vC5B2d8M0FTPY4lAKCiEqu6P0siWQwp+5z0Ix/4KbY9Yf+1/ySTQbB3a5BwN/khbVIAMq2K0DuLpAR7PibY/iy98qSgURuJW9Ed+rYWbMAYSouPXgp5ezJ9mMY5Tc9k+552aDz0EciRJ3pvv2QOVW7gYm4INMhMLvKcpG8a/lZzdiJDVsYXzBFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none X-Received: from AS8PR04CA0206.eurprd04.prod.outlook.com (2603:10a6:20b:2f3::31) by DB8PR08MB5497.eurprd08.prod.outlook.com (2603:10a6:10:11a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.28; Tue, 23 May 2023 13:04:28 +0000 X-Received: from AM7EUR03FT004.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:2f3:cafe::65) by AS8PR04CA0206.outlook.office365.com (2603:10a6:20b:2f3::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.29 via Frontend Transport; Tue, 23 May 2023 13:04:28 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C X-Received: from nebula.arm.com (40.67.248.234) by AM7EUR03FT004.mail.protection.outlook.com (100.127.140.210) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6433.14 via Frontend Transport; Tue, 23 May 2023 13:04:28 +0000 X-Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 23 May 2023 13:04:23 +0000 X-Received: from E114225.Arm.com (10.1.196.36) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.23 via Frontend Transport; Tue, 23 May 2023 13:04:23 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , , , , , , Subject: [edk2-devel] [PATCH v1 02/12] ArmPkg: Fix data type used for GicInterruptInterfaceBase Date: Tue, 23 May 2023 14:04:11 +0100 Message-ID: <20230523130421.10804-3-sami.mujawar@arm.com> In-Reply-To: <20230523130421.10804-1-sami.mujawar@arm.com> References: <20230523130421.10804-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: AM7EUR03FT004:EE_|DB8PR08MB5497:EE_|DBAEUR03FT028:EE_|AS8PR08MB9244:EE_ X-MS-Office365-Filtering-Correlation-Id: fe800745-caf2-4d06-c03c-08db5b8e4774 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: H43/tnG4bOo3BQutsJ1tUkfS0KJx9FCwM4cTPRtebraPjIaY//M7hepkNKUMsHpOQug+w71BCj0fdLmd5/coPZf87r2JcDgWYckveGjwlU6dAqWbhn93i4N6qj5UGCLjbpnlR75NnvvM2dOpWk2t7orgA7vr/xnOMnSL9ZArrDC6W6HMr9iOowViIArd3VI8W0dw16qM2NjlXvOFACpq8aUFMX15HsUB5exwHz1PhGsUuKWHRxw06L7ZPHi4Vl8XFXqOlUZm56u5x14tJVcKQ7F3d/1+6k1YN+04vKNEUCgANQp99sIaIUNKywOuW+gz2niWGhoz+rChDGmqlZTqgV05VvB2c7IZ/jKk7xCPcPdmbhGVWzCK4N40euYaLVQxHM3CJLcGUDJsLJLxa2htgJY6LzBGwcA+khzpvEmtY4Kfa6Fav+Qf6+xKRJ3HqONZS28sUyhNJ6fCnJ6GMUccTeSj0HUaA7QaO7zReU953AGr7obaJuWrBv1PKoNCaBkRxIUWRhBhUF//Jvm15pPkD+fvf4SJaniGocJ6rEnRdNorFRxGb0sWlUq7GBUQ5w5KcGIQGbGENxDiRdtcXwtCKqfAjUQ++zLzQakHUbag9b2d60LY6m/AUlp7rfpt32GlPBpRFfSoQ6ODwepKquXZ5Gu7XFKYnKu5sILlkG0BS9gikppqa61B2njdKrchsMZYyrytA2r3KfLL4eFAyzMqPWAviumGgDoe1UHbKi+/FLUVvOXaZc+sqXijLG9wWp8y7eDdFqBjtDxxDYPjYL+jsw== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(136003)(346002)(396003)(376002)(451199021)(40470700004)(36840700001)(46966006)(54906003)(41300700001)(7696005)(82310400005)(316002)(6916009)(4326008)(356005)(6666004)(70586007)(81166007)(70206006)(82740400003)(5660300002)(8676002)(8936002)(86362001)(19627235002)(478600001)(44832011)(47076005)(83380400001)(1076003)(26005)(2906002)(40460700003)(186003)(36860700001)(36756003)(2616005)(40480700001)(336012)(426003)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5497 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT028.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: e6539ff9-27c4-49e1-6eb4-08db5b8e3e0f X-Microsoft-Antispam-Message-Info: fIPrpH1G4bOIPh/mp/Ag3IdyHbjMuJ0TcUWFuptX0E0BrJGAJGZd/BkwhOa1RTfWHwBbKOLWgtKUQNMrDcgL9Mo8NIiO+dd69tZVsSMxg3sMrhhqqg0hvzJJB7K1qi5liOJnt8ugnUTYKbuKGNG05C/AaJldWLtfOColHvJNJQuE6PscAwQkkAKLeHMioSTVtCWwpoc5wDl4I0Tkd8vx165eXSWPYPz49/CeePyswGMwXZLxr0kcpl03R9ocbHjPsKIw7jGb8wUE4Qt0bCjzIgxq2M20NJFONZohk5jWA6hNRCk/eO2XeY9o1wpxQex0vLNzsIUUKb9Xj1PqbuX62c10U5p0l73n1arXtisOicbQzOZiX+RSJIjJ1lPmhYRr1Qg2DMRxmXto56CjWqgcWA/101gtDHaR0WnLy6h0cgB2XTYQkVV9eEiRdosroRXXU2odcBN2/r7kt3Z6QYl8xravMrUhnEd0KqrvZ5tlwuZOocZSJuGu7LsATK/bxXUnA+taGujaabcH0cBagdEkxxG9+T/V+tl6jF53l+CAUrD4qJRoUnPDxDIybpye809cSnSKYzS3VyEZszJfqRZav/Co5s8oYAoCxRd82eL4vgTH9rCabqrJDnHNm0+zjg6qrqapygAAV4rom685r3xy6hIdZhytl83YqQ3N7xGT5Yujc63JhTSZ55xZaT8B2Qk8aHd4z0sBV0OtT7/Nst3rKGsPhthjFvHlB+QvxLsW9QdvfsX5jTyteg0YZwPevWTy X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2023 13:04:44.5374 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fe800745-caf2-4d06-c03c-08db5b8e4774 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT028.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9244 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com X-Gm-Message-State: qSc2EEL8OIcvDStqsesTbOzPx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1684847089; bh=Kqab62FrtY3dbPRQ6LeUjMGKuBhnQqiJ/kRdPFSpYv0=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=fM/gYuWue4UNR4dIABz0SWcI/81ugNivYXjPkaR+HqEtdOfHdMBYFcvXQDg0h1mIFgO aroY4oxeeCn3taZKb9yh+oqpWyCj/sKW0GeuvvxT/Y6/rb8KsrEpwTdmDIr55x3QDxEaP 4xNrWJaZyGkrTV8ZnRCTqEc3ctyDP63oky4= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1684847090533100011 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The data type used by variables representing the GicInterruptInterfaceBase has been inconsistently used in the ArmGic driver and the library. The PCD defined for the GIC Interrupt interface base address is UINT64. However, the data types for the variables used is UINTN, INTN, and at some places UINT32. Therefore, update the data types to use UINTN and add necessary typecasts when reading values from the PCD. This should then be consistent across AArch32 and AArch64 builds. Signed-off-by: Sami Mujawar Reviewed-by: Ard Biesheuvel --- ArmPkg/Drivers/ArmGic/ArmGicLib.c | 13 ++++++++++--- ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c | 2 +- ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2NonSecLib.c | 6 +++--- ArmPkg/Include/Library/ArmGicLib.h | 18 +++++++++--------- 4 files changed, 23 insertions(+), 16 deletions(-) diff --git a/ArmPkg/Drivers/ArmGic/ArmGicLib.c b/ArmPkg/Drivers/ArmGic/ArmG= icLib.c index 6e44e89390fcdaa89302d6505f75c43c84ce3535..78edc7e76a087caa5b91d896f9b= d316d6530a668 100644 --- a/ArmPkg/Drivers/ArmGic/ArmGicLib.c +++ b/ArmPkg/Drivers/ArmGic/ArmGicLib.c @@ -104,10 +104,17 @@ GicGetCpuRedistributorBase ( return 0; } =20 +/** + Return the GIC CPU Interrupt Interface ID. + + @param GicInterruptInterfaceBase Base address of the GIC Interrupt Inte= rface. + + @retval CPU Interface Identification information. +**/ UINTN EFIAPI ArmGicGetInterfaceIdentification ( - IN INTN GicInterruptInterfaceBase + IN UINTN GicInterruptInterfaceBase ) { // Read the GIC Identification Register @@ -400,7 +407,7 @@ ArmGicDisableDistributor ( VOID EFIAPI ArmGicEnableInterruptInterface ( - IN INTN GicInterruptInterfaceBase + IN UINTN GicInterruptInterfaceBase ) { ARM_GIC_ARCH_REVISION Revision; @@ -418,7 +425,7 @@ ArmGicEnableInterruptInterface ( VOID EFIAPI ArmGicDisableInterruptInterface ( - IN INTN GicInterruptInterfaceBase + IN UINTN GicInterruptInterfaceBase ) { ARM_GIC_ARCH_REVISION Revision; diff --git a/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c b/ArmPkg/Drivers/Arm= Gic/GicV2/ArmGicV2Dxe.c index b7d67d830e46b663e4054990e7456660fb22cda9..b952c3ae31c060ecbb43c0800d3= 4e57664a8262a 100644 --- a/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c +++ b/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c @@ -400,7 +400,7 @@ GicV2DxeInitialize ( // the system. ASSERT_PROTOCOL_ALREADY_INSTALLED (NULL, &gHardwareInterruptProtocolGuid= ); =20 - mGicInterruptInterfaceBase =3D PcdGet64 (PcdGicInterruptInterfaceBase); + mGicInterruptInterfaceBase =3D (UINTN)PcdGet64 (PcdGicInterruptInterface= Base); mGicDistributorBase =3D (UINTN)PcdGet64 (PcdGicDistributorBase); mGicNumInterrupts =3D ArmGicGetMaxNumInterrupts (mGicDistributo= rBase); =20 diff --git a/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2NonSecLib.c b/ArmPkg/Drive= rs/ArmGic/GicV2/ArmGicV2NonSecLib.c index 85c2a920a54a1acaccb98a94b5591ce36d20697c..832f21644233655ef2f359f1e17= 5071d2a493b7c 100644 --- a/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2NonSecLib.c +++ b/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2NonSecLib.c @@ -1,6 +1,6 @@ /** @file * -* Copyright (c) 2011-2014, ARM Limited. All rights reserved. +* Copyright (c) 2011-2021, Arm Limited. All rights reserved. * * SPDX-License-Identifier: BSD-2-Clause-Patent * @@ -13,7 +13,7 @@ VOID EFIAPI ArmGicV2EnableInterruptInterface ( - IN INTN GicInterruptInterfaceBase + IN UINTN GicInterruptInterfaceBase ) { /* @@ -26,7 +26,7 @@ ArmGicV2EnableInterruptInterface ( VOID EFIAPI ArmGicV2DisableInterruptInterface ( - IN INTN GicInterruptInterfaceBase + IN UINTN GicInterruptInterfaceBase ) { // Disable Gic Interface diff --git a/ArmPkg/Include/Library/ArmGicLib.h b/ArmPkg/Include/Library/Ar= mGicLib.h index 72dbd1ca8d626c69d9bb8727d77fd34b4ab3af28..41bbf1da6a6cbb683df4bb30c4b= 1a1762dc7814f 100644 --- a/ArmPkg/Include/Library/ArmGicLib.h +++ b/ArmPkg/Include/Library/ArmGicLib.h @@ -113,7 +113,7 @@ UINTN EFIAPI ArmGicGetInterfaceIdentification ( - IN INTN GicInterruptInterfaceBase + IN UINTN GicInterruptInterfaceBase ); =20 // GIC Secure interfaces @@ -122,7 +122,7 @@ EFIAPI ArmGicSetupNonSecure ( IN UINTN MpId, IN UINTN GicDistributorBase, - IN INTN GicInterruptInterfaceBase + IN UINTN GicInterruptInterfaceBase ); =20 VOID @@ -136,13 +136,13 @@ ArmGicSetSecureInterrupts ( VOID EFIAPI ArmGicEnableInterruptInterface ( - IN INTN GicInterruptInterfaceBase + IN UINTN GicInterruptInterfaceBase ); =20 VOID EFIAPI ArmGicDisableInterruptInterface ( - IN INTN GicInterruptInterfaceBase + IN UINTN GicInterruptInterfaceBase ); =20 VOID @@ -203,8 +203,8 @@ ArmGicEndOfInterrupt ( UINTN EFIAPI ArmGicSetPriorityMask ( - IN INTN GicInterruptInterfaceBase, - IN INTN PriorityMask + IN UINTN GicInterruptInterfaceBase, + IN INTN PriorityMask ); =20 VOID @@ -252,19 +252,19 @@ EFIAPI ArmGicV2SetupNonSecure ( IN UINTN MpId, IN UINTN GicDistributorBase, - IN INTN GicInterruptInterfaceBase + IN UINTN GicInterruptInterfaceBase ); =20 VOID EFIAPI ArmGicV2EnableInterruptInterface ( - IN INTN GicInterruptInterfaceBase + IN UINTN GicInterruptInterfaceBase ); =20 VOID EFIAPI ArmGicV2DisableInterruptInterface ( - IN INTN GicInterruptInterfaceBase + IN UINTN GicInterruptInterfaceBase ); =20 UINTN --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#105179): https://edk2.groups.io/g/devel/message/105179 Mute This Topic: https://groups.io/mt/99086460/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 18 21:00:39 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+105180+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=arm.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1684847092735457.0265316243574; Tue, 23 May 2023 06:04:52 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id CaoFYY1788612x90eOPK3O0T; Tue, 23 May 2023 06:04:51 -0700 X-Received: from EUR05-DB8-obe.outbound.protection.outlook.com (EUR05-DB8-obe.outbound.protection.outlook.com [40.107.20.41]) by mx.groups.io with SMTP id smtpd.web11.21713.1684847090775025411 for ; Tue, 23 May 2023 06:04:51 -0700 X-Received: from AS4P189CA0042.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:5dd::20) by DU2PR08MB7341.eurprd08.prod.outlook.com (2603:10a6:10:2f0::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.28; Tue, 23 May 2023 13:04:40 +0000 X-Received: from AM7EUR03FT050.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:5dd:cafe::90) by AS4P189CA0042.outlook.office365.com (2603:10a6:20b:5dd::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.29 via Frontend Transport; Tue, 23 May 2023 13:04:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+105180+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT050.mail.protection.outlook.com (100.127.141.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.15 via Frontend Transport; Tue, 23 May 2023 13:04:40 +0000 X-Received: ("Tessian outbound e13c2446394c:v136"); Tue, 23 May 2023 13:04:40 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 2ee1dcce219255a0 X-CR-MTA-TID: 64aa7808 X-Received: from 0bc7e3f752b6.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 08EE4B31-30A5-4679-878B-1D7465392015.1; Tue, 23 May 2023 13:04:32 +0000 X-Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0bc7e3f752b6.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 23 May 2023 13:04:32 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mb8GwXdByTqxrTAC+kNo7JHF2prx97wKFJgx08Eo7IiEAe3fcuVu3fWsSLCBZlSh1d6mFDDCXcJq39rSEgtylpuQLET5CjDiiExDTux3Fth0YXe4ws5CV/PWeW+cGSpb6b4RAmBgMYOiBq+Yk6RD9uHgUFQg53BRtGhhDovzoetRLC5175NBvyzCC8kd+ppDgnvNyGtCm0djhTq5CXwq9BG7zFOrrA4VnbXWqvtgnX2nr0STutwN05R6bZztsCvVv19MsJgDe+TjxI/+DbUYPsQfaJ0T6wpLIF4WQOZdybY37MK+CZGnW3AKmqk6ofP2Z7psyzPjWxYVbv35ddXpaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CgnPc/zSDRYS9KmvwIAqT+/2hagMwgUOyghdf5oYpDA=; b=iiF51+qRv/EbvfCqMkxxKLTM+zgCRylrO+ldSMuJdnqiXC4gDi7H3aKQvi40LQczW0k9tMYUZNAvIFUX0y7I2tUSOYYIMHTnF19BWxzoPGxxpwv24dm7jYWcCxsj8TQHD5aMZZF0tLXA8ZhKx1CRHNYWorjuyDXAg0YppFLL7H4m9yqz1J102RbXoGorLUgr5iyYjxeSMKay6KmnIsfI8ZoKXk799gwckjaxwgF1P1DqGBgvMDGnkXjgtasmfVo7Qu0IKbuO1rcPUuqioOzjBw8SWU/YghKM91PfN5odm83QfPcA3Tz/tMl3QrMi6CpkS5X9L6RCwDGS2LiBMtyw5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none X-Received: from AS8P251CA0020.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:2f2::16) by VE1PR08MB5725.eurprd08.prod.outlook.com (2603:10a6:800:1b0::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.28; Tue, 23 May 2023 13:04:29 +0000 X-Received: from AM7EUR03FT033.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:2f2:cafe::b9) by AS8P251CA0020.outlook.office365.com (2603:10a6:20b:2f2::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.29 via Frontend Transport; Tue, 23 May 2023 13:04:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C X-Received: from nebula.arm.com (40.67.248.234) by AM7EUR03FT033.mail.protection.outlook.com (100.127.140.129) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6433.14 via Frontend Transport; Tue, 23 May 2023 13:04:29 +0000 X-Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 23 May 2023 13:04:24 +0000 X-Received: from E114225.Arm.com (10.1.196.36) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.23 via Frontend Transport; Tue, 23 May 2023 13:04:24 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , , , , , , Subject: [edk2-devel] [PATCH v1 03/12] ArmPkg: Fix ArmGicSendSgiTo() parameters Date: Tue, 23 May 2023 14:04:12 +0100 Message-ID: <20230523130421.10804-4-sami.mujawar@arm.com> In-Reply-To: <20230523130421.10804-1-sami.mujawar@arm.com> References: <20230523130421.10804-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: AM7EUR03FT033:EE_|VE1PR08MB5725:EE_|AM7EUR03FT050:EE_|DU2PR08MB7341:EE_ X-MS-Office365-Filtering-Correlation-Id: 4fae2f2b-6807-430a-2717-08db5b8e4505 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: L3mqpdBZgx38iehUgynWhNlPRdGSUAO19pjyXv6N1wChDZIqa+X83KhWySUJEPZbkQQy5qIiY80xjYian+wDs8dqIH18ETaJ/1NAW+klwrkJVblL9oCRkx9/Zgl56CpDXwJhd04/6wtTA+Qg/HOcophmqltBrMnH7Oaeb1BFOxrqpAfp3T/HSHuN81GjIW3MySJl9r9ZUvECLcsLAlIvwDRCHZRDK0C8VozNoDw8euhEWLGQwfkPQop/3a2pl/vKYm9EgGBvviDs8U5h0TLgbTyLVQyeAUCa4XJL2p/rR8DFdwiulS53XF4PK5f6VbxpEkGa8+g3U44aL9UenALboDhwcmEUX7oLuWhOfm8cbRgyx/T/z3dww3Xi9jWFW3b163XYjA+2A4drdLmJSmGQfCDUsfMdfLm/xsGvstH+l/ny/gDRVR/niUOsZg3nLpnRWr9+BvIxStLtyLZcivw/BO4TPHCFJ/2pZbtWKKblBQmaBK1cuCaDdVGDCHC7NTA+M5bV/hHbpQYVX6s8ahp/1tA/s8ywxqeuzInYtK/21t4j31r+q4HeS0AsZhkdtoXGl6Rx7/gKNAUkOBB1wy21NcW4iIlcrg8PNnMaels4NIGzz+16F5I4aI2CYjeonA2dj/vGgZqgUpboDoqrr4q6luwObpdJ8FQirCzmRdWSFUG8MkGCLeir1kwkAEnuGjHcM4Lu3FDku7tL3Ot3cAcqDeStTIv5P9LJo/IZ0vZzj6/4+mJ91o/i6s0PUQHESX0f X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(136003)(346002)(396003)(376002)(451199021)(36840700001)(46966006)(54906003)(41300700001)(7696005)(82310400005)(316002)(6916009)(4326008)(356005)(6666004)(70586007)(81166007)(70206006)(82740400003)(5660300002)(8676002)(8936002)(86362001)(478600001)(44832011)(47076005)(83380400001)(1076003)(26005)(2906002)(186003)(36860700001)(36756003)(2616005)(40480700001)(336012)(426003)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5725 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT050.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 7e796299-c885-43e6-00ec-08db5b8e3e58 X-Microsoft-Antispam-Message-Info: bXRCI0V0C89vDI1vu+LaUkhk6sJGrTXXVuAKflqLT8smF5DegbbtOHtAEtGGbQoMHrv8W3rmxIhG5Ay+JQqoC3GsZKkGVNMrIJJMfccJCIFzyFp4zU0GK2qwL3x5cvsMyWFC4rgQjYTNvQX9yywwDSpdPIxomYPxMIm7s1BvIh0lWSc0sAd0XzQMuHnAHpKwNmSBkZiPRHe6eEerUimzuLXFoI+IPHpxgZFFnKJ1JT9shm5ds+pHkoCSdvxVDgnLSEyZUxHtWXjZ/aVlKAQhJqvF6Sz7Cowli3mn5Gvadn7LFol5ylEKaq51NEpU6y/CiLJUaFugfjorasUFUNBnBS1FwEQbRXgsTor7zctAWHn9dU4Udx3/ldJkmAfb3dS6dK81MKcwjJBzggoLi5NxsipQP7rPavO/FmHafzMor+qnjuW59ybjMcjRSI6aQuEMZ6d4Gi4tfGAiVxizxdD6MRuJbrDHU2jCAj+ZoHYVJY0xI5Hd5zz4AmAddm352RGJd0ck+O43YeKDr+VTz3byTaFBwH4/2TF9ehBBY+Rzw/J+3few+jvYExrxYEgNhwl5jOtBvH1E7+tmpkrdJhirXlRle6QIxaL3HwO/yii6QOxEbhFREXpqBkwPubkZxXwKLjeyteuoi4H4MN11Vy7osvHCt2vX5q6h2/+HisNidPF5hFuZvlIr78Gm3nri9eRG6GRP0CqfGDs8N6wie5N5Qs9CjP6QQlFIhQ6Gy6pV5MrGazlPx/TCQnuUiCxJD3IB X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2023 13:04:40.3881 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4fae2f2b-6807-430a-2717-08db5b8e4505 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT050.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR08MB7341 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com X-Gm-Message-State: FvFIilwlrzJU9T2qiHI9tcGxx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1684847091; bh=FPsn7l8FLEroHnSIQ2WDiihy6U0QApmVhG8/TVQJnok=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=ZnYrulGwe85x2rJc7WRujjc+RR6sjP5dVX0SqHS1S0r2yxihQsqM4osUbIayyAr7c4V MfplyKMArhmfcT6VyyHqfW8tbUaP3O+ufH6QHfedxvVufI17aEgD3fIOi/0QQTbRSmayC 9q3uzgnjiCbBA5TPyqIdN//LugsETn2uCBA= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1684847094495100004 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The Software Generated Interrupt Register (GICD_SGIR) is a 32 bit register with the following bit assignment: TargetListFilter, bits [25:24] CPUTargetList, bits [23:16] NSATT, bit [15] SGIINTID, bits [3:0] Therefore, modify the TargetListFilter, CPUTargetList, SGI Interrupt ID parameters of the ArmGicSendSgiTo () to use UINT8 instead of INTN. Signed-off-by: Sami Mujawar --- ArmPkg/Drivers/ArmGic/ArmGicLib.c | 6 +++--- ArmPkg/Include/Library/ArmGicLib.h | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/ArmPkg/Drivers/ArmGic/ArmGicLib.c b/ArmPkg/Drivers/ArmGic/ArmG= icLib.c index 78edc7e76a087caa5b91d896f9bd316d6530a668..2a5e22e7b68f7c44adbf8a3f26b= 2b7ec04849b96 100644 --- a/ArmPkg/Drivers/ArmGic/ArmGicLib.c +++ b/ArmPkg/Drivers/ArmGic/ArmGicLib.c @@ -141,9 +141,9 @@ VOID EFIAPI ArmGicSendSgiTo ( IN UINTN GicDistributorBase, - IN INTN TargetListFilter, - IN INTN CPUTargetList, - IN INTN SgiId + IN UINT8 TargetListFilter, + IN UINT8 CPUTargetList, + IN UINT8 SgiId ) { MmioWrite32 ( diff --git a/ArmPkg/Include/Library/ArmGicLib.h b/ArmPkg/Include/Library/Ar= mGicLib.h index 41bbf1da6a6cbb683df4bb30c4b1a1762dc7814f..1b879708f84315035723d77c530= 1279c8130bd51 100644 --- a/ArmPkg/Include/Library/ArmGicLib.h +++ b/ArmPkg/Include/Library/ArmGicLib.h @@ -167,9 +167,9 @@ VOID EFIAPI ArmGicSendSgiTo ( IN UINTN GicDistributorBase, - IN INTN TargetListFilter, - IN INTN CPUTargetList, - IN INTN SgiId + IN UINT8 TargetListFilter, + IN UINT8 CPUTargetList, + IN UINT8 SgiId ); =20 /* --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#105180): https://edk2.groups.io/g/devel/message/105180 Mute This Topic: https://groups.io/mt/99086461/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 18 21:00:39 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+105184+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=arm.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 16848470957311009.504639733444; Tue, 23 May 2023 06:04:55 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id fl9BYY1788612x64fcFnbq6W; Tue, 23 May 2023 06:04:55 -0700 X-Received: from EUR05-AM6-obe.outbound.protection.outlook.com (EUR05-AM6-obe.outbound.protection.outlook.com [40.107.22.57]) by mx.groups.io with SMTP id smtpd.web10.21871.1684847093410720117 for ; Tue, 23 May 2023 06:04:53 -0700 X-Received: from DU2PR04CA0073.eurprd04.prod.outlook.com (2603:10a6:10:232::18) by DB3PR08MB8820.eurprd08.prod.outlook.com (2603:10a6:10:438::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.28; Tue, 23 May 2023 13:04:45 +0000 X-Received: from DBAEUR03FT035.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:232:cafe::3b) by DU2PR04CA0073.outlook.office365.com (2603:10a6:10:232::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.29 via Frontend Transport; Tue, 23 May 2023 13:04:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+105184+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT035.mail.protection.outlook.com (100.127.142.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.14 via Frontend Transport; Tue, 23 May 2023 13:04:44 +0000 X-Received: ("Tessian outbound 3a01b65b5aad:v136"); Tue, 23 May 2023 13:04:44 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 11422318ec9da45a X-CR-MTA-TID: 64aa7808 X-Received: from f35e45dbfabe.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 468A759B-22DD-4B7D-AC47-886E5A1E1C21.1; Tue, 23 May 2023 13:04:33 +0000 X-Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f35e45dbfabe.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 23 May 2023 13:04:33 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OfB4TRYKeM3SBMCHOfJ3fviL8xOuV1vLqdZpnGLVdcjIzFY7BVsRntuaMRkJaj7+GUvHIWiSXw/e428GRcNpimWieaZEnJzCy5kOiBCZqqUKr7AOfTt4RYJg68j5Ikb6+R/0rMxwx8uumibMshgmC0ViIzKP4SGXzEiqjngdxS7/fw7L7B7gIuDpmyB4wnTBAwfCLjUSNAeJpXXzvotJwITIDTg3hv8/MyAQqE83JbT5iVsP1WFSbwmjv+fv+WAscjlpwsAzguB+DrHrh1Zv3AU1ZYSeDiihIb6TCcC0wgVMKKdO25qoYrbe/mvC1Bg80XwIqDIHPKzgUa8emCDoUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CDsdIUErr5xs1zf3WLqrTh9p7VYyGHvcDdTjR/tZT1o=; b=Sw1enXVHaP9O4aSTB12uTy17RjQG6Q5X41KDsGXGlUAdhqgZ2YRdjj6PlJ4UYo9vXXlnMMjGwwptON8HL0m6z22w9QQBjxAVE7fUI5wqqwQDMHLXDwybZ51GeMOQr0cPfvkZNM0C3lXPFEOXXVmVPjizqtUQW8Tq1wFVqIGP0r6jwy1y74jBzXa3lJItikIfnepcjYAklxFnpYCTf0ri95oD6Tp879uiNPl9iV7P6riE0Nt2OuhDbI9QlLJHNvQh06RRLWAtQGLXnakR4GARWDk1W1KcYdRYnJ4FN9Lk9rvrSY97zmly8Zd9mp2OVWe5nkpwFEGNlOTUeKni/j2bIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none X-Received: from AS8P251CA0026.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:2f2::17) by GV2PR08MB9349.eurprd08.prod.outlook.com (2603:10a6:150:da::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.28; Tue, 23 May 2023 13:04:29 +0000 X-Received: from AM7EUR03FT033.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:2f2:cafe::37) by AS8P251CA0026.outlook.office365.com (2603:10a6:20b:2f2::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.29 via Frontend Transport; Tue, 23 May 2023 13:04:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C X-Received: from nebula.arm.com (40.67.248.234) by AM7EUR03FT033.mail.protection.outlook.com (100.127.140.129) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6433.14 via Frontend Transport; Tue, 23 May 2023 13:04:29 +0000 X-Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 23 May 2023 13:04:25 +0000 X-Received: from E114225.Arm.com (10.1.196.36) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.23 via Frontend Transport; Tue, 23 May 2023 13:04:24 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , , , , , , Subject: [edk2-devel] [PATCH v1 04/12] ArmPkg: Fix Non-Boolean comparison in ArmGicEnableDistributor Date: Tue, 23 May 2023 14:04:13 +0100 Message-ID: <20230523130421.10804-5-sami.mujawar@arm.com> In-Reply-To: <20230523130421.10804-1-sami.mujawar@arm.com> References: <20230523130421.10804-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: AM7EUR03FT033:EE_|GV2PR08MB9349:EE_|DBAEUR03FT035:EE_|DB3PR08MB8820:EE_ X-MS-Office365-Filtering-Correlation-Id: 1895ee7d-1440-4d34-ef22-08db5b8e47ae x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Uo1wDQTqXKyn215esUduxeT5pMPouCoDyFtqiBLb8DAo3p+rmVp5iuKvKhcstNk8l6Sd0amKkG3D/lyy+yXGwgW3wFFMauiKMgsaJDiJl9btn3MMKuHB3ageRl6qU4KJ4k0SdSjjLRUuH70Os3xXPAxNrUDqU3PFIeoORg8Wg10xxPEqXAAVmKgSmJo5Klu2Vi0U0uZmg/ZKBAwnu/lwslEFAQrITx464oI2Mhtp/b+pc/zDPVXCU9buOgS8SxH7aZr7qP1p8ryPMoJh5AI15TSJxD1J6mWflerM9UqlDEQCaOzMniIqKQjxl4bpR/tKML7jv5ZYRYLc3rC2hIkRpFRrs3wlDV6nRUOhgt4pV2uAljDkbynHJbZtahnho7SbAplWxxbHslPi9WCOBmb9Li+9jjEUrh0NL/ZV0S2yN+bssKBtKdk66SPn8aArsR+7xAvCvlaFWWuS8O0wPAeqhLxCVnQQL3FWnfR7gXYR/rBCOBvpiRLFWzLVHBA2JgjrsGtC+8MoG6nqCNp1vEW+nkOlgn086UcwJedpE7K55lB5KzVP0BqhdJhObfyD1mQwK8Yb3vO5jRdotzZXP0BV08ynvJL00JZ230uFkfcq+B71X7Z0FrCL1uVHvdUA4kHyylLfhe6YT1rJIvZIvfuWs6ySCOy9I1qcAMObVBl+Fj25sqtSfRe+co4f5PErhEmLKHgL1vfb3ch5pZLS/NWmVzw+jlNPFMkUvyo5PezhNSn5Cmhk1XEUgY3Ue4MIE1xc X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(376002)(396003)(346002)(136003)(39860400002)(451199021)(46966006)(40470700004)(36840700001)(966005)(478600001)(7696005)(6666004)(54906003)(36860700001)(426003)(47076005)(336012)(40480700001)(83380400001)(2616005)(36756003)(40460700003)(86362001)(6916009)(4326008)(82310400005)(186003)(1076003)(316002)(2906002)(26005)(82740400003)(356005)(81166007)(70206006)(70586007)(8936002)(8676002)(5660300002)(44832011)(41300700001)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB9349 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT035.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 71b8014d-5447-4a55-9a93-08db5b8e3e93 X-Microsoft-Antispam-Message-Info: E5qDnYQvmRqWtxhwOmcfMvelNfRMJ5Qbb/zkyBSsesVvvzyGTrs3OHvdcZ0sEc3uBPXOfI8DGnHyfwWXi1fvhrjF+K53dDWzawWzAhge8m0GAO6Wi3mdUE/lbxqhgvyJlzVMf2QMmTV7cIOwIoV6f0PYEnEMuYViuCK3UUcGA58DDD148hgRrfjNNt+QtNtMy2es04KXfjdiw/D4VLt8J87pft4sY8KZKOTjFIDrZzNhp0GFe7bTbM/p2KzP71w+dvIR0wrvIUcOSwETGbAot4fmZT9A1bKYCEszl0h2k855VCgDxV2gZlCcpHmtihwwJ9vK1cQzLh7Tidg57vTUC0nQ59F44dHKZrJDAX42r38fZpqMwSjvOG4NbrEFyiLBvPqBbJbEjQiLT07D5NifKl5HUorQq6+uXjDjRSRTn9KT71E0h/z6O8MxPhMNrHlPFEX6rm9LAuGLrLqg3SIWxRjhKm+j7laQzHfUBnYQyqbipBS8L/7XavScsJ37fRq8W61RhGfg/4EJT38ptJvvMzyatb5GgFdiEU8Gs+2nfhFzb9OrM7nDUROW7E30N4C1a9TUxZ6T2peVjRw0sBKniR/raA0JAFPDyISeV0zao1aNrV8NBaoNa28+mVFYucOWCdlEGkZXIgRexeaHGx8bUBcyvPYUztqPF1g9mherH3QDH2v/CBOoMiTt0ZMrVo3ZtTiC+QniKo72ass1fh+mMCWi6PG8+CptU3hpPXF1nFg= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2023 13:04:44.9187 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1895ee7d-1440-4d34-ef22-08db5b8e47ae X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT035.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR08MB8820 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com X-Gm-Message-State: 4RfNxPgYuUDSYwQsVKPw2Vvyx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1684847095; bh=klCTBtmIIEfSygY+ye20KGymuC/WBIFNl1VK11WYOOs=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=smAwI6LuNFy13Ve3crhnz2ir/yt2cKKsA0XOKt6lcRIkQErrEcC4pKyyk6eCNFuEBBX +0wtOc+BT/P9PnoKPOGNZaS/RbemlE6vt4rQGa4TA+cG/N/D32vaLOsOPMQk1pjjGVYPH 0+ahcFeNihCWng1AznGHy/Do6UoR87XhaJg= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1684847096433100007 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" According to edk2 coding standard specification, Non-Boolean comparisons must use a compare operator (=3D=3D, !=3D, >, < >=3D, <=3D). See Section 5.7.2.1 at https://edk2-docs.gitbook.io/ edk-ii-c-coding-standards-specification/5_source_files/ 57_c_programming Therefore, fix the comparison in ArmGicEnableDistributor() Signed-off-by: Sami Mujawar --- ArmPkg/Drivers/ArmGic/ArmGicNonSecLib.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ArmPkg/Drivers/ArmGic/ArmGicNonSecLib.c b/ArmPkg/Drivers/ArmGi= c/ArmGicNonSecLib.c index c17cbe041e8a9ceb8c8c3a6b953ff88b75f6f206..1ca66a40940434d6d89e243650f= 3e81aa3f588b5 100644 --- a/ArmPkg/Drivers/ArmGic/ArmGicNonSecLib.c +++ b/ArmPkg/Drivers/ArmGic/ArmGicNonSecLib.c @@ -26,7 +26,10 @@ ArmGicEnableDistributor ( if (Revision =3D=3D ARM_GIC_ARCH_REVISION_2) { MmioWrite32 (GicDistributorBase + ARM_GIC_ICDDCR, 0x1); } else { - if (MmioRead32 (GicDistributorBase + ARM_GIC_ICDDCR) & ARM_GIC_ICDDCR_= ARE) { + if ((MmioRead32 ( + GicDistributorBase + ARM_GIC_ICDDCR + ) & ARM_GIC_ICDDCR_ARE) !=3D 0) + { MmioOr32 (GicDistributorBase + ARM_GIC_ICDDCR, 0x2); } else { MmioOr32 (GicDistributorBase + ARM_GIC_ICDDCR, 0x1); --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#105184): https://edk2.groups.io/g/devel/message/105184 Mute This Topic: https://groups.io/mt/99086468/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 18 21:00:39 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+105185+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=arm.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1684847096128413.0776728719445; Tue, 23 May 2023 06:04:56 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id kEFHYY1788612xnEo6zXG9GP; Tue, 23 May 2023 06:04:55 -0700 X-Received: from EUR01-DB5-obe.outbound.protection.outlook.com (EUR01-DB5-obe.outbound.protection.outlook.com [40.107.15.82]) by mx.groups.io with SMTP id smtpd.web11.21718.1684847094242730204 for ; Tue, 23 May 2023 06:04:54 -0700 X-Received: from AM6PR10CA0009.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:89::22) by DU0PR08MB8068.eurprd08.prod.outlook.com (2603:10a6:10:3eb::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.28; Tue, 23 May 2023 13:04:46 +0000 X-Received: from AM7EUR03FT059.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:89:cafe::1f) by AM6PR10CA0009.outlook.office365.com (2603:10a6:209:89::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.29 via Frontend Transport; Tue, 23 May 2023 13:04:46 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+105185+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT059.mail.protection.outlook.com (100.127.140.215) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.14 via Frontend Transport; Tue, 23 May 2023 13:04:46 +0000 X-Received: ("Tessian outbound 3a01b65b5aad:v136"); Tue, 23 May 2023 13:04:45 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: babecd2de0491bd4 X-CR-MTA-TID: 64aa7808 X-Received: from 28f34d365321.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 8117DAF3-DE75-4A39-8481-3C343138911D.1; Tue, 23 May 2023 13:04:33 +0000 X-Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 28f34d365321.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 23 May 2023 13:04:33 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iNaB/26oESXSt8P+Xaoe4rBvxc7QFWYvOEprccUU5rLR/IM6/dsRFZemCOlhsh7bvlj9cm4lK9I9fDx5LH+UPx6p6pXsa3YXgPj2cnb4ggN+VscM4kDCjhVu/YX6xDYzd/OFAe5jBDanX1b0six5s8LEntBOFO9S3yTHS87jNAby0P9ArpZnT9I0hyQsg0xZxphsmWReM94oYDrX507X7auz+EScreF20qpkofrc/a4MWlzXTbacW4Zuy8QBhsL7/lVx2T+UXbCiTM1mj9VAGRthqdUHnmsIfaVgfoh4q4fxYCt2l4RMRwYEnys0a7PGJRY5kX3X6YkuoiUxZV113g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xdDo6pE9ycQJXBwRADwxZ5TnWDEkH/ZAaS8yX5QmdhU=; b=eUCf+qd+yHs2D3X4a/4OHlwuOBfSV0zmhTDxkYVuH1/lAS6Gi4v2jO6IDO9bGpYD1ZALeUtOC2RO5/z1qfdkHvaq9b4viyxPlAlEx46+1a2qJ7UCQgeOGKgjDNB+M5LIYKjApOFzTVAVLVbtwxveUtXD8zdJrcY6ZXqxCTh/I/zWsI0RWHDgvB808g4cAaeEIBu0to4XglBW++x+z5T3IcLeK7J1WYxauEk8lRDb7+wtQ31v9nnVf9BPVFDjkyvqbCfBI86A3wRbJ1AemjOGq8G9POcWY7J3lqQmoOK824bdZ82CSNVE5k5jtd5bK7Av3K5W4p/Rp/1/O6rDemv1QQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none X-Received: from AS8P251CA0030.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:2f2::19) by PAWPR08MB9030.eurprd08.prod.outlook.com (2603:10a6:102:342::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.28; Tue, 23 May 2023 13:04:30 +0000 X-Received: from AM7EUR03FT033.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:2f2:cafe::2c) by AS8P251CA0030.outlook.office365.com (2603:10a6:20b:2f2::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.29 via Frontend Transport; Tue, 23 May 2023 13:04:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C X-Received: from nebula.arm.com (40.67.248.234) by AM7EUR03FT033.mail.protection.outlook.com (100.127.140.129) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6433.14 via Frontend Transport; Tue, 23 May 2023 13:04:29 +0000 X-Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 23 May 2023 13:04:25 +0000 X-Received: from E114225.Arm.com (10.1.196.36) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.23 via Frontend Transport; Tue, 23 May 2023 13:04:25 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , , , , , , Subject: [edk2-devel] [PATCH v1 05/12] ArmPkg: Fix return type for ArmGicGetInterfaceIdentification Date: Tue, 23 May 2023 14:04:14 +0100 Message-ID: <20230523130421.10804-6-sami.mujawar@arm.com> In-Reply-To: <20230523130421.10804-1-sami.mujawar@arm.com> References: <20230523130421.10804-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: AM7EUR03FT033:EE_|PAWPR08MB9030:EE_|AM7EUR03FT059:EE_|DU0PR08MB8068:EE_ X-MS-Office365-Filtering-Correlation-Id: dc77f297-8dd2-4cc6-34e0-08db5b8e4862 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 9wP9j2KBIS6zgE00g9moY1w8kwbUuLwqtH3/OK7DQCIllm/qPnfVumSrtIUf6urquTPqZKYIFhRxUvcE6asr/aCfRJNMjJGLbaF/HulVPBCrx7by0/M2N0fkVDsKhe9dnPkXbTjFWoX3BV7NAx3jKV9bfrboDCwoL3xMx1CwomgvLuaoEYtY9kXlzr8a41XaogAHjk+LqbbxIPcTZH/nQTSPqJ8L88AIl6x0HBIQleYeVbIpJf8FechBs9/GYmlBxqhUTGXEGTskmQOGGH7JJ4nKcbPcE1X0vwCvJHDvQx9lewSXy3RkBmFI3l8A94182Ywj9meDbmgjZS/G97ljkIaACTgyalwhdSdR4KrPKNh/7plyj04zBm4wQpkoculT4FaHc072sPqhhxBg34EwYL4OPJ4jOGGuMX8xW6wk6s32pjYZl5p2LPrqson1vS4VFNRr4QIRJmO4Wi5oxrS/WzCl/oCaRCEa2h07jPMD92rxDo1sLPwAj9ffnh7MmNh5EOe0FOsaY03gMDfC2bsfDbQuQlDGz1/EWoa/6P4mJ/RmrALZZ8B148p1QIG4czOiVoOHdLVmP4M/H2v8NhccDK5qF0l5sMOCujtsz8FIp59EpnZXv6iGDMRkvkc7GoutO07Xv1jgj3LQquaursFJAI5r99EZh/cSn57HxUMbTqh7R39YTNRlgKhz71u/+nLdmlMNRCRBZBn8mvIFglfTploQz1vh4wcLIm4d8zAYNxpIPcB4dTMfrC9K2iEk2LHH34EI2PdXHsx0b586z9tAwzYlP3otWJXxyHi7/D05aUo= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(136003)(39860400002)(376002)(346002)(396003)(451199021)(40470700004)(46966006)(36840700001)(186003)(40460700003)(356005)(81166007)(26005)(1076003)(82740400003)(2906002)(44832011)(2616005)(36756003)(36860700001)(47076005)(83380400001)(336012)(426003)(40480700001)(316002)(6666004)(86362001)(70586007)(70206006)(4326008)(6916009)(41300700001)(7696005)(54906003)(82310400005)(478600001)(8676002)(8936002)(5660300002)(213903007)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9030 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 9bf3f07d-5364-4804-aafa-08db5b8e3ec5 X-Microsoft-Antispam-Message-Info: W/RXPB/PaaE/8Ew/+XkINdN+qgA+bsGnxB4CCIi6NBUKg7M4Jwj46W9qAdX909nsUun1SUewTxVtUsv3gq0B1kJlrOG8U78qt5+Gb/DqMqLx6BLYhwzaIV2obzZq8mZQGyEM5BnrBlNaDb5Z0QNZhScN2/kTeTjjkFue4RswSSOTdalmnSklh55HT1to9BXeMYtrNaiR6vA4fcNaUzu4lPF30YPuQGTXVxJas8opsHVmUk1VfSrTnjfonaxkvejF+pV2nco1QJgAIrkUOXpV/V5Lr8b1CC7mo2rqbFYDoKKfR1qj11oKlGR4QIhciajEn4J4mksOB+Mah74yXRZxMfqf2Hfi1PABm5nsa5ML8g3AOU+PoQdK8Uqhm9IAWMRZ9+L1Vdx9g81T8ScXx3kiTj4CcQQ2XZqZ7XqP/3icEzUjCt3bO6gFiVQ3g8MVrLmt6W13WpgBj43O+6Mo8Ynnuyi7no/ul+/yr9dpRrA4Iep+UBjKMWATVh37pN+v9GaOmUn5Mhf4PVwKFsjGFX5wbTRD5Z9YJONbyjh0ArRZErP8Zj7kJOdFFBm1GYgpIj8c1aO+LlmVJ1ar9fEQzc/YYcJz1oCFFNZU+H0UB8KuId3lsTTLFLU9ObkDEq38cjc+Es0sWw/7BQMRruIQmrd/Du4bo2nqc0haGdWVrKhis3WAszcStgNyP/coeF31qZztEBGIC2wLp/hFZfjZW8TEGyIta8urHiS1prj5tFjuVPx5jMrF7gE58bb9cG45d0rEQzi0YK21tq3QueTRAdRtSA== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2023 13:04:46.0311 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dc77f297-8dd2-4cc6-34e0-08db5b8e4862 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8068 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com X-Gm-Message-State: u3qBdoxlyeeFOMSCcJgEyi9fx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1684847095; bh=qkYb4FqPvK4CjdxlXiQvdEzFXWA0pRHkK9cuq5V7DwY=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=djZqiPIlxC0XyIS6fOOjb7RyzurUOvANWvxU5k+AXuMP5CpPaOTaStb08Rkxbp07wxm j5g21oHWVBK4UX89C8H2rhz0DM5dqoRflWutnrHqTtEsMry8wgX3GiyVEdxR7HMgDMx0p C+RMwDhBjY7OM7krFm9nq62AM57LlYgvOGg= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1684847096472100009 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The CPU Interface Identification Register (GICC_IIDR) is a 32-bit register. Since ArmGicGetInterfaceIdentification () returns the value read from the GICC_IIDR register, update the return type for this function to UINT32. Signed-off-by: Sami Mujawar --- ArmPkg/Drivers/ArmGic/ArmGicLib.c | 2 +- ArmPkg/Include/Library/ArmGicLib.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ArmPkg/Drivers/ArmGic/ArmGicLib.c b/ArmPkg/Drivers/ArmGic/ArmG= icLib.c index 2a5e22e7b68f7c44adbf8a3f26b2b7ec04849b96..df61e3aad4a7899eaa888cb248a= d2a285c7f317d 100644 --- a/ArmPkg/Drivers/ArmGic/ArmGicLib.c +++ b/ArmPkg/Drivers/ArmGic/ArmGicLib.c @@ -111,7 +111,7 @@ GicGetCpuRedistributorBase ( =20 @retval CPU Interface Identification information. **/ -UINTN +UINT32 EFIAPI ArmGicGetInterfaceIdentification ( IN UINTN GicInterruptInterfaceBase diff --git a/ArmPkg/Include/Library/ArmGicLib.h b/ArmPkg/Include/Library/Ar= mGicLib.h index 1b879708f84315035723d77c5301279c8130bd51..49ea3422270bec90fa161593c14= c7095b7598c53 100644 --- a/ArmPkg/Include/Library/ArmGicLib.h +++ b/ArmPkg/Include/Library/ArmGicLib.h @@ -110,7 +110,7 @@ // Bit Mask for #define ARM_GIC_ICCIAR_ACKINTID 0x3FF =20 -UINTN +UINT32 EFIAPI ArmGicGetInterfaceIdentification ( IN UINTN GicInterruptInterfaceBase --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#105185): https://edk2.groups.io/g/devel/message/105185 Mute This Topic: https://groups.io/mt/99086469/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 18 21:00:39 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+105174+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=arm.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1684847084656628.3293929233897; Tue, 23 May 2023 06:04:44 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id qkx8YY1788612x2Vliy7gJFi; Tue, 23 May 2023 06:04:44 -0700 X-Received: from EUR04-VI1-obe.outbound.protection.outlook.com (EUR04-VI1-obe.outbound.protection.outlook.com [40.107.8.75]) by mx.groups.io with SMTP id smtpd.web10.21862.1684847083209655536 for ; Tue, 23 May 2023 06:04:43 -0700 X-Received: from DB6P193CA0012.EURP193.PROD.OUTLOOK.COM (2603:10a6:6:29::22) by PAXPR08MB7527.eurprd08.prod.outlook.com (2603:10a6:102:24d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.28; Tue, 23 May 2023 13:04:38 +0000 X-Received: from DBAEUR03FT052.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:29:cafe::4d) by DB6P193CA0012.outlook.office365.com (2603:10a6:6:29::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.29 via Frontend Transport; Tue, 23 May 2023 13:04:38 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+105174+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT052.mail.protection.outlook.com (100.127.142.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.15 via Frontend Transport; Tue, 23 May 2023 13:04:38 +0000 X-Received: ("Tessian outbound 945aec65ec65:v136"); Tue, 23 May 2023 13:04:38 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 1c736b56059f48f7 X-CR-MTA-TID: 64aa7808 X-Received: from d2fd7313fdbf.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 1324198C-5F49-4D53-B88E-D7C87E004EAD.1; Tue, 23 May 2023 13:04:32 +0000 X-Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d2fd7313fdbf.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 23 May 2023 13:04:32 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TpjJGOk42UgUeUg73EVrd1Ugo/XlBzW0SY1SqqQVoiV9/UvLBUBGX9WGtqyTJ5+A+FNDSVnI7EA5YI7Ac29YWN453w3lz8IJIU/6sq2nL5BX4UMYTbBJ4GVxgb/ghLMwEf/ECVs3ik0XCzBzMio1VDIFPngUNd1Jbyi1iaOjz/xljPkEh6kfD/uPDYHwriHbbdBRO+X8mWcKWcYuHgSKvd/dzpTf7sJ1AmoDvtPC8xOlHlUEvQVHsSMQYGAlJsnvr7McVtwJTJlEfbJjn2K00T55VlTxbRRBHQ14tKXLKuKdnvbSFNzFXN7d87RPYlFcLpIZPBk7eviF+6ULmB+xnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r6XkahbVh8oH2vZ3XfR4memkfJgyjWBktXupB5davIk=; b=VKeQHPwBxppZU37pKB0Zh8SfbAq7ETDaWlVp7mj8i4VLW7fpcMaRqxh0wYe76FmX47V/tmI/m8NkgpSYRGQH7nJIrhWkeG9aZP39wKX4PwwoAwJPjsAfPc3YejBhv85U8+Y7y97zLX6O5CuYz8rtqwyd/y9c/U0miY4NVt9nHAqJDZkfiQFPC/NcXIrDy9PGWYEXtBs196vcvD0gm4UWCiriih9fDG6dEYj1l3/S/tCmTC1pnjsiAL8Ll5GdrjL5fyVbQBk284yf0BIeajxL1cmR+HJvTVBBzcyf3jkdUu1it56VnS2D5+kGtyi1rANCERc6VCd8+GY08TgspN2YVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none X-Received: from AS8P251CA0025.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:2f2::20) by AM0PR08MB5378.eurprd08.prod.outlook.com (2603:10a6:208:18a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.29; Tue, 23 May 2023 13:04:30 +0000 X-Received: from AM7EUR03FT033.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:2f2:cafe::c1) by AS8P251CA0025.outlook.office365.com (2603:10a6:20b:2f2::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.29 via Frontend Transport; Tue, 23 May 2023 13:04:30 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C X-Received: from nebula.arm.com (40.67.248.234) by AM7EUR03FT033.mail.protection.outlook.com (100.127.140.129) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6433.14 via Frontend Transport; Tue, 23 May 2023 13:04:30 +0000 X-Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 23 May 2023 13:04:26 +0000 X-Received: from E114225.Arm.com (10.1.196.36) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.23 via Frontend Transport; Tue, 23 May 2023 13:04:25 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , , , , , , Subject: [edk2-devel] [PATCH v1 06/12] ArmPkg: Make variables used for GicInterrupt UINTN Date: Tue, 23 May 2023 14:04:15 +0100 Message-ID: <20230523130421.10804-7-sami.mujawar@arm.com> In-Reply-To: <20230523130421.10804-1-sami.mujawar@arm.com> References: <20230523130421.10804-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: AM7EUR03FT033:EE_|AM0PR08MB5378:EE_|DBAEUR03FT052:EE_|PAXPR08MB7527:EE_ X-MS-Office365-Filtering-Correlation-Id: cc653cfd-72a9-4188-b090-08db5b8e43d8 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 5+WLpNY7R+FzfRzldvoEK7x4oQhslCIs+hZ7c8VxiW+xLnyIckVpVSCQa/uUQx0jqBe/tSwDySGSdz6b9m7p60tzCjTiO1pmIspl0m8wb4ouonX9KNCT1wgOzpip1off6bpwhP6rtlrOdFx+H68l79d1PEG0SRly9VJPpiX+XTMwczPyDNwYohhL1Qahbx/ZeZ+tk6TW+xtppzO6tSmHZBlPvDABgOWbLp+1n7GgkkJm3IMREQOnmtWOcf09acxRViOhsPRmx5CYfHbV9R3SlljE3/f1xKEChiZs/FekrAnrWkPXQFfHNtmA/aKvAzQBRibxJkPsuN9cojgImnZp+MaCrd7Y9Fzk5mUiMWEid6GroCMEJMhmw5Ql8sBHCaQ3JoIkKt+PJkEhUelaOo4qxGRQFC1/0291LXyMDuaIEpDiGoUsB97jQzGPMZX+XR5EdtSKAbEhtrGlpcvZwtORxoNCSP7wNHoI9kSu1LrxC1+enYFtSnvWaMC8oMNf1v8DMESHXVofASzplEQRZTfPjXFkr/CfmJ/rSu4jVrD5VUqeNS2CF++jl/I2hHE4DT2Xnjn91aoLFvO2gLJQ/ft+nCqJLz+6rRWqgIqFX7XSbE51G1SPHc7DqHw8O5sOLHcTbECW4su+xJFK4QNf7l/MGj9lkpQqkHGwTmaSHQRswkuFuFfvoZZqhfOI3ccStxYwWuSosAqyKViPi3kX7EHmy/RLhLjL+rYDbn6zssETkV3890knMCm416Ry3RD6oYabu+RmAMLbg+23Iekb1Ma/iA== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(376002)(396003)(136003)(39860400002)(346002)(451199021)(46966006)(40470700004)(36840700001)(82310400005)(478600001)(70586007)(70206006)(6916009)(4326008)(7696005)(41300700001)(6666004)(316002)(54906003)(5660300002)(8936002)(8676002)(19627235002)(86362001)(44832011)(81166007)(82740400003)(356005)(1076003)(26005)(40460700003)(186003)(336012)(426003)(83380400001)(40480700001)(2906002)(2616005)(36756003)(36860700001)(47076005)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5378 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: e1ee4637-20b1-4c48-8004-08db5b8e3efc X-Microsoft-Antispam-Message-Info: W+yg8cH53pwny6C+pzpM1fJ99Aao/3rc/vusj/6pnx2n++kboyej/L/56ACTPccA4lbh0B1NwWWLcUpwmghbubzVDCMadsGNM51SUgCnWY+WCxWw9Q3lTSG3AhPb+C8z0/gCNU6XLaCgTwkJhx+rhie8kNwx5z/O8Ha3AUAC9tll8jVLOPA+sq9nFxwIxhkUQrvdCwperhFMh++j1i3T9FLgk8wYyUnW0eAF2WFPCyoi47gAqQIwAZP8QGHzWDvHyQiwM8x75IkhwMvH2xvQPgaoIBYB8mluPgYFVYaDyVDOI/Q8F9mtK3mrlC5s1ffj2ROrHsU1nwajhlEjj9NsqVnQvQTmv28joY+l7gD+mXybelL/6A1gff9Xmlq0JgIoZpSYrGqH4BaqvtZutlgAdbR/wf2mVPevsDkuWbjbPnBvbaSjtzy8A6vg50G3NxEF7638QJuWT3+sYB4FModmccnaebsYzkyUnslnQxKPEHt1pyc80kRaiDbiD1ZysbLYy012oCQIynWVKmAjzmueOcrHOTO56KoO/zCsJ08tZi/ueX0B/E+DOaWQK/wB2ddiCmgZ3JhOlbwtLxvTqC+/m+F0090klkOkMP2y4yBpFJRq2sgRgq+08HiUnuLdW9EHLDHWWzPu+sL1lEMoRP6qapoI4JhM0a0C3tNek+NskhxUC4DgUuMFY81FM0t/WahuUtMKkz/TT6SNJcxgpmQQvw0vH0kARe0hyVH4OznyDa4KrWQglzotZFTfWHpAo2ga X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2023 13:04:38.4659 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cc653cfd-72a9-4188-b090-08db5b8e43d8 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7527 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com X-Gm-Message-State: iTSnkmdJf1mfACXhlno3TBw0x1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1684847084; bh=nc5CrE3LM8uESGU51Itg9phgyTqSwsKOpBFSVKS14dc=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=Au/AtpnPVtNG+xGeYxq3po7VksDfTDlc7yoilnLreFM8E137ktoeLC0nKYdYNYMjNNT MaAp4qEWjrA4+rX26zHtUDieLKIEa6LYICmzoxZnI3cOUHp8NhNIwkjjCLyuvHsNEZHFC gIBYYqkmFub3DaU0q/kFgde0Br269dj3/+A= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1684847085864100001 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Although the maximum interrupt ID on GicV2 is 10bit and for GicV3/4 is 24bit, and that the IAR and EOIR registers of the Gic CPU interface are 32 bit; the typedef HARDWARE_INTERRUPT_SOURCE is defined as UINTN in EmbeddedPkg\Include\Protocol\HardwareInterrupt.h Therefore, use UINTN for Gic Interrupt variables and use appropriate typecasts wherever needed. Signed-off-by: Sami Mujawar --- ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c b/ArmPkg/Drivers/Arm= Gic/GicV2/ArmGicV2Dxe.c index b952c3ae31c060ecbb43c0800d34e57664a8262a..fb40f56ff9231f3a28c3d90939b= fd25ac3432f89 100644 --- a/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c +++ b/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c @@ -162,7 +162,7 @@ GicV2IrqInterruptHandler ( IN EFI_SYSTEM_CONTEXT SystemContext ) { - UINT32 GicInterrupt; + UINTN GicInterrupt; HARDWARE_INTERRUPT_HANDLER InterruptHandler; =20 GicInterrupt =3D ArmGicV2AcknowledgeInterrupt (mGicInterruptInterfaceBas= e); @@ -349,8 +349,8 @@ GicV2ExitBootServicesEvent ( IN VOID *Context ) { - UINTN Index; - UINT32 GicInterrupt; + UINTN Index; + UINTN GicInterrupt; =20 // Disable all the interrupts for (Index =3D 0; Index < mGicNumInterrupts; Index++) { --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#105174): https://edk2.groups.io/g/devel/message/105174 Mute This Topic: https://groups.io/mt/99086448/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 18 21:00:39 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+105177+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=arm.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1684847092482876.6838781455426; Tue, 23 May 2023 06:04:52 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id Q4DGYY1788612xUkFZRzalut; Tue, 23 May 2023 06:04:52 -0700 X-Received: from EUR05-VI1-obe.outbound.protection.outlook.com (EUR05-VI1-obe.outbound.protection.outlook.com [40.107.21.42]) by mx.groups.io with SMTP id smtpd.web10.21864.1684847086087904942 for ; Tue, 23 May 2023 06:04:46 -0700 X-Received: from DUZPR01CA0340.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b8::13) by DBBPR08MB6123.eurprd08.prod.outlook.com (2603:10a6:10:20a::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.28; Tue, 23 May 2023 13:04:42 +0000 X-Received: from DBAEUR03FT048.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:4b8:cafe::89) by DUZPR01CA0340.outlook.office365.com (2603:10a6:10:4b8::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.29 via Frontend Transport; Tue, 23 May 2023 13:04:42 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+105177+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT048.mail.protection.outlook.com (100.127.142.200) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.14 via Frontend Transport; Tue, 23 May 2023 13:04:42 +0000 X-Received: ("Tessian outbound 8b05220b4215:v136"); Tue, 23 May 2023 13:04:42 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: af0d9369c49d084b X-CR-MTA-TID: 64aa7808 X-Received: from f2bc052b20fa.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C2865199-906A-4BF8-A47D-28583742028F.1; Tue, 23 May 2023 13:04:34 +0000 X-Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f2bc052b20fa.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 23 May 2023 13:04:34 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nn4pWKPPPwzImNf8twsLeUyE+xTSBM8WL7LKGWEDAqI4KNqNsH8t5mxjRorIoywHtf9cvTg/w0Q7Ee4yRGKwxI5loFodKwbL3PdApyTJfdIWRaVIUiQX0lDBka/udLstfks9x3pd5xz32NduWa9QqB7TxqjmfBBkECufUMleQ1/rEccLvuk1sc5ji5VSK4mlFCbX8uga4tuRvLgR/3nS/i6AZR/2gNMtvPK1xF9TWHMUpCAtt9X8ZofIM1sLPnVkuFtR4ranCV5A3aHBM/eePQfWgeUNlZB688jH0Eqw02fvWI3KIczKziWd8mdhmDVsvK0kZvR9ydwIEH4iZtvAsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dKo33xW2LUOCXUF/oXnu8gALFsfh2T7x0t5+8aEAn6s=; b=jY/KorGJtnT0H3tkMUOm8AJWqvptSS5SnXz/tCwyqXYN9X5DhGGUnOC9oiTU92uo6Zuqsr7cR5iYQb2ugbwUPx5UMA1zD5I6CgTZHM36HJO/Aq1o89aHrQXOYDnKI1wOvd2SgdYzVL7hewKHRl6L+CgxPgsnQHhN37HsS429nRJ2uJUmSURRxd/z8Xpg8SP0nUqyBG2Cj5UkyrVJ0ahMsKwbbVfFevUurIOEsslxAPKypn3ww2y00SdZVxr/OWrrnvPXXW1uEJG5QWMiHae10u6zRxr3zDEXSC1+lG70COPgFXgCpP/8J3Mop00QyLPKXZ4wGBDt5O9SdaSfmkmT1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none X-Received: from AM6PR10CA0007.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:89::20) by AS8PR08MB9480.eurprd08.prod.outlook.com (2603:10a6:20b:61f::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.28; Tue, 23 May 2023 13:04:28 +0000 X-Received: from AM7EUR03FT059.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:89:cafe::55) by AM6PR10CA0007.outlook.office365.com (2603:10a6:209:89::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.29 via Frontend Transport; Tue, 23 May 2023 13:04:28 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C X-Received: from nebula.arm.com (40.67.248.234) by AM7EUR03FT059.mail.protection.outlook.com (100.127.140.215) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6433.14 via Frontend Transport; Tue, 23 May 2023 13:04:28 +0000 X-Received: from AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 23 May 2023 13:04:27 +0000 X-Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 23 May 2023 13:04:26 +0000 X-Received: from E114225.Arm.com (10.1.196.36) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.23 via Frontend Transport; Tue, 23 May 2023 13:04:26 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , , , , , , Subject: [edk2-devel] [PATCH v1 07/12] ArmPkg: Fix return value for ArmGicV2AcknowledgeInterrupt Date: Tue, 23 May 2023 14:04:16 +0100 Message-ID: <20230523130421.10804-8-sami.mujawar@arm.com> In-Reply-To: <20230523130421.10804-1-sami.mujawar@arm.com> References: <20230523130421.10804-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: AM7EUR03FT059:EE_|AS8PR08MB9480:EE_|DBAEUR03FT048:EE_|DBBPR08MB6123:EE_ X-MS-Office365-Filtering-Correlation-Id: a6d9c0a1-1061-443b-65ce-08db5b8e4612 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: GPCFtrBYAl6Prv3t4xVg4Oq9vq8M2PBTS+cEen0NgtXDq4awHXKjs33Gm+opoo6tlUzlXyvxNGyjF3uBArgioIVVzxSjllyK7SfP/cdV612UjzbgBfTT4ozwS7Mov1UsH5TLT+BURuAi2ZhEf91U8VGC5yOiABRCs6ewfW32yQfI6ZnkuJhmCqLoQWUJBJkuhsaerTEWvytvvro4tBLIiJEBw2Qn13emGqkd5poI5fS5HACPm0uOgpoH/gs0g4fih/JBHli22UZw4dui2KH5o5XrjetKqyJxN3gA6jWE5IsiPYPnEuoxulKqoJ7O6buG8HFtq2ERlqOGTjqsTZnae7wsgW+BHX7ZJASVgxpYtjIQARsMQnkXsJ5/GB7Zsf7KNgdCkJL90gbaj0YrdWy2TnJ5oLkFaXY149g7AleJHutWygSko2pjREXq8eLAO42DzcaPAhTjDAK2mCqy1XCAZjIGihdGf2gtxKko2bL6txnCw3uTc1KjC9mKW2YlyPTyebVBzY7AHMcRLOEBgR2G51eyBQGiZWQekcFBVNcvsyK6/xbBOKOOrQvqxnMoItEoD40sdhCAILzJZvZZklxkA2ijCRQJrc9LDCponJeTez6+Bu0hXUKZQ7t2abULpDz/W2CNfNlOM8Tcm5yoZ8pdxZR3TyKDFkxDc70HVe9krXS+VGOT6q0At5XdBFV69Ggy9P9JX0OlKU6gWn5SWUl1rPxDvTbW1om3VjcMFpwJRi7qC5+pt7kknwYsbSr5zNtXYdwFqm4rNc6VC8WscWVdNA== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(136003)(396003)(376002)(39860400002)(346002)(451199021)(36840700001)(46966006)(40470700004)(54906003)(82310400005)(41300700001)(7696005)(478600001)(19627235002)(316002)(4326008)(70586007)(6916009)(6666004)(70206006)(86362001)(5660300002)(8936002)(8676002)(44832011)(2906002)(1076003)(26005)(356005)(81166007)(82740400003)(186003)(4744005)(40460700003)(426003)(336012)(83380400001)(40480700001)(2616005)(36756003)(36860700001)(47076005)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9480 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT048.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 373e3c79-cd13-4d8f-bf26-08db5b8e3db3 X-Microsoft-Antispam-Message-Info: RxoqpuWvDrSJpgd2/Bg/twj/ZJ/inW3jbUhfrgHicV7wVM7b5xJDtzpANUh/YB8bwuLU1HIEJPHnonRuaHOjq1emzMVHBO9GbNf3rZK4o+mq8UPzYO/h88AhxKToLCTeFiRBa9ziBACtSKB6T52YrfvpgaoaCcC+qpqw3rK4oFl66j62dIdcJ4ONVZmmdHTe7vdIVrYdIYW93kaOTT2+ewbdliH8n8mNnpglg+xLCWZMZd0PA1zBvE57kJbO+A4Odgd6ifnLNrAECu+v8AAuxJc0zcVQoslhdqnH1P8YHRjEsmX58FryAszAdFwB1IQhTg6H+c31G3kdZIiowbytO9ZJ7KXHpAzfSJsevIo8TGhGfakpP4ohLzhlqmdNDm8shqETDaa/zDbnLOarpLgi48eNgL/ghI+MYqhnu2sF4wFLbkbQXJYolPYfhLXwzvezYZDFJfNU0tQIneAhlgM9/mHhETuPYQZpxzO5chQU93ircZqKWdNbc0XfmtazYUoJKPu/G7a33NLqGnUCThCKfa4bZPwyTXEBKNv9bPbeztSFICSFDSvERLNkZhHR7rxYcnDaQxwx3h2IEnWEVPXOe6E5iNMwuPYH0uU28gJRSAfFnWlg37ygWYbX4wMFcYe1193j9VnpKswsxYvzNJMutmjf3MwJjLI4/bMmOOtX5pWtTR+Yq4VwFLOSj4ukBQ1kE0I3crOsJ3iEbbsb7xcnjpEHP3EgkOgyplWenAdG9kLycNcsDR8B2hFLDsx4nWce X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2023 13:04:42.1995 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a6d9c0a1-1061-443b-65ce-08db5b8e4612 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT048.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6123 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com X-Gm-Message-State: 5oOhGAWdXiRanuTSd5blnwwMx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1684847092; bh=QO5cQxrl6+x/bWJbRIziBMurXBzlQ8hIve5MUJnx1/Y=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=guFAjc65rlaAz1dnQhi1ZkTWK3Jayz8dh1xhG2LL3F4zFbL+UB9TPHb1Js48ddFy/D3 9aiMHV31QVz53+vlhKI6mqXS3tsDlZPeljyoG//grn/Jv5lOrQUqaKSZNt/VkMZfrHv/o k8wxDAtI3I1gg0gy6DV8p+c0SUT4Fbxvnpc= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1684847093805100001 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The IAR register of the Gic CPU interface is 32 bit, while the value returned by ArmGicV2AcknowledgeInterrupt() is UINTN. Therefore, typecast the return value to UINTN before returning. Signed-off-by: Sami Mujawar --- ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Lib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Lib.c b/ArmPkg/Drivers/Arm= Gic/GicV2/ArmGicV2Lib.c index f403bec367b5254c248e620e56471904e520f9f2..80115b243afabd5e4faad88089a= f738b19ce4cd1 100644 --- a/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Lib.c +++ b/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Lib.c @@ -16,7 +16,7 @@ ArmGicV2AcknowledgeInterrupt ( ) { // Read the Interrupt Acknowledge Register - return MmioRead32 (GicInterruptInterfaceBase + ARM_GIC_ICCIAR); + return (UINTN)MmioRead32 (GicInterruptInterfaceBase + ARM_GIC_ICCIAR); } =20 VOID --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#105177): https://edk2.groups.io/g/devel/message/105177 Mute This Topic: https://groups.io/mt/99086456/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 18 21:00:39 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+105175+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=arm.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1684847085095148.8104831567831; Tue, 23 May 2023 06:04:45 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id HrW7YY1788612xVQVkX9li2N; Tue, 23 May 2023 06:04:44 -0700 X-Received: from EUR02-DB5-obe.outbound.protection.outlook.com (EUR02-DB5-obe.outbound.protection.outlook.com [40.107.249.75]) by mx.groups.io with SMTP id smtpd.web10.21860.1684847082980447896 for ; Tue, 23 May 2023 06:04:43 -0700 X-Received: from DB6P193CA0013.EURP193.PROD.OUTLOOK.COM (2603:10a6:6:29::23) by DB9PR08MB9513.eurprd08.prod.outlook.com (2603:10a6:10:459::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.27; Tue, 23 May 2023 13:04:39 +0000 X-Received: from DBAEUR03FT052.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:29:cafe::65) by DB6P193CA0013.outlook.office365.com (2603:10a6:6:29::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.29 via Frontend Transport; Tue, 23 May 2023 13:04:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+105175+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT052.mail.protection.outlook.com (100.127.142.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.15 via Frontend Transport; Tue, 23 May 2023 13:04:39 +0000 X-Received: ("Tessian outbound 945aec65ec65:v136"); Tue, 23 May 2023 13:04:39 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 87bb84191ec39206 X-CR-MTA-TID: 64aa7808 X-Received: from a5850309d05c.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 790E4DF1-D4DB-40A4-B019-41A2734E19F6.1; Tue, 23 May 2023 13:04:32 +0000 X-Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a5850309d05c.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 23 May 2023 13:04:32 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HCb5s/NqszrECCk8werhkQGZ/0nTrTKiWLfGUuWf3kaIjL9QROxLeUADdgScHyeuCpbmj97WKjSQ61LmoDtTc5+6mDuadE5lZvtpaZRZVvAUpK1vog3vFgyz5VGv3MZZB8HlOqooUo+HY4cx+LwOtsVvacQSR5pc4UH6C7G7Fwn+djZmNxVaC7ybYhrg3NBGMNePMr5wK/togrcAC36qnXPoMUWZV/lAnvavsjopt+A16OtHG6/xvVRgirOnK/zVgtEyJB5hdkRWryoailG7XThtHIn7hVbESfXlkd3l6EK6zjkfp0eEn7Fuop/gRY1/6WJ8yOSWj0+nlD05df8KSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VnA6AubNH+7I8+qU74679VkeHGelrV09BV5TqKT2/TQ=; b=b8CVvqc6Yfx6wfNlnf4X7lKTADWj2ysa0Gu4LENlziumfAE5z1oLbGk+j/Pe1EWLPw+tkCwkpEkVrcYHPucGqz+1usFpq5m+SUZPldTaljd3CRYCxJhwuKu5YcgtqtjIU5jh4nQjptXL0hyi7K9zqg0laa1uy3Gg6Q2fqaDOBCiSb8w0YkxvtisEwVaJHRIMpa2qx/6ruK7+A49wJCZXLim0gHdm+PtwcoEQXmsip5f6c2PhzEYeZ9O6uhgcZQwrDOFkWNohHdijFZ7M3EwL0q0Nb/mbX05aTUgANkL3GocBppfAFm1N0xfzf7mHg7+YWKcvb7tF5pKUYEewL7SDLw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none X-Received: from AM6PR10CA0015.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:89::28) by DB9PR08MB6731.eurprd08.prod.outlook.com (2603:10a6:10:2a4::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.28; Tue, 23 May 2023 13:04:31 +0000 X-Received: from AM7EUR03FT059.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:89:cafe::88) by AM6PR10CA0015.outlook.office365.com (2603:10a6:209:89::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.29 via Frontend Transport; Tue, 23 May 2023 13:04:31 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C X-Received: from nebula.arm.com (40.67.248.234) by AM7EUR03FT059.mail.protection.outlook.com (100.127.140.215) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6433.14 via Frontend Transport; Tue, 23 May 2023 13:04:30 +0000 X-Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 23 May 2023 13:04:27 +0000 X-Received: from E114225.Arm.com (10.1.196.36) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.23 via Frontend Transport; Tue, 23 May 2023 13:04:27 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , , , , , , Subject: [edk2-devel] [PATCH v1 08/12] ArmPkg: Typecast IntID to UINT32 in ArmGicV2EndOfInterrupt Date: Tue, 23 May 2023 14:04:17 +0100 Message-ID: <20230523130421.10804-9-sami.mujawar@arm.com> In-Reply-To: <20230523130421.10804-1-sami.mujawar@arm.com> References: <20230523130421.10804-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: AM7EUR03FT059:EE_|DB9PR08MB6731:EE_|DBAEUR03FT052:EE_|DB9PR08MB9513:EE_ X-MS-Office365-Filtering-Correlation-Id: 8be44f49-968e-42f3-1d60-08db5b8e446a x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 71vj8LtK0VFyVDGBvXWILmZMqfU7lfvcihrVdqRo4pFRCy4NQ4B1+Hk2Ygn3iP4/sG7KfwaKjgH0TLtWQymuIRx3gi203GtFcq8M9opFWAt/Xs0mhXZsj6OMgtI4wgiHVaVPsg1Ddcq1eHk9U+pnRjVnByyT0gwLAw5wiAJvWLzDvXoA5VzZ54oFNETE7LeXDJEfLTM9XwwvtrFeWz70yqVGA20I39A1k3L1s51OoWN2L8gs/W+WzB87t0rSJysK9WZC5XkxCG4vtj/m+KlKcQWzBw5rwVIp7nmxAgE1hbAb1BJqqvACOd+cyDuih5Ikcc0pcv0htP4Bhi2n7HmIlW1F2CNsVkAYqFYFMwuQzqqOXOzvrnhUlnwXI+O4TUeDUzDiPyk2l+zPaRTbWp6nofBF+B9Ijr00ORoj65DrV58NEEtogqQS6eGo5NS0ZsC3LtvcpUEapaULGhwPEDaOodZbnw/zWwqnLvamUvuRO68wZiNt8zQCkJgko5cs9uLaOhxJshg2a6MmlVr8DxNJuCpuCCYatM3SMS0doYF31jhFrmVS+OYVARK0b3V2+NbolR09mkpSj/+iC7WUE99K/447T8e/ZFs/w+5ihVIEKNtPD3ZoCLIcJTVraOEneLn6oDzJXuWU9KXUuqtMHk6J5dR54uEI/DKjzLmBUEoQGhIb76P+O2K+BD5F9oqI4uwJHkuYbEZm4xTm3GNoXv5arbZWzb7x9frhGzI6nDNhFVlKQVZBFbp1+DWRYJnAXXYHWmfe9FOZ8YCtEZTqdQoETA== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(6029001)(4636009)(376002)(346002)(396003)(136003)(39860400002)(451199021)(40470700004)(46966006)(36840700001)(54906003)(86362001)(41300700001)(7696005)(82310400005)(478600001)(19627235002)(316002)(4326008)(6916009)(6666004)(70586007)(70206006)(5660300002)(8936002)(8676002)(44832011)(81166007)(356005)(40460700003)(82740400003)(26005)(186003)(1076003)(426003)(336012)(83380400001)(40480700001)(2906002)(2616005)(36756003)(36860700001)(47076005)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6731 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 2fa72022-15e2-4310-40b7-08db5b8e3f63 X-Microsoft-Antispam-Message-Info: GodPtOxaUVPaupuA43mHDxjzVZXU3iJ0yIE5z1fDGWPaO0ayd0hhdxar7nxTzX3F6UjOW94YLzzAtvQnivW+foWIcZnyLCPP4hh2eAxN2TG3pd2emonoLxebcynGjFP56PyJbikJPBSsn01UXrxqQOZGnbWRjF/BX3EQs6fwX5xgxPeKA16QWf/STY523ylhurTb2YTcCiEB3tDSRpATaDMZFU3rx3V1mTbeaWZwqJsw0cYnDADjjNWwKIqs+xusz/zlawp5olRV0gpPIJU9bIN6OT50rU+o54NoUxg9Z4uSAYJ5ivaYWBYAgbEDkOgRmGEFmdbuEa8vWC13jdOtxy0GfjYYGqTCb+DXZVC6euABaLaYjjZkPgFPMlNz9QrWoGXCs8iE8dHpQSZswlFAcEecSLP2GqgYncnCgr2n4m/7lzzkzd425TZTwzkQhSAmxHXfPZMCn/bgKC+/C8XWTMSEHBABwMjKb/2UkAYKRWSK1G0kDt6+JPmH+EOU9qGCo21CJZJI0gJFhwe71WQkDVp5fiHrHbBOEZ36zd6C+svpa2Nqhg0PZmXaPAUaYZ/CyjQ1BgoCrtxK0ywYI4AHNAhmiatKlqMmhW7qAjwxiHs7qf8C9TN/8FDbJDCcpOKTEQ/OXsyG6wrucRiXpk7eZRJL8qGZd1wKE1EvEtl6tZ86ewxjxnbMouiKHGePBR7UKVDwbOMqaOVbnz9nlvDwcE6mBNLpSACU6XPBP4JPugisn7lg0wT0QFx08SN06D5L X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2023 13:04:39.4033 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8be44f49-968e-42f3-1d60-08db5b8e446a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB9513 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com X-Gm-Message-State: UcWdLjF5tOb3tcAtKxmSJX4ox1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1684847084; bh=DHOexlWAluX0SeryU/hdipc68k+dIGN2ke8Q+v1wbzs=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=MdzJm/M38k1budQzSsTowwEbqznbvoBvUQ0B0IvAn0bzkuRWEyWNC+0gNNN1w9WNEiy riN1vmr6JOSd+k97cSgOuRz7WhX5r/guNY2rPNYGAccefKyUe+kweTJLlZPR/NfQ3WDxY PUu86HmJ15O0gRmtI0BWQfcP9KYIjVjFR+g= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1684847086012100002 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The EIOR register of the Gic CPU interface is a 32 bit register. However, the HARDWARE_INTERRUPT_SOURCE used to represent the interrupt source (Interrupt ID) is typedefed as UINTN, see EmbeddedPkg\Include\Protocol\HardwareInterrupt.h Therfore, typecast the interrupt ID (Source) value to UINT32 before setting the EOIR register. Also, add an assert to check that the value does not exceed 32 bits. Signed-off-by: Sami Mujawar --- ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Lib.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Lib.c b/ArmPkg/Drivers/Arm= Gic/GicV2/ArmGicV2Lib.c index 80115b243afabd5e4faad88089af738b19ce4cd1..e98cd9705616e7a8dfc7aaba7c8= 0b176f8f6d0c9 100644 --- a/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Lib.c +++ b/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Lib.c @@ -7,6 +7,7 @@ **/ =20 #include +#include #include =20 UINTN @@ -26,5 +27,6 @@ ArmGicV2EndOfInterrupt ( IN UINTN Source ) { - MmioWrite32 (GicInterruptInterfaceBase + ARM_GIC_ICCEIOR, Source); + ASSERT (Source < MAX_UINT32); + MmioWrite32 (GicInterruptInterfaceBase + ARM_GIC_ICCEIOR, (UINT32)Source= ); } --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#105175): https://edk2.groups.io/g/devel/message/105175 Mute This Topic: https://groups.io/mt/99086450/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 18 21:00:39 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+105181+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=arm.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1684847093930671.8232456634299; Tue, 23 May 2023 06:04:53 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id eRcAYY1788612xQ6kwYPZ1UE; Tue, 23 May 2023 06:04:53 -0700 X-Received: from EUR05-VI1-obe.outbound.protection.outlook.com (EUR05-VI1-obe.outbound.protection.outlook.com [40.107.21.56]) by mx.groups.io with SMTP id smtpd.web10.21868.1684847092544116875 for ; Tue, 23 May 2023 06:04:52 -0700 X-Received: from DU2PR04CA0344.eurprd04.prod.outlook.com (2603:10a6:10:2b4::17) by AS8PR08MB6053.eurprd08.prod.outlook.com (2603:10a6:20b:292::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.28; Tue, 23 May 2023 13:04:43 +0000 X-Received: from DBAEUR03FT016.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2b4:cafe::db) by DU2PR04CA0344.outlook.office365.com (2603:10a6:10:2b4::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.29 via Frontend Transport; Tue, 23 May 2023 13:04:42 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+105181+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT016.mail.protection.outlook.com (100.127.142.204) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.14 via Frontend Transport; Tue, 23 May 2023 13:04:42 +0000 X-Received: ("Tessian outbound 3a01b65b5aad:v136"); Tue, 23 May 2023 13:04:42 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 7d0c9b668400b65b X-CR-MTA-TID: 64aa7808 X-Received: from f5f32eacab88.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id DE421CD1-7E0B-45DE-9092-DE6A3F341634.1; Tue, 23 May 2023 13:04:35 +0000 X-Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f5f32eacab88.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 23 May 2023 13:04:35 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XqHViBBeyGBdPARccTnO+a6uO27cvvbkERCUcC8WwIEGQequU1F1oX4yXcMYYmgbaBF1FSsNv9C2qwQDJnRkVbmmBLYxQmM8Poh8heN59jQXL7KvxMqZ2RsrBntkqXwal6CdrlZKGzEGefdhMq6xSeeBTNeMe9PEjNiPj+hZpb5ipRMxnA/xfHssPQjYQYNnhNM8Rtm0KY6GH0OFPK9NKmKJa5QVQiMC+LCXgJ9aNfioleIspY9a5YLDnSXiJUWLAyEz7AvRa1XDkWf7m853vzfhTJb+VKA0/hq0y3i7uBi0obritsi0PXJieowvFW8F1glF1Asw9hTnvSL1nkrOnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sbb1nSMwf8OCJXjbj+su5txyff63bUauGCYkIViKWLc=; b=lxCf/nPpPQbtV5WUvVe4FPU/clhbEasCKTkQCnyGBXSd99ZN4s2GsHMa81VO5Wcca03wVw8VdwOeK2njMOHsOazgOUtxlLdt8O/Zj+0WbOHk5U2d7N+veOzXdMM7ekpDic9NHC91OvfsyZqWZ2BnvExkvc0aXTkj7LrJomxGc2HlDFxmkSOhtdT0sBl06XLB57Od5vZcj6LCtk44r2TRVw6/eJ4JpYbVrY6rQZv/yx+awGNyMPT8/qmfhnRRWEKwP2i1y8U3dDtsaXZyCz1UqsK2ful8rI8jTd4SNVhfi4QdFOJvHdyQcYNNcJlC48n1BLtX0vpybOTcv83pRffvWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none X-Received: from AM6PR10CA0016.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:89::29) by GV2PR08MB9879.eurprd08.prod.outlook.com (2603:10a6:150:d2::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.27; Tue, 23 May 2023 13:04:32 +0000 X-Received: from AM7EUR03FT059.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:89:cafe::47) by AM6PR10CA0016.outlook.office365.com (2603:10a6:209:89::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.29 via Frontend Transport; Tue, 23 May 2023 13:04:32 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C X-Received: from nebula.arm.com (40.67.248.234) by AM7EUR03FT059.mail.protection.outlook.com (100.127.140.215) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6433.14 via Frontend Transport; Tue, 23 May 2023 13:04:32 +0000 X-Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 23 May 2023 13:04:27 +0000 X-Received: from E114225.Arm.com (10.1.196.36) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.23 via Frontend Transport; Tue, 23 May 2023 13:04:27 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , , , , , , Subject: [edk2-devel] [PATCH v1 09/12] ArmPkg: Remove unused function declarations Date: Tue, 23 May 2023 14:04:18 +0100 Message-ID: <20230523130421.10804-10-sami.mujawar@arm.com> In-Reply-To: <20230523130421.10804-1-sami.mujawar@arm.com> References: <20230523130421.10804-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: AM7EUR03FT059:EE_|GV2PR08MB9879:EE_|DBAEUR03FT016:EE_|AS8PR08MB6053:EE_ X-MS-Office365-Filtering-Correlation-Id: 6b3b3858-08dc-469e-35d3-08db5b8e467d x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: IlrFDSAQfX3zWOQPufNhiopFgB/6QzTkSuq7QfJvcKCae2tHEx6IQx50m9QW0KGWWGPys5E1/cI4PNdkbigdyymV9l3Mn8BJ0L9GSsbmo7Jbfq5MCegYfZp+piHNVP9V8BD53RZcgVaNwS5kw9nvarcGsbjddSZWv2QtOvzTvmdT5QZTOfJkoFGrIB03qVwdQoa6wI/s6Q+vcJADJZgiqnc46ul4EqhDDQQ3bJvVCsm/3w1Ye7MeIO5gMkHh6wzweOZAZ4jLm99tofAKuQBlLQugprGFmqvAp5HkYCKq2f+sRVG8QlfzYwG2upXnaSlln+dmRzu893ttrdlf7RJprZ7gmG2i6xwrM9wU/Mo6WR4VBQXTZ1PiwsKCrWkObQBT9T6FECdBeQmlAMvRqgP7fW8HsZ6kq85V7IQ9uDKzGv4ys+QfQMnAS518VflAsIBe6DHNyL9PW7VT4vm001a9l140y9JK3UwZvWEWxSU7lnnrZTsDbscYcgHCaCDTfgHjUy43FZrVU0lUQdqVsMp8V1SxgpuOUHG14N97/q4tPL+7UwSCL41V+8S2DMmUjwZbvEPvFoSl4o+Tk3Qc8h3nenq6Kz6vt2W2+P3naw7XXfOsZl4tVy/ebyhbFNxzhHG4yVwjjn/YOcKZzY2czghDNMUeqCRWOpdMV0Qg7Zlf0euIcPRglCC93n45neR/pSFQGV6vt+qWDCYSWBjxGBUFMvPWlcFfbmYUcf3iS1MkcJmiB9EJHSuvRIIWOdZFFb9CuM9wwVfk6AUEmoSjpZSPEg== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(136003)(39860400002)(376002)(346002)(396003)(451199021)(46966006)(36840700001)(40470700004)(8936002)(5660300002)(40460700003)(8676002)(47076005)(83380400001)(36860700001)(2906002)(4744005)(2616005)(426003)(336012)(36756003)(81166007)(356005)(82740400003)(186003)(40480700001)(86362001)(82310400005)(44832011)(26005)(1076003)(316002)(6916009)(4326008)(6666004)(478600001)(54906003)(70206006)(70586007)(7696005)(41300700001)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB9879 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT016.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 92176f83-ba03-4f4f-bdcb-08db5b8e4026 X-Microsoft-Antispam-Message-Info: Hg2aRtWfGiTAnA8QnjxeUEuW96iRFxWMMo9uetPFEqLcSsD0OMbZZj5tITlUMRUdQOYtqU/qIX8Jo49R58twJD779Nt5ph2Ig3ZftgeZMGRiP9KBTER6vGcVgGxSprAgTyXfcxhl9KCjRybn7zSV7LtIzQLQbWfxfbofAC9cz3DtrM3uXPVl2WTtTsp4sXjQVS1s1ws/zK3H6qXSJ0wI3QzkTU4la6/NnHlDDdt1p34RTJqeJ/6Me/45cY8iYTu7LXWzewZh9oistY3I7rQpfXAnVrq63QFqzI/M+L7kjbGDjDEAQTl4SpRHS3R5uAZtSXJpbv8pp5dpCP7v/qnJT3xK9+qa7jQJl8wruptCBrR3I9ELnijJBJyP9fUl1f2nof8weZXoWvNPRzYT+xOG/PpLApHRIzkggCLeyg+4PUwbfnAB/Y7h975lJJE0yidyoJGf0Yis760FwcDvWV5nG7//Ir8mXg3m+Ay06DFGBggRtNWfzqIYWwGEjWies2X9WzJp+YX8oKBsVMQbR57lvR6ZsHIkc3eUcllBTLNhE6LzExJ18cm1lM5FRtHGQM5+cpOdhWnc7N+TJRy2HAzZdibjzRKbvjr+aShdytgUCc9tJzi1euKUNDB2TSAmVfnRtfp5PS/Xzpb4DJKdaN0b9VzGRf+ocWP7EkWP2k59guEt1JY2mLczigJh9mHd+S5GMQFwvKszaaVXsdM50fNagdisPMuIp/DZB93DAQ1C0PN1w/mzR7euDiHVqhtKlb/4 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2023 13:04:42.8995 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6b3b3858-08dc-469e-35d3-08db5b8e467d X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT016.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6053 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com X-Gm-Message-State: SmMOQjBYuoTjoOycCl8b2XBjx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1684847093; bh=ye74D/FRB6lnRTEXEWtsfNDXrsFJ6o0m2Al5laVebiE=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=hfbeT3cfZH+7prFmx+Ze9a6bm/V+YEotqpTvVAaXs3mxfDdRuxbVFE4sN/LW8CgULhs T3gcmHL02VhfIi1qf3wGEzkerfUPuu7mVgFQ4/d60YDXQYP7TRo0pu0YPoHx0zhGG4wSt UfkbYvsvmbhinPvDBz4IcOUY47H4oIS5zzg= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1684847094477100003 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The IrqInterruptHandler () and ExitBootServicesEvent () function declarations were unused. Therefore, remove these declarations. Signed-off-by: Sami Mujawar --- ArmPkg/Drivers/ArmGic/ArmGicCommonDxe.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/ArmPkg/Drivers/ArmGic/ArmGicCommonDxe.c b/ArmPkg/Drivers/ArmGi= c/ArmGicCommonDxe.c index 9ac073db36ce92fc14de71e9a264059afd63d729..26c3a06761d197c0047f9eee357= 25b488ec2a132 100644 --- a/ArmPkg/Drivers/ArmGic/ArmGicCommonDxe.c +++ b/ArmPkg/Drivers/ArmGic/ArmGicCommonDxe.c @@ -8,20 +8,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent =20 #include "ArmGicDxe.h" =20 -VOID -EFIAPI -IrqInterruptHandler ( - IN EFI_EXCEPTION_TYPE InterruptType, - IN EFI_SYSTEM_CONTEXT SystemContext - ); - -VOID -EFIAPI -ExitBootServicesEvent ( - IN EFI_EVENT Event, - IN VOID *Context - ); - // Making this global saves a few bytes in image size EFI_HANDLE gHardwareInterruptHandle =3D NULL; =20 --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#105181): https://edk2.groups.io/g/devel/message/105181 Mute This Topic: https://groups.io/mt/99086464/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 18 21:00:39 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+105183+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=arm.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1684847095361996.7560676680149; Tue, 23 May 2023 06:04:55 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 9oFGYY1788612xgoUCKqXzgE; Tue, 23 May 2023 06:04:55 -0700 X-Received: from EUR03-AM7-obe.outbound.protection.outlook.com (EUR03-AM7-obe.outbound.protection.outlook.com [40.107.105.65]) by mx.groups.io with SMTP id smtpd.web11.21717.1684847093063792406 for ; Tue, 23 May 2023 06:04:53 -0700 X-Received: from AM0PR03CA0066.eurprd03.prod.outlook.com (2603:10a6:208::43) by DU0PR08MB7392.eurprd08.prod.outlook.com (2603:10a6:10:353::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.29; Tue, 23 May 2023 13:04:49 +0000 X-Received: from AM7EUR03FT048.eop-EUR03.prod.protection.outlook.com (2603:10a6:208:0:cafe::a4) by AM0PR03CA0066.outlook.office365.com (2603:10a6:208::43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.29 via Frontend Transport; Tue, 23 May 2023 13:04:48 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+105183+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT048.mail.protection.outlook.com (100.127.140.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.14 via Frontend Transport; Tue, 23 May 2023 13:04:48 +0000 X-Received: ("Tessian outbound e13c2446394c:v136"); Tue, 23 May 2023 13:04:48 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 586c460c4527615d X-CR-MTA-TID: 64aa7808 X-Received: from 113e4eba5dfc.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id FA9810DC-5B8C-45A8-9652-9C678EA55CA7.1; Tue, 23 May 2023 13:04:37 +0000 X-Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 113e4eba5dfc.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 23 May 2023 13:04:37 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GDVUl1+mrc1Q0TrkMf+auN6Q1CK8iqITFVAO1L1+yFOdbcQzmXbMyXEFSiA/6vnz8qIZLO2wo9Yb4BtC8f3h7UQcEQZAiAlgb5jjNdb9KJF8E4w8rPi4puBGuDV243/5I9k0AIc6BUOzSOhOP7XycBKyC8TaxwvDl4hRb9HSnyRXcCpqGpxvMyuqFfDM2aw/PYKLh3qIXuU7TXSyBjXDc/0EYPOO+erRKfAGSGSVn46uPlhEcmdi/BKG8BjgVVRg5BD2M3U8MT7DB0be0QVwZ10p8tOFWgH5QdKM3vF4YJR4I3ZV2KFFoK0lJiA0aCoVROfCrn6VKC33vGuQ3jRhrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PLinzapPJysSxrfPlPPA5lCdBv2fakLFiQ6J5iu44uE=; b=Z1ULxdNJryq3LnO1heKlfCZ32EyQ2TKyCJjbjG4XU/8qH1+CbJgqS9TNeA3YfuNgkiRYV+3t/cJTr5HPGCUAQbc/9GhfvuNiGdM491J/Oap9BdLMOGYsf78PPBoDj06KlQxASnikKo/dvawFrCWlnMPzeKRxxFYAtluAQscdzHiqJgWkoPQKha+ydgQHI7z+v6UCY4Y2ilDHThJr7wNRZj3cQ2ZSk1pYsIVFR7zXymMdoAuZGqcvr0AOYHxqxVqFA11wVHXSMEKtT4rk7ZL4vOozz5CAMbnOoIgdaNBYK5r3MK+Qo3xXSVqRvgDeXhlw7GN1Qw2JSC8oA5L0u86LKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none X-Received: from AM6PR10CA0025.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:89::38) by GV1PR08MB7377.eurprd08.prod.outlook.com (2603:10a6:150:21::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.29; Tue, 23 May 2023 13:04:33 +0000 X-Received: from AM7EUR03FT059.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:89:cafe::fc) by AM6PR10CA0025.outlook.office365.com (2603:10a6:209:89::38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.29 via Frontend Transport; Tue, 23 May 2023 13:04:33 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C X-Received: from nebula.arm.com (40.67.248.234) by AM7EUR03FT059.mail.protection.outlook.com (100.127.140.215) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6433.14 via Frontend Transport; Tue, 23 May 2023 13:04:33 +0000 X-Received: from AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 23 May 2023 13:04:28 +0000 X-Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 23 May 2023 13:04:28 +0000 X-Received: from E114225.Arm.com (10.1.196.36) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.23 via Frontend Transport; Tue, 23 May 2023 13:04:28 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , , , , , , Subject: [edk2-devel] [PATCH v1 10/12] ArmPkg: Prevent SgiId from setting RES0 bits of GICD_SGIR Date: Tue, 23 May 2023 14:04:19 +0100 Message-ID: <20230523130421.10804-11-sami.mujawar@arm.com> In-Reply-To: <20230523130421.10804-1-sami.mujawar@arm.com> References: <20230523130421.10804-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: AM7EUR03FT059:EE_|GV1PR08MB7377:EE_|AM7EUR03FT048:EE_|DU0PR08MB7392:EE_ X-MS-Office365-Filtering-Correlation-Id: 9bfd94aa-1c7a-4e86-85b5-08db5b8e49ed x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: RVTDUUHkQ0AyPNvDHgcwQE/HFeDtmENCpI2pvYqg6hAyKlkdB9qqowj6ZT1W4A8HFOTyZmbe74pN4c2y0tIcFuzLpHqeu003lzuwMSIZ5jnteCKlKnueKF4oN18MJtBXbRJRpEgL99//hyeH2qkUAmyACfrE9ePXF2RIj3HCDcL0aXh9zMFFgTWDsN72KKkkmpEQbzN1o8x7xkVo/ZedN9V3dHUfr7Ud0xE5ev/a7BMW7AxkqS26TczPZXX18zFvAqY9ps50JfIODBaUc9NRmgHFQIPX4wBd79oLQ4UBpFSaiMhQ0TFrxi9SYTdMPdzIXU+8LBHRsaDrwtiMCwD+fUab7G+3zbmq52kaylSvIqOoS2LtcQ/Ofuw3R4dBtfizXg6qK12V+dMZB94B8aZQGH47ulCStvnR0kQotVb6Md2aAYXaTRKUkrrpiGKnU44zH0DNJK5a6XayVf93p7ncaBmWsWeqVZldLnT+g/N/N2XKFQy8Eody/C7c6FmIp7BIaHp0fS9tkqEd5mR3CkThvjLSUyGbBsR9nAVFzn6POFFAq36Eb6aBgtVn0KtTdxzXPtNMYb0xP7CIliZAz6xSpIxhO6aa0wzSOrjKtN8+8KHS6d2bQyUTY3fifQZdBqlTz9yRvnpC4ZFvvgMF+HRyiijy2ELKoVUdR3VrHmMg+rHsRIB+nSiRcMJDb55fXfGL6jOPSrlXKq3CPFSVagLleyWOIfppdCS3sBK89wT2mXEe5K2iIIzn078rPr3FPP6U52jE8ePO8TDXh4nBs8uDsQ== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(346002)(39860400002)(136003)(396003)(376002)(451199021)(36840700001)(46966006)(40470700004)(82740400003)(186003)(1076003)(26005)(356005)(81166007)(40460700003)(44832011)(2616005)(36860700001)(47076005)(36756003)(83380400001)(426003)(336012)(2906002)(40480700001)(316002)(6666004)(70586007)(70206006)(4326008)(6916009)(41300700001)(7696005)(86362001)(54906003)(478600001)(82310400005)(8676002)(8936002)(5660300002)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7377 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT048.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 346ada08-765c-4c97-1811-08db5b8e40a5 X-Microsoft-Antispam-Message-Info: MdE887o2krNhrvD/EkW1VlyTgsWw305Tdb5V+sQOwoMSjJ5EPsqU20+yd6A6HevclrKKqKJGZBmsrzbVGstB7UjlHiudYV8s40IPaQDmk03MT2ejuyS9O9AbUitw82GdfHkBXQT4jafyhHtPiQJNd8B2dF3qFTG/9kz1nOkos1F4v+Ig/qgJIUuUFJpqfnxg09PiBlIBa3+xa3ZpINdQPJpFs2gnPLoNsmIaJnKYBl3rH58x0Nrnjy/s3QbjzWzMHQvX7xPnxJImZkI6139KinSrG+DGggiA3/Ql24v4jkrWIfs2RKl6o4NufKNk46WahLgb4VdNfkY8EbeCxik7sDIyPiwILI2n2vnXRXxys2/QG3nX6lG90KuRYnCw4S9hiXyDlp6Vr3FBvSnVW2apGhfSyINPSpugj7ikApU/aMo33HDu6t3yBMOL3oHqzt1OGrovGk1b0K6gLSI9nSk24K7huBobP6EJEEUUJQKSyg6Lc42/H2/0vaolQOt3w8a0HCmMWMr4+IV50oTK92nCjKpRyQp+D8Mn+ibwvDoUEn39BPmuibRwf1UxydLGNELOLWLQ8qMhldMMif21Teh23SZvAjJjaSgqs9LwWkiGj7sMhmVFDYR4x13VQJ1kaTKfEtCokkkZTkVEeaJ0nooRQdiLb4PjYlUVy0m1uwEIyV/z2zYMjqOrJqoDMfC5zrY4HCPyIZwk1zGR47cug9qVEMDdt8sj22+MckAFbPVR9SzZtWElSIy/k0IYwSO9UGea X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2023 13:04:48.6218 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9bfd94aa-1c7a-4e86-85b5-08db5b8e49ed X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT048.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7392 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com X-Gm-Message-State: dkgtKSShAlJc0tQhmNfSkQP8x1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1684847095; bh=e7ax0zzvDPdwzg03RDPNlM6IG2acKxBvVLOgryr+8jk=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=edFyhrSjgc3sZP4bLCv5YPBtboDYm1G22zcmCLRq6CapvglDbaoFpkzgLj+++p6klHt /dOGstB1T3BFBQwkA5Zc5WY1/QydR9acSKpOa4Woao11ue7JQeTPM1ujPK31AcCS5cXox 69BN4EYnaZkwP1tlHyV4ZWjEEwEO9XxCM8Q= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1684847096476100010 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" GICD_SGIR is a 32-bit register, of which INTID is bits [3:0] and Bits [14:4] is RES0. Since SgiId parameter in the function ArmGicSendSgiTo () is UINT8, mask unused bits of SgiId before writing to the GICD_SGIR register to prevent accidental setting of the RES0 bits. Signed-off-by: Sami Mujawar Reviewed-by: Ard Biesheuvel --- ArmPkg/Drivers/ArmGic/ArmGicLib.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/ArmPkg/Drivers/ArmGic/ArmGicLib.c b/ArmPkg/Drivers/ArmGic/ArmG= icLib.c index df61e3aad4a7899eaa888cb248ad2a285c7f317d..0127cca3bf0567bc80702f415e9= cbb9bd2709fbc 100644 --- a/ArmPkg/Drivers/ArmGic/ArmGicLib.c +++ b/ArmPkg/Drivers/ArmGic/ArmGicLib.c @@ -1,6 +1,6 @@ /** @file * -* Copyright (c) 2011-2021, Arm Limited. All rights reserved. +* Copyright (c) 2011-2023, Arm Limited. All rights reserved. * * SPDX-License-Identifier: BSD-2-Clause-Patent * @@ -148,7 +148,9 @@ ArmGicSendSgiTo ( { MmioWrite32 ( GicDistributorBase + ARM_GIC_ICDSGIR, - ((TargetListFilter & 0x3) << 24) | ((CPUTargetList & 0xFF) << 16) | Sg= iId + ((TargetListFilter & 0x3) << 24) | + ((CPUTargetList & 0xFF) << 16) | + (SgiId & 0xF) ); } =20 --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#105183): https://edk2.groups.io/g/devel/message/105183 Mute This Topic: https://groups.io/mt/99086466/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 18 21:00:39 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+105178+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=arm.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1684847087750742.0215257077999; Tue, 23 May 2023 06:04:47 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 4nDMYY1788612xTQp7ti4fGS; Tue, 23 May 2023 06:04:47 -0700 X-Received: from EUR05-AM6-obe.outbound.protection.outlook.com (EUR05-AM6-obe.outbound.protection.outlook.com [40.107.22.84]) by mx.groups.io with SMTP id smtpd.web10.21865.1684847086211348566 for ; Tue, 23 May 2023 06:04:46 -0700 X-Received: from DU2PR04CA0309.eurprd04.prod.outlook.com (2603:10a6:10:2b5::14) by AS8PR08MB9575.eurprd08.prod.outlook.com (2603:10a6:20b:619::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.28; Tue, 23 May 2023 13:04:43 +0000 X-Received: from DBAEUR03FT007.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2b5:cafe::22) by DU2PR04CA0309.outlook.office365.com (2603:10a6:10:2b5::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.29 via Frontend Transport; Tue, 23 May 2023 13:04:43 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+105178+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT007.mail.protection.outlook.com (100.127.142.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.15 via Frontend Transport; Tue, 23 May 2023 13:04:43 +0000 X-Received: ("Tessian outbound 8b05220b4215:v136"); Tue, 23 May 2023 13:04:43 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 735425f68b77052c X-CR-MTA-TID: 64aa7808 X-Received: from c110738cae15.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id E7D9FFE8-CD89-4D06-83F5-740DBEAC6F03.1; Tue, 23 May 2023 13:04:34 +0000 X-Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c110738cae15.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 23 May 2023 13:04:34 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V33rreN2sgdDcawPdlKpkjYDIZ5ryuVg5wLxzTJMnRVO5Xk+4vXWVKBHm35/9OgM42iWt0yCj9QPdTY4qI6k5Gor+3/BUMUo7QBEB6slvwt9HlvJNcMa992mhQZRi01vEG9mtw9WiDM86ecTjrdvA2sUwu8xgesviEEaXTPbg73C++qNNrU6cK3QVIqa9dJ5TFMzprEoXG7NMRKM8+M4NOozh1N0Hhic+fGcVKnNJsDAgZekDRHbVkk7e/opTAdf6wk4qFRGmi0+g4z6Yk/OgK0SdU+hSvKRIvFLGALBmkhV8x2VOHdGVsrEiMwFjXPDNTSM4vr6SKpSrX5JIfxjIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0eGWGJoXqpSaH25N6Qj2pvbwCuzmTl4ncTFVW+pB5Jg=; b=LmiPoXNjQFzqHTApBnKJPrMFb4JX5Ll8K+NK3IrH7NA9ALCD1mGEu5AB4LvMhcvPe/8OO54/26H3AmSv1nv2uud7ZxFMEBJafbeO13EQKn3begxkqF9ldadvZ2f6z4Ka7XYG+RinSM0M3fOutYZhP2VgM9DtwFsLPF5LmUGvxw90fSWQU2zvv5PUepYBkiJrTI/xjhvguzcM0zjRoW1a1rMKkZ2uvCu/mBjXlvqOkcpGcmoj76YwXgw0Nys6jb+vtcwN/H9FH/Bvs98tEkafP0QOkqpbwVlGcJPJEjbgXU6NncCc4k+n7GHk5T2bIgRTXNhPYCevyX8r9S+x7vl2JA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none X-Received: from AS8P251CA0007.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:2f2::7) by DB3PR08MB9035.eurprd08.prod.outlook.com (2603:10a6:10:429::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.28; Tue, 23 May 2023 13:04:32 +0000 X-Received: from AM7EUR03FT033.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:2f2:cafe::96) by AS8P251CA0007.outlook.office365.com (2603:10a6:20b:2f2::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.29 via Frontend Transport; Tue, 23 May 2023 13:04:32 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C X-Received: from nebula.arm.com (40.67.248.234) by AM7EUR03FT033.mail.protection.outlook.com (100.127.140.129) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6433.14 via Frontend Transport; Tue, 23 May 2023 13:04:32 +0000 X-Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 23 May 2023 13:04:28 +0000 X-Received: from E114225.Arm.com (10.1.196.36) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.23 via Frontend Transport; Tue, 23 May 2023 13:04:28 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , , , , , , Subject: [edk2-devel] [PATCH v1 11/12] ArmPkg: Adjust variable type and cast for RegShift & RegOffset Date: Tue, 23 May 2023 14:04:20 +0100 Message-ID: <20230523130421.10804-12-sami.mujawar@arm.com> In-Reply-To: <20230523130421.10804-1-sami.mujawar@arm.com> References: <20230523130421.10804-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: AM7EUR03FT033:EE_|DB3PR08MB9035:EE_|DBAEUR03FT007:EE_|AS8PR08MB9575:EE_ X-MS-Office365-Filtering-Correlation-Id: 2f9494b0-f5ad-4bd1-a5f7-08db5b8e46a3 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: HeeMorwgLEPZKc0A7FY/I3cJfEpo5gMiSDpSyf+lzYioNKfczACjCv/ZhjLjVwQHXun9u3TY1rXYWIKpcROoKm25q6akMcSWRM4KdkHAlSxbherS3nAZMYzilnrPR1UwKk97GjFo61lr+3b0UZ5PsY3NWHnM3xxj9XCEDTCsUMVnFRtzsHYLhU1LMGgpLUA8JCrOpY+8xYSRdAyvMvbIS+nVpBooOS4zyYf1Hc79tE1usggEaZk5OnQ8nsdIr9pd2bkF6Pa/gL88qmwcFe8q6NOfNpn0hliCOqB5DnoES6sN57jb7I43/dPFXlM1BaEOcW6Ko0F+/5K/zGW69m+MEh8gRhHpAQh3ZHVFUZGWewRzD8aAt6ahZ92VsSMJmuK4N1FT7FHM6oE1ZfM1RTTOMpbdBYWz885+XI1EQpjEMgakV+5jTx3knXMf1CW2CiRMmvKBbH8VRvuiSxclb7OS1j2JbmPEuGKJ+dSDgNp358JOD/kOWBQ/jQdoiBMeaGDTIHvEVhGCbWi1D3zHWhmJyeJOAFvFF5O14GS4l0Bb7u3I5x03uiEr/mKZf7Wl5BQ8Xl6vHT+zBMZXB/NUjEOrd/qvyAqR+mbYOVhbGLTnLft91rywLF/lZJn3HwbbOt90O3YlYcmWlbEMVvYotOeii3JJyTQuhE/FeTpnCzIYbs3bFIJLkjYsXqRC2uzB+JV1YcpuqfAgKwaQvVoq/NdbX2AppW+7Wzbotup8GxF6CfgpfNmvmsAEjGEQ9a1kIovi X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(346002)(376002)(136003)(39860400002)(396003)(451199021)(46966006)(36840700001)(82310400005)(19627235002)(82740400003)(478600001)(86362001)(70586007)(70206006)(54906003)(356005)(81166007)(36860700001)(83380400001)(47076005)(2906002)(7696005)(2616005)(6666004)(36756003)(426003)(336012)(316002)(4326008)(6916009)(1076003)(8936002)(8676002)(40480700001)(26005)(186003)(5660300002)(44832011)(41300700001)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR08MB9035 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT007.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 2b49c6c2-2791-4602-f4f1-08db5b8e403b X-Microsoft-Antispam-Message-Info: /1WO8rfjjJkDx1nRQ1vTVGgCQEnDJw0rXsN1dtHfa49Y5/bC3B/lm45P+rVWObMahAn+n1eInIbUK/haWKN5pim4CxCAhZtBvKsqxiax0H2exvaBnFEfcS0pYf35qhTzPVZ79tB1CT/9kskUm6NoYwBQLY+FL1hBjKpAfVt88ay2wBqEQS40Xu5sscYPMDtiKTtJ9Vdj8pqbaNKN9auMtjFD85vpQcU5yVo+8Yn3aUnQvSPttZ3p7IdLRDz3UPv6y7usfFeeG+jSQwo8xCqde+Dj5+z6KphW5NtBEMjH46XPpOMT78Spi4V09Wp6w0KRVpKM7wupJvnU5I/X0LcsGQc/ATemvqT58s4QJ13zJGQui8c/HfBg+/GA3nByUf7+aJgTc+P2BxjULL3ZQ1c2KXtlRNRKXBc2BLen0/c0plyqVYXBA15kDrAntfQd1E+wpzzOCs61qUiBsMTP6RQTgtEVzN2cv690q0er5s3yVX1aSZu0UkQZY97ks1mzwEH1OmF7kJO7kKNPkFVXvp/Q3ZDlqbgWAKcs4G8aGDfY/w/wqTE0cpDPASrx+QiaUJVh30fvanLv4x+FKPdIIlZHD4XKzmDhkWL+e6Tc2D9tXI4ZXlcmlPJTEJYpAjkaip0NHQHmUPG7D6114qtqt6K1L6FF2WeV4f+khpQQqOzPpGAvWmjI4w7hhK0Ff1TvnkMt6iDK/nIUyFkwoEOAXLMKwoSLZqxyzqmIVqOi12y5K1gPIuSexBR5wBJhw/nK6zoH X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2023 13:04:43.1358 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2f9494b0-f5ad-4bd1-a5f7-08db5b8e46a3 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT007.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9575 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com X-Gm-Message-State: oYMGvESvTe0GMp2Oq215vJE8x1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1684847087; bh=ZJ5zsBuiHdlP1RXF3N8r9HY7X28MzXjJxXbQGOX30z8=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=RjEW4i/nI8WI088eWaAD2It1lcPiQNzF68xS8ntbeuC5AVC01qD2qZb7NATI8Lervex beGU7MeCa1tpeHkRTqOx0y/E/TZ29bBlcbABmta2tj4bx0t0uB5gsg0irMUhnX0fDWFve BP1o4lIwosJb7sbgzunvWUNVhkqiuJvVnFo= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1684847088475100009 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" According to the GIC architecture version 3 and 4 specification, the maximum number of INTID bits supported in the CPU interface is 24. Considering this the RegShift variable is not required to be more than 8 bits. Therefore, make the RegShift variable type to UINT8. Also add necessary typecasts when calculating the RegOffset and RegShift values. Signed-off-by: Sami Mujawar --- ArmPkg/Drivers/ArmGic/ArmGicLib.c | 24 ++++++++++---------- ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c | 8 +++---- 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/ArmPkg/Drivers/ArmGic/ArmGicLib.c b/ArmPkg/Drivers/ArmGic/ArmG= icLib.c index 0127cca3bf0567bc80702f415e9cbb9bd2709fbc..8f3315d76f6f2b28a551d734009= 38430ff3e23c7 100644 --- a/ArmPkg/Drivers/ArmGic/ArmGicLib.c +++ b/ArmPkg/Drivers/ArmGic/ArmGicLib.c @@ -228,13 +228,13 @@ ArmGicSetInterruptPriority ( ) { UINT32 RegOffset; - UINTN RegShift; + UINT8 RegShift; ARM_GIC_ARCH_REVISION Revision; UINTN GicCpuRedistributorBase; =20 // Calculate register offset and bit position - RegOffset =3D Source / 4; - RegShift =3D (Source % 4) * 8; + RegOffset =3D (UINT32)(Source / 4); + RegShift =3D (UINT8)((Source % 4) * 8); =20 Revision =3D ArmGicGetSupportedArchRevision (); if ((Revision =3D=3D ARM_GIC_ARCH_REVISION_2) || @@ -272,13 +272,13 @@ ArmGicEnableInterrupt ( ) { UINT32 RegOffset; - UINTN RegShift; + UINT8 RegShift; ARM_GIC_ARCH_REVISION Revision; UINTN GicCpuRedistributorBase; =20 // Calculate enable register offset and bit position - RegOffset =3D Source / 32; - RegShift =3D Source % 32; + RegOffset =3D (UINT32)(Source / 32); + RegShift =3D (UINT8)(Source % 32); =20 Revision =3D ArmGicGetSupportedArchRevision (); if ((Revision =3D=3D ARM_GIC_ARCH_REVISION_2) || @@ -317,13 +317,13 @@ ArmGicDisableInterrupt ( ) { UINT32 RegOffset; - UINTN RegShift; + UINT8 RegShift; ARM_GIC_ARCH_REVISION Revision; UINTN GicCpuRedistributorBase; =20 // Calculate enable register offset and bit position - RegOffset =3D Source / 32; - RegShift =3D Source % 32; + RegOffset =3D (UINT32)(Source / 32); + RegShift =3D (UINT8)(Source % 32); =20 Revision =3D ArmGicGetSupportedArchRevision (); if ((Revision =3D=3D ARM_GIC_ARCH_REVISION_2) || @@ -361,14 +361,14 @@ ArmGicIsInterruptEnabled ( ) { UINT32 RegOffset; - UINTN RegShift; + UINT8 RegShift; ARM_GIC_ARCH_REVISION Revision; UINTN GicCpuRedistributorBase; UINT32 Interrupts; =20 // Calculate enable register offset and bit position - RegOffset =3D Source / 32; - RegShift =3D Source % 32; + RegOffset =3D (UINT32)(Source / 32); + RegShift =3D (UINT8)(Source % 32); =20 Revision =3D ArmGicGetSupportedArchRevision (); if ((Revision =3D=3D ARM_GIC_ARCH_REVISION_2) || diff --git a/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c b/ArmPkg/Drivers/Arm= Gic/GicV2/ArmGicV2Dxe.c index fb40f56ff9231f3a28c3d90939bfd25ac3432f89..ba43150fe57015994573d82c88d= 6a8d9f3174533 100644 --- a/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c +++ b/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c @@ -2,7 +2,7 @@ =20 Copyright (c) 2009, Hewlett-Packard Company. All rights reserved.
Portions copyright (c) 2010, Apple Inc. All rights reserved.
-Portions copyright (c) 2011-2021, Arm Ltd. All rights reserved.
+Portions copyright (c) 2011-2023, Arm Ltd. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -393,7 +393,7 @@ GicV2DxeInitialize ( EFI_STATUS Status; UINTN Index; UINT32 RegOffset; - UINTN RegShift; + UINT8 RegShift; UINT32 CpuTarget; =20 // Make sure the Interrupt Controller Protocol is not already installed = in @@ -408,8 +408,8 @@ GicV2DxeInitialize ( GicV2DisableInterruptSource (&gHardwareInterruptV2Protocol, Index); =20 // Set Priority - RegOffset =3D Index / 4; - RegShift =3D (Index % 4) * 8; + RegOffset =3D (UINT32)(Index / 4); + RegShift =3D (UINT8)((Index % 4) * 8); MmioAndThenOr32 ( mGicDistributorBase + ARM_GIC_ICDIPR + (4 * RegOffset), ~(0xff << RegShift), --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#105178): https://edk2.groups.io/g/devel/message/105178 Mute This Topic: https://groups.io/mt/99086457/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 18 21:00:39 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+105182+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=arm.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1684847094800414.7609478549077; Tue, 23 May 2023 06:04:54 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id iVXSYY1788612xSKdgcjBQ8P; Tue, 23 May 2023 06:04:54 -0700 X-Received: from EUR01-VE1-obe.outbound.protection.outlook.com (EUR01-VE1-obe.outbound.protection.outlook.com [40.107.14.81]) by mx.groups.io with SMTP id smtpd.web10.21869.1684847092747448149 for ; Tue, 23 May 2023 06:04:53 -0700 X-Received: from AM0PR02CA0224.eurprd02.prod.outlook.com (2603:10a6:20b:28f::31) by AS8PR08MB7307.eurprd08.prod.outlook.com (2603:10a6:20b:442::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.28; Tue, 23 May 2023 13:04:48 +0000 X-Received: from AM7EUR03FT011.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:28f:cafe::3d) by AM0PR02CA0224.outlook.office365.com (2603:10a6:20b:28f::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.29 via Frontend Transport; Tue, 23 May 2023 13:04:48 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+105182+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT011.mail.protection.outlook.com (100.127.140.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.14 via Frontend Transport; Tue, 23 May 2023 13:04:48 +0000 X-Received: ("Tessian outbound 5154e9d36775:v136"); Tue, 23 May 2023 13:04:48 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: f1e12b647088cb12 X-CR-MTA-TID: 64aa7808 X-Received: from bc4f8fa32982.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 999F69AC-3EF3-42C0-949D-ECB7302634FD.1; Tue, 23 May 2023 13:04:37 +0000 X-Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id bc4f8fa32982.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 23 May 2023 13:04:37 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PTReplQAHsdMc79SAmq8h2ipQTy5Bb5/5HbH6Eb72dylTYn1+AKdPXzX0KvBA2JtmAJEZ9gVQflZvQmO6fnLQDi3W3T2BHQdysZkPhJsgwCKsliRrpW9P0bhgV9pLcun4al87fahd8DvAbYGQUN+M/UG7DyKZY7VaJ4MgjFdMz9D9MPgfrrOOi7QIv/IwpgibY+G33r4BotTNPKNASVVBnrZGkqLkGXS/vYmFjFoiyZkrj1cNV64daIhre+ZMAuz78n1wxDzPLSiinYTIgUzZnpQSrq/Xx6N0F0kc/8CB9jiF2/xz9cu9ZqxNc4U1np9G+iX+mqOg03b4xsEFZ+J9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AgTfk0XmxsX9zz+JKu4cKRYQg+A2fY6fr1ZDPecD83o=; b=aulTO0EFKVfJCg6H0qRU1T4VG7/o5J3w5aZMn64elS23tauzfQijux/aD2BPhAyRFOK8lsiK9Ce1c3NU4uRk4tW/MAwGqc6ubHMmxgED1aoX1LsD2qrw5a2nT0RMIzY0AlJYhPrsLhqSen5eufbCnD1RLJBtIWiRqIutHHW8DVzAMrWXC7Od1pjJpqjdOMCmswoH7BM1bL1YA7g7A/3lsdASraviqkpw7mz6msERm5xcdZMeHZbwNg1JEr4dgG9yS/WtixpvsKvP0B/Ctpuqi1Dee24CRCiw1dmnAhf0mrmIbupRyhSKmjPfMRejCqiBHMn6E59ZKR2Wr8zHz0+mWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none X-Received: from AM6PR02CA0010.eurprd02.prod.outlook.com (2603:10a6:20b:6e::23) by PA4PR08MB5919.eurprd08.prod.outlook.com (2603:10a6:102:e0::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.21; Tue, 23 May 2023 13:04:34 +0000 X-Received: from AM7EUR03FT051.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:6e:cafe::ea) by AM6PR02CA0010.outlook.office365.com (2603:10a6:20b:6e::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.29 via Frontend Transport; Tue, 23 May 2023 13:04:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C X-Received: from nebula.arm.com (40.67.248.234) by AM7EUR03FT051.mail.protection.outlook.com (100.127.140.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6433.14 via Frontend Transport; Tue, 23 May 2023 13:04:33 +0000 X-Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 23 May 2023 13:04:29 +0000 X-Received: from E114225.Arm.com (10.1.196.36) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.23 via Frontend Transport; Tue, 23 May 2023 13:04:29 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , , , , , , Subject: [edk2-devel] [PATCH v1 12/12] ArmPkg: Fix ArmGicAcknowledgeInterrupt () for GICv3 Date: Tue, 23 May 2023 14:04:21 +0100 Message-ID: <20230523130421.10804-13-sami.mujawar@arm.com> In-Reply-To: <20230523130421.10804-1-sami.mujawar@arm.com> References: <20230523130421.10804-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: AM7EUR03FT051:EE_|PA4PR08MB5919:EE_|AM7EUR03FT011:EE_|AS8PR08MB7307:EE_ X-MS-Office365-Filtering-Correlation-Id: 2c791ca6-9609-4284-58cc-08db5b8e49f4 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: BETJcFkTvBEwlSXq4YLS+xPpjvDlLTKkQZyqe5hVlTALp7lZlXdE45WvoV8Q/KjLeYMvkp8Iji1IwQB4UA4EJolkQShNY3zpiZ6fW/PukPOpNrSraIxVZC1fTwqCtU6NgirPgiDq35MXxqBz22wzbq73VYOcYS4KkXvZOJcRkijzJohcWXOPeQsUbqge3T0lMzRkV3gwwJMBh3Tj5DiOn1qYQrjkJwk2pM6wWrnl6z/Zd8c6KvFn9t5JgaC1BuDNafTvxPnnz7A1/3hYErl0qD1ZzFRWFIzQzVbpZko6kVtivwRDyoLqtYXCqt96eJEQKbcWMFrBoVv6YRzn97cqQC3Xqu8CWSXEkNWCiMYQJ6wkbnlUMyeVkPqgi4OFt3+YtMy5N2SS0mrVvqvB8n9U5P+yS4ABaJI4xxHyLqNE1My9dfTRRQQxgMKdah2nKeFQpHc4dBoOIX/R3mqIgKfG51Je2ics97e05PW2ALYRpoSeJsl6lj6XrsRnaj2AEsp8kd7LHFy1h4a3ZU65ZGgb1q0tfZ5KFAxFH/vin+C71MzLnkzSYiu3rgjYdoIH8DtNYW5zlWVsNxaNuSUOQZgLHIdWPtGmpHtbKSVy8Okowh2TTBb1wgWfBOaWEGp7u35YIR9DyN8Gum9Trb+0k7vG/q0PgykC5IlbSNxy4twzF4GM7Baiaih7gPVelkpC6uFY82JldeEGt9+Rl5/4diIvZvR+YZn0KxI4CJLPajRyRi7++8JBMbrrDa/wmtaTGm5WUYYlEH0pUub5fWUCN76liw== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(376002)(39860400002)(396003)(136003)(346002)(451199021)(46966006)(36840700001)(40470700004)(8676002)(8936002)(478600001)(426003)(336012)(40480700001)(7696005)(54906003)(41300700001)(44832011)(5660300002)(4326008)(6916009)(6666004)(316002)(70586007)(70206006)(19627235002)(186003)(2906002)(1076003)(40460700003)(26005)(2616005)(82740400003)(47076005)(83380400001)(36860700001)(82310400005)(81166007)(356005)(86362001)(36756003)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB5919 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT011.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: aeba318f-c9ae-4b34-abcd-08db5b8e4116 X-Microsoft-Antispam-Message-Info: 9MPq+zQWktE9sIzEcODDETxgLuhvZzgpkITUPPbmBvPEik+r+sUIorRG68mN4VRSGTp+cROBdEQTo2tbB4JOed1G3iYSAAx3RARLNOq6yhyXmef9cqw5a3mHdcpkBpwk8+S/xAZuRuASD/ik3YZEocgf4COcJcLFxRrmGvrxRiGReum/QdQPKwbv0t7iTs/uFRV83aM109LeDhxWkcNICTthsq/tTDymN/NEbF+EsxPC9c091fqRMWqdM9STgRxbSOnueFRccn7Bh1VLNoYRBoR95EUn89imw28QyXbMlD2k2yhfy09E5E6wz4JLa5R/c8Wzuv3WVtiNb/PzJXEtQE+HDzJybqXoAG8eSDxbQOR4X3vmSPqnlhTR0ftXgwsWmdbgsfy9dDyp6fOiyzZderrG168ey1mbD2/1h4ZAe2tnVhLzlUOgrprzCdeXGAGI8cs7DhArSLBDHWOarWozjZTeEdZp3nHwxd6crpEbNV6SXpJ/DqKKPGrEKTVbp2q82BYd4vIQdc30PMF76qXC27M0YWeBs6R2+VbxS/NuYqbN8JH+rd/PbkCTzEJO7c87B902Cwrj/1t3wS6lvBZ1Ee7AqxLp6NF7RmI3O/lpUs+aNsNQO1PMF71Xtdp4F9qkqGDIyOCyiLn4UZlkkP939B0jhXFMbeoHiknVUQWNmfANDa/j4e9nHybiaZGaZ3Ay/CFXBMrrrN+BDURtz60WH5aeP3tkEyi7pyXR7mo8tMxKlvRuyxFxX+1kUFH6CMMM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2023 13:04:48.6666 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2c791ca6-9609-4284-58cc-08db5b8e49f4 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT011.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7307 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com X-Gm-Message-State: 8BmATQzU78vEINNbakqUE1qJx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1684847094; bh=s1HY/5mJgkTH9JHD7RGNxxoyNXdHFp+vwo2VjKMV18c=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=mNmRA9yjX3SgDw+zmtKZ28UtJpPJCjG/856NonoDqpmaYZmjugXJmdoAQ9dkqqGN28N wwXzpiDy2j/gC/PHX3i4QYR4FAbItPtbbVJFxzNvbKQMB8cfWsv0YZN3I05ICxMRcc3Sx Ji5TWJjYheRmZAv/iCLR0r3PwSHzpNZ+vGk= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1684847096466100008 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The ArmGicAcknowledgeInterrupt () returns the value returned by the Interrupt Acknowledge Register and the InterruptID separately in an out parameter. The function documents the following: 'InterruptId is returned separately from the register value because in the GICv2 the register value contains the CpuId and InterruptId while in the GICv3 the register value is only the InterruptId.' This function skips setting the InterruptId in the out parameter for GICv3. Although the return value from the function is the InterruptId for GICv3, this breaks the function usage model as the caller expects the InterruptId in the out parameter for the function. e.g. The caller may end up using the InterruptID which could potentially be an uninitialised variable value. Therefore, set the InterruptID in the function out parameter for GICv3 as well. Signed-off-by: Sami Mujawar Reviewed-by: Ard Biesheuvel --- ArmPkg/Drivers/ArmGic/ArmGicLib.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/ArmPkg/Drivers/ArmGic/ArmGicLib.c b/ArmPkg/Drivers/ArmGic/ArmG= icLib.c index 8f3315d76f6f2b28a551d73400938430ff3e23c7..7f4bb248fc7225bf63f0aea7204= 86092b30ced10 100644 --- a/ArmPkg/Drivers/ArmGic/ArmGicLib.c +++ b/ArmPkg/Drivers/ArmGic/ArmGicLib.c @@ -176,19 +176,17 @@ ArmGicAcknowledgeInterrupt ( ) { UINTN Value; + UINTN IntId; ARM_GIC_ARCH_REVISION Revision; =20 + ASSERT (InterruptId !=3D NULL); Revision =3D ArmGicGetSupportedArchRevision (); if (Revision =3D=3D ARM_GIC_ARCH_REVISION_2) { Value =3D ArmGicV2AcknowledgeInterrupt (GicInterruptInterfaceBase); - // InterruptId is required for the caller to know if a valid or spurio= us - // interrupt has been read - ASSERT (InterruptId !=3D NULL); - if (InterruptId !=3D NULL) { - *InterruptId =3D Value & ARM_GIC_ICCIAR_ACKINTID; - } + IntId =3D Value & ARM_GIC_ICCIAR_ACKINTID; } else if (Revision =3D=3D ARM_GIC_ARCH_REVISION_3) { Value =3D ArmGicV3AcknowledgeInterrupt (); + IntId =3D Value; } else { ASSERT_EFI_ERROR (EFI_UNSUPPORTED); // Report Spurious interrupt which is what the above controllers would @@ -196,6 +194,12 @@ ArmGicAcknowledgeInterrupt ( Value =3D 1023; } =20 + if (InterruptId !=3D NULL) { + // InterruptId is required for the caller to know if a valid or spurio= us + // interrupt has been read + *InterruptId =3D IntId; + } + return Value; } =20 --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#105182): https://edk2.groups.io/g/devel/message/105182 Mute This Topic: https://groups.io/mt/99086465/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-