From nobody Sat May 18 19:48:03 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+105021+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=arm.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1684401006397287.6345128772233; Thu, 18 May 2023 02:10:06 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id WY2zYY1788612xY0lax2goAV; Thu, 18 May 2023 02:10:06 -0700 X-Received: from EUR04-DB3-obe.outbound.protection.outlook.com (EUR04-DB3-obe.outbound.protection.outlook.com [40.107.6.87]) by mx.groups.io with SMTP id smtpd.web10.12801.1684401005115467074 for ; Thu, 18 May 2023 02:10:05 -0700 X-Received: from DUZPR01CA0145.eurprd01.prod.exchangelabs.com (2603:10a6:10:4bd::12) by GV1PR08MB7937.eurprd08.prod.outlook.com (2603:10a6:150:8e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.19; Thu, 18 May 2023 09:09:52 +0000 X-Received: from DBAEUR03FT061.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:4bd:cafe::29) by DUZPR01CA0145.outlook.office365.com (2603:10a6:10:4bd::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.19 via Frontend Transport; Thu, 18 May 2023 09:09:52 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+105021+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT061.mail.protection.outlook.com (100.127.143.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.18 via Frontend Transport; Thu, 18 May 2023 09:09:51 +0000 X-Received: ("Tessian outbound 3a01b65b5aad:v136"); Thu, 18 May 2023 09:09:51 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 69a9f4687ba253bc X-CR-MTA-TID: 64aa7808 X-Received: from dfe864fc23d9.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9F40790D-1C3F-4D46-86F8-631F4FA8946A.1; Thu, 18 May 2023 09:09:40 +0000 X-Received: from EUR02-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id dfe864fc23d9.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 18 May 2023 09:09:40 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mqQHiaKsPNNWz9So0nkEwVEvtLy4Z/dncacclSzSrAHXbqrHJxKgFNlTSbBp9okyGNG8snDbDnm1GEouJLoR+W2ZJP4Z9fphVIpmteXYzb08OxUe7LcYvM8U6IUMJzj+Lobk0f15qULDwPON+rrfsu5TWKLqZ7zJvE7liIEfYCkyP9UOD5x/22NvkH9ntj0aQ8VUTZ0opjQ3Iu3scXPXrlA30QmcW/DIjZ8p9dzCOT6Q7TsoG/TIAXpHCBqaZu97t3MwRiAyuYsmbOa6zDNwZletIzH4UTtcSXjKXnjezKxv3LY1o5G2KdmQYIt/xf9iK7TB9Q3qOXoCILqE+tMs0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gpfzZFKtuOzUW19xnuK8wzj5KIF1D8MGFtq78PSJ7fY=; b=G6DTQQtxI6Hf2inGjWuxDWKzszucCEHl2ok42tZg3GPH6NMI+SGrvfvTZ9/94Pt2XxwkU/ZirLMEb+n4dT7JO4inn3RPsSDBFPzW/p1vATZfKvnqmaNkhFrNvG+hODYNofbykW7Wp7e2WYaZxSOu86tFIddBYo1UJ8GXumD00DqVRkY2326zV0sjJ2F9vpmvJSakuDif2UDL5+dYKaLTFWHF5MRhJ/iXTWFhU7PeVQtUTqJyHmInvv+GeSU4xG3qlIxuGWwEuyVsNyY5uXtHc97N3dIshXwwvJ7rET0fdUXJhYTBJg4tCSsD/8T4pbJktEkL90M/SUVHzkL9BC/Atg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none X-Received: from DUZPR01CA0170.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b3::28) by PA4PR08MB7618.eurprd08.prod.outlook.com (2603:10a6:102:273::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.19; Thu, 18 May 2023 09:09:37 +0000 X-Received: from DBAEUR03FT050.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:4b3:cafe::7d) by DUZPR01CA0170.outlook.office365.com (2603:10a6:10:4b3::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.19 via Frontend Transport; Thu, 18 May 2023 09:09:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C X-Received: from nebula.arm.com (40.67.248.234) by DBAEUR03FT050.mail.protection.outlook.com (100.127.142.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6411.19 via Frontend Transport; Thu, 18 May 2023 09:09:37 +0000 X-Received: from AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 18 May 2023 09:09:37 +0000 X-Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 18 May 2023 09:09:36 +0000 X-Received: from E114225.Arm.com (10.1.196.36) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.23 via Frontend Transport; Thu, 18 May 2023 09:09:36 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , , , , , , Subject: [edk2-devel] [PATCH v1 1/6] ArmPkg: Configure PcdEmuVariableNvModeEnable as a dynamic PCD Date: Thu, 18 May 2023 10:09:30 +0100 Message-ID: <20230518090935.10984-2-sami.mujawar@arm.com> In-Reply-To: <20230518090935.10984-1-sami.mujawar@arm.com> References: <20230518090935.10984-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: DBAEUR03FT050:EE_|PA4PR08MB7618:EE_|DBAEUR03FT061:EE_|GV1PR08MB7937:EE_ X-MS-Office365-Filtering-Correlation-Id: a071f599-3cee-416c-5fd0-08db577fa386 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: wBdQrKc5qmXCtu76SSkJL5zqUig9d3h9qXDJqnzY1xljSUB8Nis1ZF8iZqovaTjbsTxm/wA0ltYtZ+Ra2mnlmL1MWEw/f4VMfVwV4t7CMhXu8BarxzEW3Fg0z/Xob53GjzHWi4opWQYnPzUSW9bEkHSvbcUor3b3NX0iR8HtHa0xae4WGhpBsr1CTGLyNMAdGXGf6Isc8yFAQaHap+tJAMMglrS22Ttw9tomCwurE0yCVQ9iZMHId1va0SdxuWqzviMZFEITfu1+tWsHg4eiObDMpH2+UyOT/53CJcz7nuHeDrpV1kG8/SIUBqWVqwwb364OlSwELn/0uzvNvA/TNI0vGEQHcovGt2x2U6KaWCG6nbcMMwuzak8kCSeeAT0zKT5ZUttYIhTSAMmrisLCDNuA4/u1WIp9lxP+j96qGQPoeF07aRk7zQG2BHb4gGrX9jzxubqU7CiCKR0zmmJtMpKGseRVfvAYAobKbXhTe/zO4dC3Etb6sYUJIShaOv1QTFDhoL52uMJ3mxQ/UuqD+vxZ4zSM9COxpCGL4pCtc+t3UufxHGQfturX2+t3uvpz1txxhYBHke1idwUhdCuCPDjqVB69D/KyTUCBb046RbwuCkBVb1Dr4J0ccKjjRzxfHW3940QT9ljV9lW5VYp6DibmjaVOQVBwWSa0uhpwPM0m4PBaJVunf56tevXh2Hh9JJzcf0hd2mtnYOqKyApmHkpxI/SRyEUZ+5yI/TjTXbswllP9qRr/pNlhUBq9+fcZyMWC2XdrkZBkPsSGvnseBw== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(6029001)(4636009)(346002)(376002)(39860400002)(136003)(396003)(451199021)(40470700004)(36840700001)(46966006)(26005)(40460700003)(1076003)(7696005)(36756003)(36860700001)(83380400001)(2616005)(40480700001)(47076005)(336012)(426003)(86362001)(82310400005)(356005)(81166007)(82740400003)(186003)(54906003)(44832011)(478600001)(2906002)(316002)(4326008)(8936002)(8676002)(6916009)(41300700001)(5660300002)(70206006)(70586007)(6666004)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB7618 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT061.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 467fc875-db1a-4746-fa8b-08db577f9af2 X-Microsoft-Antispam-Message-Info: HTIAL2rrmQQVWPEur8fxz3KuOaQ+2y9f0JYeMiY9Ndw1hSTK1/IWoTTn+0XZutMO/ETjA83Upf5tMi3s6xSLVASJwUedn+1WwtleedyEw8pv+MnZUO6NSKfQla/7LWOyGfGh/96cIn2ON4Degiy2EAh4CdoxjQn2V5r9yjWtAa4Kb3edsrwJOgWCYfly2bKUOOvdvZZvjXzjKgizSNtu0daRvHT8dGm3+LYgYq0Q3OCQNq+cQZ+mrve+fb8Sen2gkKZIb++7zXYs0JsaqMHYhHin1UkCRlpoXu0eMu45s1z63hbh4DQxNCB1548qmlqpWv8Xk9EGI0chpTPlk7uG0Nbk8UwhjDx9lTaMRHz7CL2uFfs7E3n+ZbiTYgYXGFAN3UINatBVrGDz1RrumEdTCBaUMuP6O/xZvMmc8UddR+yZc7eIdY/QWf6vJNq7Xupfozrr7rMMmhaqn4zWG4xrJHoOw8IkojHs4S4G++Pyki2apCcLxYfQFsugj1nlOTcXmZVKVHC3+UVrLumomP3B+AYuLqF+zEoC6lIE70/YABFzFziYBGno75hR2NC+BUB6xN7EpBQZAlDXUUh6BrEjVYsQqaQX0amu6LqO5UgT53IUck1ko35oRXWn+t+XdHqD/1rE9m1sA/nHN1ouVRzPSMXcBwjliUcc+9tvU+uG6Go8/eQvz6MsWqBxTRYaQJ8qGWtC/dG/Jo4zpdCtAqZXHPmoAz2n1+VGjCp/zYlB2GI8KjeNh7yPeaHvVuS8ea4a X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2023 09:09:51.8856 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a071f599-3cee-416c-5fd0-08db577fa386 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT061.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7937 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com X-Gm-Message-State: JuzxgL6l5zqEv8LemwONi34yx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1684401006; bh=wNnjyJGEO67i+PXzuocXGiTVs5cUHsnmRT53n0SckvI=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=n30LyzVZR/fYh2OmXZ4FkPKyL0S7oCRFihAZy9XfYqPLF6/S7gDgPotspogqZxl2xdH t5ewssnJIBdOOMOOj2eIT/RabA3gwRWhXB12jZ4I1dxqCa3xo4XK8GUcTmo8GovYwEau3 dFn8s1JZQFBieCO+G+4QIrFy0DC6Oyz0wIo= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1684401008259100003 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The PCD gEfiMdeModulePkgTokenSpaceGuid.PcdEmuVariableNvModeEnable indicates if a variable driver will emulate the variable NV mode. This PCD is defined as [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx]. Some firmware builds may define this PCD as a dynamic PCD and initialise the value at runtime. Therefore, move the PCD declaration from the [FixedPcd] section to the [Pcd] section in the platform boot manager library file PlatformBootManagerLib.inf. Without this change the build would not succeed. Signed-off-by: Sami Mujawar --- ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.i= nf b/ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf index 05ed46456cc482d735490ad4418aa75a1b331aa7..bc029be635f26fa29731a413910= 9d0f5eb177054 100644 --- a/ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf +++ b/ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf @@ -57,7 +57,6 @@ [FeaturePcd] =20 [FixedPcd] gArmTokenSpaceGuid.PcdUefiShellDefaultBootEnable - gEfiMdeModulePkgTokenSpaceGuid.PcdEmuVariableNvModeEnable gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString gEfiMdePkgTokenSpaceGuid.PcdUartDefaultBaudRate gEfiMdePkgTokenSpaceGuid.PcdUartDefaultDataBits @@ -68,6 +67,7 @@ [FixedPcd] [Pcd] gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut gEfiMdeModulePkgTokenSpaceGuid.PcdBootDiscoveryPolicy + gEfiMdeModulePkgTokenSpaceGuid.PcdEmuVariableNvModeEnable =20 [Guids] gBootDiscoveryPolicyMgrFormsetGuid --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#105021): https://edk2.groups.io/g/devel/message/105021 Mute This Topic: https://groups.io/mt/98987546/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 18 19:48:03 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+105019+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=arm.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 168440100252899.04757805527186; Thu, 18 May 2023 02:10:02 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id phXVYY1788612xFCjGkbVU8j; Thu, 18 May 2023 02:10:02 -0700 X-Received: from EUR04-HE1-obe.outbound.protection.outlook.com (EUR04-HE1-obe.outbound.protection.outlook.com [40.107.7.59]) by mx.groups.io with SMTP id smtpd.web10.12799.1684401000952269112 for ; Thu, 18 May 2023 02:10:01 -0700 X-Received: from AM6P194CA0033.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:90::46) by PR3PR08MB5819.eurprd08.prod.outlook.com (2603:10a6:102:92::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.19; Thu, 18 May 2023 09:09:52 +0000 X-Received: from AM7EUR03FT004.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:90:cafe::f1) by AM6P194CA0033.outlook.office365.com (2603:10a6:209:90::46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.19 via Frontend Transport; Thu, 18 May 2023 09:09:52 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+105019+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT004.mail.protection.outlook.com (100.127.140.210) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.19 via Frontend Transport; Thu, 18 May 2023 09:09:52 +0000 X-Received: ("Tessian outbound 99a3040377ca:v136"); Thu, 18 May 2023 09:09:52 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 301798a32c53fe59 X-CR-MTA-TID: 64aa7808 X-Received: from d6931e1e5f81.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2E4A4E6F-1082-4732-BB7A-725F351A55B4.1; Thu, 18 May 2023 09:09:41 +0000 X-Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d6931e1e5f81.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 18 May 2023 09:09:41 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gTb+4wr+aZvh3d1742wUB+eh4s0GTWBUm70UOTR+ag/CATH5bYTsXJceiylYNmBffQoAiqBIJ3DIMDZy6FaSX5Y+/Hm9HJ/IM80XvmCqmvdIm/8kc6ibJ2DSPFZnlc2+62LP3nlxOFhWDFqKPregz3JSj8JBOwRHKHGnueaNJJoGHRinm0VPIPo7QfKZ21BlnkBwBeK8v71f4G3UDCy7X3YHihJNwYDkjApIVPa6ot0SqKk+wrjTuIqrO+TOOiNzjyCDbozCb/T8hn6Q1gGEdDR6PkPWdF1DAVFScdIL3t+B0psYLTfz/v7rNwEOGJyHWQ9d85486tsE00EsH6OlHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wuPsKTPSr6EpYO3aOnyOjIwA9j725Griq7G+aTvkVEo=; b=bYxhol68f3OtJnZWERQAbtvGE3ip+o7NZBU4+A0g4Opn8RWLd7cR6bcbL+d/lor++6DP5jKgZiVCI6mlzer9Kx8Kj1V54LKhd3KODlInVuqCoLAS4dVhrqMIOu3HRpL6px+54jUlQrQt29JERb63FJLUUr3a1nerx+HkoR/fxIDf7CtEd87JwN496qgA+/mMwzHx+gC0zWbOYChcjA5nL4S0DuoXBSYU+qYBzIPxAsYjXHCLxndoXHcrD3+DozjDtBrMRYPzcLrwzfK/oMuTpYF2x+kZFjK211W2Pgmj/XwDpGRUMjkC2b4wzcQFhmpAC2sND22YmkpVt4yuxgYvdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none X-Received: from DB7PR05CA0048.eurprd05.prod.outlook.com (2603:10a6:10:2e::25) by GV1PR08MB8035.eurprd08.prod.outlook.com (2603:10a6:150:98::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.19; Thu, 18 May 2023 09:09:37 +0000 X-Received: from DBAEUR03FT018.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2e:cafe::cd) by DB7PR05CA0048.outlook.office365.com (2603:10a6:10:2e::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.19 via Frontend Transport; Thu, 18 May 2023 09:09:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C X-Received: from nebula.arm.com (40.67.248.234) by DBAEUR03FT018.mail.protection.outlook.com (100.127.142.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6411.18 via Frontend Transport; Thu, 18 May 2023 09:09:37 +0000 X-Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 18 May 2023 09:09:37 +0000 X-Received: from E114225.Arm.com (10.1.196.36) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.23 via Frontend Transport; Thu, 18 May 2023 09:09:36 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , , , , , , Subject: [edk2-devel] [PATCH v1 2/6] ArmVirtPkg: Define variables for emulating runtime variables Date: Thu, 18 May 2023 10:09:31 +0100 Message-ID: <20230518090935.10984-3-sami.mujawar@arm.com> In-Reply-To: <20230518090935.10984-1-sami.mujawar@arm.com> References: <20230518090935.10984-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: DBAEUR03FT018:EE_|GV1PR08MB8035:EE_|AM7EUR03FT004:EE_|PR3PR08MB5819:EE_ X-MS-Office365-Filtering-Correlation-Id: 21e1436c-cee5-47aa-0e9a-08db577fa3d0 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: F9yEH9WQ7ldaJ05WohQOj/msQJE9dfmDEW5ZwBcbDG2SZFpO7yK1wudGg1LFovObthYqo4AwTWmJKqGYoIqJ8BvaaxhAYOpUJcbuaidsIaDqpePxgH19UMutpbAXNiwdvbXEIf4OtDDUPqpaDi4FgAj6YbmPiU2Hd1hNBaAd/EvdIyb9rs8YHHWT6gD9O/3cCGFifaLhwvBsETHN8A+FYtxy09sRJg9JSbw3BO8/LoJZcl55e+z5IRc7st7ZPFSB/AxUENWM944iwI0dG6NXfhQa7rfRrNpwKfWXdtfyZqJBWSTwUf7aN8GI047T9WhYYeRW00K3XsQlASinp4QbDsn8g3uwTsceaUQI7FPQtDtXtZIlF/ggGNksKZHBRHEag6TsMf2pNnvBtaNbMfEI3SV6oIkFx69xndlPoGydaQb6hfnzhdDBYr/kYoZ9FHVGElvk/EJPRgndW58VY20ONTJYrlRTBN+49bPUYMjUcyj2wLhdo/SAaVf7PvWJrAkJUvQwURl0gfaXdyKW7HcKw+4epVpenVTs+4tuzK+DlS1yFCRGYIxhVfmW1baSazOqjtstLoFvW5U0ODvn9SyWwAz9pPoDVsyANeHdSCCf2HijpiHle3MhnU7G/em1AYXktstO4hssah0evvdbPLDxrNk8huunW4DxuxhmY8g7k5HCaUIZQjuiFmLPw9YW48krrRZBA4B5+od8oOpvFxgAF3nBChm6ePDO5ymGsxbzqGT/WGvoLDssqiAM3Y5CSv4STtJsFfOQXB0WI9tIg/tHKA== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(39860400002)(376002)(346002)(451199021)(46966006)(36840700001)(40470700004)(40460700003)(1076003)(26005)(186003)(36860700001)(47076005)(426003)(2616005)(83380400001)(336012)(5660300002)(6916009)(70206006)(44832011)(70586007)(4326008)(316002)(41300700001)(8676002)(8936002)(6666004)(7696005)(54906003)(40480700001)(478600001)(2906002)(36756003)(86362001)(82310400005)(356005)(81166007)(82740400003)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8035 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT004.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 0fac6927-9d55-489c-000a-08db577f9b12 X-Microsoft-Antispam-Message-Info: TWLM9FpeoNXJD4fvXCSvCAmhKQ2GtUgvnRG8F1XxZBHBi04P1UojghX7bUQbELdnbAFg0QneCF9q+cLp7/Xx+rF7VEEO0ODdm/g25GcLYSjR9Tvx+L3SbDbDldV0D6GXL/EdzTCTPRJG4oCOx9FCFkxRutNS6xn8CKRLciwYkZZSXbH45oQPOw9CyebEdfhGJt85wH7NC5GDqf8m1P5SBGNQ3s9YMDR0ZFF83SwKO+cDzga84WmGpZqj/Sx6eHlOXWHLO2yBeirGxVkeKTWMocuQ8b1gbKZjbfdTkaVNLoQUhPaBmDzpWVt+WjHuaW6eDI8lFlyNLCzNAnflYMuo36ROtIcsEc1PpwVzi7ZJexAqHTIfmClyvEpYfnu1/dlKZW1K8clJ7PAQ+FgpXDyCyJ+NgWx+HsiBSl20tIXcAIPBn89wcAyH/wHCQuFjYq0UiW4y/RUrYYEqipi/I8+YF+ToZ+qeK2Y+RVAHXoIzQp4SL91MaNA+P9VPnJpwcv1Prmlx0DrYnPd7CDss/4TouJCHb3LF3RntwCdoBMpY5BCzJpBXkbUexw8f/J6wbG1EXqUXm7K4f2mT0K/5+p6eNsgBMBRLI3g2vFg6/dOHXVl14x7sL186+6Ykrp9aTd++V+7NjEzEtlTV53P5FuzCVgQ7/Xqjead6Uxt3gn0xEoMGwT5M3Or2qZRoijlU5xUhryvaAAyMvDZp91HirZGgGf8fhOtlUY7QSQhSlcgzGiFsVxNtt6/TcCh8PYN/9CQP X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2023 09:09:52.3372 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 21e1436c-cee5-47aa-0e9a-08db577fa3d0 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT004.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5819 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com X-Gm-Message-State: permhlRyUx7x5ggyjxm7GOGIx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1684401002; bh=Y557+E7KFktRXhCF4lzMno86K3d6Mq8bO1/BqeV9tnc=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=sTz34++5+5APm3lwBT1+RODHh0Mzq+QtckP+X2o4bdWI15l0quppl4pRe0nt2HvZgYr SGVS+PZsbISqu4aCN2DB/jnhu/R1IiNKvURDJBreoFz2DtklIodUdC8jXY+AItydEVjVI FYIlOafDwjgwW0wct/TbzXpVxJoofyfVMAE= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1684401004243100019 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Kvmtool allows guest VMs to be launched with or without a CFI flash device. When the kvmtool option '--flash ' is used to launch a guest VM a CFI flash device maps the flash file that was specified at the command line. The NorFlash driver uses this flash as the variable storage backend. However, when the above option is not specified, a CFI flash device is not present. In such cases, the firmware can fallback to use emulated runtime variables (which uses the VMs DRAM as the storage backend). Therefore, define the PCD PcdEmuVariableNvModeEnable required to enable the emulated runtime variable support, but do not enable it by default. The firmware is expected to dynamically discover if the CFI flash is present and subsequently enable NorFlash or emulate the runtime variables. Signed-off-by: Sami Mujawar --- ArmVirtPkg/ArmVirtKvmTool.dsc | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/ArmVirtPkg/ArmVirtKvmTool.dsc b/ArmVirtPkg/ArmVirtKvmTool.dsc index d0afe1b49e250c554313c2077b89650d6f6d67cb..25920ab4ae3cce20fdbe8e9ff7e= 25b8696d2c851 100644 --- a/ArmVirtPkg/ArmVirtKvmTool.dsc +++ b/ArmVirtPkg/ArmVirtKvmTool.dsc @@ -1,7 +1,7 @@ # @file # Workspace file for KVMTool virtual platform. # -# Copyright (c) 2018 - 2022, ARM Limited. All rights reserved. +# Copyright (c) 2018 - 2023, Arm Limited. All rights reserved. # # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -219,6 +219,10 @@ [PcdsDynamicDefault.common] gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareBase|0 gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareSize|0x40000 =20 + # Define PCD for emulating Runtime Variable storage when + # CFI flash is absent. + gEfiMdeModulePkgTokenSpaceGuid.PcdEmuVariableNvModeEnable|FALSE + ## RTC Register address in MMIO space. gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister64|0x0 gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister64|0x0 --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#105019): https://edk2.groups.io/g/devel/message/105019 Mute This Topic: https://groups.io/mt/98987543/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 18 19:48:03 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+105018+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=arm.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1684401001115628.6677259026567; Thu, 18 May 2023 02:10:01 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id hQWZYY1788612x3qonTWDUO5; Thu, 18 May 2023 02:10:00 -0700 X-Received: from EUR04-HE1-obe.outbound.protection.outlook.com (EUR04-HE1-obe.outbound.protection.outlook.com [40.107.7.79]) by mx.groups.io with SMTP id smtpd.web10.12798.1684400999667267758 for ; Thu, 18 May 2023 02:10:00 -0700 X-Received: from AS9PR07CA0059.eurprd07.prod.outlook.com (2603:10a6:20b:46b::34) by GV2PR08MB8702.eurprd08.prod.outlook.com (2603:10a6:150:b6::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.19; Thu, 18 May 2023 09:09:55 +0000 X-Received: from AM7EUR03FT032.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:46b:cafe::6a) by AS9PR07CA0059.outlook.office365.com (2603:10a6:20b:46b::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.6 via Frontend Transport; Thu, 18 May 2023 09:09:55 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+105018+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT032.mail.protection.outlook.com (100.127.140.65) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.18 via Frontend Transport; Thu, 18 May 2023 09:09:55 +0000 X-Received: ("Tessian outbound 3570909035da:v136"); Thu, 18 May 2023 09:09:54 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 3718bc4a4f61bcd8 X-CR-MTA-TID: 64aa7808 X-Received: from 31e92718b82b.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 613E0BFC-5637-43E9-942B-3106F60B4494.1; Thu, 18 May 2023 09:09:43 +0000 X-Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 31e92718b82b.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 18 May 2023 09:09:43 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QLzB00665U/yXbRfEvHeRwfAoLhixph5flvx82esJqjCNIjjSFPfbe3UP/Fdco6kALbOzBJDojyuFiNm7IVB0Vhm8XZyPBX3nADyur2+vk4yDNIXhBCzduA/Pku4xwpqrJMrhMQ0OIITROfRhluF9dJcqC7Dop6C2EcZ2DbapxpEUc3DbJWLE60qAoRkHTs5F9Q9s5KMP8f/L36JFifiENaxcYVspqops+5Gh2aC81UWpgQl162W0Fq9bgOGqNDKsaqczX6k+Z/rS7QyZj+3rb37p7v9CQb0tK7ROYnuaVX7ajEL5/CW+CfOcgijZ3J2YI3TmucjAL2p1E3+0DI8gQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=87dNbn7Tu+DDmq8qbw5npGWOcEK7Sxh5oy6/rbNCwY0=; b=KRckMs/xAt6sp641Hr2pVOMNZxdcwc5wdLu1f0y1pWKhUKGVOPWgTA8pRP2/WNiAljDSN2KyJQxVaW8YxMH4a0DztUGfxBwDXaBXTVqUPd0z7H2bRhn7Sdal11THxWTH0syqAjFs5ZYaggd6Fr+l4JNTyB/laepOEYkAnEMWqdWu3HEm0B6s88WJ2//G+zfI9wSpWUBO2oOwYckDt/FbdtjTHEwTOFhPMx3AD4Lghdu7ZEDUUDxKbx85axPttlIx8Z9pzZ02Tx9rCIFcuDonIjB/2wEchUluMiOf3FJp6TW6mnCJF/8lixCyJrG5co2sS5uRpBRmXxfhNm+Upiqamw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none X-Received: from DU2PR04CA0028.eurprd04.prod.outlook.com (2603:10a6:10:3b::33) by PAWPR08MB9781.eurprd08.prod.outlook.com (2603:10a6:102:2e6::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.19; Thu, 18 May 2023 09:09:40 +0000 X-Received: from DBAEUR03FT029.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:3b:cafe::22) by DU2PR04CA0028.outlook.office365.com (2603:10a6:10:3b::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.19 via Frontend Transport; Thu, 18 May 2023 09:09:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C X-Received: from nebula.arm.com (40.67.248.234) by DBAEUR03FT029.mail.protection.outlook.com (100.127.142.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6411.19 via Frontend Transport; Thu, 18 May 2023 09:09:40 +0000 X-Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 18 May 2023 09:09:37 +0000 X-Received: from E114225.Arm.com (10.1.196.36) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.23 via Frontend Transport; Thu, 18 May 2023 09:09:37 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , , , , , , Subject: [edk2-devel] [PATCH v1 3/6] ArmVirtPkg: Fallback to variable emulation if no CFI is found Date: Thu, 18 May 2023 10:09:32 +0100 Message-ID: <20230518090935.10984-4-sami.mujawar@arm.com> In-Reply-To: <20230518090935.10984-1-sami.mujawar@arm.com> References: <20230518090935.10984-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: DBAEUR03FT029:EE_|PAWPR08MB9781:EE_|AM7EUR03FT032:EE_|GV2PR08MB8702:EE_ X-MS-Office365-Filtering-Correlation-Id: dba77df2-4e02-4c2d-11a1-08db577fa56a x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: rRrHuNoNxvHHpDqYyTj8L+KK0RoquAfvhMlf0EIbOOCy6oabb2x+6+Hy4Lu3yB3J3omgZorgoutQXE8LVdlkfaRYlxLXR6hcplak1YNJfloLAtLsq3s8B6VcDlkMOstdGHAPHBGzskofjx5D0nfhxUcMwCsTxjlXSHbVpQcte5aOSgk/k0ytuQbiNh72ZuR1r0fmn4VSrpiOpvlQ/Mg1GY+sRDREfp7S2NFvvkmJzevp9ge2caokNA3WtHvceYGyLTY+SKe8dA2ZS4/KC+hcF9WLgT/VgkJ/Q/arn6kAi76ALc/j8yikNVo5dKhZ14h0wNyLAPSbABZbrNkbgvT7vJGMy9Kp71W2JsNxQhmKG0jnIEp4w5eBDfmHF74hKslfMh930mr/rLNFwCr7yGGKfylbsy/M5AfWQBDDaZniQkzHATCXYmCq38qvMi1lQa5WGFXrgP15K8Li3/om+iA4Msoy0iLPM7Jz2QBXRKT9tujusGonZxy23DEppbZVYBEF5lNVslVgEhjjHZSEgXHm5dNsZC7oJwtkC1DvmP980TAZ8SqrZ01swWdVuNWLtoyeV+jXh1TnIvL6pHsGo/mvCjYC6YyDWC2YVVMeqrmt/6CBgSIDl2I5F24TQu7lPmHRvohxEbtaOClNQTZd1mqtbKUDBsqtQGB6u+XCcaQLM1RYDLnpBqj/KYwJdE4F5Zre2WIeAt0u60Nf347PfsbWo30CFeWQqcuWUmYVsfjXK2w6S1jeki0UipwtXIO2tD3zphGgRCdvtj8hUJKYqUKGVA== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(136003)(346002)(396003)(376002)(451199021)(46966006)(40470700004)(36840700001)(40460700003)(6666004)(1076003)(26005)(7696005)(8676002)(426003)(336012)(478600001)(186003)(44832011)(316002)(36756003)(82310400005)(81166007)(86362001)(4326008)(356005)(2616005)(5660300002)(70586007)(70206006)(54906003)(82740400003)(6916009)(40480700001)(83380400001)(41300700001)(36860700001)(47076005)(2906002)(8936002)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9781 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT032.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 4569b82c-bbda-4cbc-df89-08db577f9c83 X-Microsoft-Antispam-Message-Info: ypt4VKl3z+wwUZCVyOGISgO6o0jdSPXH8AXO5SdJMLoRofzXZ6ysu/84cQCp05CPMiopSc3r8oJqJsJot97MTQ0nBhIXOEfwhr4t9rpvyK655fsmQjzfkOTuEZIMHrYwTCI0HNiq6doBUqC56kzNjZ/OvLMnn84KPJj5ocaIAXBnHyS430+nzTPpDrkfOV4+dN1Bfrm02KJMekE/USXJPpGO6fQFMEk+EY2JWvSOmnVYOvjLNxN9CiLpNWJUV8kv7VDhOHpqMZtIaOMZdGCZDBN7s4/e0U5C+dsQ6sTxhdAXhsGSSVOh4ripqKEgWt6e2SIqNKB+ln0nDHJeGPhm1c/BIyEQGgmkBs049VZArbjXVQ/Bpd2sE8452MFNz0qVXJMJmdkKgtf6Wny5SxVatEmJ8Ttkdv1vka2lnDWCuR77Dy7n0TNV/7eRzy7ThLrt95nviBtIGU8tH015YpkVHLchhak6nEyRVfIlflR8epeCWbvJyhnz+6QUhTedYimHBhmDY1AqV6JJOICVUqgVgafIibncvXren+yjHJiYy9aEhoeea9LQFmfy2+TfD+ycpX4rHGQdv4/LuUd8b1nJLoDkFSeRUvD1FIGQjsmxalng6SVuAIJChRCLhVEYCYocWD9Wy/TdKS/t6KcwmbHUAfMc48uy3HASQdKZWtZGga61bUK6uUcEV8S/C0W54VRf3+dNDnDUiLiLxDEtY2rixjMUD5U2EThttxrEUFx4CUEVcnpHZHjzcq1ZDfqLPlWy X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2023 09:09:55.0087 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dba77df2-4e02-4c2d-11a1-08db577fa56a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT032.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8702 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com X-Gm-Message-State: e6raJhjzqIGcX9jjPUzy2uBVx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1684401000; bh=Exa7T/MhPp0MIRBA58BpNij6Te/Std7NP4pqvQajxEw=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=m6f+PL9G1N5p67XoRWuBvO0xl+yX33vStarX+rbSmY4qUTyZKMygZx/3+bNSG42Ytyj +2amhzY25pmLT9Hckd0Ufd3HZOdxxvFCmo8p/IHAj/+WXEvieEyqJtnAmJKEdhxMMqY0Y d1IT3PQXDsr14DLOQXonj2Gc+FnTUoboAr8= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1684401001465100001 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The kvmtool option '--flash ' is used to launch a guests VM with a CFI flash device that maps the flash file specified at the command line. However, kvmtool allows guest VMs to be launched without a CFI flash device. In such scenarios the firmware can utilize the emulated variable storage for UEFI variables. To support this the PCD gEfiMdeModulePkgTokenSpaceGuid.PcdEmuVariableNvModeEnable must be set to TRUE. Therefore, update the NorFlashKvmtoolLib to fallback to variable emulation if a CFI device is not detected. Also improve the error logging. Signed-off-by: Sami Mujawar --- ArmVirtPkg/Library/NorFlashKvmtoolLib/NorFlashKvmtool.c | 38 ++++++++= +++++++++--- ArmVirtPkg/Library/NorFlashKvmtoolLib/NorFlashKvmtoolLib.inf | 3 +- 2 files changed, 36 insertions(+), 5 deletions(-) diff --git a/ArmVirtPkg/Library/NorFlashKvmtoolLib/NorFlashKvmtool.c b/ArmV= irtPkg/Library/NorFlashKvmtoolLib/NorFlashKvmtool.c index 43f5858644b1f47ada17e00fba55a670ab5862bd..2beeefdd272d6f8841f7d0b9723= 94739b745982e 100644 --- a/ArmVirtPkg/Library/NorFlashKvmtoolLib/NorFlashKvmtool.c +++ b/ArmVirtPkg/Library/NorFlashKvmtoolLib/NorFlashKvmtool.c @@ -1,7 +1,7 @@ /** @file An instance of the NorFlashPlatformLib for Kvmtool platform. =20 - Copyright (c) 2020, ARM Ltd. All rights reserved.
+ Copyright (c) 2020 - 2023, Arm Ltd. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -228,7 +228,7 @@ NorFlashPlatformLibConstructor ( CONST CHAR8 *Label; UINT32 LabelLen; =20 - if (mNorFlashDeviceCount !=3D 0) { + if ((mNorFlashDeviceCount !=3D 0) || PcdGetBool (PcdEmuVariableNvModeEna= ble)) { return EFI_SUCCESS; } =20 @@ -337,9 +337,39 @@ NorFlashPlatformLibConstructor ( } =20 if (mNorFlashDevices[UefiVarStoreIndex].DeviceBaseAddress !=3D 0) { - return SetupVariableStore (&mNorFlashDevices[UefiVarStoreIndex]); + Status =3D SetupVariableStore (&mNorFlashDevices[UefiVarStoreIndex]); + if (EFI_ERROR (Status)) { + DEBUG (( + DEBUG_ERROR, + "ERROR: Failed to setup variable store, Status =3D %r\n", + Status + )); + ASSERT (0); + } + } else { + DEBUG (( + DEBUG_ERROR, + "ERROR: Invalid Flash device Base address\n" + )); + ASSERT (0); + Status =3D EFI_NOT_FOUND; + } + } else { + // No Flash device found fallback to Runtime Variable Emulation. + DEBUG (( + DEBUG_INFO, + "INFO: No Flash device found fallback to Runtime Variable Emulation.= \n" + )); + Status =3D PcdSetBoolS (PcdEmuVariableNvModeEnable, TRUE); + if (EFI_ERROR (Status)) { + DEBUG (( + DEBUG_ERROR, + "ERROR: Failed to set PcdEmuVariableNvModeEnable, Status =3D %r\n", + Status + )); + ASSERT (0); } } =20 - return EFI_NOT_FOUND; + return Status; } diff --git a/ArmVirtPkg/Library/NorFlashKvmtoolLib/NorFlashKvmtoolLib.inf b= /ArmVirtPkg/Library/NorFlashKvmtoolLib/NorFlashKvmtoolLib.inf index b5f35d4782896761e7975a6e5c196ff0fab0d6db..fba1245e41ec4b146db79a821b8= 343247377af41 100644 --- a/ArmVirtPkg/Library/NorFlashKvmtoolLib/NorFlashKvmtoolLib.inf +++ b/ArmVirtPkg/Library/NorFlashKvmtoolLib/NorFlashKvmtoolLib.inf @@ -1,7 +1,7 @@ ## @file # Nor Flash library for Kvmtool. # -# Copyright (c) 2020, ARM Ltd. All rights reserved.
+# Copyright (c) 2020 - 2023, Arm Ltd. All rights reserved.
# SPDX-License-Identifier: BSD-2-Clause-Patent # ## @@ -39,6 +39,7 @@ [Pcd] gArmTokenSpaceGuid.PcdFvBaseAddress gArmTokenSpaceGuid.PcdFvSize =20 + gEfiMdeModulePkgTokenSpaceGuid.PcdEmuVariableNvModeEnable gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableSize gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwWorkingBase --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#105018): https://edk2.groups.io/g/devel/message/105018 Mute This Topic: https://groups.io/mt/98987541/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 18 19:48:03 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+105017+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=arm.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 168440100074264.28668732014114; Thu, 18 May 2023 02:10:00 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id dDERYY1788612x8kBzVBoAVA; Thu, 18 May 2023 02:10:00 -0700 X-Received: from EUR04-DB3-obe.outbound.protection.outlook.com (EUR04-DB3-obe.outbound.protection.outlook.com [40.107.6.47]) by mx.groups.io with SMTP id smtpd.web10.12797.1684400998959097100 for ; Thu, 18 May 2023 02:09:59 -0700 X-Received: from DUZPR01CA0103.eurprd01.prod.exchangelabs.com (2603:10a6:10:4bb::15) by DU2PR08MB10232.eurprd08.prod.outlook.com (2603:10a6:10:49b::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.17; Thu, 18 May 2023 09:09:55 +0000 X-Received: from DBAEUR03FT062.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:4bb:cafe::51) by DUZPR01CA0103.outlook.office365.com (2603:10a6:10:4bb::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.19 via Frontend Transport; Thu, 18 May 2023 09:09:55 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+105017+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT062.mail.protection.outlook.com (100.127.142.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.19 via Frontend Transport; Thu, 18 May 2023 09:09:55 +0000 X-Received: ("Tessian outbound e13c2446394c:v136"); Thu, 18 May 2023 09:09:55 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 9f4360e4f4eab0c3 X-CR-MTA-TID: 64aa7808 X-Received: from af8be12ef294.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id AB63DFF8-D297-46EA-97B6-EA12E62E2F5E.1; Thu, 18 May 2023 09:09:44 +0000 X-Received: from EUR03-AM7-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id af8be12ef294.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 18 May 2023 09:09:44 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F5ia5+ulThGLCCbjaqoyjEgnyiXOLg63M6ZIq/7N0SwXUBaVISoti3rBqTpzBIFYbscmJ8UBZiJjXBf/qFP30Me4F/l3mVHCFJzS9RpbvamUNW8+WS9jbQsj6rjTUtDEs+2Dm9RxLU2zRWWRzAYhft/o1Trpn16Ttz9+jl4KBg5Z5fv18ON7BgyY0ZplrElqcVlHEkHorC/pnXMcvxU6ke/DOC9MLV12208l0kc/4cKLArjLEPgvQ9NaQDFOTmYTC51VrYFKu4a1kAQX74OExaFOJ8J1rUxIkgmuAitCzDwVrkiTnYtzQModk1SNgOlpGetVSs+jYGCcJ7KhvDfa7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ms8rYsbdoin2HCDXX0IUw4Xcq0Y6cxNR85E7Lq/0f5I=; b=Oh0DpC9RbW6cpk0xDe5lI4JJRUhppHQpostfFhJSgIvaOEI1BRSK8nLb+rkaBopRBdsnD/B+f8VkdDAvh85zZ+I6CZMP4Vpf/tzmqpQRCgwy43XLZD/KpnBWdhP9CM+jgxKiThLUKAkapxhS9AbMcMmkTfsoAyLAc6aLCj6YYmZ7KdWTmvGQ4JKDx9QOiUacQqdItwuI8/B55HAs0mKY22NWOPlclLu4DszuqzdnpFSZjcA6U0EeSPU0DXc5bc2vSbkFzhIg9Awu/WgWym21ynrehpuwOajnpjc9TER/f61dUAXsXuniyyQXDHWB7ayWvaiYZqKI8Nt+N12lq8lw0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none X-Received: from DB7PR05CA0057.eurprd05.prod.outlook.com (2603:10a6:10:2e::34) by DB5PR08MB10254.eurprd08.prod.outlook.com (2603:10a6:10:488::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.34; Thu, 18 May 2023 09:09:41 +0000 X-Received: from DBAEUR03FT018.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2e:cafe::bd) by DB7PR05CA0057.outlook.office365.com (2603:10a6:10:2e::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.19 via Frontend Transport; Thu, 18 May 2023 09:09:41 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C X-Received: from nebula.arm.com (40.67.248.234) by DBAEUR03FT018.mail.protection.outlook.com (100.127.142.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6411.18 via Frontend Transport; Thu, 18 May 2023 09:09:41 +0000 X-Received: from AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 18 May 2023 09:09:38 +0000 X-Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 18 May 2023 09:09:38 +0000 X-Received: from E114225.Arm.com (10.1.196.36) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.23 via Frontend Transport; Thu, 18 May 2023 09:09:37 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , , , , , , Subject: [edk2-devel] [PATCH v1 4/6] ArmVirtPkg: Dispatch variable service if variable emulation is enabled Date: Thu, 18 May 2023 10:09:33 +0100 Message-ID: <20230518090935.10984-5-sami.mujawar@arm.com> In-Reply-To: <20230518090935.10984-1-sami.mujawar@arm.com> References: <20230518090935.10984-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: DBAEUR03FT018:EE_|DB5PR08MB10254:EE_|DBAEUR03FT062:EE_|DU2PR08MB10232:EE_ X-MS-Office365-Filtering-Correlation-Id: 0190a589-543d-470a-6fbe-08db577fa5b6 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: PibCjzNfvfKScJE9eMUnH5umh/IAuKBM/ThIu6GdxBmPbx/7GIq8su/qWOldMfJBfNcTKi8Zxkx4IHoDD6qshNQ+l70rL/7F/2Ap9w5bYVBNKyp8rwTCXuy1CIOcRsOdcHtqRpysny6k/CFeQew8QhhH/4ip6mvRH/0D4T/7Uic5IJ8YjDt1yQQxMwMeccMyn+Yts9QozlfOyhXgltXwNazftuXHBpD5TsCacZ7VyJ0scGh5R4ZN60+PsbEVtnvG7YEPkvy02qoKiTV9mNwrWvjFFb+o8a5NCZKMFyztJdsBP8MmnypbnnQ+JsVztdj5pDIklR2WjUeixmyGIZ4Y9Q5eRIitRwDhMl0ARBB+wVRK2/I3SxBl14CbjqRo76NtgpYupzxP3sDARQNFAuZBydPjvn3QOP+jn7+0bb7nQPyVl0F1o+HgbdOv7/XxtI5lnwKO0s7T0SM3Vjyxc4xCxtKXf4LZpepAhLXR8igLXY+S97rKTfeXyhskiUuhhEEL8YFUjhjxd3AHkLnY97Lht5UWMsSbZEHiZfvUXFpio3qN3z9uasfOCAupik0hgUP17i8DnpiUlf0JsxaxvgM2kN+uYzWrCNtRlxbFRLcoao8CWxn/F9OChEhyVQTZDVWF6rqzgiEmmWZ8ENTWdG15P4Y2rUlSlX/ehYej32K9LLwxHihy+PaK/K18s5BnQ70mGWQ2dvcTfiFHmRv1SPxpac7x4bobRcITp6kwB/hVAB2hN2c+oE2nuIHB6rMpMqT1 X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(376002)(346002)(39860400002)(396003)(136003)(451199021)(36840700001)(46966006)(4326008)(6916009)(70586007)(40480700001)(26005)(6666004)(1076003)(44832011)(54906003)(316002)(70206006)(478600001)(7696005)(5660300002)(41300700001)(86362001)(82310400005)(336012)(36860700001)(2906002)(8936002)(8676002)(47076005)(2616005)(83380400001)(356005)(36756003)(81166007)(426003)(82740400003)(186003)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR08MB10254 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT062.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a7b57b29-704b-4024-f03c-08db577f9d33 X-Microsoft-Antispam-Message-Info: vh0VTAYx792kzPxY6uKGEftbjV2G3D5EUOObElqcnZzsUgwwZuTyXjr7PW8yV2SWChVK1CAT7fnmBEmtGNzXIVZeeZXNVmfSVd+S/XRKTyt35STUfg0RrvnNZ7MPRoKQY7L/0fGgzQmtGvFqa+td21nHz0BCUYvrYUzbkcbNNH9fU+KtsCNYNAtHediQFIOz3/ZBTbqUe6SND53rGCqDCTuULSROejePkCEF+KlN1Fo3FbEUA9Q/y/Vn7JQaXJaZ2xy18btlDsNn7oLufpmBJxrdAZ3gV6kMVExjLZdFjPd4hOMXjTVDK5U/JmPjJsJITURfimvusYvNIPsLDx1sKwQDRVCIzsX6k/ZhVMhWCfFCUVmlk9oXNAWywbUurMgJb3+yRNE1lbzgy3gvjHSR9rlajGdsSYe21p9dzFHVLcK74y5KzW1Ez7lR7pFQD6SamWwwC3wINaG3Gid/+b7VXemTYMLBTyEhEmB1sdwot+hyZ98/Gv8cXtXapcj97lIZdA/OVUo2go2tvvzJ0PRvAVos4O58UzzgjbAvrP0t5uKqqQ1sVx/Qlbn8SxvpElcf8xkR7B/84JIrUci+ZCiJkFNC0otucNWXB4wQJiuEqhrWY6LYVAe3rBl+GyFauuLaaef9P7VsbA03l8hAFuFNM4qLRPr1MKWdkcOZvQ5R4SfH2S8Z0nOovkRVnAN4EA7gOMU8ByG7Nd6ym3qaHTPXIhEj6wsfTWybshy3kW+14hPJuac1E5e+mFBk+KL2oNEn X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2023 09:09:55.4467 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0190a589-543d-470a-6fbe-08db577fa5b6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT062.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR08MB10232 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com X-Gm-Message-State: b3IjPKe1uJGBbTr1MPyal6Aux1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1684401000; bh=XfBYvpm05uGBCy1kaHti72RVNVbpeUnBsJrcfv7DCqQ=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=FFcg3i6kORibXxAEz5N4biDxoroYZO8v3EBfrDuQDMBUHfuvIzb45UTZKLHXppwAhYz eHIcM6R4adlMkNfKRAMIkPrdBi0shpcFx9xyW2YvHx1YzRM4FIZ4Qn2qW97sBZO3gwpF+ ivQrvMshtEEBgPF6JkMyE20Ud7HpOn3fD50= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1684401002009100008 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The VariableRuntimeDxe links with NvVarStoreFormattedLib which is required to establish the dependency on OvmfPkg\VirtNorFlashDxe. The VirtNorFlashDxe installs the gEdkiiNvVarStoreFormattedGuid to indicate it has finished initialising the flash variable storage and that the variable service can be dispatched. However, the kvmtool guest firmware dynamically detects if CFI flash is absent and sets PcdEmuVariableNvModeEnable to TRUE indicating emulated runtime variable must be used. Therefore, in this scenario install the gEdkiiNvVarStoreFormattedGuid so that the variable service can be dispatched. Also link the NorFlashKvmtoolLib as a NULL library so that it can discover if the CFI flash is absent and setup the PCD PcdEmuVariableNvModeEnable. This is required in case the NorFlashDxe is not yet dispatched. Signed-off-by: Sami Mujawar --- ArmVirtPkg/ArmVirtKvmTool.dsc | 5 ++++- ArmVirtPkg/KvmtoolPlatformDxe/KvmtoolPlatformDxe.c | 13 ++++++++++++- ArmVirtPkg/KvmtoolPlatformDxe/KvmtoolPlatformDxe.inf | 4 +++- 3 files changed, 19 insertions(+), 3 deletions(-) diff --git a/ArmVirtPkg/ArmVirtKvmTool.dsc b/ArmVirtPkg/ArmVirtKvmTool.dsc index 25920ab4ae3cce20fdbe8e9ff7e25b8696d2c851..4541d03d23e0d98915b3d3ada68= 8c48d979b75d2 100644 --- a/ArmVirtPkg/ArmVirtKvmTool.dsc +++ b/ArmVirtPkg/ArmVirtKvmTool.dsc @@ -311,7 +311,10 @@ [Components.common] # # Platform Driver # - ArmVirtPkg/KvmtoolPlatformDxe/KvmtoolPlatformDxe.inf + ArmVirtPkg/KvmtoolPlatformDxe/KvmtoolPlatformDxe.inf { + + NULL|ArmVirtPkg/Library/NorFlashKvmtoolLib/NorFlashKvmtoolLib.inf + } OvmfPkg/Fdt/VirtioFdtDxe/VirtioFdtDxe.inf EmbeddedPkg/Drivers/FdtClientDxe/FdtClientDxe.inf OvmfPkg/Fdt/HighMemDxe/HighMemDxe.inf diff --git a/ArmVirtPkg/KvmtoolPlatformDxe/KvmtoolPlatformDxe.c b/ArmVirtPk= g/KvmtoolPlatformDxe/KvmtoolPlatformDxe.c index 3f5027fac4d65c4ae3f370c5349c6f410aae5b43..bf6fc1f1f070f32e3ce351f57da= 955c5cc849409 100644 --- a/ArmVirtPkg/KvmtoolPlatformDxe/KvmtoolPlatformDxe.c +++ b/ArmVirtPkg/KvmtoolPlatformDxe/KvmtoolPlatformDxe.c @@ -4,7 +4,7 @@ - It decides if the firmware should expose ACPI or Device Tree-based hardware description to the operating system. =20 - Copyright (c) 2018 - 2020, ARM Limited. All rights reserved. + Copyright (c) 2018 - 2023, Arm Limited. All rights reserved. =20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -75,6 +75,17 @@ KvmtoolPlatformDxeEntryPoint ( { EFI_STATUS Status; =20 + if (PcdGetBool (PcdEmuVariableNvModeEnable)) { + // The driver implementing the variable service can now be dispatched. + Status =3D gBS->InstallProtocolInterface ( + &gImageHandle, + &gEdkiiNvVarStoreFormattedGuid, + EFI_NATIVE_INTERFACE, + NULL + ); + ASSERT_EFI_ERROR (Status); + } + Status =3D PlatformHasAcpiDt (ImageHandle); ASSERT_EFI_ERROR (Status); =20 diff --git a/ArmVirtPkg/KvmtoolPlatformDxe/KvmtoolPlatformDxe.inf b/ArmVirt= Pkg/KvmtoolPlatformDxe/KvmtoolPlatformDxe.inf index c5bf798c3b2b7bf1f77e0c5ada9000f536123d6a..b0583d52058805aaeece31d7e37= 76ac498f101ad 100644 --- a/ArmVirtPkg/KvmtoolPlatformDxe/KvmtoolPlatformDxe.inf +++ b/ArmVirtPkg/KvmtoolPlatformDxe/KvmtoolPlatformDxe.inf @@ -3,7 +3,7 @@ # - It decides if the firmware should expose ACPI or Device Tree-based # hardware description to the operating system. # -# Copyright (c) 2018 - 2020, ARM Limited. All rights reserved. +# Copyright (c) 2018 - 2023, Arm Limited. All rights reserved. # # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -33,10 +33,12 @@ [LibraryClasses] UefiDriverEntryPoint =20 [Guids] + gEdkiiNvVarStoreFormattedGuid ## SOMETIMES_PRODUCES ## PROTOCOL gEdkiiPlatformHasAcpiGuid ## SOMETIMES_PRODUCES ## PROTOCOL gEdkiiPlatformHasDeviceTreeGuid ## SOMETIMES_PRODUCES ## PROTOCOL =20 [Pcd] + gEfiMdeModulePkgTokenSpaceGuid.PcdEmuVariableNvModeEnable gUefiOvmfPkgTokenSpaceGuid.PcdForceNoAcpi =20 [Depex] --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#105017): https://edk2.groups.io/g/devel/message/105017 Mute This Topic: https://groups.io/mt/98987540/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 18 19:48:03 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+105015+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=arm.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1684400996062793.5749711391351; Thu, 18 May 2023 02:09:56 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id vFNGYY1788612xBQtriueOI5; Thu, 18 May 2023 02:09:55 -0700 X-Received: from EUR05-AM6-obe.outbound.protection.outlook.com (EUR05-AM6-obe.outbound.protection.outlook.com [40.107.22.70]) by mx.groups.io with SMTP id smtpd.web11.12664.1684400994280887644 for ; Thu, 18 May 2023 02:09:54 -0700 X-Received: from DB6PR07CA0165.eurprd07.prod.outlook.com (2603:10a6:6:43::19) by AS8PR08MB9219.eurprd08.prod.outlook.com (2603:10a6:20b:5a2::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.19; Thu, 18 May 2023 09:09:51 +0000 X-Received: from DBAEUR03FT050.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:43:cafe::d8) by DB6PR07CA0165.outlook.office365.com (2603:10a6:6:43::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.6 via Frontend Transport; Thu, 18 May 2023 09:09:50 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+105015+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT050.mail.protection.outlook.com (100.127.142.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.19 via Frontend Transport; Thu, 18 May 2023 09:09:50 +0000 X-Received: ("Tessian outbound 3a01b65b5aad:v136"); Thu, 18 May 2023 09:09:50 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 4798730df8e2518a X-CR-MTA-TID: 64aa7808 X-Received: from f68436d0ad73.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id DBFD0252-B46A-49CF-8A69-975404CF0B0F.1; Thu, 18 May 2023 09:09:43 +0000 X-Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f68436d0ad73.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 18 May 2023 09:09:43 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NFrf15soQrJKCEcRDtlbDQtkcqZiS3cDCtVjqCm37WjEvnYzGy3bi03k05kb/Wl6Y+49HMi9oCJKqxYm7Za83rgCfL1nI2NIYdlxNina6DVpg2SKe42T3z9aT6Ny1vNgeEBFa3i+pPqYNr0V1u/pSJKYMpEjRnmxHJRMppFDvzRTlYC1qb07vRRT0eiGgf0mbxxW1OTRhLMVf3XavC+Pp2ixuS7P9UFniguP/NbgMmn2x86rrV8WLPiIb+oZcd+bGKdTYHX07CDVfuYAOMrE4cii0kRNdVP2jH3CitCxGJpF/0ZpJNtcT2LAf6FqqY0Q3fpkbfDY/kw4gpTYshsdAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mKLurZNE8sdvZ61z44rBAP/GTB+s/Rz1Mn6PnRYzXcY=; b=QLtliezZkY4ZJ56jzozsbjoJvO8xrYzkz/z6ffv4FzowuRsUlWOwOXyk5w/LQtkwlEveV+VfDEB0VuRR411mvWaYmaTR8EseV3tknzm+AUdvEYRutaUVCekwYbKCMf77hEq6OJTJ4nc7udW6PjSc/e2VmMGaiTExbXft8fIbbtanrwMTxnBmZRFcZDWZcA0d58qnVxhI5O1MBF5b5WYLlpR5MlnN4iPqtmu90QEUHngalb9Hpe3NMdAsG0f6wSQgVrwIpk7wv7a1v/DhIlukc3mqnxTMN70VFr/g7MvxsjQYeIuOWwqOa2MciF1WE/MhBal3KeKEzrzPT155BMUcRQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none X-Received: from DB7PR05CA0048.eurprd05.prod.outlook.com (2603:10a6:10:2e::25) by AM8PR08MB6579.eurprd08.prod.outlook.com (2603:10a6:20b:356::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.17; Thu, 18 May 2023 09:09:41 +0000 X-Received: from DBAEUR03FT018.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2e:cafe::6) by DB7PR05CA0048.outlook.office365.com (2603:10a6:10:2e::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.19 via Frontend Transport; Thu, 18 May 2023 09:09:41 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C X-Received: from nebula.arm.com (40.67.248.234) by DBAEUR03FT018.mail.protection.outlook.com (100.127.142.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6411.18 via Frontend Transport; Thu, 18 May 2023 09:09:41 +0000 X-Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 18 May 2023 09:09:38 +0000 X-Received: from E114225.Arm.com (10.1.196.36) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.23 via Frontend Transport; Thu, 18 May 2023 09:09:38 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , , , , , , Subject: [edk2-devel] [PATCH v1 5/6] ArmVirtPkg: Kvmtool: Increase primary core stack size Date: Thu, 18 May 2023 10:09:34 +0100 Message-ID: <20230518090935.10984-6-sami.mujawar@arm.com> In-Reply-To: <20230518090935.10984-1-sami.mujawar@arm.com> References: <20230518090935.10984-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: DBAEUR03FT018:EE_|AM8PR08MB6579:EE_|DBAEUR03FT050:EE_|AS8PR08MB9219:EE_ X-MS-Office365-Filtering-Correlation-Id: 8fbfff2a-0895-49fb-2a56-08db577fa2f5 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: +tPnJXzJIEJOJUZdD7X0PA3+iyh69prPBKcsjdL0msU/nUH6akNXKZADxfP/1FPFGkWOCG0uKEgKYlvEM40saJBQV8r++fSlMLDmGxb0e6IbU2ZhChen0yXy3zU6mkEOoz62mo9+b9AO9YOvyeT3BMZlySgDnv4V7+rQVH6Vz0VaCKISl57wRU7JANN1KmyLmPHCZ5iuaPsrlg2n55hR2mF439KYmTVH7DZmVt2FKzyDeez6vS5xtdTROZMxcT3pGpnuxWBYqTNsrUS2gE5YLJuEDQ+7MprfHo1hLaAeHd/H2IbdDBnFjrYF3yf5bB7l7yQNzJCCIGErL6wCpSvkwsgYz0sei6B8lwH1DGnZBXBY6WXDOzltYKLv+FWlw78NCTJ5gmq+E6tHt/tcVC9HQAePkCwxmTpXOLGfK8rkWcxbXMdqp5qSlQOAp5L3UIU42On2YV1bCxlZLmrBvAtEg0Yyvtf6H8tHr4U5ikFGZGZAp8jAigd9kuP+roJi7GB2tvTbJy0r/v1exle3NvBjs4fxq2tDt1xi9MXpwmVWwx72EpThML6uMacQTvokCWu5Ww7jwQbN6HU5uhBSZ2VhBJf8NaEoVzZ+/VA69w0zjew8VWV1ahKMRtly5oF6X91S+METXPv/tQM5VJ5TXMVCxlFk+MumcN5HweWfiWU/+FiqapiNWHhFwtWhslZGjh3aHEwNFBeQiMsYGPHUkcpv9USCy112r7nrQDvwJhdOrRrO5sHD6tjaWEZqtiQHyUEwztsJ/bJLF2EwS+kNGnBTzQ== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(396003)(136003)(376002)(346002)(451199021)(40470700004)(36840700001)(46966006)(82740400003)(81166007)(186003)(1076003)(336012)(356005)(2906002)(40480700001)(426003)(47076005)(2616005)(26005)(83380400001)(44832011)(8676002)(8936002)(5660300002)(6666004)(36756003)(41300700001)(4326008)(478600001)(54906003)(70586007)(7696005)(70206006)(82310400005)(6916009)(36860700001)(86362001)(40460700003)(316002)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6579 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT050.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 675eb724-fcee-420a-c54c-08db577f9d6a X-Microsoft-Antispam-Message-Info: pRWEijoDkviDiPxjYOeHfMILNXHuNkx8yHddEX3QOqQPEhWSUYR9H7r8dq6G/FHtsATWN868LEkS4Rbk/57VSbgo2zApiICcm753gCSperIYpDa38XlbAIQHTpztBpOPM7spn6iqzh8Pjij+c3LwFNdMeTXpP9Z5E+XOC1YRFvUDri3MXR+Own6meq5GoAE6px+nRe/Try5m+PEYhLuyaK8QW40JlRZ1caT3eLZhYwF+dXlIjoZ3cFWfl0AKZQQ+l1sNuThbWQaTef3pdmqu1H+81RAn1oD7qAv08mFj1pBAz6+NpByp6+4DX32uWHjkdq8mthkDmAU8OPfWyVC0HXvFBSqv0F44WXKDdYnj64YphsJSpuaBjhA3AdryyofFOPJwgWJwYAnT9ZQ9nRJriYmaTtqT+emOHDQNQUf7Wl9pJZxDTMNKlWrPEN+og4dV94YX0B9iJz6QhU3TCA/J8osFY5Y6e0ViI8skyHPw4YzrIumVBQX1EVv44kFYAYd4brE2FXT3Q8kIF0/A3qyHztPIXrhgr3QESZi4eQ3K6rS7Q8jNBs2b2uTaPmo40Sv/qCg3D2gW+ryUoXC3GQ5jtYRrSMD4rWvnlVzjX/yn9LVLfuTIhczxKBvIT0b/BoAuFIv9A8Rrev9YS/DZ/Hk3LCKsjmEvUso61RpakeTnpPDRuQDEnXga21D8KKmzjZuE0ARHTnWdkPQSZ5ls2upHmos9FklLwZU/dEG+LxJJJRwBNj20jaFXrqUGLZIUoNQw X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2023 09:09:50.9340 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8fbfff2a-0895-49fb-2a56-08db577fa2f5 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT050.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9219 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com X-Gm-Message-State: viRwIGTuCaGCexwdcDdpCRqix1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1684400995; bh=61f1eac4apSmt5RwvXkQdr2+bcZTdDIBqyfsfCVfFF4=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=mEtS+75Axio6wM3TrOJCDIuMzO58LhEM4Rs2yq6Bdd2BKGvben9hVCWs0h5BQUudkox 1l+t09YEuYMqLDELitSZ+qSifUwEPkEEhMojeayEz3ePc8R8ZYQBD/RTJM9hgS09UVJgR p78rW0vFcEEJxfz77ptzVAU/R9Q4GDreNbw= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1684400997986100003 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The patch "f07a9df9af60 ArmVirtPkg: Enable stack guard" enabled stack overflow detection for ArmVirtPkg. Following this patch, running UEFI shell command 'dmpstore' resulted in a crash indicating a stack overflow. Invoking 'dmpstore' results in recursive calls to CascadeProcessVariables () which apparently consumes the available stack space and overflows. Therefore, increase the primary core stack size. Signed-off-by: Sami Mujawar --- ArmVirtPkg/ArmVirtKvmTool.dsc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ArmVirtPkg/ArmVirtKvmTool.dsc b/ArmVirtPkg/ArmVirtKvmTool.dsc index 4541d03d23e0d98915b3d3ada688c48d979b75d2..664a624fd2a30bb466a3df21034= 82e3e6c1f303a 100644 --- a/ArmVirtPkg/ArmVirtKvmTool.dsc +++ b/ArmVirtPkg/ArmVirtKvmTool.dsc @@ -126,7 +126,7 @@ [PcdsFixedAtBuild.common] gArmTokenSpaceGuid.PcdVFPEnabled|1 !endif =20 - gArmPlatformTokenSpaceGuid.PcdCPUCorePrimaryStackSize|0x4000 + gArmPlatformTokenSpaceGuid.PcdCPUCorePrimaryStackSize|0x8000 gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000 gEfiMdeModulePkgTokenSpaceGuid.PcdMaxAuthVariableSize|0x2800 =20 --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#105015): https://edk2.groups.io/g/devel/message/105015 Mute This Topic: https://groups.io/mt/98987538/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 18 19:48:03 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+105020+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=arm.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1684401003364473.85404457991524; Thu, 18 May 2023 02:10:03 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id nReOYY1788612xLRHnFKnPJi; Thu, 18 May 2023 02:10:03 -0700 X-Received: from EUR03-DBA-obe.outbound.protection.outlook.com (EUR03-DBA-obe.outbound.protection.outlook.com [40.107.104.46]) by mx.groups.io with SMTP id smtpd.web11.12668.1684401002222824621 for ; Thu, 18 May 2023 02:10:02 -0700 X-Received: from AS9PR06CA0329.eurprd06.prod.outlook.com (2603:10a6:20b:45b::35) by GV2PR08MB9926.eurprd08.prod.outlook.com (2603:10a6:150:c1::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.17; Thu, 18 May 2023 09:09:53 +0000 X-Received: from AM7EUR03FT063.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:45b:cafe::bf) by AS9PR06CA0329.outlook.office365.com (2603:10a6:20b:45b::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.19 via Frontend Transport; Thu, 18 May 2023 09:09:53 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+105020+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT063.mail.protection.outlook.com (100.127.140.221) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.19 via Frontend Transport; Thu, 18 May 2023 09:09:53 +0000 X-Received: ("Tessian outbound 5154e9d36775:v136"); Thu, 18 May 2023 09:09:52 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 61b26035920badb3 X-CR-MTA-TID: 64aa7808 X-Received: from a02e394bc4a8.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 888CA4DD-65B9-468C-91AA-44726420EEDC.1; Thu, 18 May 2023 09:09:46 +0000 X-Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a02e394bc4a8.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 18 May 2023 09:09:46 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GL856hgiel8pAU1vBqveuMhI6Ka5r8M9kGzNNOMFCNlyWoAWAFbCgd0XiBHsg6wfUp1TM4xieeauJ40eSupBvN4XLcKQHNmWeDnX+Gos8TjyhgLBsIvUhj2HLoRwVL2sxNSnzFHm0JlK3kXpiychhPZKBAZtRnTZBxtXzoL3VLTDsgYHGi5/4HubPMz8AikTzqyKXqdsT5zg9DgUTAvXBowXi4z9V0uuctO+fg2pG18hXPqG99X9cd7mtKO8JpkjcusGnCRJ5We7kzcVx1Qi+yVLm4FAuGZMn6wFCqsBe4hjLGDJGLaD1iYPUCqcgDFAABTvQxsWwAKP3iMDAeT3qA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=z+94fjb0SM4RkDl7SdpvPvRqHG99IS4sTcmolxya118=; b=i1PFohRw+cQlK5d0W34zmvKMS7ogkbyTUOAw2HhHBT7k2+Ibm4ZZ37HzVht5bPz7AvurI4ZORkt4HdEHO0mqLvRIOyGKpi62iUiPlp9PWfCgJ/6ypwOSUd/Bu7pVIIOcOTE1Z4qiDBrBcre/KYNIc6n0m9qmpM8d9DEFe1d43LtA/ESXJuTmHx5Gbq3GsQmX6LvDcZJw4I77bM9Ss38DC+gpi+/NsH9FvRxlYseq8S1nE+TvyEqnu/XzFsgqRY70VIeaWm/mG9GCZcPAidH0RSb8cYsEKEM0TG7PRfivWLW8n5x69OAXNNLx3eeIpp2oK403Ify4Z5BiFsk5o2nCXw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none X-Received: from DB7PR05CA0049.eurprd05.prod.outlook.com (2603:10a6:10:2e::26) by PAWPR08MB9711.eurprd08.prod.outlook.com (2603:10a6:102:2ee::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.19; Thu, 18 May 2023 09:09:43 +0000 X-Received: from DBAEUR03FT018.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2e:cafe::bd) by DB7PR05CA0049.outlook.office365.com (2603:10a6:10:2e::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.19 via Frontend Transport; Thu, 18 May 2023 09:09:42 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C X-Received: from nebula.arm.com (40.67.248.234) by DBAEUR03FT018.mail.protection.outlook.com (100.127.142.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6411.18 via Frontend Transport; Thu, 18 May 2023 09:09:42 +0000 X-Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 18 May 2023 09:09:39 +0000 X-Received: from E114225.Arm.com (10.1.196.36) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.23 via Frontend Transport; Thu, 18 May 2023 09:09:38 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , , , , , , Subject: [edk2-devel] [PATCH v1 6/6] ArmVirtPkg: ArmVirtQemuKernel: Increase primary core stack size Date: Thu, 18 May 2023 10:09:35 +0100 Message-ID: <20230518090935.10984-7-sami.mujawar@arm.com> In-Reply-To: <20230518090935.10984-1-sami.mujawar@arm.com> References: <20230518090935.10984-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: DBAEUR03FT018:EE_|PAWPR08MB9711:EE_|AM7EUR03FT063:EE_|GV2PR08MB9926:EE_ X-MS-Office365-Filtering-Correlation-Id: 0e2606ab-bcac-455f-6967-08db577fa459 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: oGKtv8hSb/5/uO4kJLLOjLTahXhctweeOAmA8ismwXnEgiUXTlAjc4lS4L1/SLp1iDaKawetFIMfoVgu4uLcgL57IPy6Q6fgPBGNaxRVHJa/A9j1r/7NQtD2CE8sWbR7eRlfA7FMRRArkWNy3wyYmL+UPJMhBBucZzwgTT9LNkY3dAZyfrRwO+3gIY1B5h15NBSod9zc6J1eFdNkceB/jK3OTR/N1ekozXEEL5CIWyi42dHYGIjCJhnpIxENgyUoJTibA7et7uhZ412bFppkHadIkUL1p/Y58MuJVdoj182Lve4W6noHLcgwlFR6GTkJTFc39aKicQB894sidUsaYPRAEJeVkqYnEN8KOLAKJfDPmB/SYFjC5E69nXTL3SbjKlHDzhnoAMwDsTHyYotoUBN0ED+/7taNEvwOoU8S2UCVyb1Lm/cA3S/G322+8p6phGqtmdHhV86h7P/eBTZhxyQsU/5nZMC4kIsYC7rzPLFaInJcOtwnovE5rjEtFdyNmmJAryFZ1rzT5rtpiyCBXjI4BFxnaOtlgFcCsT1GWkgD/1JusHcO8b64EFNtoLI8Q4LSvmpQBZrzMWOHB4YDwKM/D9bmKZEvFx1z+BNN7U3J0FhtIdVFcOfFLNloSvzaUm++wy+j+J+AxVV6eAqTZwwH4smySkuPexLEv2qViOaITRZcTXy9FGhS+5mjyPK6EIj62zGCjyAd+MI7PT0mvaq+298YuMtBfiM3gYMv1o/hJUxe1jKs9HW/ZWRjTNlmV8YFBJ+qbmUjgNxrvQXPVw== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(39860400002)(346002)(376002)(451199021)(36840700001)(46966006)(40470700004)(2906002)(478600001)(41300700001)(8676002)(8936002)(316002)(54906003)(44832011)(7696005)(6666004)(4326008)(6916009)(70586007)(70206006)(5660300002)(1076003)(40460700003)(26005)(82740400003)(356005)(186003)(83380400001)(336012)(426003)(40480700001)(47076005)(36860700001)(36756003)(81166007)(86362001)(82310400005)(2616005)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9711 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT063.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 2d7976b4-2c75-41d7-81e7-08db577f9deb X-Microsoft-Antispam-Message-Info: qG9pwVsE5QY+dFHU24mEPqKMmv6/UmmKbmhfds/Na7V1vC9dFDXg1pOxNPSIt2KhpH6rLyxpHY9he8h1OlPqwgHH6NKrM3+5Vpt9cqQrFS8sA5hCzYYiQ9uj/vGAG8IqV6zP27kz1MwvKc91YIOpRtubTiHK7WPQ6+d9ykCq+RP36QSFDl+rOeUh2TWFwYgNffw0q+6peO6TLTFRUy7O0m97hZz7jI1+fKp8qnWmSQeT3w7abRWerQXzD5PnFWFGP2edSFj/ZxCsxcTPtDD7Bc1qzx0it6DnF/4gDVWxiVtdXWXZl+9Vb/Mk1ww8lQgAZx/roAiyD/SYWZa6I49qqd5zOLkVLdlmjmyDs67tdonXEfyar2y3GzDxokj/NJpa0qTFM3/kiKMtjXL5asHc+ieoFxkxieikE5LTYLzIahimQ9BMtH4+6jWGdai3FOf2uT3Wzk2fMlfO5VcKah29niA63hl4ga6HdJPM2Z6CIO2FfSPHXbJDedSEnMaoVr5QExXvwr/QaU04zcAHEHkATgUn2IxTryz9iPnE9T3+rF17FioU3M1tmBn/+Vw0wdAfwQy5JyPcSIfi6H6/Lm7VmvcN8SD7nbYuwRyaXdiqdhZK8NDGz1wL97OvZvIaZkXWvvOkhSwUdcNcvp03qwpK7WBWiXBA/u9FMBpUc1QXlkN0C9oq+mFM1/0NBBFfTMmIC/u+nwvvYfOSAxNgSTt7ZsZkHQ4saRqa95s6NAvNVXjU1naKktafx52X6ktoKCR7 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2023 09:09:53.2374 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0e2606ab-bcac-455f-6967-08db577fa459 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT063.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB9926 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com X-Gm-Message-State: S5WVn5lziWqAb47A5n9EH8Wyx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1684401003; bh=06VyhPN3Mr6w8OHSqkA5C5ArwlROuGHSOmDo8PxIW3I=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=cDfoM9XeCD09zbo+U4TKNhpCvEDEL+lFWyUVZQoS70jH4D4+zyXliwoyRFcXklsOd6B L15PZgGhyJlHyohkyVp+/2v9b0A0wve/2gWWSoYee9JQEEw6gIk2bVMiEZyKwgJhnPG6Q 4Kbl6yy22BHiSF3tr07Dpbqjmmq0KpDf/7s= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1684401004118100017 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The patch "f07a9df9af60 ArmVirtPkg: Enable stack guard" enabled stack overflow detection for ArmVirtPkg. Following this patch, running UEFI shell command 'dmpstore' resulted in a crash indicating a stack overflow. Invoking 'dmpstore' results in recursive calls to CascadeProcessVariables () which apparently consumes the available stack space and overflows. Therefore, increase the primary core stack size. Signed-off-by: Sami Mujawar --- ArmVirtPkg/ArmVirtQemuKernel.dsc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKerne= l.dsc index 3cb9120e4e10551a2dc283f29b7d75fa8926a273..23b0296d8c7bc01b86a592e561b= 62c306d2fe018 100644 --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc @@ -119,7 +119,7 @@ [PcdsFixedAtBuild.common] gArmTokenSpaceGuid.PcdVFPEnabled|1 !endif =20 - gArmPlatformTokenSpaceGuid.PcdCPUCorePrimaryStackSize|0x4000 + gArmPlatformTokenSpaceGuid.PcdCPUCorePrimaryStackSize|0x8000 gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000 gEfiMdeModulePkgTokenSpaceGuid.PcdMaxAuthVariableSize|0x2800 !if $(NETWORK_TLS_ENABLE) =3D=3D TRUE --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#105020): https://edk2.groups.io/g/devel/message/105020 Mute This Topic: https://groups.io/mt/98987544/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-