From nobody Sun May 19 10:01:17 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+104765+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1683872751563903.9664602706333; Thu, 11 May 2023 23:25:51 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id o6DDYY1788612xC4fATUUZIy; Thu, 11 May 2023 23:25:51 -0700 X-Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.48]) by mx.groups.io with SMTP id smtpd.web11.17854.1683872750558675486 for ; Thu, 11 May 2023 23:25:50 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UlNxqp5EiU2b9ENMdTPQvTmojH6+hR40pCUaJrMXAPHH1FUmIxKlQmWxZ/71jFnr4RCpHdpque495C/ibZtXsgl2a5InLTvX+aUZniX9Hk2BzbZ32nX47bBrUr27sXVtHRnWwX4w2F/7Tq1PVpwGn23Omo+tBcNDvRRbTnBchKMtYDCgsouFCJFVTFTdR4MI7RRXsnU+cqK0Xddw3ZbGIToU/dBxwbqQA6xHD3divDza7EYiSBUcKKckMarOKDdmPz/jFchGDuhqUN+TeCQ5Hw3W1lkeXQQYB/DutvLV071YyVPJ9niMNOjJNOdUR8HhWa5i5N/LjYFZmb/rPXvluA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0GgRt17eMKUYJDI2c9L/9G3dL1lIuTD8T3FuQCWy438=; b=DAyet8jJYJsB7sKalYki3nNCKJZAFHa0yuAPKa1R3EBKarcn+nnPNPZMe9f4kX/DtwyBZkQqQdtDonAB5vqEF2j1JgcgFwYOhS+idF79LaimfcjVcViKW0PmmBZa9VSushT21dF5zbzxk+wEL0lJTNT/nLa/UHXhnc1BvgkL2cfjSmvdq6ZI7jXG8In0KigOQpKKaRFkpEqSZWaJa48d7tms251JMYf5X20ZlIBxzwhurF+7a9Zq3jvx4PPaWhR8zBEL5liPbuL1d3w9sgOqYXQ+zlh72WpQM0kDE4jMQDybaiDEpc+flj4E2SYjcgvfAzN7jtzaJ7taA56xxQ9d+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none X-Received: from BN9P222CA0015.NAMP222.PROD.OUTLOOK.COM (2603:10b6:408:10c::20) by PH0PR12MB8125.namprd12.prod.outlook.com (2603:10b6:510:293::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.18; Fri, 12 May 2023 06:25:48 +0000 X-Received: from BN8NAM11FT116.eop-nam11.prod.protection.outlook.com (2603:10b6:408:10c:cafe::f6) by BN9P222CA0015.outlook.office365.com (2603:10b6:408:10c::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.22 via Frontend Transport; Fri, 12 May 2023 06:25:47 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+104765+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C X-Received: from mail.nvidia.com (216.228.118.233) by BN8NAM11FT116.mail.protection.outlook.com (10.13.176.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.24 via Frontend Transport; Fri, 12 May 2023 06:25:47 +0000 X-Received: from drhqmail201.nvidia.com (10.126.190.180) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Thu, 11 May 2023 23:25:31 -0700 X-Received: from drhqmail202.nvidia.com (10.126.190.181) by drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Thu, 11 May 2023 23:25:31 -0700 X-Received: from NV-CL38DL3.nvidia.com (10.127.8.9) by mail.nvidia.com (10.126.190.181) with Microsoft SMTP Server id 15.2.986.37 via Frontend Transport; Thu, 11 May 2023 23:25:30 -0700 From: "Nickle Wang via groups.io" To: CC: Abner Chang , Igor Kulchytskyy Subject: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/ConverterLib: Fix empty string value issue Date: Fri, 12 May 2023 14:25:29 +0800 Message-ID: <20230512062529.3944-1-nicklew@nvidia.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT116:EE_|PH0PR12MB8125:EE_ X-MS-Office365-Filtering-Correlation-Id: e2ea9a22-b08d-45a7-f636-08db52b1b995 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: O5w5hQ0Gsti9bwlmZfoJQ/Nu4QiAErUsSn3WPqTt1EB0UtE8NDWwLtdBN77q/tHldRybGIcua0PuIlaTfrpBI0n4vblQMW5/L0PcNrTxlJ9alUJdPAknqEcvhPaxBw9DlIfLyPK27oLAhj0eMmobp8qztC1wKm9oZbc2zdThDzn5ehjL7bHWVeuqGRXKi6WMRO6PRJ7XGX+PyScNwEz3I9mK1SP2hHMW02dGBInboW90XPdRuNUkJs62n2PgyUlRLsCBXqZzM010il3LmwoZmATeHC+aa29my3v0WjM0DJFeV+qrSbCuRVSKq0Fx9gSPR6flkH85qclJVUm9iFuhxuHD0lG7ADktP/VY6eVkjs0+B4M08EYFWAL4EgDQi9BO3sMd9yEYOsr1gveg68fFIoKKyyRMeLKhAHWSgQzCtpNqklSnGy66a+NN2zXsQAVxkMEyexUIEuyNsV+K/zyEIGWex0qtWclzlp+ehZSZOoIBOO5iJUgEgU+8A+75YkzeQ9opN4Du/9V5Qkhq+NQ5peUByic4KruUyZkGFM1SWBTL5GzYH9RhnGPAiMbOmhXKcXlolvNIgmijVfieFb69nIxxgR8/hlQtPkF99+69ysQ9Rl2XNn0w4ml3g9xb70O9csgGpuPq1nD+OPHSx554VMrEGhA3dFnP+9MFaiqEOiPEsfOAg7Z69xHIyXQ2oamqxQcOENRlWDwOxtnNseND9g2HWzkJP5JXiopKuZ7L32h9dYZfy/4XB1frm0+R/8JN X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2023 06:25:47.7325 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e2ea9a22-b08d-45a7-f636-08db52b1b995 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.233];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT116.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB8125 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nicklew@nvidia.com X-Gm-Message-State: 0HcdOaHkZnw7P2WxKQAYHb4Ix1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1683872751; bh=7o4GHtOTn84IMJnZqRLGf1+sVWWqh2PueMs5CLYGcGg=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=luhd5CkYlOfJ8PY2YBj6qE2U2Vz8BPJc8xvPt49m9AHkuEg1uCdvzaZObOcRMgF+NXh 42viQcpADr/dwV6LOL0C0y0YaEGU50zEqF9VDrGkfRriMzDskm+iVYMeGsODSo0LRA08A /iT0YVLg6i+2H2aQdR3FTZOrOzFFLsCr+bE= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1683872753813100002 Content-Type: text/plain; charset="utf-8" allocateDuplicateStr() will not copy input string when input string is empty string. It returns NULL pointer and creates assertion in application driver. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Reviewed-by: Abner Chang --- RedfishClientPkg/ConverterLib/src/RedfishCsCommon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/RedfishClientPkg/ConverterLib/src/RedfishCsCommon.c b/RedfishC= lientPkg/ConverterLib/src/RedfishCsCommon.c index 964904a2..02fcb2b2 100644 --- a/RedfishClientPkg/ConverterLib/src/RedfishCsCommon.c +++ b/RedfishClientPkg/ConverterLib/src/RedfishCsCommon.c @@ -223,7 +223,7 @@ allocateDuplicateStr ( { RedfishCS_status Status; =20 - if ((Str =3D=3D NULL) || (strlen (Str) =3D=3D 0)) { + if (Str =3D=3D NULL) { *DstBuffer =3D NULL; return RedfishCS_status_success; } --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#104765): https://edk2.groups.io/g/devel/message/104765 Mute This Topic: https://groups.io/mt/98844375/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-